On 4/27/2014 3:37 PM, Chuck Lever wrote:
SNIP
Why not first create a new id+qp and assign them - and then destroy the old
id+qp?
see SRP related section: ib_srp.x:srp_create_target_ib()
Anyway it is indeed important to guarantee that no xmit flows happens
concurrently to that,
and cleanups
On Apr 27, 2014, at 6:12 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote:
On 4/24/2014 6:01 PM, Chuck Lever wrote:
On Apr 24, 2014, at 3:12 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote:
On 4/24/2014 2:30 AM, Devesh Sharma wrote:
Hi Chuck
Following is the complete call trace of a
On 4/24/2014 2:30 AM, Devesh Sharma wrote:
Hi Chuck
Following is the complete call trace of a typical NFS-RDMA transaction while
mounting a share.
It is unavoidable to stop calling post-send in case it is not created.
Therefore, applying checks to the connection state is a must
While
On Apr 24, 2014, at 3:12 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote:
On 4/24/2014 2:30 AM, Devesh Sharma wrote:
Hi Chuck
Following is the complete call trace of a typical NFS-RDMA transaction while
mounting a share.
It is unavoidable to stop calling post-send in case it is not
; Linux NFS Mailing List; linux-rdma@vger.kernel.org;
Trond Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
On Apr 24, 2014, at 3:12 AM, Sagi Grimberg sa...@dev.mellanox.co.il
wrote:
On 4/24/2014 2:30 AM, Devesh Sharma wrote:
Hi Chuck
Following
15, 2014 11:56 PM
To: Chuck Lever
Cc: Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond Myklebust
Subject: RE: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
-Original Message-
From: Chuck Lever [mailto:chuck.le...@oracle.com]
Sent: Tuesday, April 15, 2014 6:10
-Original Message-
From: Chuck Lever [mailto:chuck.le...@oracle.com]
Sent: Tuesday, April 15, 2014 6:10 AM
To: Devesh Sharma
Cc: Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
On Apr 14
Hi Devesh-
On Apr 13, 2014, at 12:01 AM, Chuck Lever chuck.le...@oracle.com wrote:
On Apr 11, 2014, at 7:51 PM, Devesh Sharma devesh.sha...@emulex.com wrote:
Hi Chuck,
Yes that is the case, Following is the trace I got.
4RPC: 355 setting alarm for 6 ms
4RPC: 355 sync task
Hi Chuck
-Original Message-
From: Chuck Lever [mailto:chuck.le...@oracle.com]
Sent: Tuesday, April 15, 2014 2:24 AM
To: Devesh Sharma
Cc: Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
Hi
V1] NFS-RDMA: fix qp pointer validation checks
Hi Devesh-
On Apr 10, 2014, at 1:54 PM, Devesh Sharma
devesh.sha...@emulex.com
wrote:
Alright here it is:
3ocrdma_mbx_create_qp(0) rq_err
3ocrdma_mbx_create_qp(0) sq_err
3ocrdma_create_qp(0) error=-1
1BUG: unable to handle
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
Hi Devesh-
On Apr 13, 2014, at 12:01 AM, Chuck Lever chuck.le...@oracle.com wrote:
On Apr 11, 2014, at 7:51 PM, Devesh Sharma
devesh.sha...@emulex.com wrote:
Hi Chuck,
Yes that is the case, Following is the trace
11:21 PM
To: Devesh Sharma
Cc: Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond
Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
On Apr 10, 2014, at 1:42 PM, Devesh Sharma
devesh.sha...@emulex.com
wrote:
However it seems to me the new (!ia-ri_id-qp
...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Chuck Lever
Sent: Thursday, April 10, 2014 11:21 PM
To: Devesh Sharma
Cc: Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond
Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
On Apr 10
Lever [mailto:chuck.le...@oracle.com]
Sent: Thursday, April 10, 2014 1:57 AM
To: Devesh Sharma
Cc: Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
On Apr 9, 2014, at 4:22 PM, Trond Myklebust trond.mykleb
-Original Message-
From: Chuck Lever [mailto:chuck.le...@oracle.com]
Sent: Thursday, April 10, 2014 5:56 AM
To: Devesh Sharma
Cc: Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
On Apr 9, 2014
@vger.kernel.org; Trond Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
On Apr 9, 2014, at 4:22 PM, Trond Myklebust
trond.mykleb...@primarydata.com wrote:
Hi Devesh,
This looks a lot better. I still have a couple of small suggestions,
though.
On Apr 9
On Apr 10, 2014, at 1:42 PM, Devesh Sharma devesh.sha...@emulex.com wrote:
However it seems to me the new (!ia-ri_id-qp) checks outside the connect
logic are unnecessary.
Clearly, as you noticed, the ib_post_{send,recv} verbs do not check that
their
qp argument is NULL before
List; linux-rdma@vger.kernel.org; Trond Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
On Apr 10, 2014, at 1:42 PM, Devesh Sharma
devesh.sha...@emulex.com wrote:
However it seems to me the new (!ia-ri_id-qp) checks outside the
connect logic are unnecessary
-Original Message-
From: Chuck Lever [mailto:chuck.le...@oracle.com]
Sent: Thursday, April 10, 2014 12:44 PM
To: Steve Wise
Cc: Devesh Sharma; Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond
Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
Sharma
Cc: Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
On Apr 10, 2014, at 1:42 PM, Devesh Sharma
devesh.sha...@emulex.com wrote:
However it seems to me the new (!ia-ri_id-qp) checks outside
If the rdma_create_qp fails to create qp due to device firmware being in
invalid state
xprtrdma still tries to destroy the non-existant qp and ends up in a NULL
pointer reference
crash.
Adding proper checks for vaidating QP pointer avoids this to happen.
Signed-off-by: Devesh Sharma
Hi Devesh,
This looks a lot better. I still have a couple of small suggestions, though.
On Apr 9, 2014, at 14:40, Devesh Sharma devesh.sha...@emulex.com wrote:
If the rdma_create_qp fails to create qp due to device firmware being in
invalid state
xprtrdma still tries to destroy the
On Apr 9, 2014, at 4:22 PM, Trond Myklebust trond.mykleb...@primarydata.com
wrote:
Hi Devesh,
This looks a lot better. I still have a couple of small suggestions, though.
On Apr 9, 2014, at 14:40, Devesh Sharma devesh.sha...@emulex.com wrote:
If the rdma_create_qp fails to create qp
Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
On Apr 9, 2014, at 4:22 PM, Trond Myklebust trond.mykleb...@primarydata.com
wrote:
Hi Devesh,
This looks a lot better. I still have a couple of small suggestions, though.
On Apr 9, 2014, at 14:40, Devesh Sharma
will trigger a separate completion event.
-Original Message-
From: Chuck Lever [mailto:chuck.le...@oracle.com]
Sent: Thursday, April 10, 2014 1:57 AM
To: Devesh Sharma
Cc: Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer
25 matches
Mail list logo
