Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

2013-07-03 Thread Joe Perches
On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > From: Eli Cohen trivial comments: > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c > b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c [] > +static const char *deliv_status_to_str(u8 status) > +{ > + switch (status) { > +

Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

2013-07-04 Thread Jack Morgenstein
On Wednesday 03 July 2013 23:29, Joe Perches wrote: > On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > > From: Eli Cohen > > trivial comments: > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c > > b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c > [] > > +static const char *

Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

2013-07-04 Thread Joe Perches
On Thu, 2013-07-04 at 16:26 +0300, Jack Morgenstein wrote: > On Wednesday 03 July 2013 23:29, Joe Perches wrote: > > On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > > > From: Eli Cohen > > > > trivial comments: > > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c > > > b/

Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

2013-07-04 Thread Jack Morgenstein
On Thursday 04 July 2013 17:17, Joe Perches wrote: > Not the vertical spacing, the newline inside the quotes. > ie: "unknown status code\n" should be "unknown status code" > You're right! I misunderstood, and did not notice the newline char. Good catch! While I was at it, though, I eliminated th