Re: [PATCH V2 FIX for-3.19] IB/ipoib: Fix broken multicast flow

2015-01-25 Thread Erez Shitrit
On 1/22/2015 10:40 PM, Doug Ledford wrote: On Thu, 2015-01-22 at 15:31 +0200, Or Gerlitz wrote: From: Erez Shitrit Following commit 016d9fb25cd9 "IPoIB: fix MCAST_FLAG_BUSY usage" both IPv6 traffic and for the most cases all IPv4 multicast traffic aren't working. After this change there is no

Re: [PATCH V2 FIX for-3.19] IB/ipoib: Fix broken multicast flow

2015-01-22 Thread Doug Ledford
On Fri, 2015-01-23 at 09:07 +0200, Or Gerlitz wrote: > >> 2. Sync between ipoib_mcast_sendonly_join() to > >> ipoib_mcast_sendonly_join_complete > >> using a IS_ERR_OR_NULL() test > > > This part is no good. You just added a kernel data corrupter or kernel > > oopser depending on the situation.

Re: [PATCH V2 FIX for-3.19] IB/ipoib: Fix broken multicast flow

2015-01-22 Thread Or Gerlitz
On Thu, Jan 22, 2015 at 10:40 PM, Doug Ledford wrote: > On Thu, 2015-01-22 at 15:31 +0200, Or Gerlitz wrote: >> Changes from V1: >> 1. always do clear_bit(IPOIB_MCAST_FLAG_BUSY) >> inipoib_mcast_sendonly_join_complete() > This part is good. good to know... >> 2. Sync between ipoib_mcast_sendon

Re: [PATCH V2 FIX for-3.19] IB/ipoib: Fix broken multicast flow

2015-01-22 Thread Doug Ledford
On Thu, 2015-01-22 at 15:31 +0200, Or Gerlitz wrote: > From: Erez Shitrit > > Following commit 016d9fb25cd9 "IPoIB: fix MCAST_FLAG_BUSY usage" both > IPv6 traffic and for the most cases all IPv4 multicast traffic aren't > working. > > After this change there is no mechanism to handle the work th

[PATCH V2 FIX for-3.19] IB/ipoib: Fix broken multicast flow

2015-01-22 Thread Or Gerlitz
From: Erez Shitrit Following commit 016d9fb25cd9 "IPoIB: fix MCAST_FLAG_BUSY usage" both IPv6 traffic and for the most cases all IPv4 multicast traffic aren't working. After this change there is no mechanism to handle the work that does the join process for the rest of the mcg's. For example, if