Re: [PATCH WIP 00/43] New fast registration API

2015-07-23 Thread Sagi Grimberg
On 7/23/2015 12:28 PM, Christoph Hellwig wrote: On Wed, Jul 22, 2015 at 08:42:32PM +0300, Sagi Grimberg wrote: We can do that, but I'd prefer not to pollute the API just for this single use case. What we can do, is add a pool API that would take care of that. But even then we might end up with d

Re: [PATCH WIP 00/43] New fast registration API

2015-07-23 Thread Christoph Hellwig
On Wed, Jul 22, 2015 at 08:42:32PM +0300, Sagi Grimberg wrote: > We can do that, but I'd prefer not to pollute the API just for this > single use case. What we can do, is add a pool API that would take care > of that. But even then we might end up with different strategies as not > all ULPs can use

Re: [PATCH WIP 00/43] New fast registration API

2015-07-23 Thread Christoph Hellwig
On Wed, Jul 22, 2015 at 11:27:02AM -0600, Jason Gunthorpe wrote: > What is SRP trying to accomplish with that? > > The only reason that springs to mind is to emulate IB_MR_MAP_ARB_SG ? It's not emulating IB_MR_MAP_ARB_SG, it simply allows muliple memory registrations per I/O request. Be that to

Re: [PATCH WIP 00/43] New fast registration API

2015-07-22 Thread Sagi Grimberg
On 7/22/2015 8:10 PM, Christoph Hellwig wrote: Thanks Sagi, this looks pretty good in general, various nitpicks nonwithstanding. The one thing I'm curious about is how we can support SRP with it's multiple MR support without too much boilerplate code. One option would be that pass an array of

Re: [PATCH WIP 00/43] New fast registration API

2015-07-22 Thread Jason Gunthorpe
On Wed, Jul 22, 2015 at 10:10:23AM -0700, Christoph Hellwig wrote: > The one thing I'm curious about is how we can support SRP with it's > multiple MR support without too much boilerplate code. One option > would be that pass an array of MRs to the map routines, and while > most callers would just

Re: [PATCH WIP 00/43] New fast registration API

2015-07-22 Thread Christoph Hellwig
Thanks Sagi, this looks pretty good in general, various nitpicks nonwithstanding. The one thing I'm curious about is how we can support SRP with it's multiple MR support without too much boilerplate code. One option would be that pass an array of MRs to the map routines, and while most callers w

[PATCH WIP 00/43] New fast registration API

2015-07-21 Thread Sagi Grimberg
Hi all, So I went ahead and tried to implement some of the stuff we've been talking about. I figured I'd send out a WIP version to try and communicate early where this is heading. In order to have a sane patchset I followed a scheme that add-new/port-existing/drop-old... The set starts with: - C