Re: [PATCH for-next 5/7] IB/mlx4: Enable send of RoCE QP1 packets with IP/UDP headers

2015-12-30 Thread Or Gerlitz
On 12/30/2015 1:04 PM, Moni Shoua wrote: The last hunk that you removed had a role and was by no means dead-code, right? so... (1) why it's correct to remove it? (2) if you want to introduce different way to implement what was done here, why in this patch? maybe add pre-patch for that In a way y

Re: [PATCH for-next 5/7] IB/mlx4: Enable send of RoCE QP1 packets with IP/UDP headers

2015-12-30 Thread Moni Shoua
> > The last hunk that you removed had a role and was by no means > dead-code, right? so... (1) why it's correct to remove it? (2) if you > want to introduce different way to implement what was done here, why > in this patch? maybe add pre-patch for that In a way you are right. This hunk does not

Re: [PATCH for-next 5/7] IB/mlx4: Enable send of RoCE QP1 packets with IP/UDP headers

2015-12-29 Thread Or Gerlitz
On Tue, Dec 29, 2015 at 3:24 PM, Matan Barak wrote: > @@ -2413,34 +2442,27 @@ static int build_mlx_header(struct mlx4_ib_sqp *sqp, > struct ib_ud_wr *wr, > > if (is_eth) { > struct in6_addr in6; > - > + u16 ether_type; > u16 pcp = (be32_to_cpu

[PATCH for-next 5/7] IB/mlx4: Enable send of RoCE QP1 packets with IP/UDP headers

2015-12-29 Thread Matan Barak
From: Moni Shoua RoCEv2 packets are sent over IP/UDP protocols. The mlx4 driver uses a type of RAW QP to send packets for QP1 and therefore needs to build the network headers below BTH in software. This patche adds option to build QP1 packets with IP and UDP headers if RoCEv2 is requested. Sign