Re: [PATCH for-next V5 3/5] IB/uverbs: Enable device removal when there are active user space applications

2015-06-29 Thread Yishai Hadas
On 6/25/2015 8:09 PM, Jason Gunthorpe wrote: On Thu, Jun 25, 2015 at 04:51:49PM +0300, Yishai Hadas wrote: On 6/24/2015 9:25 PM, Jason Gunthorpe wrote: Is not holding the RCU lock while ib_uverbs_release_dev is reading ib_dev. The barriers in kref are not strong enough to guarentee the RCU

Re: [PATCH for-next V5 3/5] IB/uverbs: Enable device removal when there are active user space applications

2015-06-25 Thread Yishai Hadas
On 6/24/2015 9:25 PM, Jason Gunthorpe wrote: On Mon, Jun 22, 2015 at 05:47:16PM +0300, Yishai Hadas wrote: +++ b/drivers/infiniband/core/uverbs_main.c @@ -137,7 +137,12 @@ static void ib_uverbs_release_dev(struct kref *ref) struct ib_uverbs_device *dev =

Re: [PATCH for-next V5 3/5] IB/uverbs: Enable device removal when there are active user space applications

2015-06-25 Thread Jason Gunthorpe
On Thu, Jun 25, 2015 at 04:51:49PM +0300, Yishai Hadas wrote: On 6/24/2015 9:25 PM, Jason Gunthorpe wrote: Is not holding the RCU lock while ib_uverbs_release_dev is reading ib_dev. The barriers in kref are not strong enough to guarentee the RCU protected data will be visible. (remember when I

Re: [PATCH for-next V5 3/5] IB/uverbs: Enable device removal when there are active user space applications

2015-06-24 Thread Jason Gunthorpe
On Mon, Jun 22, 2015 at 05:47:16PM +0300, Yishai Hadas wrote: +++ b/drivers/infiniband/core/uverbs_main.c @@ -137,7 +137,12 @@ static void ib_uverbs_release_dev(struct kref *ref) struct ib_uverbs_device *dev = container_of(ref, struct ib_uverbs_device, ref); -