RE: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-11 Thread Liran Liss
From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] It does if you want a planned 'gental' removal to be possible.. There could be a lot of design options for a 'gentle' removal, such as first sending a 'prepare' event, and only then doing the flow proposed here. I do not want

Re: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-11 Thread Jason Gunthorpe
On Tue, Aug 11, 2015 at 12:47:03PM +, Liran Liss wrote: Still needs to have the locking fixed.. As pointed out (https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg27023.html), this barrier scheme is used in several places including in the RDMA stack. If there is no functional

Re: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-10 Thread Jason Gunthorpe
On Thu, Aug 06, 2015 at 03:36:39PM +, Liran Liss wrote: I don't think that the order matters. It does if you want a planned 'gental' removal to be possible.. When you do a surprise removal, you disconnect the application from both ucma and uverbs device references. In this state, the

RE: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-06 Thread Liran Liss
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe I have no real problem with that, it would be nice to have an answer to the uverbs vs ucma removal ordering question and the basic issue of if we even want to do this so async

Re: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-05 Thread Yishai Hadas
On 8/5/2015 1:09 AM, Jason Gunthorpe wrote: On Tue, Aug 04, 2015 at 05:03:28PM +0300, Yishai Hadas wrote: Currently, IB/cma remove_one flow blocks until all user descriptor managed by IB/ucma are released. This prevents hot-removal of IB devices. This patch allows IB/cma to remove devices

Re: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-05 Thread Yishai Hadas
On 8/5/2015 3:23 AM, Jason Gunthorpe wrote: On Tue, Aug 04, 2015 at 05:03:28PM +0300, Yishai Hadas wrote: Currently, IB/cma remove_one flow blocks until all user descriptor managed by IB/ucma are released. This prevents hot-removal of IB devices. This patch allows IB/cma to remove devices

Re: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-05 Thread Jason Gunthorpe
On Wed, Aug 05, 2015 at 06:09:45PM +0300, Yishai Hadas wrote: +static void ucma_close_id(struct work_struct *work) +{ + struct ucma_context *ctx = container_of(work, struct ucma_context, close_work); + + /* Fence to ensure that ctx-closing was seen by all +* ucma_get_ctx running

Re: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-04 Thread Jason Gunthorpe
On Tue, Aug 04, 2015 at 05:03:28PM +0300, Yishai Hadas wrote: Currently, IB/cma remove_one flow blocks until all user descriptor managed by IB/ucma are released. This prevents hot-removal of IB devices. This patch allows IB/cma to remove devices regardless of user space activity. Upon getting

Re: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-04 Thread Jason Gunthorpe
On Tue, Aug 04, 2015 at 05:03:28PM +0300, Yishai Hadas wrote: Currently, IB/cma remove_one flow blocks until all user descriptor managed by IB/ucma are released. This prevents hot-removal of IB devices. This patch allows IB/cma to remove devices regardless of user space activity. Upon getting