Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-05 Thread Mike Christie
On 03/04/2014 03:59 AM, Sagi Grimberg wrote: On 3/4/2014 11:38 AM, Or Gerlitz wrote: On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would currently want to do the mapping in

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Or Gerlitz
On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would currently want to do the mapping in the init_task callout instead. If it makes it easier on the driver implementation then

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Sagi Grimberg
On 3/4/2014 11:38 AM, Or Gerlitz wrote: On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would currently want to do the mapping in the init_task callout instead. If it makes it

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Or Gerlitz
On 04/03/2014 11:59, Sagi Grimberg wrote: On 3/4/2014 11:38 AM, Or Gerlitz wrote: On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would currently want to do the mapping in

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Sagi Grimberg
On 3/4/2014 1:25 PM, Or Gerlitz wrote: On 04/03/2014 11:59, Sagi Grimberg wrote: On 3/4/2014 11:38 AM, Or Gerlitz wrote: On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Or Gerlitz
On 04/03/2014 16:44, Sagi Grimberg wrote: @@ -1707,10 +1707,17 @@ int iscsi_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc) goto prepd_fault; } } - if (session-tt-xmit_task(task)) { -

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Sagi Grimberg
On 3/4/2014 6:16 PM, Or Gerlitz wrote: On 04/03/2014 16:44, Sagi Grimberg wrote: @@ -1707,10 +1707,17 @@ int iscsi_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc) goto prepd_fault; } } - if

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-03 Thread Sagi Grimberg
On 3/3/2014 6:44 AM, Mike Christie wrote: On 02/27/2014 05:13 AM, Sagi Grimberg wrote: diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c b/drivers/infiniband/ulp/iser/iser_initiator.c index 58e14c7..7fd95fe 100644 --- a/drivers/infiniband/ulp/iser/iser_initiator.c +++

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-02 Thread Mike Christie
On 02/27/2014 05:13 AM, Sagi Grimberg wrote: diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c b/drivers/infiniband/ulp/iser/iser_initiator.c index 58e14c7..7fd95fe 100644 --- a/drivers/infiniband/ulp/iser/iser_initiator.c +++ b/drivers/infiniband/ulp/iser/iser_initiator.c @@ -62,6

[PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-02-27 Thread Sagi Grimberg
Add logic to initialize protection information entities. Upon each iSCSI task, we keep the scsi_cmnd in order to query the scsi protection operations and reference to protection buffers. Modify iser_fast_reg_mr to receive indication weather it is registering the data or protection buffers. In