RE: [PATCH v4 01/50] IB: Add CNP opcode enumeration.

2015-07-30 Thread Marciniszyn, Mike
That is obvious and useless. Patches should have a meaningful description and justify the changes. The driver uses the CNP opcode for congestion control. And that requires a new transport protocol??? The opcode is 0x80, which appears in the protocol part of the 8 bit opcode.

RE: [PATCH v4 01/50] IB: Add CNP opcode enumeration.

2015-07-30 Thread Marciniszyn, Mike
The opcode is 0x80, which appears in the protocol part of the 8 bit opcode. That is what is specified in A3.10.2 of the 1.3 spec. Correction A10.3.2. Mike -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v4 01/50] IB: Add CNP opcode enumeration.

2015-07-30 Thread Christoph Lameter
On Thu, 30 Jul 2015, Mike Marciniszyn wrote: This patch adds the value of the CNP opcode to the existing list of enumerated opcodes. That is obvious and useless. Patches should have a meaningful description and justify the changes. Why do you add the CNP opcode and what in the world does it

RE: [PATCH v4 01/50] IB: Add CNP opcode enumeration.

2015-07-30 Thread Christoph Lameter
On Thu, 30 Jul 2015, Marciniszyn, Mike wrote: That is obvious and useless. Patches should have a meaningful description and justify the changes. The driver uses the CNP opcode for congestion control. And that requires a new transport protocol??? Why do you add the CNP opcode and what

RE: [PATCH v4 01/50] IB: Add CNP opcode enumeration.

2015-07-30 Thread Marciniszyn, Mike
That is obvious and useless. Patches should have a meaningful description and justify the changes. The driver uses the CNP opcode for congestion control. Why do you add the CNP opcode and what in the world does it do? CNP is what? And why do the other enum values not work for you? The

Re: [PATCH v4 01/50] IB: Add CNP opcode enumeration.

2015-07-30 Thread ira.weiny
On Thu, Jul 30, 2015 at 09:18:17PM +, Marciniszyn, Mike wrote: The opcode is 0x80, which appears in the protocol part of the 8 bit opcode. That is what is specified in A3.10.2 of the 1.3 spec. Correction A10.3.2. This value also appears in Table 38 of section 9.2 where the other