RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-15 Thread Weiny, Ira
> > On Fri, Jun 12, 2015 at 05:24:32AM +, Weiny, Ira wrote: > > > > PATH_USE_* is a better name. But I think the defines should be: > > > > PATH_USE_ANY (or ALL?) > > How about PATH_USE_CONNECTED? I don't want to bikeshed this too much as I'm not really good on names but... How does "Conne

Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-15 Thread Jason Gunthorpe
On Fri, Jun 12, 2015 at 05:24:32AM +, Weiny, Ira wrote: > > PATH_USE_* is a better name. But I think the defines should be: > > PATH_USE_ANY (or ALL?) How about PATH_USE_CONNECTED? > Why not treat unknown type as "ANY/ALL" and return all 6 if > possible. If not possible/supported (ie like

RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Weiny, Ira
> > > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > > Sent: Thursday, June 11, 2015 8:22 PM > > To: Wan, Kaike > > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > > Subject: Re: [PATCH v5 1/4] IB/netlink: Add defines for local ser

RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 8:22 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests > through netlink &

Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Jason Gunthorpe
On Thu, Jun 11, 2015 at 11:45:46PM +, Wan, Kaike wrote: > Apparently, to achieve this goal, we need the following changes: I don't expect anything more than a proper hole in the UAPI to make this work. I already have patches that implement full kernel support for the 6-path format, and global

RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Weiny, Ira
> > > Is QP type definition already exported to user space? > > QP Type could be a bad name, open to ideas I think the name "QP Type" is bad... I want to say "transport type" but I don't think that really communicates what we want here. > > > I see IBV_QPT_RC/UC/UD/RAW_PACKET/XRC_SEND/XRC_R

RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 3:52 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests > through netlink &

Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Jason Gunthorpe
On Thu, Jun 11, 2015 at 07:21:11PM +, Wan, Kaike wrote: > > Recommend a 'QP Type' with options of: > > - RC QP: Return up to the full 6 path tuple with full APM data > > - UD QP: Return a single non-reversible path > > - GMP QP: Return up to two reversible GMP paths. > > > > If it is hard t

RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 2:52 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests > through netlink &

Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Jason Gunthorpe
On Thu, Jun 11, 2015 at 06:32:44PM +, Wan, Kaike wrote: > > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > > Sent: Thursday, June 11, 2015 1:58 PM > > To: Wan, Kaike > > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > > Subject: Re:

Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Jason Gunthorpe
On Thu, Jun 11, 2015 at 06:32:44PM +, Wan, Kaike wrote: > > Why are you sending this again without responding the comments I provided > > on this patch? > > Are you referring to the mandatory/option attributes comments? Hum weird, I typed in a message yesterday but it seems to have evaporated

Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Jason Gunthorpe
On Thu, Jun 11, 2015 at 01:03:42PM -0400, kaike@intel.com wrote: > From: Kaike Wan > > This patch adds netlink defines for SA client, local service group, local > service operations, and related attributes. Why are you sending this again without responding the comments I provided on this pat

RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 1:58 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests > through netlink &

[PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread kaike . wan
From: Kaike Wan This patch adds netlink defines for SA client, local service group, local service operations, and related attributes. Signed-off-by: Kaike Wan Signed-off-by: John Fleck Signed-off-by: Ira Weiny Reviewed-by: Sean Hefty --- include/uapi/rdma/rdma_netlink.h | 82 +