Re: FW: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-10-20 Thread Richard Frank
Oracle is starting the process of certifying IBoE with Oracle solutions.. It would be great if IBoE makes into the 2.6.37 kernel.. If not - when / what kernel do you think it might ? Rick Roland Dreier wrote: Following Eli's update below, we have not received any further comments on this

Re: FW: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-10-05 Thread Tziporet Koren
On 9/26/2010 6:46 PM, Tziporet Koren wrote: Roland, Following Eli's update below, we have not received any further comments on this matter. Please confirm that this is in line with what you had requested. Also, having not heard any other concerns with the rest of the iboe v10 patchset, we

Re: FW: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-10-05 Thread Roland Dreier
Following Eli's update below, we have not received any further comments on this matter. Please confirm that this is in line with what you had requested. Also, having not heard any other concerns with the rest of the iboe v10 patchset, we assume it is in good shape for upstream

Re: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-09-07 Thread Eli Cohen
On Thu, Sep 02, 2010 at 01:10:17PM -0700, Roland Dreier wrote: Please just resend this, thanks. Here's the new code. I added a function that tries to find a match for a given port, istead of ib_find_cached_gid() which searches all the ports. I tested this on a machine with two cards with

Re: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-09-02 Thread Roland Dreier
The point is it cma_acquire_dev() may get called when dev_addr-transport has not yet been set so we can't rely on its value to retrieve the correct GID; for example when it gets called by rdma_bind_addr() it will only set the transport a few lines down the function when calling

Re: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-09-02 Thread Eli Cohen
On Thu, Sep 02, 2010 at 10:46:10AM -0700, Roland Dreier wrote: looks better but since we know everything about the device we're comparing to, can't we do something like: if (addr and dev ARPHRD agree) if (dev is IBoE) ret =

Re: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-09-02 Thread Roland Dreier
Please let me know if you'd like me to send a new series or just send this patch again. Please just resend this, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-08-29 Thread Eli Cohen
On Thu, Aug 26, 2010 at 11:14:26PM -0700, Roland Dreier wrote: I thought the whole point of this change: static inline void rdma_addr_get_sgid(struct rdma_dev_addr *dev_addr, union ib_gid *gid) { - memcpy(gid, dev_addr-src_dev_addr + rdma_addr_gid_offset(dev_addr), sizeof

Re: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-08-27 Thread Roland Dreier
if (dev_addr-dev_type != ARPHRD_INFINIBAND) { iboe_addr_get_sgid(dev_addr, gid); list_for_each_entry(cma_dev, dev_list, list) { ret = ib_find_cached_gid(cma_dev-device, gid,

RE: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-08-26 Thread Hefty, Sean
@@ -330,15 +348,29 @@ static int cma_acquire_dev(struct rdma_id_private *id_priv) union ib_gid gid; int ret = -ENODEV; - rdma_addr_get_sgid(dev_addr, gid); + if (dev_addr-dev_type != ARPHRD_INFINIBAND) { + iboe_addr_get_sgid(dev_addr, gid); How does this

Re: [PATCHv10 02/12] ib_core: IBoE CMA device binding

2010-08-26 Thread Eli Cohen
On Thu, Aug 26, 2010 at 01:11:56PM -0700, Hefty, Sean wrote: @@ -330,15 +348,29 @@ static int cma_acquire_dev(struct rdma_id_private *id_priv) union ib_gid gid; int ret = -ENODEV; - rdma_addr_get_sgid(dev_addr, gid); + if (dev_addr-dev_type != ARPHRD_INFINIBAND) { +