Re: [infiniband-diags] [PATCH] [2/2] split out scan specific data from ibnd_node_t

2009-11-12 Thread Ira Weiny
On Thu, 12 Nov 2009 18:31:05 +0200 Sasha Khapyorsky sas...@voltaire.com wrote: On 10:34 Fri 06 Nov , Al Chu wrote: Why do you want to remove this? port-path_portid can be useful for logging, specific querying, etc.. Even node-dnext can be helpful for some advanced use too.

Re: [infiniband-diags] [PATCH] [2/2] split out scan specific data from ibnd_node_t

2009-11-12 Thread Sasha Khapyorsky
Hi Al, On 09:51 Thu 12 Nov , Al Chu wrote: Really? I thought that it could be a useful data for advanced uses. It was removed in commit 094f922a34d6378d6a3bd1d137f90d6530685f94. It was a simpler version of a patch that Ira had proposed on the mailing list. This means that I'm

RE: [infiniband-diags] [PATCH] [2/2] split out scan specific data from ibnd_node_t

2009-11-12 Thread Sean Hefty
Making things private allows us to change the library without breaking the interface. I don't think Furthermore, it simplifies the interface for users who want to write code at a higher level. I'm not asking to make high level life harder :). My point is to not prevent from advanced

[infiniband-diags] [PATCH] [2/2] split out scan specific data from ibnd_node_t

2009-11-02 Thread Al Chu
Hey Sasha, This splits out some scan specific data from ibnd_node_t that doesn't need to be in the public struct. Al -- Albert Chu ch...@llnl.gov Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory From: Albert Chu ch...@llnl.gov Date: Thu, 29 Oct 2009

Re: [infiniband-diags] [PATCH] [2/2] split out scan specific data from ibnd_node_t

2009-11-02 Thread Al Chu
Hi Sasha, Oops. I forgot to free the newly created memory. Here's a new patch. Al On Mon, 2009-11-02 at 11:33 -0800, Al Chu wrote: Hey Sasha, This splits out some scan specific data from ibnd_node_t that doesn't need to be in the public struct. Al -- Albert Chu ch...@llnl.gov