Re: [opensm] [PATCH 1/5] Free memory from osm_subn_opt_t when osm_subn_t destroyed

2012-01-10 Thread Alex Netes
Hi Al, On 14:49 Mon 14 Nov , Albert Chu wrote: > Signed-off-by: Albert L. Chu > --- Removed unneeded checks before free. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [opensm] [PATCH 1/5] Free memory from osm_subn_opt_t when osm_subn_t destroyed

2011-11-14 Thread Bart Van Assche
On Mon, Nov 14, 2011 at 11:49 PM, Albert Chu wrote: > +       if (opt->vlarb_high) > +               free(opt->vlarb_high); Those if-statements are superfluous - invoking free(NULL) is safe. See e.g. http://pubs.opengroup.org/onlinepubs/009695399/functions/free.html. Bart. -- To unsubscribe from

[opensm] [PATCH 1/5] Free memory from osm_subn_opt_t when osm_subn_t destroyed

2011-11-14 Thread Albert Chu
Signed-off-by: Albert L. Chu --- opensm/osm_subnet.c | 73 +++ 1 files changed, 73 insertions(+), 0 deletions(-) diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c index 554a950..03b73dd 100644 --- a/opensm/osm_subnet.c +++ b/opensm/osm_subne