RE: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-30 Thread Chris Moore
> On 10/29/2014 8:05 PM, Chris Moore wrote: > >> On Wed, 2014-10-22 at 12:02 +0300, Or Gerlitz wrote: > >>> On 10/22/2014 8:06 AM, Nicholas A. Bellinger wrote: > On Tue, 2014-10-21 at 00:13 +0300, Or Gerlitz wrote: > > On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore > >> wrote: > >> The

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-30 Thread Sagi Grimberg
On 10/29/2014 8:05 PM, Chris Moore wrote: On Wed, 2014-10-22 at 12:02 +0300, Or Gerlitz wrote: On 10/22/2014 8:06 AM, Nicholas A. Bellinger wrote: On Tue, 2014-10-21 at 00:13 +0300, Or Gerlitz wrote: On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore wrote: The following code is in isert_conn_set

RE: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-29 Thread Chris Moore
> On Wed, 2014-10-22 at 12:02 +0300, Or Gerlitz wrote: > > On 10/22/2014 8:06 AM, Nicholas A. Bellinger wrote: > > > On Tue, 2014-10-21 at 00:13 +0300, Or Gerlitz wrote: > > >> On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore > wrote: > > >>> The following code is in isert_conn_setup_qp() in ib_isert.

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-28 Thread Eli Cohen
On Tue, Oct 28, 2014 at 12:06:06PM +0200, Or Gerlitz wrote: > >we already have reported max_sge value. Maybe what we need is another > >field, "guarnateed_num_sge" so applicatios providing this value can be > >sure it would succeed (or there is some other problem). Then they can > >either use this

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-28 Thread Or Gerlitz
On 10/26/2014 4:08 PM, Eli Cohen wrote: On Sun, Oct 26, 2014 at 01:57:33PM +0100, Bart Van Assche wrote: Applications really need a way to query what the maximum supported number of scatter/gather entries per work request is. The current approach, namely using "dev_attr.max_sge - " is cumbersome

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-26 Thread Eli Cohen
On Sun, Oct 26, 2014 at 01:57:33PM +0100, Bart Van Assche wrote: > > Applications really need a way to query what the maximum supported > number of scatter/gather entries per work request is. The current > approach, namely using "dev_attr.max_sge - " is > cumbersome since this approach doesn't wor

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-26 Thread Bart Van Assche
On 10/23/14 09:43, Eli Cohen wrote: On Tue, Oct 21, 2014 at 12:13:22AM +0300, Or Gerlitz wrote: On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore wrote: The following code is in isert_conn_setup_qp() in ib_isert.c: /* * FIXME: Use devattr.max_sge - 2 for max_send_sge as

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-23 Thread Eli Cohen
On Tue, Oct 21, 2014 at 12:13:22AM +0300, Or Gerlitz wrote: > On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore wrote: > > The following code is in isert_conn_setup_qp() in ib_isert.c: > > > > /* > >* FIXME: Use devattr.max_sge - 2 for max_send_sge as > >* work-around f

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-22 Thread Nicholas A. Bellinger
On Wed, 2014-10-22 at 12:02 +0300, Or Gerlitz wrote: > On 10/22/2014 8:06 AM, Nicholas A. Bellinger wrote: > > On Tue, 2014-10-21 at 00:13 +0300, Or Gerlitz wrote: > >> On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore > >> wrote: > >>> The following code is in isert_conn_setup_qp() in ib_isert.c: > >

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-22 Thread Sagi Grimberg
On 10/22/2014 8:06 AM, Nicholas A. Bellinger wrote: On Tue, 2014-10-21 at 00:13 +0300, Or Gerlitz wrote: On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore wrote: The following code is in isert_conn_setup_qp() in ib_isert.c: /* * FIXME: Use devattr.max_sge - 2 for max_send_sge

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-22 Thread Or Gerlitz
On 10/22/2014 8:06 AM, Nicholas A. Bellinger wrote: On Tue, 2014-10-21 at 00:13 +0300, Or Gerlitz wrote: On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore wrote: The following code is in isert_conn_setup_qp() in ib_isert.c: /* * FIXME: Use devattr.max_sge - 2 for max_send_sge

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-21 Thread Nicholas A. Bellinger
On Tue, 2014-10-21 at 00:13 +0300, Or Gerlitz wrote: > On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore wrote: > > The following code is in isert_conn_setup_qp() in ib_isert.c: > > > > /* > >* FIXME: Use devattr.max_sge - 2 for max_send_sge as > >* work-around for RDMA

Re: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-20 Thread Or Gerlitz
On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore wrote: > The following code is in isert_conn_setup_qp() in ib_isert.c: > > /* >* FIXME: Use devattr.max_sge - 2 for max_send_sge as >* work-around for RDMA_READ.. >*/ > attr.cap.max_send_sge = device

Can someone help me understand the reason for this code in ib_isert.c?

2014-10-20 Thread Chris Moore
The following code is in isert_conn_setup_qp() in ib_isert.c: /* * FIXME: Use devattr.max_sge - 2 for max_send_sge as * work-around for RDMA_READ.. */ attr.cap.max_send_sge = device->dev_attr.max_sge - 2; It's not clear from the comment what this