On 3/12/2014 12:17 PM, Bart Van Assche wrote:
On 02/18/14 15:32, Moni Shoua wrote:
Ha ha. Take another look. That's what I was just explaining about! :) On
line 1743 when curr_master is non-NULL then Smatch doesn't complain
because it understands about the relationship between curr_master and
cu
On 02/18/14 15:32, Moni Shoua wrote:
>> Ha ha. Take another look. That's what I was just explaining about! :) On
>> line 1743 when curr_master is non-NULL then Smatch doesn't complain
>> because it understands about the relationship between curr_master and
>> curr_netdev. But here it is complaining
Ha ha. Take another look. That's what I was just explaining about! :) On
line 1743 when curr_master is non-NULL then Smatch doesn't complain
because it understands about the relationship between curr_master and
curr_netdev. But here it is complaining about line 1749 where
curr_master is NULL so
On Tue, Feb 18, 2014 at 04:13:28PM +0200, Moni Shoua wrote:
> On 2/17/2014 1:52 PM, Dan Carpenter wrote:
> >Hello Moni Shoua,
> >
> >This is a semi-automatic email about new static checker warnings.
> >
> >The patch ad4885d279b6: "IB/mlx4: Build the port IB
On 2/17/2014 1:52 PM, Dan Carpenter wrote:
Hello Moni Shoua,
This is a semi-automatic email about new static checker warnings.
The patch ad4885d279b6: "IB/mlx4: Build the port IBoE GID table
properly under bonding" from Feb 5, 2014, leads to the following
Smatch complaint:
drivers/
Hello Moni Shoua,
This is a semi-automatic email about new static checker warnings.
The patch ad4885d279b6: "IB/mlx4: Build the port IBoE GID table
properly under bonding" from Feb 5, 2014, leads to the following
Smatch complaint:
drivers/infiniband/hw/mlx4/main.c:1749 mlx4_ib_sc
From: Moni Shoua
When scanning netdevices we need to check few more conditions and cases
to build the IBoE GID table properly. For example, under a bonding use-case
we must make sure that when a port is down, the bond IP address isn't
programmed there as GID, since not doing so will cause failure
