Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel

2011-10-21 Thread Kumar Sanghvi
: Steve Wise [mailto:sw...@opengridcomputing.com] Sent: Thursday, October 20, 2011 9:52 PM To: Roland Dreier Cc: Pandit, Parav; kuma...@chelsio.com; linux-rdma@vger.kernel.org; d...@chelsio.com Subject: Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel On 10/20/2011 11:06 AM, Roland

Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel

2011-10-20 Thread Steve Wise
-rdma-ow...@vger.kernel.org] On Behalf Of Steve Wise Sent: Thursday, October 13, 2011 9:43 PM To: Roland Dreier Cc: Kumar Sanghvi; linux-rdma@vger.kernel.org; d...@chelsio.com Subject: Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel On 10/13/2011 11:01 AM, Roland Dreier wrote: Would

Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel

2011-10-20 Thread Roland Dreier
On Thu, Oct 20, 2011 at 2:11 AM, parav.pan...@emulex.com wrote: http://lxr.linux.no/#linux+v3.0.4/Documentation/infiniband/core_locking.txt Line no 66 to 97 states that - at a given point of time, there should be only one callback per CQ should be active. Is this ensured? compl_handler()

Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel

2011-10-20 Thread Steve Wise
On 10/20/2011 11:06 AM, Roland Dreier wrote: On Thu, Oct 20, 2011 at 2:11 AM,parav.pan...@emulex.com wrote: http://lxr.linux.no/#linux+v3.0.4/Documentation/infiniband/core_locking.txt Line no 66 to 97 states that - at a given point of time, there should be only one callback per CQ should be

RE: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel

2011-10-20 Thread Parav.Pandit
- From: Steve Wise [mailto:sw...@opengridcomputing.com] Sent: Thursday, October 20, 2011 9:52 PM To: Roland Dreier Cc: Pandit, Parav; kuma...@chelsio.com; linux-rdma@vger.kernel.org; d...@chelsio.com Subject: Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel On 10/20/2011 11:06 AM, Roland Dreier

Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel

2011-10-20 Thread Steve Wise
; kuma...@chelsio.com; linux-rdma@vger.kernel.org; d...@chelsio.com Subject: Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel On 10/20/2011 11:06 AM, Roland Dreier wrote: On Thu, Oct 20, 2011 at 2:11 AM,parav.pan...@emulex.com wrote: http://lxr.linux.no/#linux+v3.0.4/Documentation

Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel

2011-10-14 Thread Roland Dreier
On Thu, Oct 13, 2011 at 9:12 AM, Steve Wise sw...@opengridcomputing.com wrote: I'm not sure other drivers have this issue.  For example, when a mlx or mthca QP moves out of RTS, does the HW flush the pending recv WRs?  For Chelsio devices, the provider driver/library must handle this. Yeah,

Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel

2011-10-13 Thread Steve Wise
Acked-by: Steve Wise sw...@opengridcomputing.com -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel

2011-10-13 Thread Roland Dreier
Would this generate a completion event even if no completion entries are queued? Maybe I'm misunderstanding, but this sounds like a bandaid for broken applications, and a bandaid that other hardware drivers won't implement. On Thu, Oct 13, 2011 at 1:21 AM, Kumar Sanghvi kuma...@chelsio.com

Re: [PATCH] RDMA/cxgb4: Unblock reads on comp_channel

2011-10-13 Thread Steve Wise
On 10/13/2011 11:01 AM, Roland Dreier wrote: Would this generate a completion event even if no completion entries are queued? I guess it can if the QP has no WRs posted at all. Maybe I'm misunderstanding, but this sounds like a bandaid for broken applications, and a bandaid that other