Re: [PATCH 01/37] IB/rdmavt: Create module framework and handle driver registration

2015-12-10 Thread Haggai Eran
On 07/12/2015 22:43, Dennis Dalessandro wrote: > +struct rvt_dev_info { > + struct ib_device ibdev; > + int (*port_callback)(struct ib_device *, u8, struct kobject *); > + > + /* > + * TODO: > + * need to reflect module parameters that may vary by dev > + */ > +};

Re: [PATCH 01/37] IB/rdmavt: Create module framework and handle driver registration

2015-12-10 Thread Dennis Dalessandro
On Thu, Dec 10, 2015 at 01:49:31PM +0200, Haggai Eran wrote: On 07/12/2015 22:43, Dennis Dalessandro wrote: +struct rvt_dev_info { + struct ib_device ibdev; + int (*port_callback)(struct ib_device *, u8, struct kobject *); + + /* +* TODO: +* need to

Re: [PATCH 01/37] IB/rdmavt: Create module framework and handle driver registration

2015-12-08 Thread Dennis Dalessandro
On Tue, Dec 08, 2015 at 07:55:45AM +0200, Leon Romanovsky wrote: On Mon, Dec 07, 2015 at 03:43:02PM -0500, Dennis Dalessandro wrote: +#include +#include +#include "vt.h" + +#define RDMAVT_DRIVER_VERSION "0.1" Do we really need driver version? Based on these patches thus far. Probably not.

RE: [PATCH 01/37] IB/rdmavt: Create module framework and handle driver registration

2015-12-08 Thread Hefty, Sean
> >> +#define RDMAVT_DRIVER_VERSION "0.1" > >Do we really need driver version? > > Based on these patches thus far. Probably not. We do still have a bit more > development to go here, I added it more as a just in case but am not > steadfast in keeping it. > > What's the general rule here? Should

Re: [PATCH 01/37] IB/rdmavt: Create module framework and handle driver registration

2015-12-07 Thread Leon Romanovsky
On Mon, Dec 07, 2015 at 03:43:02PM -0500, Dennis Dalessandro wrote: > +#include > +#include > +#include "vt.h" > + > +#define RDMAVT_DRIVER_VERSION "0.1" Do we really need driver version? > + > +MODULE_LICENSE("Dual BSD/GPL"); > +MODULE_DESCRIPTION("RDMA Verbs Transport Library"); >

RE: [PATCH 01/37] IB/rdmavt: Create module framework and handle driver registration

2015-12-07 Thread Hefty, Sean
> @@ -0,0 +1,89 @@ > +/* > + * > + * This file is provided under a dual BSD/GPLv2 license. When using or > + * redistributing this file, you may do so under either license. > + * > + * GPL LICENSE SUMMARY > + * > + * Copyright(c) 2015 Intel Corporation. I'm guessing that the GPL license text