-Original Message-
From: Hefty, Sean [mailto:sean.he...@intel.com]
Sent: Wednesday, March 21, 2012 10:49 PM
To: Pandit, Parav; linux-rdma@vger.kernel.org
Subject: RE: [PATCH 1/9] ocrdma: Driver for Emulex OneConnect RDMA
adapter
+struct ocrdma_cq {
+ struct ib_cq ibcq
On Thu, Mar 22, 2012 at 7:27 AM, parav.pan...@emulex.com wrote:
I prefer to have it in this first patch and once the internal test cycle is
finish (with removed code) in few days, will submit the separate patch?
It's fine to leave some of these items for future cleanups post-merge.
Just
-Original Message-
From: Roland Dreier [mailto:rol...@purestorage.com]
Sent: Thursday, March 22, 2012 9:30 PM
To: Pandit, Parav
Cc: sean.he...@intel.com; linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/9] ocrdma: Driver for Emulex OneConnect RDMA
adapter
On Thu, Mar 22, 2012
+#define ocrdma_err(format, arg...) printk(KERN_ERR format, ##arg)
I think you'd be better off using pr_err() rather than defining your own macro.
+struct ocrdma_cq {
+ struct ib_cq ibcq;
+ struct ocrdma_dev *dev;
+ struct ocrdma_cqe *va;
+ u32 phase;
+ u32
On Tue, Mar 20, 2012 at 3:39 PM, parav.pan...@emulex.com wrote:
+struct ocrdma_queue_info {
+ void *va;
+ dma_addr_t dma;
+ u32 size;
+ u16 len;
+ u16 entry_size; /* Size of an element in the queue */
+ u16 id; /* qid, where to
+struct ocrdma_cq {
+ struct ib_cq ibcq;
+ struct ocrdma_dev *dev;
nit: There are several structures where you store ocrdma_dev *. You can remove
these and use the struct ib_* to reach it as well.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a
