Re: [PATCH RFC 2/9] IB/core: Introduce Signature Verbs API

2013-10-23 Thread Sagi Grimberg
On 10/22/2013 9:20 PM, Hefty, Sean wrote: Would we lose anything making this a new operation for the QP, versus trying to hook it into the existing ib_post_send call? If I understand correctly you are suggesting making it a verb? Well this operation is a fast-path operation - so I guess we

RE: [PATCH RFC 2/9] IB/core: Introduce Signature Verbs API

2013-10-22 Thread Hefty, Sean
I don't think so, Signature MR simply describes a signature associated memory region i.e. it is a memory region that also defines some signature operation offload aside from normal RDMA (for example validate strip). SGL are used to publish several rkeys for the server/target/peer to

RE: [PATCH RFC 2/9] IB/core: Introduce Signature Verbs API

2013-10-22 Thread Hefty, Sean
Would we lose anything making this a new operation for the QP, versus trying to hook it into the existing ib_post_send call? If I understand correctly you are suggesting making it a verb? Well this operation is a fast-path operation - so I guess we will loose it in this case. Take SCSI

RE: [PATCH RFC 2/9] IB/core: Introduce Signature Verbs API

2013-10-21 Thread Hefty, Sean
The signature handover operation is binding all the necessary information for the HCA together: where is the data (data_mr), where is the protection information (prot_mr), what are the signature properties (sig_attrs). Once this step is taken (WR is posted), a single MR (sig_mr) describes

Re: [PATCH RFC 2/9] IB/core: Introduce Signature Verbs API

2013-10-21 Thread Sagi Grimberg
On 10/21/2013 5:34 PM, Hefty, Sean wrote: The signature handover operation is binding all the necessary information for the HCA together: where is the data (data_mr), where is the protection information (prot_mr), what are the signature properties (sig_attrs). Once this step is taken (WR is

Re: [PATCH RFC 2/9] IB/core: Introduce Signature Verbs API

2013-10-20 Thread Sagi Grimberg
On 10/18/2013 1:51 AM, Hefty, Sean wrote: @@ -885,6 +901,19 @@ struct ib_send_wr { u32 rkey; struct ib_mw_bind_info bind_info; } bind_mw; + struct { + struct ib_sig_attrs

RE: [PATCH RFC 2/9] IB/core: Introduce Signature Verbs API

2013-10-17 Thread Hefty, Sean
@@ -885,6 +901,19 @@ struct ib_send_wr { u32 rkey; struct ib_mw_bind_info bind_info; } bind_mw; + struct { + struct ib_sig_attrs*sig_attrs; + struct ib_mr