RE: [PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and use-after-free

2015-10-26 Thread Hefty, Sean
> > Sean, I need to close on this patch. What is your position after > > Matan's explanation? > > > > Absent an objection from Sean, I've pulled this in. A use after free > bug is a pretty serious issue, and you've listed an error flow that > triggers it. The only thing bugging me is that this

Re: [PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and use-after-free

2015-10-21 Thread Doug Ledford
On 10/20/2015 04:27 PM, Doug Ledford wrote: > On 10/15/2015 11:15 AM, Matan Barak wrote: >> >> >> On 10/12/2015 7:37 PM, Hefty, Sean wrote: ib_send_cm_sidr_rep could sometimes erase the node from the sidr (depending on errors in the process). Since ib_send_cm_sidr_rep is called both

Re: [PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and use-after-free

2015-10-20 Thread Doug Ledford
On 10/15/2015 11:15 AM, Matan Barak wrote: > > > On 10/12/2015 7:37 PM, Hefty, Sean wrote: >>> ib_send_cm_sidr_rep could sometimes erase the node from the sidr >>> (depending on errors in the process). Since ib_send_cm_sidr_rep is >>> called both from cm_sidr_req_handler and cm_destroy_id, cm_id_

Re: [PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and use-after-free

2015-10-15 Thread Matan Barak
On 10/12/2015 7:37 PM, Hefty, Sean wrote: ib_send_cm_sidr_rep could sometimes erase the node from the sidr (depending on errors in the process). Since ib_send_cm_sidr_rep is called both from cm_sidr_req_handler and cm_destroy_id, cm_id_priv This should clarify that it is the app calling from

RE: [PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and use-after-free

2015-10-12 Thread Hefty, Sean
> ib_send_cm_sidr_rep could sometimes erase the node from the sidr > (depending on errors in the process). Since ib_send_cm_sidr_rep is > called both from cm_sidr_req_handler and cm_destroy_id, cm_id_priv This should clarify that it is the app calling from the callback, and not a direct call from

Re: [PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and use-after-free

2015-10-12 Thread Or Gerlitz
28 PM > To: Matan Barak > Cc: Doug Ledford ; linux-rdma@vger.kernel.org; Or > Gerlitz ; Eran Ben Elisha ; Sean > Hefty ; Jason Gunthorpe > ; Doron Tsur > Subject: Re: [PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and > use-after-free > >> Fixes: a977049dacde ('

Re: [PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and use-after-free

2015-10-11 Thread Or Gerlitz
> Fixes: a977049dacde ('[PATCH] IB: Add the kernel CM implementation') Please remove the the "[PATCH]" thing from the change-log and respin -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://