Re: [PATCH v2 05/13] IB/cm: Share listening CM IDs

2015-07-28 Thread Haggai Eran
On 28/07/2015 20:05, Hefty, Sean wrote: >> I think it would be better just to remove the service_mask parameter >> from this function, right? rdma_cm makes no use of the service mask. > > If it is not being used, then, yes, I would remove it. I'll do that, thanks. -- To unsubscribe from this lis

RE: [PATCH v2 05/13] IB/cm: Share listening CM IDs

2015-07-28 Thread Hefty, Sean
> I think it would be better just to remove the service_mask parameter > from this function, right? rdma_cm makes no use of the service mask. If it is not being used, then, yes, I would remove it. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to

Re: [PATCH v2 05/13] IB/cm: Share listening CM IDs

2015-07-28 Thread Haggai Eran
On 27/07/2015 22:04, Hefty, Sean wrote: >> +struct ib_cm_id *ib_cm_insert_listen(struct ib_device *device, >> > + ib_cm_handler cm_handler, >> > + __be64 service_id, __be64 service_mask) >> > +{ >> > + struct cm_id_private *cm_id_priv; >>

RE: [PATCH v2 05/13] IB/cm: Share listening CM IDs

2015-07-27 Thread Hefty, Sean
> +/** > + * Create a new listening ib_cm_id and listen on the given service ID. > + * > + * If there's an existing ID listening on that same device and service > ID, > + * return it. > + * > + * @device: Device associated with the cm_id. All related communication > will > + * be associated with t