RE: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-31 Thread Christoph Lameter
On Fri, 31 Jul 2015, Marciniszyn, Mike wrote: > > And lspci as well as other tools will not be able to distinguish between > > different versions of the hardware. > > Sorry if I misled. > > We do fully support the PCI revision number, and that will be set that diff= > erently for different hardwar

RE: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-31 Thread Marciniszyn, Mike
> > > If that wasn't done, the HW can't be changed, we are stuck with wonky > > sysfs files.. Try and get it right next time > > And lspci as well as other tools will not be able to distinguish between > different versions of the hardware. Sorry if I misled. We do fully support the PCI revisio

Re: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-31 Thread Christoph Lameter
On Fri, 31 Jul 2015, Jason Gunthorpe wrote: > If that wasn't done, the HW can't be changed, we are stuck with > wonky sysfs files.. Try and get it right next time And lspci as well as other tools will not be able to distinguish between different versions of the hardware. -- To unsubscribe from

Re: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-31 Thread Jason Gunthorpe
On Fri, Jul 31, 2015 at 03:32:07PM +, Marciniszyn, Mike wrote: > > > > > > +HFI1 > > > > > > + > > > > > > + The hfi1 driver also creates these additional files: > > > > > > + > > > > > > + hw_rev - hardware revision > > > >=20 > > > > I'm checking on this to see if it is indeed a duplicate.

RE: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-31 Thread Christoph Lameter
On Fri, 31 Jul 2015, Marciniszyn, Mike wrote: > > Please get someone knowledgeable at Intel to look at this. There is a (re= > v 04) > > when using lspci on my nic here. This seems to be the hardware revision. > >=20 > > I'm not sure what else to say other that the source for the sysfs file disp= >

RE: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-31 Thread Marciniszyn, Mike
> > > > > +HFI1 > > > > > + > > > > > + The hfi1 driver also creates these additional files: > > > > > + > > > > > + hw_rev - hardware revision > > >=20 > > > I'm checking on this to see if it is indeed a duplicate. > > >=20 > > > > Our hardware architect has indicated there is not PCIe equivale

RE: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-31 Thread Christoph Lameter
On Fri, 31 Jul 2015, Marciniszyn, Mike wrote: > > > > +HFI1 > > > > + > > > > + The hfi1 driver also creates these additional files: > > > > + > > > > + hw_rev - hardware revision > >=20 > > I'm checking on this to see if it is indeed a duplicate. > >=20 > > Our hardware architect has indicated

RE: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-31 Thread Marciniszyn, Mike
> > > +HFI1 > > > + > > > + The hfi1 driver also creates these additional files: > > > + > > > + hw_rev - hardware revision > > I'm checking on this to see if it is indeed a duplicate. > Our hardware architect has indicated there is not PCIe equivalent for this case. Mike -- To unsubscribe f

Re: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-31 Thread Christoph Lameter
On Thu, 30 Jul 2015, Jason Gunthorpe wrote: > I'm not sure, but I kinda remember there is even a PCI-E standard for > the temp sensor these days.. There is definitely lots of power / temperature related drivers and code in the kernel. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-30 Thread Jason Gunthorpe
On Thu, Jul 30, 2015 at 10:47:00PM +, Marciniszyn, Mike wrote: > I'm checking to make sure. > > Was this an lspci -vvv output for the example you showed? Yes. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org M

RE: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-30 Thread Marciniszyn, Mike
> > There is no PCIe equivalent. > > > > > > + serial - board serial number > > > > No PCIe equivalent. > > > > > > + boardversion - board version > > These all have PCI-E versions. Most should live in the config space VPD. > I'm not seeing VPD in our current cards. I'm checking to make sur

Re: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-30 Thread Jason Gunthorpe
On Thu, Jul 30, 2015 at 10:28:42PM +, Marciniszyn, Mike wrote: > > > + board_id - manufacturing board id > > There is no PCIe equivalent. > > > > + serial - board serial number > > No PCIe equivalent. > > > > + boardversion - board version These all have PCI-E versions. Most should l

RE: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-30 Thread Marciniszyn, Mike
> > +HFI1 > > + > > + The hfi1 driver also creates these additional files: > > + > > + hw_rev - hardware revision I'm checking on this to see if it is indeed a duplicate. > > + board_id - manufacturing board id There is no PCIe equivalent. > > + version - driver version This IS a duplic

Re: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

2015-07-30 Thread Christoph Lameter
On Thu, 30 Jul 2015, Mike Marciniszyn wrote: > +HFI1 > + > + The hfi1 driver also creates these additional files: > + > + hw_rev - hardware revision > + board_id - manufacturing board id > + version - driver version > + tempsense - thermal sense information > + serial - board serial num