RE: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Hefty, Sean
> For the UDP port used by the usNIC QP, the usnic_verbs kernel driver > requires user space to pass a file descriptor of a regular UDP socket down > at create_qp time. The reference count on this socket is incremented to > make sure that the socket can't disappear out from under us. Then an RX >

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Dave Goodell (dgoodell)
On Apr 28, 2015, at 2:53 PM, Hefty, Sean wrote: >> Is the concern here about CM issues or the UDP ports used by the actual >> usNIC RQs? > > UDP port space sharing For the UDP port used by the usNIC QP, the usnic_verbs kernel driver requires user space to pass a file descriptor of a regular U

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Doug Ledford
On Tue, 2015-04-28 at 12:56 -0600, Jason Gunthorpe wrote: > On Mon, Apr 27, 2015 at 09:24:35PM -0400, Doug Ledford wrote: > > On Mon, 2015-04-27 at 17:53 -0700, Tom Talpey wrote: > > > Having some of it refer to things as IBOE and some as ROCE would be > > similarly confusing, and switching existi

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Doug Ledford
On Tue, 2015-04-28 at 22:11 +0300, Or Gerlitz wrote: > On Tue, Apr 28, 2015 at 9:56 PM, Jason Gunthorpe > wrote: > > On Mon, Apr 27, 2015 at 09:24:35PM -0400, Doug Ledford wrote: > >> On Mon, 2015-04-27 at 17:53 -0700, Tom Talpey wrote: > > > >> Having some of it refer to things as IBOE and some a

RE: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Hefty, Sean
> Is the concern here about CM issues or the UDP ports used by the actual > usNIC RQs? UDP port space sharing -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Dave Goodell (dgoodell)
On Apr 28, 2015, at 1:14 AM, Hefty, Sean wrote: >>> Keep in mind that this enum was Liran's response to Michael's original >>> patch. In the enum in Michael's patch, there was both USNIC and >>> USNIC_UDP. >> >> Right! That's why I'm confused. Seems wrong to drop it, right? > > I think the ori

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Or Gerlitz
On Tue, Apr 28, 2015 at 9:56 PM, Jason Gunthorpe wrote: > On Mon, Apr 27, 2015 at 09:24:35PM -0400, Doug Ledford wrote: >> On Mon, 2015-04-27 at 17:53 -0700, Tom Talpey wrote: > >> Having some of it refer to things as IBOE and some as ROCE would be >> similarly confusing, and switching existing IB

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Jason Gunthorpe
On Mon, Apr 27, 2015 at 09:24:35PM -0400, Doug Ledford wrote: > On Mon, 2015-04-27 at 17:53 -0700, Tom Talpey wrote: > Having some of it refer to things as IBOE and some as ROCE would be > similarly confusing, and switching existing IBOE usage to ROCE would > cause pain to people with out of tree

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Michael Wang
On 04/28/2015 03:24 AM, Doug Ledford wrote: [snip] Also wondering, why add "UDP" to USNIC, is there a different USNIC? >>> >>> Yes, there are two transports, one a distinct ethertype and one that >>> encapsulates USNIC in UDP. >> >> But this new enum isn't about transport, it's about protoco

RE: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-27 Thread Hefty, Sean
> > Keep in mind that this enum was Liran's response to Michael's original > > patch. In the enum in Michael's patch, there was both USNIC and > > USNIC_UDP. > > Right! That's why I'm confused. Seems wrong to drop it, right? I think the original USNIC protocol is layered directly over Ethernet.

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-27 Thread Tom Talpey
On 4/27/2015 6:24 PM, Doug Ledford wrote: On Mon, 2015-04-27 at 17:53 -0700, Tom Talpey wrote: On 4/27/2015 5:36 PM, Doug Ledford wrote: On Mon, 2015-04-27 at 17:16 -0700, Tom Talpey wrote: On 4/27/2015 2:52 PM, ira.weiny wrote: On Mon, Apr 27, 2015 at 09:39:05AM +0200, Michael Wang wrote: O

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-27 Thread Doug Ledford
On Mon, 2015-04-27 at 17:53 -0700, Tom Talpey wrote: > On 4/27/2015 5:36 PM, Doug Ledford wrote: > > On Mon, 2015-04-27 at 17:16 -0700, Tom Talpey wrote: > >> On 4/27/2015 2:52 PM, ira.weiny wrote: > >>> On Mon, Apr 27, 2015 at 09:39:05AM +0200, Michael Wang wrote: > On 04/24/2015 05:12 PM, Li

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-27 Thread Tom Talpey
On 4/27/2015 5:36 PM, Doug Ledford wrote: On Mon, 2015-04-27 at 17:16 -0700, Tom Talpey wrote: On 4/27/2015 2:52 PM, ira.weiny wrote: On Mon, Apr 27, 2015 at 09:39:05AM +0200, Michael Wang wrote: On 04/24/2015 05:12 PM, Liran Liss wrote: [snip] Like: enum rdma_protocol { RDMA_PROTO

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-27 Thread Doug Ledford
On Mon, 2015-04-27 at 17:16 -0700, Tom Talpey wrote: > On 4/27/2015 2:52 PM, ira.weiny wrote: > > On Mon, Apr 27, 2015 at 09:39:05AM +0200, Michael Wang wrote: > >> > >> > >> On 04/24/2015 05:12 PM, Liran Liss wrote: > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > >>> [sn

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-27 Thread Tom Talpey
On 4/27/2015 2:52 PM, ira.weiny wrote: On Mon, Apr 27, 2015 at 09:39:05AM +0200, Michael Wang wrote: On 04/24/2015 05:12 PM, Liran Liss wrote: From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- [snip] a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 65994a1..d54f91e 100644

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-27 Thread ira.weiny
On Mon, Apr 27, 2015 at 09:39:05AM +0200, Michael Wang wrote: > > > On 04/24/2015 05:12 PM, Liran Liss wrote: > >> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > >> > > [snip] > >> a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index > >> 65994a1..d54f91e 100644 > >> --- a/incl

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-27 Thread Michael Wang
On 04/24/2015 05:12 PM, Liran Liss wrote: >> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- >> > [snip] >> a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index >> 65994a1..d54f91e 100644 >> --- a/include/rdma/ib_verbs.h >> +++ b/include/rdma/ib_verbs.h >> @@ -75,10 +75,13 @@ enum

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-24 Thread Doug Ledford
On Fri, 2015-04-24 at 10:46 -0400, Tom Talpey wrote: > On 4/24/2015 10:35 AM, Michael Wang wrote: > > > > > > On 04/24/2015 04:29 PM, Tom Talpey wrote: > >> On 4/24/2015 8:23 AM, Michael Wang wrote: > > [snip] > >>> +static enum rdma_transport_type > >>> +mlx5_ib_query_transport(struct ib_device *d

RE: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-24 Thread Liran Liss
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > [snip] > a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index > 65994a1..d54f91e 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -75,10 +75,13 @@ enum rdma_node_type { }; > > enum rdma_transport_type

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-24 Thread Tom Talpey
On 4/24/2015 10:35 AM, Michael Wang wrote: On 04/24/2015 04:29 PM, Tom Talpey wrote: On 4/24/2015 8:23 AM, Michael Wang wrote: [snip] +static enum rdma_transport_type +mlx5_ib_query_transport(struct ib_device *device, u8 port_num) +{ +return RDMA_TRANSPORT_IB; +} + Just noticed that m

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-24 Thread Michael Wang
On 04/24/2015 04:29 PM, Tom Talpey wrote: > On 4/24/2015 8:23 AM, Michael Wang wrote: [snip] >> +static enum rdma_transport_type >> +mlx5_ib_query_transport(struct ib_device *device, u8 port_num) >> +{ >> +return RDMA_TRANSPORT_IB; >> +} >> + > > > Just noticed that mlx5 is not being coded

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-24 Thread Tom Talpey
On 4/24/2015 8:23 AM, Michael Wang wrote: Add new callback query_transport() and implement for each HW. Mapping List: node-type link-layer old-transport new-transport ... mlx4IB_CA IB/ETH IB IB/IBOE mlx5IB_CA