RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-08-18 Thread Devesh Sharma
To: Chuck Lever Cc: Steve Wise; Shirley Ma; Hefty, Sean; Roland Dreier; linux- r...@vger.kernel.org Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma provider module -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-08-18 Thread Chuck Lever
31, 2014 10:45 AM To: Chuck Lever Cc: Steve Wise; Shirley Ma; Hefty, Sean; Roland Dreier; linux- r...@vger.kernel.org Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma provider module -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-30 Thread Chuck Lever
Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma provider module On Jul 21, 2014, at 1:07 PM, Devesh Sharma devesh.sha...@emulex.com wrote: Until that support is in place, obviously I would prefer that the removal of the underlying driver be prevented while there are NFS

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-30 Thread Devesh Sharma
Wise; Shirley Ma; Hefty, Sean; Roland Dreier; linux- r...@vger.kernel.org Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma provider module On Jul 21, 2014, at 1:07 PM, Devesh Sharma devesh.sha...@emulex.com wrote: Until that support is in place, obviously I would prefer

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-21 Thread Devesh Sharma
- From: Shirley Ma [mailto:shirley...@oracle.com] Sent: Friday, July 18, 2014 9:18 PM To: Steve Wise; Devesh Sharma; 'Chuck Lever' Cc: 'Hefty, Sean'; 'Roland Dreier'; linux-rdma@vger.kernel.org Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma provider module On 07/18/2014 06:27

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-21 Thread Devesh Sharma
Sent: Monday, July 21, 2014 11:42 AM To: Shirley Ma; Steve Wise; 'Chuck Lever' Cc: 'Hefty, Sean'; 'Roland Dreier'; linux-rdma@vger.kernel.org Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma provider module Shirley, Once rmmod is issued, the connection corresponding

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-21 Thread Chuck Lever
Of Devesh Sharma Sent: Monday, July 21, 2014 11:42 AM To: Shirley Ma; Steve Wise; 'Chuck Lever' Cc: 'Hefty, Sean'; 'Roland Dreier'; linux-rdma@vger.kernel.org Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma provider module Shirley, Once rmmod is issued, the connection

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-21 Thread Steve Wise
-Original Message- From: Chuck Lever [mailto:chuck.le...@oracle.com] Sent: Monday, July 21, 2014 9:54 AM To: Devesh Sharma Cc: Shirley Ma; Steve Wise; Hefty, Sean; Roland Dreier; linux-rdma@vger.kernel.org Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma provider

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-21 Thread Chuck Lever
@vger.kernel.org Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma provider module Hi Devesh- Thanks for drilling into this further. On Jul 21, 2014, at 7:48 AM, Devesh Sharma devesh.sha...@emulex.com wrote: In rpcrdma_ep_connect(): write_lock(ia-ri_qplock); old = ia

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-21 Thread Steve Wise
-rdma@vger.kernel.org Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma provider module Hi Devesh- Thanks for drilling into this further. On Jul 21, 2014, at 7:48 AM, Devesh Sharma devesh.sha...@emulex.com wrote: In rpcrdma_ep_connect(): write_lock(ia-ri_qplock

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-21 Thread Devesh Sharma
, Sean; Roland Dreier; linux-rdma@vger.kernel.org Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma provider module Hi Devesh- Thanks for drilling into this further. On Jul 21, 2014, at 7:48 AM, Devesh Sharma devesh.sha...@emulex.com wrote

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-21 Thread Chuck Lever
On Jul 21, 2014, at 1:07 PM, Devesh Sharma devesh.sha...@emulex.com wrote: Until that support is in place, obviously I would prefer that the removal of the underlying driver be prevented while there are NFS mounts in place. I think that's what NFS users have come to expect. In other words,

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-20 Thread Devesh Sharma
-Original Message- From: Steve Wise [mailto:sw...@opengridcomputing.com] Sent: Friday, July 18, 2014 6:58 PM To: Devesh Sharma; 'Chuck Lever' Cc: 'Hefty, Sean'; 'Shirley Ma'; 'Roland Dreier'; linux-rdma@vger.kernel.org Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-20 Thread Devesh Sharma
'; Devesh Sharma; 'Roland Dreier' Cc: linux-rdma@vger.kernel.org; chuck.le...@oracle.com Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma provider module -Original Message- From: Steve Wise [mailto:sw...@opengridcomputing.com] Sent: Thursday, July 17, 2014 2:56 PM

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-18 Thread Devesh Sharma
Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma provider module -Original Message- From: Steve Wise [mailto:sw...@opengridcomputing.com] Sent: Thursday, July 17, 2014 2:56 PM To: 'Hefty, Sean'; 'Shirley Ma'; 'Devesh Sharma'; 'Roland Dreier' Cc: 'linux-rdma

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-18 Thread Steve Wise
We can't really deal with a CM_DEVICE_REMOVE event while there are active NFS mounts. System shutdown ordering should guarantee (one would hope) that NFS mount points are unmounted before the RDMA/IB core infrastructure is torn down. Ordering shouldn't matter as long all NFS

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-18 Thread Chuck Lever
; 'Roland Dreier' Cc: linux-rdma@vger.kernel.org; chuck.le...@oracle.com Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma provider module -Original Message- From: Steve Wise [mailto:sw...@opengridcomputing.com] Sent: Thursday, July 17, 2014 2:56 PM To: 'Hefty, Sean

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-18 Thread Shirley Ma
On 07/18/2014 06:27 AM, Steve Wise wrote: We can't really deal with a CM_DEVICE_REMOVE event while there are active NFS mounts. System shutdown ordering should guarantee (one would hope) that NFS mount points are unmounted before the RDMA/IB core infrastructure is torn down. Ordering

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Steve Wise
On 7/17/2014 9:01 AM, Devesh Sharma wrote: If verndor driver is attempted for removal while xprtrdma still has an active mount, the removal of driver may never complete and can cause unseen races or in worst case system crash. To solve this, xprtrdma module should get reference of struct

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Chuck Lever
On Jul 17, 2014, at 11:01 AM, Steve Wise sw...@opengridcomputing.com wrote: On 7/17/2014 9:01 AM, Devesh Sharma wrote: If verndor driver is attempted for removal while xprtrdma still has an active mount, the removal of driver may never complete and can cause unseen races or in worst case

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Devesh Sharma
From: Steve Wise [sw...@opengridcomputing.com] Sent: Thursday, July 17, 2014 8:31 PM To: Devesh Sharma; Roland Dreier; Hefty, Sean Cc: linux-rdma@vger.kernel.org; chuck.le...@oracle.com Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma provider

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Devesh Sharma
Replying again, due to mail formatting issue: -Original Message- From: Chuck Lever [mailto:chuck.le...@oracle.com] Sent: Thursday, July 17, 2014 8:36 PM To: Steve Wise Cc: Devesh Sharma; Roland Dreier; Hefty, Sean; linux-rdma@vger.kernel.org Subject: Re: [for-next 1/2] xprtrdma

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Hefty, Sean
On 7/17/2014 9:01 AM, Devesh Sharma wrote: If verndor driver is attempted for removal while xprtrdma still has an active mount, the removal of driver may never complete and can cause unseen races or in worst case system crash. To solve this, xprtrdma module should get reference of

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Steve Wise
-Original Message- From: Shirley Ma [mailto:shirley...@oracle.com] Sent: Thursday, July 17, 2014 1:58 PM To: Hefty, Sean; Steve Wise; Devesh Sharma; Roland Dreier Cc: linux-rdma@vger.kernel.org; chuck.le...@oracle.com Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Steve Wise
-Original Message- From: Hefty, Sean [mailto:sean.he...@intel.com] Sent: Thursday, July 17, 2014 2:50 PM To: Steve Wise; 'Shirley Ma'; 'Devesh Sharma'; 'Roland Dreier' Cc: linux-rdma@vger.kernel.org; chuck.le...@oracle.com Subject: RE: [for-next 1/2] xprtrdma: take reference

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Steve Wise
: [for-next 1/2] xprtrdma: take reference of rdma provider module So the rdma cm is expected to increase the driver reference count (try_module_get) for each new cm id, then deference count (module_put) when cm id is destroyed? No, I think he's saying the rdma-cm posts

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Shirley Ma
: [for-next 1/2] xprtrdma: take reference of rdma provider module So the rdma cm is expected to increase the driver reference count (try_module_get) for each new cm id, then deference count (module_put) when cm id is destroyed? No, I think he's saying the rdma-cm posts a RDMA_CM_DEVICE_REMOVAL

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Chuck Lever
@vger.kernel.org'; 'chuck.le...@oracle.com' Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma provider module -Original Message- From: Hefty, Sean [mailto:sean.he...@intel.com] Sent: Thursday, July 17, 2014 2:50 PM To: Steve Wise; 'Shirley Ma'; 'Devesh Sharma'; 'Roland Dreier' Cc

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Steve Wise
'; 'Shirley Ma'; 'Devesh Sharma'; 'Roland Dreier' Cc: 'linux-rdma@vger.kernel.org'; 'chuck.le...@oracle.com' Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma provider module -Original Message- From: Hefty, Sean [mailto:sean.he...@intel.com] Sent: Thursday, July 17

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Devesh Sharma
: RE: [for-next 1/2] xprtrdma: take reference of rdma provider module -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Chuck Lever Sent: Thursday, July 17, 2014 3:42 PM To: Steve Wise Cc: Hefty, Sean; Shirley Ma