Re: [infiniband:for-next 769/772] drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user

2013-07-08 Thread Or Gerlitz
On 08/07/2013 12:40, Fengguang Wu wrote: Hi Eli, FYI, there are coccinelle warnings in tree: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-next head: 1af1abad19f6a40d8822cb7a35736e9e102fade6 commit: 809d3a921f9047bf575488f410ed12b365fe5cd7 [769/772] mlx5: Add

Re: [infiniband:for-next 769/772] drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user

2013-07-08 Thread Or Gerlitz
On 08/07/2013 13:58, Fengguang Wu wrote: Roland, you may need to replace some with \t in the patches. Thanks, Fengguang Roland, I have prepared these patches properly and will send them to you, they can be just squashed into the initial commit or come as add on patches. Or. -- To

[PATCH 0/2] Fixes to issues in mlx5 code found by static checker

2013-07-08 Thread Or Gerlitz
All Reported-by Fengguang Wu fengguang...@intel.com Or Gerlitz (2): mlx5: Use simple_open when possible IB/mlx5: Removes unneeded semicolons drivers/infiniband/hw/mlx5/mr.c | 15 --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 13

[PATCH 2/2] IB/mlx5: Removes unneeded semicolons

2013-07-08 Thread Or Gerlitz
Found by coccinelle Generated by: coccinelle/misc/semicolon.cocci Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx5/mr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband

[PATCH 1/2] mlx5: Use simple_open when possible

2013-07-08 Thread Or Gerlitz
If the open entry for char-device just does file-private_data = inode-i_private; we can use simple_open instead. Generated by: coccinelle/api/simple_open.cocci Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw

Re: [PATCH 1/2] mlx5: Use simple_open when possible

2013-07-08 Thread Or Gerlitz
On 08/07/2013 15:34, Fengguang Wu wrote: The above chunks will need to fix alignments. sure -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH V1 0/2] Fixes to issues in mlx5 code found by static checker

2013-07-08 Thread Or Gerlitz
All Reported-by Fengguang Wu fengguang...@intel.com changes from V0: - replaced space with tabs in few places Or Gerlitz (2): mlx5: Use simple_open when possible IB/mlx5: Removes unneeded semicolons drivers/infiniband/hw/mlx5/mr.c | 15 --- drivers/net

[PATCH V1 1/2] mlx5: Use simple_open when possible

2013-07-08 Thread Or Gerlitz
If the open entry for char-device just does file-private_data = inode-i_private; we can use simple_open instead. Generated by: coccinelle/api/simple_open.cocci Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw

[PATCH V1 2/2] IB/mlx5: Remove unneeded semicolons

2013-07-08 Thread Or Gerlitz
Found by coccinelle Generated by: coccinelle/misc/semicolon.cocci Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx5/mr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband

[PATCH 0/3] iSER initiator updates for 3.11

2013-07-08 Thread Or Gerlitz
be ready by next week. Or. Or Gerlitz (1): IB/iser: Use proper debug level value for info prints Shlomo Pongratz (2): IB/iser: Restructure allocation/deallocation of connection resources IB/iser: Accept session-cmds_max from user space drivers/infiniband/ulp/iser/iscsi_iser.c | 19

[PATCH 3/3] IB/iser: Accept session-cmds_max from user space

2013-07-08 Thread Or Gerlitz
...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.c | 19 --- drivers/infiniband/ulp/iser/iscsi_iser.h | 21 +++-- drivers/infiniband/ulp/iser/iser_initiator.c | 25 +++-- drivers

[PATCH 2/3] IB/iser: Restructure allocation/deallocation of connection resources

2013-07-08 Thread Or Gerlitz
to the allocation one. Signed-off-by: Shlomo Pongratz shlo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |2 + drivers/infiniband/ulp/iser/iser_initiator.c | 92 ++- drivers/infiniband/ulp/iser/iser_verbs.c

[PATCH 1/3] IB/iser: Use proper debug level value for info prints

2013-07-08 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |4 ++-- drivers/infiniband/ulp/iser/iser_memory.c | 13 ++--- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser

Re: [PATCH 3/3] IB/iser: Accept session-cmds_max from user space

2013-07-08 Thread Or Gerlitz
On 08/07/2013 17:00, Bart Van Assche wrote: On 07/08/13 15:19, Or Gerlitz wrote: +#define ISER_DEF_XMIT_CMDS_DEFUALT 512 +#if ISCSI_DEF_XMIT_CMDS_MAX ISER_DEF_XMIT_CMDS_DEFUALT This looks like another spelling issue - shouldn't DEFUALT be changed into DEFAULT ? Bart. thanks

[PATCH V1 1/3] IB/iser: Use proper debug level value for info prints

2013-07-08 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |4 ++-- drivers/infiniband/ulp/iser/iser_memory.c | 13 ++--- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser

[PATCH V1 0/3] iSER initiator updates for 3.11

2013-07-08 Thread Or Gerlitz
be ready by next week. changes from V0: - fixed two typos pointed by Bart Van Assche (thanks!) Or. Or Gerlitz (1): IB/iser: Use proper debug level value for info prints Shlomo Pongratz (2): IB/iser: Restructure allocation/deallocation of connection resources IB/iser: Accept session

[PATCH V1 2/3] IB/iser: Restructure allocation/deallocation of connection resources

2013-07-08 Thread Or Gerlitz
to the allocation one. Signed-off-by: Shlomo Pongratz shlo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |2 + drivers/infiniband/ulp/iser/iser_initiator.c | 92 ++- drivers/infiniband/ulp/iser/iser_verbs.c

[PATCH V1 3/3] IB/iser: Accept session-cmds_max from user space

2013-07-08 Thread Or Gerlitz
...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.c | 19 --- drivers/infiniband/ulp/iser/iscsi_iser.h | 21 +++-- drivers/infiniband/ulp/iser/iser_initiator.c | 25 +++-- drivers

Re: mlx5: Add driver for Mellanox Connect-IB adapters

2013-07-10 Thread Or Gerlitz
On 10/07/2013 13:54, Dan Carpenter wrote: --- Side note: Sparse should warn about endian bugs but in linux-next endian checking is disabled because we hit: include/uapi/linux/swab.h:71:16: error: undefined identifier '__builtin_bswap64' include/uapi/linux/swab.h:71:33: error: not a function

[PATCH] mlx5_core: Adjust hca_cap.uar_page_sz to conform to Connect-IB spec

2013-07-10 Thread Or Gerlitz
, and incidentally fix the endianness bug reported by sparse. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Moshe Lazer mos...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/net/ethernet/mellanox/mlx5/core/main.c |2 +- include/linux/mlx5/device.h

Re: [patch -next] mlx5: return -EFAULT instead of -EPERM

2013-07-10 Thread Or Gerlitz
; + return -EFAULT; outlen_str[7] = 0; As Eli is still OOO (coming back soon...) Acked-by: Or Gerlitz ogerl...@mellanox.com -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [patch -next] mlx5_core: return -EFAULT if copy_to_user() fails

2013-07-10 Thread Or Gerlitz
); if (ret 0) { - err = copy_to_user(buf, tbuf, ret); - if (err) - return err; + if (copy_to_user(buf, tbuf, ret)) + return -EFAULT; } *pos += ret; ditto here Acked-by: Or Gerlitz ogerl

[PATCH libibverbs] Fix configure regression that disallowed building on older systems

2013-07-11 Thread Or Gerlitz
From: Or Gerlitz ogerl...@mellanox.com Commit 9bbd803 configure: Apply updates proposed by autoupdate forced the autoconf package on the builder node to be of version 2.67 or higher. This doesn't allow to build the library e.g on RHEL 6.x systems who install this set of tools autofs

Re: [PATCH libibverbs] Fix configure regression that disallowed building on older systems

2013-07-11 Thread Or Gerlitz
On 11/07/2013 14:03, Yann Droneaud wrote: If the release tarball is used, the library should build regardless of the installed autoconf/automake. indeed, but when we d/d (develop/debug) with the library we should be able to build it through simple configure and make -- To unsubscribe from this

[PATCH V2 6/8] IB/core: Add RoCE IP based addressing extensions for uverbs

2013-07-11 Thread Or Gerlitz
CREATE_AH_EX command that uses a new struct ib_uverbs_create_ah_ex. struct ib_user_path_rec was extended too, to contain source and destination MAC and VLAN ID, this structure is of use by the rdma_ucm driver. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com

[PATCH V2 1/8] IB/core: Ethernet L2 attributes in verbs/cm structures

2013-07-11 Thread Or Gerlitz
they are irrelevant for IB. Vendor drivers are modified to support the new function signature. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/cm.c| 58 ++ drivers/infiniband/core/cma.c

[PATCH V2 8/8] IB/mlx4: Enable mlx4_ib support for MODIFY_QP_EX

2013-07-11 Thread Or Gerlitz
From: Matan Barak mat...@mellanox.com mlx4_ib driver should indicate that it supports MODIFY_QP_EX user verbs extended command. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c |3 ++- 1 files changed, 2

[PATCH V2 2/8] IB/CMA: RoCE IP based GID addressing

2013-07-11 Thread Or Gerlitz
parameters are not longer encoded within gids, had to extend the Infiniband address structures (e.g. ib_ah_attr) with layer 2 address parameters, namely mac and vlan. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/cma.c

[PATCH V2 4/8] IB/mlx4: Handle Ethernet L2 parameters for IP based GID addressing

2013-07-11 Thread Or Gerlitz
, instead of parsing the dgid to get the MAC and VLAN, take them from the address handle attributes. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/ah.c | 24 +++- drivers/infiniband/hw/mlx4/cq.c

[PATCH V2 0/8] IP based RoCE GID Addressing

2013-07-11 Thread Or Gerlitz
Currently, the IB stack (core + drivers) handle RoCE (IBoE) gids as they encode related Ethernet net-device interface MAC address and possibly VLAN id. This series changes RoCE GIDs to encode IP addresses (IPv4 + IPv6) of the that Ethernet interface, under the following reasoning: 1. There are

[PATCH V2 3/8] IB/mlx4: Use RoCE IP based GIDs in the port GID table

2013-07-11 Thread Or Gerlitz
on top of that port so this should be considered when building and maintaining the gid table. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c| 476 +++-- drivers/infiniband/hw/mlx4

[PATCH V2 5/8] IB/core: Infra-structure to support verbs extensions through uverbs

2013-07-11 Thread Or Gerlitz
and processed a bit differently. Signed-off-by: Igor Ivanov igor.iva...@itseez.com Signed-off-by: Hadar Hen Zion had...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/uverbs_main.c | 29 - include/uapi/rdma/ib_user_verbs.h

[PATCH V2 7/8] IB/core: Add RoCE IP based addressing extensions for rdma_ucm

2013-07-11 Thread Or Gerlitz
uses ib_user_path_rec_ex Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/ucma.c | 175 - include/uapi/rdma/rdma_user_cm.h | 29 ++- 2 files changed, 198 insertions(+), 6

Re: [GIT PULL] please pull infiniband.git

2013-07-11 Thread Or Gerlitz
On Fri, Jul 12, 2013 at 2:52 AM, Roland Dreier rol...@kernel.org wrote: Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus What happened to the July 10th pull request, was it lost? -- To unsubscribe from this list: send

Re: ibdiagnet: ibdiagnet /tmp clobbering vulnerability

2013-07-15 Thread Or Gerlitz
On 15/07/2013 08:19, Pramod Gunjikar wrote: Sending this on behalf of Rajkumar Sivaprakasam. you didn't copy the author -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: mlx5: Add driver for Mellanox Connect-IB adapters

2013-07-15 Thread Or Gerlitz
On 10/07/2013 13:55, Dan Carpenter wrote: Hello Eli Cohen, The patch e126ba97dba9: mlx5: Add driver for Mellanox Connect-IB adapters from Jul 7, 2013, leads to the following Smatch warning: drivers/net/ethernet/mellanox/mlx5/core/cmd.c:822 mlx5_alloc_cmd_msg() warn: use 'flags' here

Re: [PATCH for-next 0/4] IP based RoCE GID Addressing

2013-07-15 Thread Or Gerlitz
Devesh Sharma deves...@gmail.com wrote: [...] What will happen to those devices which does not suppot IP based RoCE, How connection management will happen with those if Native RoCE support is removed. There may be other devices/implementations which does not support IP Base RoCE. RoCE GIDs

Re: [PATCH V2 for-next 2/4] IB/core: Infra-structure to support verbs extensions through uverbs

2013-07-15 Thread Or Gerlitz
On Tue, Jul 9, 2013 at 6:00 PM, Tzahi Oved tza...@mellanox.com wrote: On 26/06/2013 16:05, Roland Dreier wrote: I don't understand what extended capabilities are or why we need to change the header format. First let me clarify the target of *this* patch - allow extending uverbs new

Re: [PATCH librdmacm 3/8] autogen.sh: Use autoreconf in autogen.sh

2013-07-17 Thread Or Gerlitz
On 17/07/2013 07:22, Hefty, Sean wrote: Thanks - I pulled in these patches, but see below: Hi Sean, If you do this house cleanup, could you also address the below build warnings. I can see them when I build rpm from the 1.0.17 tar ball, but not when doing plain make on the latest git,

[PATCH FIXES for-3.11 4/4] IB/ipoib: Fix pkey-change flow for Virtualization environments

2013-07-17 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib_ib.c| 68 +++- drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 12 - 2 files changed, 66 insertions(+), 14 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband

[PATCH FIXES for-3.11 1/4] IB/core: Create QP1 using the pkey index which contains the default pkey

2013-07-17 Thread Or Gerlitz
-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/mad.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index dc3fd1e..9be6754

[PATCH FIXES for-3.11 3/4] IB/ipoib: Make sure child devices use valid/proper pkeys

2013-07-17 Thread Or Gerlitz
Make sure that the IB invalid pkey (0x or 0x8000) isn't used for child devices. Also, make sure to always set the full membership bit for the pkey of devices created by rtnl link ops. Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib_main.c|2

[PATCH FIXES for-3.11 2/4] IB/mlx4: Use default pkey when creating tunnel QPs

2013-07-17 Thread Or Gerlitz
to search for the default pkey in the slave's pkey table -- and this pkey is present in the table (at index 0) at tunnel QP creation time, so that the tunnel QP creation will succeed. Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers

[PATCH FIXES for-3.11 0/4] Pkey fixes for IB core and IPoIB

2013-07-17 Thread Or Gerlitz
: Fix pkey-change flow for Virtualization environments Jack Morgenstein (2): IB/core: Create QP1 using the pkey index which contains the default pkey IB/mlx4: Use default pkey when creating tunnel QPs Or Gerlitz (1): IB/ipoib: Make sure child devices use valid/proper pkeys drivers

[PATCH REPOST FIXES for-3.11 1/4] IB/core: Create QP1 using the pkey index which contains the default pkey

2013-07-17 Thread Or Gerlitz
-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/mad.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index dc3fd1e..9be6754

[PATCH REPOST FIXES for-3.11 4/4] IB/ipoib: Fix pkey-change flow for Virtualization environments

2013-07-17 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib_ib.c | 76 +- 1 files changed, 63 insertions(+), 13 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c index 2cfa76f..196b1d1 100644

Re: [PATCH REPOST FIXES for-3.11 1/4] IB/core: Create QP1 using the pkey index which contains the default pkey

2013-07-18 Thread Or Gerlitz
On 17/07/2013 19:31, Hefty, Sean wrote: diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index dc3fd1e..9be6754 100644 --- a/drivers/infiniband/core/mad.c +++ b/drivers/infiniband/core/mad.c @@ -2663,6 +2663,7 @@ static int ib_mad_port_start(struct ib_mad_port_private

[PATCH V1 FIXES for-3.11 3/4] IB/ipoib: Make sure child devices use valid/proper pkeys

2013-07-18 Thread Or Gerlitz
Make sure that the IB invalid pkey (0x or 0x8000) isn't used for child devices. Also, make sure to always set the full membership bit for the pkey of devices created by rtnl link ops. Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib_main.c|2

[PATCH V1 FIXES for-3.11 2/4] IB/mlx4: Use default pkey when creating tunnel QPs

2013-07-18 Thread Or Gerlitz
to search for the default pkey in the slave's pkey table -- and this pkey is present in the table (at index 0) at tunnel QP creation time, so that the tunnel QP creation will succeed. Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers

[PATCH V1 FIXES for-3.11 4/4] IB/ipoib: Fix pkey-change flow for Virtualization environments

2013-07-18 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib_ib.c | 76 +- 1 files changed, 63 insertions(+), 13 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c index 2cfa76f..196b1d1 100644

[PATCH V1 FIXES for-3.11 1/4] IB/core: Create QP1 using the pkey index which contains the default pkey

2013-07-18 Thread Or Gerlitz
). Reviewed-by: Sean Hefty sean.he...@intel.com Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/mad.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/core/mad.c b/drivers

[PATCH for-3.11 1/7] IB/iser: Use proper debug level value for info prints

2013-07-18 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |4 ++-- drivers/infiniband/ulp/iser/iser_memory.c | 13 ++--- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser

[PATCH for-3.11 5/7] IB/iser: Handle unaligned SG in separate function

2013-07-18 Thread Or Gerlitz
, and call them from there, later they will be called also from other reg methods code. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iser_memory.c | 66 +++-- 1 files changed, 43 insertions

[PATCH for-3.11 0/7] Add Fast-Reg support to the iser initiator driver

2013-07-18 Thread Or Gerlitz
. Or. Or Gerlitz (1): IB/iser: Use proper debug level value for info prints Sagi Grimberg (4): IB/iser: Generalize rdma memory registration IB/iser: Handle unaligned SG in separate function IB/iser: Place the fmr pool into a union in iser's IB conn struct IB/iser: Introduce fast memory registration

[PATCH for-3.11 7/7] IB/iser: Introduce fast memory registration model (FRWR)

2013-07-18 Thread Or Gerlitz
of appropriate resources (fast_reg descriptors). Registration is done using posting IB_WR_FAST_REG_MR to the QP and invalidations using posting IB_WR_LOCAL_INV. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h | 21

[PATCH for-3.11 3/7] IB/iser: Accept session-cmds_max from user space

2013-07-18 Thread Or Gerlitz
...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.c | 19 --- drivers/infiniband/ulp/iser/iscsi_iser.h | 21 +++-- drivers/infiniband/ulp/iser/iser_initiator.c | 25 +++-- drivers

[PATCH for-3.11 6/7] IB/iser: Place the fmr pool into a union in iser's IB conn struct

2013-07-18 Thread Or Gerlitz
From: Sagi Grimberg sa...@mellanox.com This is preparation step for other memory registration methods to be added. In addition, change reg/unreg routines signature to indicate they use FMRs. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com

[PATCH for-3.11 4/7] IB/iser: Generalize rdma memory registration

2013-07-18 Thread Or Gerlitz
be function pointers which are now just set to the existing FMR ones. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h | 13 +++- drivers/infiniband/ulp/iser/iser_initiator.c | 28

[PATCH for-3.11 2/7] IB/iser: Restructure allocation/deallocation of connection resources

2013-07-18 Thread Or Gerlitz
to the allocation one. Signed-off-by: Shlomo Pongratz shlo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |2 + drivers/infiniband/ulp/iser/iser_initiator.c | 92 ++- drivers/infiniband/ulp/iser/iser_verbs.c

Re: [PATCH V7 libibverbs 0/7] Add extension and XRC QP support

2013-07-18 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Mon, Jul 15, 2013 at 03:40:47PM +0300, Yishai Hadas wrote: Let me clarify the place holder reservation mentioned in the cover letter. The entries I was referring to are not proprietary vendor verbs but rather user space verbs who are

Re: [PATCH for-3.11 7/7] IB/iser: Introduce fast memory registration model (FRWR)

2013-07-22 Thread Or Gerlitz
On Mon, Jul 22, 2013 at 2:46 PM, Bart Van Assche bvanass...@acm.org wrote: [...] What will happen if a new FRWR is submitted with an rkey that is still valid ? The HW will fail this WR, we must invalidate the mapping before re-using the MR. Or. -- To unsubscribe from this list: send the line

Re: [PATCH for-3.11 7/7] IB/iser: Introduce fast memory registration model (FRWR)

2013-07-23 Thread Or Gerlitz
On Tue, Jul 23, 2013 at 2:58 PM, Bart Van Assche bvanass...@acm.org wrote: [...] Hello Sagi and Or, Thanks for the clarifications. I have one more question though. My interpretation of section 10.6 Memory Management in the IB specification is that memory registration maps a memory region

Re: infiniband build warning

2013-07-23 Thread Or Gerlitz
On Mon, Jul 22, 2013 at 8:40 AM, Hefty, Sean sean.he...@intel.com wrote: I am seeing build warnings in drivers/infiniband/core/cma.c starting with v3.11-rc1. These can be reproduced with gcc 4.6.3. Would you consider applying the following fix ? A patch to fix this was submitted to the

Re: [PATCH, RFC] mlx4: Avoid that mlx4_cmd_wait() contributes to the system load

2013-07-24 Thread Or Gerlitz
On 22/07/2013 18:23, Bart Van Assche wrote: Avoid that kernel threads running mlx4_cmd_wait() contribute to the system load by setting the task state to TASK_INTERRUPTIBLE instead of TASK_UNINTERRUPTIBLE while waiting. This patch reduces the load average from about 0.5 to about 0.0 on an idle

Re: [PATCH for-3.11 7/7] IB/iser: Introduce fast memory registration model (FRWR)

2013-07-24 Thread Or Gerlitz
On 23/07/2013 17:47, Bart Van Assche wrote: Sorry but I had overlooked the bounce buffer patch. Regarding page sizes: is an InfiniBand HCA required to support a page size of 512 bytes ? To me it seems like the smallest page size supported by e.g. the ocrdma driver is 4KB. From

Re: [PATCH, RFC] mlx4: Avoid that mlx4_cmd_wait() contributes to the system load

2013-07-24 Thread Or Gerlitz
On 24/07/2013 19:48, Bart Van Assche wrote: I saw a load of 0.5 with several different upstream kernels (3.6..3.10 at least). The only IB-related process that was running on the system was opensmd. This is definitely reproducible. It was only a month after I had noticed this phenomenon that I

Re: [PATCH for-3.11 7/7] IB/iser: Introduce fast memory registration model (FRWR)

2013-07-28 Thread Or Gerlitz
On 26/07/2013 20:15, Vu Pham wrote: Hello Or/Sagi, Just a minor /** + * iser_create_frwr_pool - Creates pool of fast_reg descriptors + * for fast registration work requests. + * returns 0 on success, or errno code on failure + */ +int iser_create_frwr_pool(struct iser_conn *ib_conn, unsigned

[PATCH V1 for-3.11 1/7] IB/iser: Use proper debug level value for info prints

2013-07-28 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |4 ++-- drivers/infiniband/ulp/iser/iser_memory.c | 13 ++--- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser

[PATCH V1 for-3.11 2/7] IB/iser: Restructure allocation/deallocation of connection resources

2013-07-28 Thread Or Gerlitz
to the allocation one. Signed-off-by: Shlomo Pongratz shlo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |2 + drivers/infiniband/ulp/iser/iser_initiator.c | 92 ++- drivers/infiniband/ulp/iser/iser_verbs.c

[PATCH V1 for-3.11 0/7] Add Fast-Reg support to the iser initiator driver

2013-07-28 Thread Or Gerlitz
pre-steps for allowing more registration models such as FastReg WRs except for FMR, and the last patch adds the actual support for fastreg. Or. Or Gerlitz (1): IB/iser: Use proper debug level value for info prints Sagi Grimberg (4): IB/iser: Generalize rdma memory registration IB/iser

[PATCH V1 for-3.11 3/7] IB/iser: Accept session-cmds_max from user space

2013-07-28 Thread Or Gerlitz
...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.c | 19 --- drivers/infiniband/ulp/iser/iscsi_iser.h | 21 +++-- drivers/infiniband/ulp/iser/iser_initiator.c | 25 +++-- drivers

[PATCH V1 for-3.11 6/7] IB/iser: Place the fmr pool into a union in iser's IB conn struct

2013-07-28 Thread Or Gerlitz
From: Sagi Grimberg sa...@mellanox.com This is preparation step for other memory registration methods to be added. In addition, change reg/unreg routines signature to indicate they use FMRs. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com

[PATCH V1 for-3.11 5/7] IB/iser: Handle unaligned SG in separate function

2013-07-28 Thread Or Gerlitz
, and call them from there, later they will be called also from other reg methods code. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iser_memory.c | 66 +++-- 1 files changed, 43 insertions

[PATCH V1 for-3.11 7/7] IB/iser: Introduce fast memory registration model (FRWR)

2013-07-28 Thread Or Gerlitz
of appropriate resources (fast_reg descriptors). Registration is done using posting IB_WR_FAST_REG_MR to the QP and invalidations using posting IB_WR_LOCAL_INV. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h

Re: [PATCH] mlx5: Implement new initialization sequence

2013-07-30 Thread Or Gerlitz
On Thu, Jul 18, 2013 at 3:31 PM, Eli Cohen e...@dev.mellanox.co.il wrote: Introduce enbale_hca and disable_hca commands to signify when the driver starts or ceases to operate on the device. In addition the driver will use boot and init pages count; boot pages is required to allow firmware to

Re: [PATCH librdmacm 3/8] autogen.sh: Use autoreconf in autogen.sh

2013-07-31 Thread Or Gerlitz
On 17/07/2013 09:58, Or Gerlitz wrote: On 17/07/2013 07:22, Hefty, Sean wrote: Thanks - I pulled in these patches, but see below: Hi Sean, If you do this house cleanup, could you also address the below build warnings. I can see them when I build rpm from the 1.0.17 tar ball, but not when

[PATCH 1/3] net/mlx4_core: Fix XRC QPs detection in the resource tracker

2013-08-01 Thread Or Gerlitz
Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- .../net/ethernet/mellanox/mlx4/resource_tracker.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4

[PATCH 0/3] XRC fixes

2013-08-01 Thread Or Gerlitz
Hi Roland, Here are some XRC fixes from Yishai and Jack. Basically they all are fixes and have good match for 3.11, but if this works better for you, we can merge them for 3.12 too and later get them back in to 3.10 and 3.11 through -stable, please let me know what's your preference. Sean,

[PATCH 2/3] IB/core: Add locking around event dispatching on XRC target QPs

2013-08-01 Thread Or Gerlitz
within the handler. Signed-off-by: Yishai Hadas yish...@mellanox.com Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/verbs.c |3 +++ include/rdma/ib_verbs.h |6 ++ 2 files changed, 9 insertions

Re: [PATCH V1 FIXES for-3.11 0/4] Pkey fixes for IB core and IPoIB

2013-08-03 Thread Or Gerlitz
On Thu, Aug 1, 2013 at 12:42 PM, Or Gerlitz ogerl...@mellanox.com wrote: I think its perfectly OK to expect a written answer from you on the iser patches. Are you OK with merging them for 3.11 or they will have to wait for 3.12? They bring in the benefit of avoiding bounce buffer when used

Re: [PATCH V1 FIXES for-3.11 0/4] Pkey fixes for IB core and IPoIB

2013-08-05 Thread Or Gerlitz
On Mon, Aug 5, 2013 at 9:40 PM, Roland Dreier rol...@kernel.org wrote: Yes, the iSER stuff looks fine for the 3.12 merge window. OK, good. So we're post 3.11-rc4 now, which means the merge window can be three weeks away. Are you planning to pick 3.12 materials such as the iser series and more

Re: [PATCH v3.10.y 0/4] IB/IPoIB fixes for SRIOV / cloud environment

2013-08-06 Thread Or Gerlitz
On 06/08/2013 12:38, Greg KH wrote: On Tue, Aug 06, 2013 at 11:38:38AM +0300, Or Gerlitz wrote: Hi Greg, This series contains few fixes to the IB core, mlx4 IB driver and IPoIB. The patches enable working properly with IPoIB devices set over SRIOV Virtual Functions probed to VMs in cloud

Re: [PATCH V3 for-next 0/4] Add receive Flow Steering support

2013-08-06 Thread Or Gerlitz
On 05/08/2013 23:54, Shawn Bohrer wrote: The problem with running and testing this code is that many of these features are posted in incomplete (from the user point of view) chunks. As an example I don't really see how anyone is currently using raw QPs on upstream code since this flow steering

Re: [PATCH V1 FIXES for-3.11 0/4] Pkey fixes for IB core and IPoIB

2013-08-06 Thread Or Gerlitz
On Tue, Aug 6, 2013 at 6:13 AM, Roland Dreier rol...@kernel.org wrote: On Mon, Aug 5, 2013 at 2:02 PM, Or Gerlitz or.gerl...@gmail.com wrote: OK, good. So we're post 3.11-rc4 now, which means the merge window can be three weeks away. Are you planning to pick 3.12 materials such as the iser

Re: [PATCH V9 libmlx4 0/2] Add extension and XRC QP support

2013-08-06 Thread Or Gerlitz
On Thu, Aug 1, 2013 at 6:05 PM, Yishai Hadas yish...@mellanox.com wrote: Extend XRC support to user space. Because XRC requires new verbs and extensions to existing verbs, we first implement the infra-structure changes needed to support verbs extensions matching to libibverbs scheme, later XRC

Re: [PATCH 0/8] Critical bug fixes for RDMA/cxgb4

2013-08-06 Thread Or Gerlitz
On Tue, Aug 6, 2013 at 6:34 PM, Vipul Pandya vi...@chelsio.com wrote: [...] The patch-series is based on Roland's infiniband tree for-next branch. This series is on top of previously submitted series Add IPv6 support for iWARP We request Roland to merge above series first and then apply

Re: [PATCH V1 FIXES for-3.11 0/4] Pkey fixes for IB core and IPoIB

2013-08-06 Thread Or Gerlitz
On Tue, Aug 6, 2013 at 8:40 PM, Roland Dreier rol...@kernel.org wrote: On Tue, Aug 6, 2013 at 6:14 AM, Or Gerlitz or.gerl...@gmail.com wrote: Any time estimate for when you start accepting 3.12 patches into your for-next branch? No. So we are five days from RC5 and you don't have even

Re: [PATCH V9 libmlx4 0/2] Add extension and XRC QP support

2013-08-06 Thread Or Gerlitz
On Tue, Aug 6, 2013 at 8:40 PM, Roland Dreier rol...@kernel.org wrote: On Tue, Aug 6, 2013 at 8:03 AM, Or Gerlitz or.gerl...@gmail.com wrote: Could you finally-long-lastish post some comments on how you see this? any bugs or flames you find here, is this going to be accepted? when? Have you

[PATCH V4 for-next 4/4] IB/mlx4: Add receive Flow Steering support

2013-08-07 Thread Or Gerlitz
registration ID which is placed into struct mlx4_ib_flow that wraps the instance of struct ib_flow which is retuned to caller. Later, this reg ID is used for detaching that flow from the firmware. Signed-off-by: Hadar Hen Zion had...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers

[PATCH V4 for-next 3/4] IB/core: Export ib_create/destroy_flow through uverbs

2013-08-07 Thread Or Gerlitz
From: Hadar Hen Zion had...@mellanox.com Implement ib_uverbs_create_flow and ib_uverbs_destroy_flow to support flow steering for user space applications. Signed-off-by: Hadar Hen Zion had...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/uverbs.h

[PATCH V4 for-next 0/4] Add receive Flow Steering support

2013-08-07 Thread Or Gerlitz
Hi Roland, V4 addresses further comments made by Sean. There are still some concerns/questions posed by Roland on the uverbs extensions element of the series. Both Tzahi Oved and myself have posted replies for them, but so far no further comments from you. This code is hanging out for

[PATCH V4 for-next 2/4] IB/core: Infra-structure to support verbs extensions through uverbs

2013-08-07 Thread Or Gerlitz
and processed a bit differently. Signed-off-by: Igor Ivanov igor.iva...@itseez.com Signed-off-by: Hadar Hen Zion had...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/uverbs_main.c | 29 - include/uapi/rdma/ib_user_verbs.h

[PATCH V4 for-next 1/4] IB/core: Add receive Flow Steering support

2013-08-07 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/verbs.c | 27 + include/rdma/ib_verbs.h | 121 ++- 2 files changed, 146 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c

[PATCH V3 for-next 7/9] IB/core: Add RoCE IP based addressing extensions for uverbs

2013-08-07 Thread Or Gerlitz
CREATE_AH_EX command that uses a new struct ib_uverbs_create_ah_ex. struct ib_user_path_rec was extended too, to contain source and destination MAC and VLAN ID, this structure is of use by the rdma_ucm driver. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com

[PATCH V3 for-next 8/9] IB/core: Add RoCE IP based addressing extensions for rdma_ucm

2013-08-07 Thread Or Gerlitz
uses ib_user_path_rec_ex Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/ucma.c | 175 - include/uapi/rdma/rdma_user_cm.h | 29 ++- 2 files changed, 198 insertions(+), 6

[PATCH V3 for-next 6/9] IB/core: Infra-structure to support verbs extensions through uverbs

2013-08-07 Thread Or Gerlitz
and processed a bit differently. Signed-off-by: Igor Ivanov igor.iva...@itseez.com Signed-off-by: Hadar Hen Zion had...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/uverbs_main.c | 29 - include/uapi/rdma/ib_user_verbs.h

[PATCH V3 for-next 0/9] IP based RoCE GID Addressing

2013-08-07 Thread Or Gerlitz
changes from V2: - added handling of IP based GIDs in the ocrdma driver - patch #5, as a result patches #5-8 of V1 became patches #6-9 Roland, Indeed as with the flow-steering series, we have an open issue here with the need/implementation of uverbs extensions. Execpt for that, anything

[PATCH V3 for-next 1/9] IB/core: Ethernet L2 attributes in verbs/cm structures

2013-08-07 Thread Or Gerlitz
they are irrelevant for IB. Vendor drivers are modified to support the new function signature. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/cm.c| 58 drivers/infiniband/core/cma.c

[PATCH V3 for-next 4/9] IB/mlx4: Handle Ethernet L2 parameters for IP based GID addressing

2013-08-07 Thread Or Gerlitz
, instead of parsing the dgid to get the MAC and VLAN, take them from the address handle attributes. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/ah.c | 24 +++- drivers/infiniband/hw/mlx4/cq.c

[PATCH V3 for-next 3/9] IB/mlx4: Use RoCE IP based GIDs in the port GID table

2013-08-07 Thread Or Gerlitz
on top of that port so this should be considered when building and maintaining the gid table. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c| 476 +++-- drivers/infiniband/hw/mlx4

<    6   7   8   9   10   11   12   13   14   15   >