[PATCH libmlx4] Align the Flow Steering support with libibverbs

2014-05-14 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- src/mlx4.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mlx4.c b/src/mlx4.c index 2999150..1ee0338 100644 --- a/src/mlx4.c +++ b/src/mlx4.c @@ -203,8 +203,8 @@ static int mlx4_init_context(struct verbs_device *v_device

[PATCH libibverbs V1] Align Flow Steering API to the extension verbs scheme

2014-05-15 Thread Or Gerlitz
...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- Hi Roland -- this addresses all the comments by Jason who gave a ack/reviewed-by note for both the libibverbs and libmlx4 fixes. So you can move ahead and conduct point releases for both libs. Makefile.am|6

Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP

2014-05-17 Thread Or Gerlitz
On Sat, May 17, 2014 at 8:36 AM, David Miller da...@davemloft.net wrote: From: Chen Gang gang.chen.5...@gmail.com Date: Sat, 17 May 2014 13:26:16 +0800 'struct irq_affinity_notify' and the related functions are only defined when SMP enabled, so at present, mlx4 has to only run under SMP.

Re: [PATCH v1 for-next 0/3] IB: Use GFP_NOIO calls in IPoIB connected mode TX path

2014-05-17 Thread Or Gerlitz
On Tue, May 13, 2014 at 2:38 PM, Jiri Kosina jkos...@suse.cz wrote: On Sun, 11 May 2014, Or Gerlitz wrote: This series is a refactored form of the one posted by Jiri Kosina to LKML and netdev according to the discussion that followed and the guidelines you provided here https://lkml.org/lkml

[PATCH libibverbs V4 1/5] Add ibv_port_cap_flags

2014-05-18 Thread Or Gerlitz
From: Matan Barak mat...@mellanox.com Add an enum that describes ibv_port_cap_flags that complies with the respective kernel enum. This value could be fetched when using ibv_query_port in port_cap_flags. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl

[PATCH libibverbs V4 2/5] Extend create_ah in order to pass L2 parameters to the provider

2014-05-18 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- include/infiniband/verbs.h | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/include/infiniband/verbs.h b/include/infiniband/verbs.h index 71adf2a..ab497b1 100644 --- a/include/infiniband/verbs.h +++ b/include

[PATCH libibverbs V4 4/5] Add ibv_query_port_ex support

2014-05-18 Thread Or Gerlitz
. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- Makefile.am|3 +- include/infiniband/verbs.h | 89 man/ibv_query_port_ex.3| 97 3 files

[PATCH libibverbs V4 3/5] Use neighbour lookup for RoCE UD QPs Eth L2 resolution

2014-05-18 Thread Or Gerlitz
c. query neigh table in order to know if the neigh has shown up between query until we started monitoring it 6. query vlan id from the interface This solution depends on libnl-3 with backports to libnl-1. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl

[PATCH libibverbs V4 0/5] Add support for UD QPs under RoCE IP addressing

2014-05-18 Thread Or Gerlitz
From: Or Gerlitz ogerl...@mellanox.com Hi Roland, This series adds support for Ethernet L2 address resolution for RoCE UD QPs, whose L2 address-handles, unlike RC/UC/XRC/etc QPs are set from user space without going through uverbs and the kernel IB core. The code is also compatible both with old

[PATCH libmlx4 V3 0/2] Add support for UD QPs under RoCE IP addressing

2014-05-18 Thread Or Gerlitz
From: Or Gerlitz ogerl...@mellanox.com Hi Yishai, This is just a rebased-port of the series which adds support for Ethernet L2 address resolution for UD QPs, whose L2 address-handles, unlike RC/UC/XRC/etc QPs are set from user space without going through uverbs and the kernel IB core. Matan

[PATCH libmlx4 V3 1/2] Add RoCE IP based addressing support for UD QPs

2014-05-18 Thread Or Gerlitz
and sets mlx4_ah relevant attributes. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- src/mlx4.c |1 + src/mlx4.h |2 + src/verbs.c | 85 +++--- 3 files changed, 77 insertions(+), 11

[PATCH libmlx4 V3 2/2] Add ibv_query_port_ex support

2014-05-18 Thread Or Gerlitz
layer's type in mlx4_context. Caching will allow us to avoid ibv_query_port calls and save time in ibv_create_ah. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- src/mlx4.c |3 ++ src/mlx4.h |9 src/verbs.c | 66

Re: [PATCH libibverbs V1] Align Flow Steering API to the extension verbs scheme

2014-05-20 Thread Or Gerlitz
On 20/05/2014 04:05, Roland Dreier wrote: On Thu, May 15, 2014 at 6:16 AM, Or Gerlitz ogerl...@mellanox.com wrote: Hi Roland -- this addresses all the comments by Jason who gave a ack/reviewed-by note for both the libibverbs and libmlx4 fixes. So you can move ahead and conduct point releases

Re: [PATCH libibverbs V4 0/5] Add support for UD QPs under RoCE IP addressing

2014-05-20 Thread Or Gerlitz
On 18/05/2014 12:38, Or Gerlitz wrote: [...] changes from V3 -- addressed feedback from Jason: - replaced the char* that used to hold the MAC address provided to the provider library (e.g libmlx4) with sockaddr_storage and use ARPHRD for the af_family (similar to the practice used

Re: [PATCH 0/3] RDMA/core: iWARP Port Mapper Overview

2014-05-20 Thread Or Gerlitz
On 27/03/2014 00:08, Tatyana Nikolova wrote: This patch series adds iWARP Port Mapper (IWPM) Version 2 support in RDMA/core, RDMA/nes driver and RDMA/cxgb4 driver. Guys, the link here http://vger.kernel.org/netconf2011_slides/pj_netconf2011.ppt seems to point to a damaged PPT, can you send

Re: [PATCH 0/3] RDMA/core: iWARP Port Mapper Overview

2014-05-20 Thread Or Gerlitz
On 20/05/2014 16:46, Steve Wise wrote: But here is it attached thanks -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 0/9] SRP initiator patches for kernel 3.16

2014-05-20 Thread Or Gerlitz
On 20/05/2014 16:03, Bart Van Assche wrote: Changes compared to v3: V3 is already applied -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH for-next 2/4] IB/iser: Fix a possible race in iser connection states transition

2014-05-22 Thread Or Gerlitz
RDMA_CM event ESTABLISHED we allow iser connection state to transition to UP only from PENDING. We also make sure to protect this state change (done under the connection lock). Signed-off-by: Ariel Nahum ari...@mellanox.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Reviewed-by: Or Gerlitz

[PATCH for-next 3/4] IB/iser: Add missing newlines to logging messages

2014-05-22 Thread Or Gerlitz
From: Roi Dayan r...@mellanox.com Logging messages need terminating newlines to avoid possible message interleaving. Add them. Signed-off-by: Roi Dayan r...@mellanox.com Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser

[PATCH for-next 0/4] iSER initiator updates for 3.16

2014-05-22 Thread Or Gerlitz
From: Or Gerlitz ogerl...@mellanox.com This patchset address several resiliency issues in the area of connection establishment and teardown (especially in error flows). Patch #1 introduces a re-design of iSER connection management done by Ariel and Sagi. It comes to solve few error-flow hangs

[PATCH for-next 4/4] IB/iser: Bump version to 1.4

2014-05-22 Thread Or Gerlitz
From: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h

[PATCH for-next 1/4] IB/iser: Simplify connection management

2014-05-22 Thread Or Gerlitz
scheduled. Thus proper module unload shall flush all scheduled works before allowing safe exit, to guarantee no resources got left behind. Signed-off-by: Ariel Nahum ari...@mellanox.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Reviewed-by: Roi Dayan r...@mellanox.com Reviewed-by: Or Gerlitz ogerl

Re: [PATCH for-next 1/4] IB/iser: Simplify connection management

2014-05-22 Thread Or Gerlitz
On 22/05/2014 11:00, Or Gerlitz wrote: sorry for the spam, I forgot to add Mike Christie, the iscsi maintainer, so here you are CC-ed Mike, I preferred doing it with a single reply vs. a whole new post, Mike if you need the actual patch for the sake of review/looking it's here http

Re: [PATCH v1 for-next 0/3] IB: Use GFP_NOIO calls in IPoIB connected mode TX path

2014-05-28 Thread Or Gerlitz
On Mon, May 26, 2014 at 1:52 PM, Jiri Kosina jkos...@suse.cz wrote: On Mon, 19 May 2014, Roland Dreier wrote: Roland, we're soon on -rc6 and there's no reason for this to miss 3.16, could you please comment whether you want it to go through your tree or net-next? I will pick it up.

Re: [PATCH v1 for-next 0/3] IB: Use GFP_NOIO calls in IPoIB connected mode TX path

2014-05-28 Thread Or Gerlitz
On Wed, May 28, 2014 at 5:05 PM, Roland Dreier roland.dre...@gmail.com wrote: Roland, so M2 starts worrying, you have picked into your for-next branch yesterday the other pending series, but not this one, so? Who is M2? me too -- To unsubscribe from this list: send the line unsubscribe

[PATCH for-next 1/6] mlx4_core: Fix memory leaks under SRIOV in case of error flow

2014-05-29 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il Fix few memory leaks that happen if errors happen under SRIOV mode. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/net/ethernet

[PATCH for-next 2/6] mlx4_core: Fix incorrect FLAGS1 bitmap test in mlx4_QUERY_FUNC_CAP

2014-05-29 Thread Or Gerlitz
in QUERY_FUNC_CAP) Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/net/ethernet/mellanox/mlx4/fw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet

[PATCH for-next 3/6] IB/mlx4: SET_PORT called by mlx4_ib_modify_port should be wrapped

2014-05-29 Thread Or Gerlitz
OK unconditionally (since the capability flags and qkey violations counter are not relevant). Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c | 26 +- 1 files changed, 17

[PATCH for-next 0/6] mlx4: Implement QP0 (SMI) support for privileged VFs

2014-05-29 Thread Or Gerlitz
From: Or Gerlitz ogerl...@mellanox.com Hi Roland, This patch set enables selected VFs to issue QP0 (SMI) requests and receive responses. This feature enables running tools such as infiniband-diags and ibutils on these selected (privileged) VFs. Unsolicited SMI MADs will still be sent

[PATCH for-next 6/6] IB/mlx4: Add interface for selecting VFs to enable QP0 via MLX proxy QPs

2014-05-29 Thread Or Gerlitz
at the next reset of the VF (e.g. driver restart on the VM which owns the VF). Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/sysfs.c | 105 +- drivers/net/ethernet/mellanox

[PATCH for-next 5/6] mlx4: Add infrastructure for selecting VFs to enable QP0 via MLX proxy QPs

2014-05-29 Thread Or Gerlitz
Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/qp.c| 52 +++- drivers/net/ethernet/mellanox/mlx4/cmd.c | 13 +- drivers/net/ethernet/mellanox/mlx4/fw.c| 44

[PATCH for-next 4/6] IB/mlx4: Preparation for VFs to issue/receive SMI (QP0) requests/responses

2014-05-29 Thread Or Gerlitz
for now. The next two commits allow defining and activating privileged VFs. Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/mad.c | 40 +++-- drivers/infiniband/hw/mlx4/qp.c

[PATCH for-next] mlx4_core: Add support for secure-host and SMP firewall

2014-06-01 Thread Or Gerlitz
at startup, where the feature is enabled/disabled through a procedure described in the Mellanox HCA tools package. Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/net/ethernet/mellanox/mlx4/cmd.c |9 +++ drivers/net/ethernet

Re: [PATCH 0/2] Include protection information in iscsi header

2014-06-03 Thread Or Gerlitz
On Tue, Jun 3, 2014 at 9:16 AM, Roland Dreier rol...@purestorage.com wrote: On Sun, Jun 1, 2014 at 9:19 AM, Sagi Grimberg sa...@mellanox.com wrote: Although these patches involve 3 subsystems with different maintainers (scsi, iser, target) I would prefer seeing these patches included together.

Re: [PATCH for-next 0/3] IB/core kobject cleanup

2014-06-03 Thread Or Gerlitz
On Sun, May 18, 2014 at 11:12 AM, Haggai Eran hagg...@mellanox.com wrote: Hi, These patches clean up the kobject destruction code in IB/core, and fix a memory leak. Hi Roland, it seems you missed this small patch series which Haggai sent few weeks ago, can you please pick it for 3.16? Or.

Re: [PATCH 0/3] RDMA/core: iWARP Port Mapper Overview

2014-06-03 Thread Or Gerlitz
On Tue, May 20, 2014 at 4:10 AM, Roland Dreier rol...@kernel.org wrote: So I'm looking to include this for 3.16. Roland, can you reword these patches and remove Peter's email address, it bounces back (just tried it, SB) and I don't see the point to introduce an email in a signature which is

Re: [PATCH 1/3] RDMA/core: Add support for iWARP Port Mapper user space service (Version 2)

2014-06-07 Thread Or Gerlitz
Tatyana Nikolova tatyana.e.nikol...@intel.com wrote: The patch adds support for iWarp Port Mapper user space service Reading the change-log below, I noted that pretty much nothing in it explains what is the role of this port mapper, with that presentation you sent not being part of the upstream

Re: [PATCH 0/3] RDMA/core: iWARP Port Mapper Overview

2014-06-08 Thread Or Gerlitz
Tatyana Nikolova tatyana.e.nikol...@intel.com wrote: This patch series adds iWARP Port Mapper (IWPM) Version 2 support in RDMA/core, RDMA/nes driver and RDMA/cxgb4 driver. Hi Steve, Tatyana Reading this cover letter, I think it's good idea to follow Steve's suggestion and add portions from

Re: [PATCH for-next] mlx4_core: Add support for secure-host and SMP firewall

2014-06-08 Thread Or Gerlitz
On Sun, Jun 1, 2014 at 11:53 AM, Or Gerlitz ogerl...@mellanox.com wrote: From: Jack Morgenstein ja...@dev.mellanox.co.il Secure-host is the general term for the capability of a device to protect itself and the subnet from malicious host software. Hi Roland, So, is this OK for 3.16? note

Re: [PATCH v5 00/24] Series short description

2014-06-09 Thread Or Gerlitz
On Thu, May 29, 2014 at 7:59 PM, Steve Wise sw...@opengridcomputing.com wrote: I tested this series over cxgb4 and mlx4, running cthon04, fio read/rand-rw, and xfstests, and over mthca cthon04. No regressions. Steve, Chuck, all Where this series stands? I don't see it in Roland's tree

Re: [PATCH for-next 00/15] Bug fixes for ocrdma driver

2014-06-09 Thread Or Gerlitz
On Wed, Jun 4, 2014 at 8:06 PM, Roland Dreier rol...@kernel.org wrote: On Wed, Jun 4, 2014 at 9:37 AM, Steve Wise sw...@opengridcomputing.com wrote: Seems like the subject lines in each patch are getting truncated? Yes, truncated in patchwork too -- for example:

Re: [PATCH for-next 02/15] RDMA/ocrdma: Query and initalize the PFC SL

2014-06-09 Thread Or Gerlitz
On Wed, Jun 4, 2014 at 11:52 AM, Selvin Xavier selvin.xav...@emulex.com wrote: Query the PFC service level configured on the adapter from quick looking, this is a very large patch basically doing tons of things which go way beyond what's written in the one liner change-log. Can you @ least

Re: [PATCH for-next 00/15] Bug fixes for ocrdma driver

2014-06-10 Thread Or Gerlitz
On 10/06/2014 04:37, Selvin Xavier wrote: -Original Message- From: Or Gerlitz [mailto:or.gerl...@gmail.com] Sent: Tuesday, June 10, 2014 1:15 AM To: Roland Dreier; Selvin Xavier Cc: Steve Wise; linux-rdma@vger.kernel.org; linux-kernel Subject: Re: [PATCH for-next 00/15] Bug fixes

Re: FW: [PATCH 0/3] RDMA/core: iWARP Port Mapper Overview

2014-06-10 Thread Or Gerlitz
On 10/06/2014 03:08, PJ Waskiewicz wrote: This was something I presented and discussed at NetConf 2011 Peter, the email address from your signature on the patches isn't functional anymore, is it OK if the patches will be re-worded with this (or any other address you want to) one such that we

Re: [PATCH v2 1/1] IPoIB: Improve parent interface p_key handling.

2014-06-10 Thread Or Gerlitz
On 10/06/2014 00:55, Alex Estrin wrote: With reference to commit c2904141696ee19551f155396f23cdd5d95e. It was noticed that parent interface keeps sending broadcast group join requests if p_key index 0 is invalid. That creates unnecessary noise on a fabric: ib0: multicast join failed for

Re: [PATCH for-next] mlx4_core: Add support for secure-host and SMP firewall

2014-06-10 Thread Or Gerlitz
On Tue, Jun 10, 2014 at 8:15 PM, Roland Dreier rol...@kernel.org wrote: On Sun, Jun 8, 2014 at 12:48 PM, Or Gerlitz or.gerl...@gmail.com wrote: So, is this OK for 3.16? note this touches mlx4 only. if you have any questions on the patch, please let us know and Jack will address. This came

Re: [PATCH for-next] mlx4_core: Add support for secure-host and SMP firewall

2014-06-10 Thread Or Gerlitz
On Tue, Jun 10, 2014 at 9:14 PM, Roland Dreier rol...@kernel.org wrote: By this you mean the reminder...? I sent the patch June 1st wheres the window opened on the 8th, but thanks anyway. The merge window opened June 1: https://lwn.net/Articles/600984/ Oh, I see your point now -- I missed

Re: [PATCH v1 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-10 Thread Or Gerlitz
On Tue, Jun 10, 2014 at 10:02 PM, Martin K. Petersen martin.peter...@oracle.com wrote: Sagi == Sagi Grimberg sa...@mellanox.com writes: +static inline unsigned scsi_prot_length(unsigned data_length, + unsigned sector_size) +{ + switch (sector_size)

Re: [PATCH v1 for-next 02/16] RDMA/ocrdma: Query and initalize the PFC SL

2014-06-11 Thread Or Gerlitz
On 10/06/2014 17:02, Selvin Xavier wrote: This patch implements routine to query the PFC priority from the adapter port. Following are the changes implemented: * A new FW command is implemented to query the operational/admin DCBX configuration from the FW and obtain active

Re: [PATCH libibverbs V1] Align Flow Steering API to the extension verbs scheme

2014-06-11 Thread Or Gerlitz
On 20/05/2014 09:59, Or Gerlitz wrote: On 20/05/2014 04:05, Roland Dreier wrote: On Thu, May 15, 2014 at 6:16 AM, Or Gerlitz ogerl...@mellanox.com wrote: Hi Roland -- this addresses all the comments by Jason who gave a ack/reviewed-by note for both the libibverbs and libmlx4 fixes. So you can

Re: [PATCH libibverbs V1] Align Flow Steering API to the extension verbs scheme

2014-06-11 Thread Or Gerlitz
On 11/06/2014 12:53, Or Gerlitz wrote: On 20/05/2014 09:59, Or Gerlitz wrote: On 20/05/2014 04:05, Roland Dreier wrote: On Thu, May 15, 2014 at 6:16 AM, Or Gerlitz ogerl...@mellanox.com wrote: Hi Roland -- this addresses all the comments by Jason who gave a ack/reviewed-by note for both

Re: [PATCH libibverbs V4 2/5] Extend create_ah in order to pass L2 parameters to the provider

2014-06-11 Thread Or Gerlitz
On 22/05/2014 11:52, Matan Barak wrote: On 21/5/2014 10:55 PM, Jason Gunthorpe wrote: On Sun, May 18, 2014 at 12:38:46PM +0300, Or Gerlitz wrote: From: Matan Barak mat...@mellanox.com In order to support IP based addressing, one needs to pass the L2 parameters to the provider drive

Re: [PATCH v3 1/1] IPoIB: Improve parent interface p_key handling.

2014-06-17 Thread Or Gerlitz
On 11/06/2014 22:22, Alex Estrin wrote: With reference to commit c2904141696ee19551f155396f23cdd5d95e (IPoIB: Fix pkey change flow for virtualization environments) It was noticed that parent interface keeps sending broadcast group join requests if p_key index 0 is invalid. That creates

Re: [PATCH for-next] mlx4_core: Add support for secure-host and SMP firewall

2014-06-17 Thread Or Gerlitz
On 01/06/2014 11:53, Or Gerlitz wrote: Secure-host is the general term for the capability of a device to protect itself and the subnet from malicious host software. Roland, are you planning to pull this into your next update, it's just -rc1 so I guess this is early enough to get that into 3.16

Re: rmmod mlx4_core panic 3.16-rc1

2014-06-19 Thread Or Gerlitz
On Thu, Jun 19, 2014 at 6:33 AM, Shirley Ma shirley...@oracle.com wrote: 1. Whether IB VFs is supported in ConnectX-2 (mlx4 driver)? I tried to num_vfs={port1,port2,port1+2} when loading mlx4_core module, it failed with mlx4_core :40:00.0: Invalid syntax of num_vfs/probe_vfs with IB

Re: rmmod mlx4_core panic 3.16-rc1

2014-06-19 Thread Or Gerlitz
On Fri, Jun 20, 2014 at 6:51 AM, Wei Yang weiy...@linux.vnet.ibm.com wrote: mlx4_core :40:00.0: Invalid syntax of num_vfs/probe_vfs with IB port - single port VFs syntax is only supported when all ports are configured as ethernet BUG: unable to handle kernel NULL pointer dereference

Re: rmmod mlx4_core panic 3.16-rc1

2014-06-20 Thread Or Gerlitz
On Fri, Jun 20, 2014 at 6:34 AM, Or Gerlitz or.gerl...@gmail.com wrote: On Thu, Jun 19, 2014 at 6:33 AM, Shirley Ma shirley...@oracle.com wrote: 1. Whether IB VFs is supported in ConnectX-2 (mlx4 driver)? I tried to num_vfs={port1,port2,port1+2} when loading mlx4_core module, it failed

Re: rmmod mlx4_core panic 3.16-rc1

2014-06-20 Thread Or Gerlitz
On Fri, Jun 20, 2014 at 9:21 AM, Wei Yang weiy...@linux.vnet.ibm.com wrote: From this log, it happens during probe? If not, any action after probe? yep, maybe the bug still exists in the error flow of probe? you can probe with num_vfs=1,1,1 port_type_array=1,1 and see if you hit it I tried

Re: rmmod mlx4_core panic 3.16-rc1

2014-06-20 Thread Or Gerlitz
On Fri, Jun 20, 2014 at 9:33 AM, Or Gerlitz or.gerl...@gmail.com wrote: On Fri, Jun 20, 2014 at 9:21 AM, Wei Yang weiy...@linux.vnet.ibm.com wrote: From this log, it happens during probe? If not, any action after probe? yep, maybe the bug still exists in the error flow of probe? you can probe

why flipping responder_resources/initiator_depth?

2014-06-22 Thread Or Gerlitz
Hi Sean, So we just noted that the IB CM @ cm_format_req_event() flips the values of RDMA READ initiator-depth and responder-resources advertized in the client through the REQ when before it delivers the event to the server (and the same is done the other way around in cm_format_rep_event()).

Re: rmmod mlx4_core panic 3.16-rc1

2014-06-22 Thread Or Gerlitz
On 20/06/2014 20:15, Shirley Ma wrote: On 06/19/2014 08:34 PM, Or Gerlitz wrote: On Thu, Jun 19, 2014 at 6:33 AM, Shirley Ma shirley...@oracle.com wrote: 1. Whether IB VFs is supported in ConnectX-2 (mlx4 driver)? I tried to num_vfs={port1,port2,port1+2} when loading mlx4_core module

Re: rmmod mlx4_core panic 3.16-rc1

2014-06-22 Thread Or Gerlitz
On Sun, Jun 22, 2014 at 12:29 PM, Or Gerlitz ogerl...@mellanox.com wrote: As for the crash you reported, indeed, it seems we have a bug there on the error flow of module loading when single ported VF are requested in conjunction with IB ports. I have it fixed on my system with this patch

Re: why flipping responder_resources/initiator_depth?

2014-06-22 Thread Or Gerlitz
On Mon, Jun 23, 2014 at 8:00 AM, Hefty, Sean sean.he...@intel.com wrote: Any special reason for that? specifically, it doesn't comply with our common sense (...) and the text in the rdma_connect/rdma_accept man pages http://linux.die.net/man/3/rdma_connect that say: Flipping the values keeps

Re: mlx4 - query regarding PF VF functionality division

2014-06-23 Thread Or Gerlitz
On Mon, Jun 23, 2014 at 12:33 PM, Bob Biloxi iambobbil...@gmail.com wrote: [...] Is there any way we can clearly separate the files that are used by PF vs the files that are used by VF in the (drivers/net/ethernet/mlx4 sub-directory)? [...] Not really, but let's take EIM approach, what's your

Re: [PATCH v1 00/13] NFS/RDMA patches for 3.17

2014-06-24 Thread Or Gerlitz
On Tue, Jun 24, 2014 at 1:39 AM, Chuck Lever chuck.le...@oracle.com wrote: The main purpose of this series is to address more connection drop recovery issues by fixing FRMR re-use to make it less likely the client will drop the connection due to a memory operation error. Some other clean-ups

Re: [PATCH v1 01/13] xprtrdma: Fix panic in rpcrdma_register_frmr_external()

2014-06-24 Thread Or Gerlitz
On Tue, Jun 24, 2014 at 1:39 AM, Chuck Lever chuck.le...@oracle.com wrote: seg1-mr_nsegs is not yet initialized when it is used to unmap segments during an error exit. Use the same unmapping logic for all error exits. if (frmr_wr.wr.fast_reg.length len) { used to be a BUG_ON check. The

[PATCH for 3.16] IB/mlx5: Enable block multicast loopback for kernel consumers too

2014-06-25 Thread Or Gerlitz
Signed-off-by: Eli Cohen e...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx5/qp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index d13ddf1..bbbcf38 100644

Re: mlx4 - query regarding PF VF functionality division

2014-06-25 Thread Or Gerlitz
is not specifically under mlx4_is_master, I still need to understand it because it is also part of PF driver c. I can ignore the logic which executes if mlx4_is_master is false, because that would be the VF code Thanks for the help!! On Mon, Jun 23, 2014 at 5:30 PM, Or Gerlitz or.gerl...@gmail.com wrote

Re: why flipping responder_resources/initiator_depth?

2014-06-25 Thread Or Gerlitz
On Mon, Jun 23, 2014 at 9:34 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Mon, Jun 23, 2014 at 06:00:57PM +, Hefty, Sean wrote: The behavior matches the documentation. And the problem is...? Sean, which documentation exactly? [...] I haven't looked at how this all plays

Re: [PATCH v5 1/1] IPoIB: Avoid multicast join attempts when having invalid p_key

2014-07-02 Thread Or Gerlitz
On Wed, Jul 2, 2014 at 10:18 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: Still there is an issue here, please try the following: 1. pkey table contains the pkey 8001 2. echo 0x8001 /sys/class/net/ib0/create_child ; ifconfig ib0.8001 1.1.1.1 up - till now all good. 3. change the sm

Re: [PATCH 5/5] IB/srp: Optimize completion queue polling

2014-07-03 Thread Or Gerlitz
On Thu, Jul 3, 2014 at 4:48 PM, Bart Van Assche bvanass...@acm.org wrote: [...] Limit the number of poll cycles per completion notification to preserve fairness [...] Any reason not to make use of the block layer NAPI like API for that (blk-iopoll http://lwn.net/Articles/346187/) ? Or. --

Re: [PATCH 5/5] IB/srp: Optimize completion queue polling

2014-07-08 Thread Or Gerlitz
On Fri, Jul 4, 2014 at 12:59 PM, Bart Van Assche bvanass...@acm.org wrote: [...] the blk-iopoll framework defers work to softirq context. This means that a context switch from interrupt to softirq context has to occur before SRP completion processing can start. Recent measurements on current

Re: [PATCH 5/5] IB/srp: Optimize completion queue polling

2014-07-08 Thread Or Gerlitz
On 08/07/2014 11:11, Bart Van Assche wrote: e might each be referring to different concepts here. What you are referring to is average response time for QD 1. What I was referring to is average response time for QD = 1. The measurements I ran with fio have shown that the response time for QD =

[PATCH for-3.17 0/3] IPoIB fixes

2014-07-08 Thread Or Gerlitz
and simplify your https://patchwork.kernel.org/patch/4474321/ patch Or. Erez Shitrit (2): IB/ipoib: Use pkey change event instead of pkey polling mechanism IB/ipoib: Avoid flushing the workqueue from worker context Or Gerlitz (1): IB/ipath: Add PKEY change event support drivers/infiniband

[PATCH for-3.17 1/3] IB/ipath: Add PKEY change event support

2014-07-08 Thread Or Gerlitz
Deliver PKEY_CHANGE event through the relevant IB device when the local pkey table changes. Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/ipath/ipath_mad.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw

[PATCH for-3.17 2/3] IB/ipoib: Use pkey change event instead of pkey polling mechanism

2014-07-08 Thread Or Gerlitz
polling logic/thread as they add extra complexity which isn't needed. Signed-off-by: Erez Shitrit ere...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib.h |6 +-- drivers/infiniband/ulp/ipoib/ipoib_ib.c | 73

[PATCH for-3.17 3/3] IB/ipoib: Avoid flushing the workqueue from worker context

2014-07-08 Thread Or Gerlitz
] [a056d0ba] ? ipoib_ib_dev_flush_heavy+0x1a/0x20 [ib_ipoib] [81094d20] ? worker_thread+0x170/0x2a0 [8109b2a0] ? autoremove_wake_function+0x0/0x40 Signed-off-by: Erez Shitrit ere...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib.h

Re: [PATCH for 3.16] IB/mlx5: Enable block multicast loopback for kernel consumers too

2014-07-15 Thread Or Gerlitz
On 25/06/2014 16:44, Or Gerlitz wrote: Under commit f360d88 we advertize blocking multicast loopback to both kernel and user-space consumers, but disallow the kernel ones (e.g IPoIB) to use it with their UD QPs, fix that. Fixes: f360d88 ('IB/mlx5: Add block multicast loopback support') Reported

[PATCH for-next 0/3] Add user MR re-registeration support

2014-07-31 Thread Or Gerlitz
Memory re-registration enables one to change the attributes of a memory region registered by user-space, including PD, translation (address and length) and access flags. Matan and Or. Matan Barak (3): IB/core: Add user MR re-registeration support mlx4_core: Add helper functions to support

[PATCH for-next 2/3] mlx4_core: Add helper functions to support MR re-registration

2014-07-31 Thread Or Gerlitz
and updates the HCA via fw command SW2HW_MPT. The first path is used in native mode; the second path is slower and is used only in SRIOV. Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com

[PATCH for-next 1/3] IB/core: Add user MR re-registeration support

2014-07-31 Thread Or Gerlitz
-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/uverbs.h |1 + drivers/infiniband/core/uverbs_cmd.c | 93 + drivers/infiniband/core/uverbs_main.c |1 + include/rdma/ib_verbs.h

[PATCH for-next 3/3] IB/mlx4_ib: Add support for user MR re-registration

2014-07-31 Thread Or Gerlitz
Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c|2 + drivers/infiniband/hw/mlx4/mlx4_ib.h |4 ++ drivers/infiniband/hw/mlx4/mr.c | 88 +- 3 files changed, 93 insertions(+), 1

[PATCH for-next 2/8] IB/iser: Add TIMEWAIT_EXIT event handling

2014-07-31 Thread Or Gerlitz
-by: Ariel Nahum ari...@mellanox.com Signed-off-by: Roi Dayan r...@mellanox.com Reviewed-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iser_verbs.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCH for-next 0/8] iSER initiator updates for 3.17

2014-07-31 Thread Or Gerlitz
Batch of updates from the storage folks -- stability issues, functionality (IPv6 support, proper rdma responder resources advertizement) enhacement and cleanups. Or. Ariel Nahum (3): IB/iser: Seperate iser_conn and iscsi_endpoint storage space IB/iser: Protect iser state machine with a

[PATCH for-next 7/8] IB/iser: Replace connection waitqueue with completion object

2014-07-31 Thread Or Gerlitz
where iscsid (the user space iscsi daemon) is too slow or gone. Signed-off-by: Ariel Nahum ari...@mellanox.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.c | 13 ++--- drivers/infiniband/ulp

[PATCH for-next 4/8] IB/iser: Seperate iser_conn and iscsi_endpoint storage space

2014-07-31 Thread Or Gerlitz
...@mellanox.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.c | 16 +--- drivers/infiniband/ulp/iser/iser_verbs.c |2 +- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH for-next 1/8] IB/iser: Support IPv6 address family

2014-07-31 Thread Or Gerlitz
From: Roi Dayan r...@mellanox.com Replacing struct sockaddr_in with struct ockaddr which supports both IPv4 and IPv6, and print using the %pIS format directive. Signed-off-by: Roi Dayan r...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser

[PATCH for-next 3/8] IB/iser: Fix responder resources advertizement

2014-07-31 Thread Or Gerlitz
oustanding rdma read requests (max_qp_init_rd_atom). We keep initiator_depth set to 1 in order to compat with old targets. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iser_verbs.c |4 +++- 1 files changed, 3

[PATCH for-next 5/8] IB/iser: Remove redundant return code in iser_free_ib_conn_res()

2014-07-31 Thread Or Gerlitz
From: Sagi Grimberg sa...@mellanox.com Make it void. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iser_verbs.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/ulp

[PATCH for-next 8/8] IB/iser: Clarify a duplicate counters check

2014-07-31 Thread Or Gerlitz
From: Roi Dayan r...@mellanox.com This is to prevent someone from thinking that this code section is redundant. Signed-off-by: Ariel Nahum ari...@mellanox.com Signed-off-by: Roi Dayan r...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iser_verbs.c

[PATCH for-next 6/8] IB/iser: Protect iser state machine with a mutex

2014-07-31 Thread Or Gerlitz
is invoked while CMA events keep coming (address/route resolution, connected, etc...). Signed-off-by: Ariel Nahum ari...@mellanox.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.c | 15 +-- drivers

[PATCH for-3.17 1/7] IB/mlx4: Avoid null pointer dereference in mlx4_ib_scan_netdevs()

2014-08-21 Thread Or Gerlitz
is present to a proper if () statement. Fixes: ad4885d2 ('IB/mlx4: Build the port IBoE GID table properly under bonding') Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4

[PATCH for-3.17 4/7] IB/mlx4: Get upper dev addresses as RoCE GIDs when port comes up

2014-08-21 Thread Or Gerlitz
From: Moni Shoua mo...@mellanox.com When RoCE port becomes active and netdev of the port has upper device (e.g bond/team), gids derived from the upper dev should appear in the port's RoCE gid table. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com

[PATCH for-3.17 5/7] IB/mlx4: Fix lockdep splat for the iboe lock

2014-08-21 Thread Or Gerlitz
of spin_lock/unlock on the iboe lock. Reported-by: Chuck Lever chuck.le...@oracle.com Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c | 24 1 files changed, 12 insertions(+), 12

[PATCH for-3.17 0/7] RoCE IP addressing fixes

2014-08-21 Thread Or Gerlitz
Hi Roland, This series contains RoCE related fixes to the mlx4 IB driver (and one uverbs patch), which deal with the IP addressing logic. Once applied into 3.17, we will further push them to -stable. Or. Jack Morgenstein (1): IB/mlx4: Fix lockdep splat for the iboe lock Matan Barak (1):

[PATCH for-3.17 3/7] IB/mlx4: Reorder steps in RoCE GID table initialization

2014-08-21 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c | 29 + 1 files changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index 61910f4..d95b5fe 100644 --- a/drivers/infiniband

[PATCH for-3.17 2/7] IB/mlx4: Don't duplicate the default RoCE GID

2014-08-21 Thread Or Gerlitz
index 0 is always occupied') Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4

Re: [PATCH libibverbs V5 2/2] Use neighbour lookup for RoCE UD QPs Eth L2 resolution

2014-08-26 Thread Or Gerlitz
On 25/08/2014 22:33, Doug Ledford wrote: On Aug 25, 2014, at 1:33 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: +timer_fd = timerfd_create(CLOCK_MONOTONIC, TFD_NONBLOCK | TFD_CLOEXEC); +if (-1 == timer_fd) { +print_err(Couldn't create timer\n); +return

rebasing for-next

2014-08-26 Thread Or Gerlitz
Hi Roland, Eli has some mlx5 patches which depend on other mlx5 changes which went in during the 3.17 merge window, can you please rebase for-next so he can submit them through linux-rdma? Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

[PATCH for-3.17 1/3] IB/iser: Fix RX/TX CQ resource leak on error flow

2014-09-02 Thread Or Gerlitz
From: Roi Dayan r...@mellanox.com When failing to allocate TX CQ we already allocated RX CQ, so we need to make sure we release it. Also, when failing to register notification to the RX CQ we currently leak both RX and TX CQs of the current index, fix that too. Signed-off-by: Roi Dayan

<    10   11   12   13   14   15   16   17   18   19   >