Re: [PATCH] i2c: rcar: don't open code of_device_get_match_data()

On Tue, Mar 01, 2016 at 05:36:43PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > This change will also make Coverity happy by avoiding a theoretical NULL > pointer dereference; yet another reason is to use the above helper function > to tighten the code

Re: [PATCH] PM / Runtime: Only force-resume device if it has been force-suspended

Hello. On 03/03/2016 11:16 PM, Laurent Pinchart wrote: Noticed a few typos as well, some alreayd reported... The pm_runtime_force_suspend() and pm_runtime_force_resume() helpers are designed to help driver being RPM-centric by offering an easy way to manager runtime PM state during system

Re: [PATCH] PM / Runtime: Only force-resume device if it has been force-suspended

Hi Kevin, (CC'ing Ulf) Thank you for the review. On Thursday 03 March 2016 12:35:53 Kevin Hilman wrote: > Laurent Pinchart writes: > > The pm_runtime_force_suspend() and pm_runtime_force_resume() helpers are > > designed to help driver being

Re: [PATCH] clk: renesas: move drivers to renesas directory

On 03/03, Geert Uytterhoeven wrote: > On Thu, Mar 3, 2016 at 3:18 AM, Simon Horman > wrote: > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > > appropriate name

Re: [PATCH] dmaengine: sh: shdmac: don't open code of_device_get_match_data()

On Tue, Mar 01, 2016 at 05:37:07PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > This change will also make Coverity happy by avoiding a theoretical NULL > pointer dereference; yet another reason is to use the above helper function > to tighten the code

Re: [RFC 5/7] mmc: sh_mobile_sdhi: Add UHS-I mode support

On 19 February 2016 at 21:16, Wolfram Sang wrote: > From: Ben Hutchings > > Implement voltage switch, supporting modes up to SDR-50. > > Based on work by Shinobu Uehara, Rob Taylor, William Towle and Ian Molton. > > Signed-off-by: Ben Hutchings

Re: [git pull] pinctrl: sh-pfc: Updates for v4.6 (take two)

On Fri, Feb 26, 2016 at 10:59 PM, Geert Uytterhoeven wrote: > Hi Linus, > > The following changes since commit 4c96cb027be5ceb2c7c0d4dc086d35fd0cfaf14b > (my previous pull request, which is not yet visible in pinctrl/for-next): > > pinctrl: sh-pfc: r8a7794: Add

RE: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Marc, Sorry for the late response. > On 03/02/2016 11:08 AM, Ramesh Shanmugasundaram wrote: > I see no locking for the tx-path. > >>> > >>> I am not sure why locking is needed in tx-path? > >> > >> If the tx-path is shared between both channels you need locking as > >> the networking

Re: [PATCH/RFC 1/9] clk: shmobile: r8a7795: Add FCP clocks

Hi Geert, On Thursday 03 March 2016 12:56:29 Geert Uytterhoeven wrote: > On Thu, Mar 3, 2016 at 11:49 AM, Laurent Pinchart wrote: > > On Thursday 03 March 2016 08:37:02 Kuninori Morimoto wrote: > >> - s2d2 (for 200MHz) > >> - s2d1 (for 400MHz) > > > > Thank you for the

Re: [PATCH 2/6] net: ethernet: renesas: ravb_main: test clock rate to avoid division by 0

Hello. On 3/3/2016 1:33 AM, Wolfram Sang wrote: From: Wolfram Sang The clk API may return 0 on clk_get_rate, so we should check the result before using it as a divisor. Signed-off-by: Wolfram Sang Acked-by: Sergei

Re: [PATCH v2] dma: rcar-dmac: clear pertinence number of channels

Hi Morimoto-san, Thank you for the patch. On Thursday 03 March 2016 17:25:53 Kuninori Morimoto wrote: > From: Kuninori Morimoto > > DMACHCLR clears each channels, but its channel number is based on > its SoC or IP. Current driver is using fixed 0x7fff (= for

Re: [PATCH/RFC 1/9] clk: shmobile: r8a7795: Add FCP clocks

Hi Morimoto-san, On Thursday 03 March 2016 08:37:02 Kuninori Morimoto wrote: > Hi Laurent > > - s2d2 (for 200MHz) > - s2d1 (for 400MHz) > >>> > >>> Thank you for the information. Do you mean that different FCP instances > >>> use different clocks ? If so, could you tell us which

[PATCH 2/3] phy: rcar-gen3-usb2: Add vbus-supply to handle VBUS on/off

To handle the VBUS on/off by a regulator driver, this patch adds regulator APIs calling in the driver and description about vbus-supply in the rcar-gen3-phy-usb2.txt. Signed-off-by: Yoshihiro Shimoda Acked-by: Rob Herring ---

[PATCH 3/3] phy: rcar-gen3-usb2: add extcon support

This patch adds extcon support for otg related channel. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/Kconfig | 1 + drivers/phy/phy-rcar-gen3-usb2.c | 26 ++ 2 files changed, 27 insertions(+) diff --git

[PATCH 0/3] phy: rcar-gen3-usb2: add vbus-supply and extcon

This patch set is based on the latest linux-phy / next branch (commit id = 89636adde4a05953e3bf18807ba1f6f205572f67) and the following patches: http://thread.gmane.org/gmane.linux.kernel/2166364 http://thread.gmane.org/gmane.linux.kernel.renesas-soc/1512/focus=1514 The patch "Add vbus-supply to

[PATCH 1/3] phy: rcar-gen3-usb2: remove unnecesary struct rcar_gen3_data

Since this driver uses the struct rcar_gen3_data in struct rcar_gen3_chan only, we can remove the rcar_gen3_data. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/phy-rcar-gen3-usb2.c | 33 ++--- 1 file changed, 14 insertions(+), 19

Re: [PATCH] iommu/ipmmu-vmsa: Add r8a7795 DT binding

On Thu, Mar 03, 2016 at 09:05:39AM +0900, Simon Horman wrote: > On Thu, Mar 03, 2016 at 12:46:30AM +0900, Magnus Damm wrote: > > On Wed, Mar 2, 2016 at 11:55 PM, Joerg Roedel wrote: > > > On Mon, Feb 29, 2016 at 11:33:09PM +0900, Magnus Damm wrote: > > >> From: Magnus Damm

[PATCH/RESEND] usb: renesas_usbhs: gadget: fix giveback status code in usbhsg_pipe_disable()

A udc driver should set the giveback status to -ESHUTDOWN in usb_ep_disable(). Otherwise, a gadget driver (e.g. g_serial) might request next data wrongly and it is possible to cause kernel panic. Signed-off-by: Yoshihiro Shimoda ---

RE: [PATCH] usb: renesas_usbhs: gadget: fix giveback status code in usbhsg_pipe_disable()

Hi Felipe, > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Thursday, March 03, 2016 6:22 PM > > Hi Yoshihiro, > > Yoshihiro Shimoda writes: > > [ text/plain ] > > Hi Felipe, > > > > Oops, I completely forgot this patch. > > Would you review this patch?

[PATCH 1/2] ARM: dts: r8a7790: Add SCIF2 clock

Based on Rev. 2.00 of the R-Car Gen2 datasheet. Signed-off-by: Geert Uytterhoeven --- arch/arm/boot/dts/r8a7790.dtsi| 6 +++--- include/dt-bindings/clock/r8a7790-clock.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 0/2] ARM: dts: r8a7790: Add support for SCIF2

Hi Simon, Magnus, This patch series adds support for the SCIF2 serial port on R-Car H2. SCIF2 was probably left out because its module clock appeared only in revision 2.00 of the R-Car Gen2 datasheet. This was compile-tested only due lack of hardware. I believe SCIF2 is exposed on pins

RE: [PATCH] usb: renesas_usbhs: gadget: fix giveback status code in usbhsg_pipe_disable()

Hi Yoshihiro, Yoshihiro Shimoda writes: > [ text/plain ] > Hi Felipe, > > Oops, I completely forgot this patch. > Would you review this patch? Or should I resend it? > I confirmed that this patch could be applied on your latest > testing/fixes branch. I don't

RE: [PATCH] usb: gadget: renesas_usb3: Use ARCH_RENESAS

Hi Simon-san, > From: Simon Horman [mailto:horms+rene...@verge.net.au] > Sent: Wednesday, March 02, 2016 11:17 AM > > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > ARCH_RENESAS the motivation for which being that

Re: [PATCH/RFC 1/9] clk: shmobile: r8a7795: Add FCP clocks

Hi Laurent > > >> - s2d2 (for 200MHz) > > >> - s2d1 (for 400MHz) > > > > > > Thank you for the information. Do you mean that different FCP instances > > > use different clocks ? If so, could you tell us which clock is used by > > > each instance in th H3 ES1 ? > > > > Sorry for my confusable

Re: [PATCH] bus: simple-pm-bus: Use ARCH_RENESAS

On Thu, Mar 3, 2016 at 2:39 AM, Simon Horman wrote: > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > appropriate

Re: [PATCH] ata: sata_rcar: Use ARCH_RENESAS

On Thu, Mar 3, 2016 at 2:28 AM, Simon Horman wrote: > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > appropriate

Re: [PATCH] phy: rcar-gen3-usb2, rcar-gen2: Use ARCH_RENESAS

Hi Simon, On Thu, Mar 3, 2016 at 1:12 AM, Simon Horman wrote: > On Wed, Mar 02, 2016 at 10:36:33AM +0100, Geert Uytterhoeven wrote: >> On Wed, Mar 2, 2016 at 3:25 AM, Simon Horman >> wrote: >> > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.

Re: [PATCH] dmaengine: rcar-dmac: clear pertinence number of channels

On Thu, Mar 3, 2016 at 7:04 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > DMACHCLR clears each channels, but its channel number is based on > its SoC or IP. Current driver is using fixed 0x7fff (= for 14ch), 15ch.

Re: [PATCH 2/6] ASoC: rsrc-card: add convert channels support

Hi Mark, Rob thank you for your review > > - convert-rate : platform specified sampling > > rate convert > > +- convert-channels : platform specified channel size > > convert > > This needs a better description (as did convert-rate). What is the

Re: [PATCH v2 2/2] phy: rcar-gen3-usb2: add fallback binding

On Thu, Mar 3, 2016 at 1:38 AM, Simon Horman wrote: > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > relationship between IP blocks might be. For example, I believe that

Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0

> > + if (!dev->clk_rate) > > + return -EINVAL; > > May be a nitpick, but clk_disable_unprepare() is missing. Oh, definately not a nitpick in my book, will resend! Thanks! signature.asc Description: PGP signature

Re: [PATCH v2] Input: sh_keysc - Remove dependency on SUPERH

On Thu, Mar 3, 2016 at 1:53 AM, Simon Horman wrote: > A dependency on ARCH_SHMOBILE seems to be the best option for sh_keysc: > > * For Super H based SoCs: sh_keysc is used on SH_MIGOR, SH_ECOVEC, SH_KFR2R09, > SH_7722_SOLUTION_ENGINE, and SH_7724_SOLUTION_ENGINE,