Re: [PATCH v3 5/7] soc: renesas: Add r8a7793 SYSC PM Domain Binding Definitions

Hi Geert, Thank you for the patch. On Wednesday 09 March 2016 20:18:40 Geert Uytterhoeven wrote: > R-Car M2-N is identical to R-Car M2-W w.r.t. power domains, so reuse the > definitions from the latter. > > Signed-off-by: Geert Uytterhoeven > --- > v3: > - New. > ---

Re: [PATCH v3 3/7] soc: renesas: Add r8a7790 SYSC PM Domain Binding Definitions

Hi Geert, Thank you for the patch. On Wednesday 09 March 2016 20:18:38 Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > v3: > - New. > --- > include/dt-bindings/power/r8a7790-sysc.h | 31 + > 1 file changed, 31

Re: [PATCH v3 4/7] soc: renesas: Add r8a7791 SYSC PM Domain Binding Definitions

Hi Geert, Thank you for the patch. On Wednesday 09 March 2016 20:18:39 Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > v3: > - New. > --- > include/dt-bindings/power/r8a7791-sysc.h | 23 +++ > 1 file changed, 23 insertions(+)

[PATCH] ASoC: rsnd: add simplified module explanation

From: Kuninori Morimoto Renesas sound driver user needs to read its datasheet when create DT. But it is difficult to understand, because it has many modules (SRC/CTU/MIX/DVC/SSIU/SSI/AudioDMAC/AudioDMACperiperi), and many features (Asynchronous/Synchronous mode

Re: [PATCH v3 6/7] soc: renesas: Add r8a7794 SYSC PM Domain Binding Definitions

Hi Geert, Thank you for the patch. On Wednesday 09 March 2016 20:18:41 Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > v3: > - New. > --- > include/dt-bindings/power/r8a7794-sysc.h | 23 +++ > 1 file changed, 23 insertions(+)

[PATCH v2 2/2] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

This patch fixes an issue that cannot work if R-Car Gen2/3 run on above 4GB physical memory environment to use a quirk XHCI_CLEAR_AC64. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/host/xhci-plat.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v2 0/2] usb: host: xhci: add a new quirk and fix an issue for R-Car Gen2/3

This patch set is based on the latest usb.git / usb-next branch. (commit id = ace53bfc4374cada8b645765e2b4ad5831e760932) Changes from v1: - Add a new quirk "XHCI_CLEAR_AC64" for using it on some PCIe card. http://thread.gmane.org/gmane.linux.kernel.renesas-soc/858/focus=1694 Yoshihiro

[PATCH v2 1/2] usb: host: xhci: add a new quirk XHCI_CLEAR_AC64

On some xHCI controllers (e.g. R-Car SoCs), the AC64 bit (bit 0) of HCCPARAMS1 is set to 1. However, the xHCs don't support 64-bit address memory pointers actually. So, in this case, this driver should call dma_set_coherent_mask(dev, DMA_BIT_MASK(32)) in xhci_gen_setup(). Otherwise, the xHCI

[PATCH v2 2/2] usb: renesas_usbhs: disable TX IRQ before starting TX DMAC transfer

This patch adds a code to surely disable TX IRQ of the pipe before starting TX DMAC transfer. Otherwise, a lot of unnecessary TX IRQs may happen in rare cases when DMAC is used. Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support") Cc: # v3.1+ Signed-off-by:

Re: [PATCH v3 7/7] soc: renesas: Add r8a7795 SYSC PM Domain Binding Definitions

Hi Geert, Thank you for the patch. On Wednesday 09 March 2016 20:18:42 Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > v3: > - New. > --- > include/dt-bindings/power/r8a7795-sysc.h | 42 + > 1 file changed, 42

[PATCH v2 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

When unexpected situation happened (e.g. tx/rx irq happened while DMAC is used), the usbhsf_pkt_handler() was possible to cause NULL pointer dereference like the followings: Unable to handle kernel NULL pointer dereference at virtual address pgd = c0004000 [] *pgd=

[PATCH v2 0/2] usb: renesas_usbhs: fix to avoid unexpected condition

This patch set is based on the latest Felipe's usb.git / testing/next branch. (commit id = ac5706631325ae3695bfa1527101ab2b2f64859f) Changes from v1: - Add "Fixes" and "Cc: . - Revise the commit log of patch 2. - consistent words: tx -> TX, irq -> IRQ - typo: heppen

RE: [PATCH 2/2] usb: renesas_usbhs: disable tx irq before starting TX DMAC transfer

Hello, > Hello. > > On 3/8/2016 8:58 AM, Yoshihiro Shimoda wrote: > > > This patch adds a code to surely disable tx irq of the pipe before > > TX IRQ. > > > starting TX DMAC transfer. Otherwise, a lot of unnecessary tx irqs > > TX IRQs. Mixing "TX" and "tx" on a single line is...

RE: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

Hi, > > Yoshihiro Shimoda writes: > >> Yoshihiro Shimoda writes: > >> > This patch adds a condition to avoid the dereference. > >> > > >> > Signed-off-by: Yoshihiro Shimoda > >> > >> is this

Re: [PATCH v3 1/7] PM / Domains: Add DT bindings for the R-Car System Controller

Hi Geert, Thank you for the patch. On Wednesday 09 March 2016 20:18:36 Geert Uytterhoeven wrote: > The Renesas R-Car System Controller provides power management for the > CPU cores and various coprocessors, following the generic PM domain > bindings in

Re: [PATCH 2/4] clk: renesas: cpg-mssr: Drop check for CONFIG_PM_GENERIC_DOMAINS_OF

Hi Geert, Thank you for the patch. On Wednesday 09 March 2016 20:18:32 Geert Uytterhoeven wrote: > As of commit 71d076ceb245f0d9 ("ARM: shmobile: Enable PM and > PM_GENERIC_DOMAINS for SoCs with PM Domains"), > CONFIG_PM_GENERIC_DOMAINS_OF is always enabled for SoCs with a CPG/MSSR > block. > >

[PATCH v3 4/6] ARM: dts: r8a7793: Add SYSC PM domains

Add a device node for the System Controller. Hook up the first Cortex-A15 CPU core and the Cortex-A15 L2 cache/SCU to their respective PM domains. Signed-off-by: Geert Uytterhoeven --- v3: - Drop power area hiearchy from DT, - Switch to "#power-domain-cells = <1>",

[PATCH v3 0/6] ARM/arm64: dts: rcar: Add SYSC PM domains

Hi all, This patch series adds the R-Car System Controller to the DTS files for the various R-Car SoCs, and hooks up devices to their respective PM domains. This is a dependency for the enablement of DU and VSP on R-Car H3, as the VSPs are located in a PM Domain. Changes compared to v2:

[PATCH v3 5/7] soc: renesas: Add r8a7793 SYSC PM Domain Binding Definitions

R-Car M2-N is identical to R-Car M2-W w.r.t. power domains, so reuse the definitions from the latter. Signed-off-by: Geert Uytterhoeven --- v3: - New. --- include/dt-bindings/power/r8a7793-sysc.h | 27 +++ 1 file changed, 27 insertions(+)

[PATCH v3 6/6] arm64: dts: r8a7795: Add SYSC PM domains

Add a device node for the System Controller. Hook up the Cortex-A57 CPU cores and the Cortex-A57 and Cortex A53 L2 caches/SCUs to their respective PM domains. Hook up all devices that are part of the CPG/MSSR Clock Domain to the SYSC "always-on" PM Domain. Signed-off-by: Geert Uytterhoeven

[PATCH 1/3] arm64: dts: r8a7795: Hook up PCIe devices to SYSC "always-on" PM Domain

Signed-off-by: Geert Uytterhoeven --- To be folded into either "arm64: renesas: r8a7795: Add PCIe nodes" or "arm64: dts: r8a7795: Add SYSC PM domains", depending on merge order. --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 2/6] ARM: dts: r8a7790: Add SYSC PM domains

Add a device node for the System Controller. Hook up the Cortex-A15 and Cortex-A7 CPU cores and L2 caches/SCUs to their respective PM domains. Signed-off-by: Geert Uytterhoeven --- v3: - Drop power area hiearchy from DT, - Switch to "#power-domain-cells = <1>", -

[PATCH v3 09/11] soc: renesas: rcar-sysc: Add support for R-Car M2-N power areas

R-Car M2-N is identical to R-Car M2-W w.r.t. power domains, so reuse the definitions from the latter. Signed-off-by: Geert Uytterhoeven --- v3: - New (converted from DT to C). --- drivers/soc/renesas/Makefile| 3 ++- drivers/soc/renesas/rcar-sysc.c | 3 +++

[PATCH 2/3] arm64: dts: r8a7795: Hook up FCPV devices to SYSC PM Domains

Signed-off-by: Geert Uytterhoeven --- To be folded with "arm64: dts: renesas: r8a7795: Add power domains to FCP nodes" into "arm64: dts: renesas: r8a7795: Add FCPV nodes". --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 18 +- 1 file changed, 9

[PATCH v3 0/7] PM / Domains: Add DT bindings for the R-Car System Controller

Hi all, This patch series introduces DT bindings for the R-Car System Controller. Changes compared to v2: - Move power area hierarchy from DT to C (cfr. DT bindings for Renesas CPG/MSSR), and switch to "#power-domain-cells = <1>", - Drop fallback compatibility strings, as the

[PATCH v3 05/11] soc: renesas: rcar-sysc: Enable Clock Domain for r8a7795 I/O devices

On R-Car H3, some power areas (e.g. A3VP) contain I/O devices, which are also part of the CPG/MSSR Clock Domain. Hook up the CPG/MSSR Clock Domain attach/detach callbacks to enable power management using module clocks. This also allows to support the Clock Domain for devices in the "always-on"

[PATCH v3 02/11] soc: renesas: rcar-sysc: Improve rcar_sysc_power() debug info

Print requested power domain state. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v3: - Add Reviewed-by, v2: - New. --- drivers/soc/renesas/rcar-sysc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 06/11] soc: renesas: rcar-sysc: Add support for R-Car H1 power areas

Signed-off-by: Geert Uytterhoeven --- v3: - New (converted from DT to C). --- drivers/soc/renesas/Makefile | 2 +- drivers/soc/renesas/r8a7779-sysc.c | 31 +++ drivers/soc/renesas/rcar-sysc.c| 3 +++

[PATCH v3 10/11] soc: renesas: rcar-sysc: Add support for R-Car E2 power areas

Signed-off-by: Geert Uytterhoeven --- v3: - New (converted from DT to C). --- drivers/soc/renesas/Makefile | 2 +- drivers/soc/renesas/r8a7794-sysc.c | 32 drivers/soc/renesas/rcar-sysc.c| 3 +++

[PATCH v3 11/11] soc: renesas: rcar-sysc: Add support for R-Car H3 power areas

Signed-off-by: Geert Uytterhoeven --- v3: - New (converted from DT to C). --- drivers/soc/renesas/Makefile | 1 + drivers/soc/renesas/r8a7795-sysc.c | 56 ++ drivers/soc/renesas/rcar-sysc.c| 3 ++

[PATCH v3 6/7] soc: renesas: Add r8a7794 SYSC PM Domain Binding Definitions

Signed-off-by: Geert Uytterhoeven --- v3: - New. --- include/dt-bindings/power/r8a7794-sysc.h | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 include/dt-bindings/power/r8a7794-sysc.h diff --git

[PATCH v3 3/7] soc: renesas: Add r8a7790 SYSC PM Domain Binding Definitions

Signed-off-by: Geert Uytterhoeven --- v3: - New. --- include/dt-bindings/power/r8a7790-sysc.h | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 include/dt-bindings/power/r8a7790-sysc.h diff --git

[PATCH v3 07/11] soc: renesas: rcar-sysc: Add support for R-Car H2 power areas

Signed-off-by: Geert Uytterhoeven --- v3: - New (converted from DT to C). --- drivers/soc/renesas/Makefile | 2 +- drivers/soc/renesas/r8a7790-sysc.c | 45 ++ drivers/soc/renesas/rcar-sysc.c| 3 +++

[PATCH 0/3] arm64: dts: r8a7795: SYSC PM Domain Updates

Hi all, This patch series contains DT updates related to v3 of the R-Car SYSC PM Domain series: - "[PATCH v3 0/7] PM / Domains: Add DT bindings for the R-Car System Controller", - "[PATCH v3 00/11] soc: renesas: Add R-Car SYSC PM Domain Support", - "[PATCH v3 0/6] ARM/arm64:

[PATCH v3 5/6] ARM: dts: r8a7794: Add SYSC PM domains

Add a device node for the System Controller. Hook up the Cortex-A7 CPU cores and the Cortex-A7 L2 cache/SCU to their respective PM domains. Signed-off-by: Geert Uytterhoeven --- v3: - Drop power area hiearchy from DT, - Switch to "#power-domain-cells = <1>", - Drop

[PATCH v3 3/6] ARM: dts: r8a7791: Add SYSC PM domains

Add a device node for the System Controller. Hook up the Cortex-A15 CPU cores and the Cortex-A15 L2 cache/SCU to their respective PM domains. Signed-off-by: Geert Uytterhoeven --- v3: - Drop power area hiearchy from DT, - Switch to "#power-domain-cells = <1>", -

[PATCH 3/3] arm64: dts: r8a7795: Hook up VSP devices to SYSC PM Domains

Signed-off-by: Geert Uytterhoeven --- To be folded with "arm64: dts: renesas: r8a7795: Add power domains to VSP nodes" and "arm64: dts: renesas: r8a7795: Add power domains to VSP2D nodes" into "arm64: dts: renesas: r8a7795: Add VSP instances". ---

[PATCH 2/4] clk: renesas: cpg-mssr: Drop check for CONFIG_PM_GENERIC_DOMAINS_OF

As of commit 71d076ceb245f0d9 ("ARM: shmobile: Enable PM and PM_GENERIC_DOMAINS for SoCs with PM Domains"), CONFIG_PM_GENERIC_DOMAINS_OF is always enabled for SoCs with a CPG/MSSR block. Signed-off-by: Geert Uytterhoeven --- drivers/clk/renesas/renesas-cpg-mssr.c | 9

[PATCH 4/4] clk: renesas: cpg-mssr: Export cpg_mssr_{at,de}tach_dev()

The R-Car SYSC PM Domain driver has to power manage devices in power areas using clocks. To reuse code and to share knowledge of clocks suitable for power management, this is ideally done through the existing cpg_mssr_attach_dev() and cpg_mssr_detach_dev() callbacks. Hence these callbacks can no

[PATCH v3 01/11] soc: renesas: Move pm-rcar to drivers/soc/renesas/rcar-sysc

Move the pm-rcar driver from arch/arm/mach-shmobile/ to drivers/soc/renesas/, and its header file to include/linux/soc/renesas/, so it can be shared between arm32 (R-Car H1 and Gen2) and arm64 (R-Car Gen3). Rename it to rcar-sysc as it's really a driver for the R-Car System Controller (SYSC).

[PATCH v3 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains

Populate the SYSC PM domains from DT, based on the presence of a device node for the System Controller. The actual power area hiearchy, and features of specific areas are obtained from tables in the C code. The SYSCIER register value is derived from the power areas present, which will help to get

[PATCH v3 04/11] soc: renesas: rcar-sysc: Make rcar_sysc_power_is_off() static

As of commit b12ff41658171f53 ("ARM: shmobile: r8a7779: Remove legacy PM Domain remainings"), rcar_sysc_power_is_off() is no longer used from SoC-specific code. Signed-off-by: Geert Uytterhoeven --- v3: - New. --- drivers/soc/renesas/rcar-sysc.c | 2 +-

[PATCH 3/4] clk: renesas: mstp: Clarify cpg_mstp_{at,de}tach_dev() domain parameter

Make it clear that the "domain" parameter of the cpg_mstp_attach_dev() and cpg_mstp_detach_dev() functions is not used. The cpg_mstp_attach_dev() and cpg_mstp_detach_dev() callbacks are not only used by the CPG/MSTP Clock Domain driver, but also by the R-Mobile SYSC PM Domain driver.

[PATCH 0/4] clk: renesas: PM Domain Cleanups and Preparation

Hi Mike, Stephen, This patch series performs some cleanups related to PM Domains on the Renesas clock drivers, and prepares the CPG/MSSR driver for the advent of R-Car SYSC PM Domains. Support for the latter will be introduced in 3 patch series: - "[PATCH v3 0/7] PM / Domains: Add DT

rcar-h3: codethink 4.2-bsp patches

-- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius 0x15537BB3.asc Description: application/pgp-keys

[PATCH 6/6] clk: shmobile: r8a7795: add PWM clock

Signed-off-by: Ulrich Hecht --- drivers/clk/renesas/r8a7795-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/drivers/clk/renesas/r8a7795-cpg-mssr.c index b2198aef..9de458a 100644 ---

[PATCH 4/6] arm64: dts: salvator-x: enable PWM

Enables PWM1 (brightness control) and PWM2 (PMIC switching frequency synchronization). Signed-off-by: Ulrich Hecht --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 23 ++ 1 file changed, 23 insertions(+) diff --git

Re: [RFC 4/7] mmc: tmio: Add UHS-I mode support

> > + > > + int (*start_signal_voltage_switch)(struct tmio_mmc_host *host, > > + unsigned char signal_voltage); > > Do you really need to add a new tmio specific callback for this? > > Why can't you instead have the tmio variant driver assign the >

Re: [RFC 5/7] mmc: sh_mobile_sdhi: Add UHS-I mode support

> May I suggest the following names for the pin states instead? > pins_default > pins_uhs Did this. > The corresponding pinctrl state-names I prefer are these: > > PINCTRL_STATE_DEFAULT and "state_uhs". These names are currently used by > mtk-sd. OK. I'd think "uhs" may be an even better

Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms

>I'd only like that the "Fixes:" and "Cc:" tags were added to it. To make it easier for you, Linus: Fixes: ef0eebc05130 ("drivers/pinctrl: Add the concept of an "init" state") CC: sta...@vger.kernel.org signature.asc Description: PGP signature

Re: [PATCH 2/2] usb: renesas_usbhs: disable tx irq before starting TX DMAC transfer

Hello. On 3/8/2016 8:58 AM, Yoshihiro Shimoda wrote: This patch adds a code to surely disable tx irq of the pipe before TX IRQ. starting TX DMAC transfer. Otherwise, a lot of unnecessary tx irqs TX IRQs. Mixing "TX" and "tx" on a single line is... inconsistent. :-) may heppen in

Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms

Hi Linus, On Wed, Mar 9, 2016 at 11:32 AM, Linus Walleij wrote: > On Wed, Mar 9, 2016 at 4:58 PM, Wolfram Sang wrote: >> On Mon, Mar 07, 2016 at 10:00:37PM +0100, Geert Uytterhoeven wrote: > >>> >This approach is better then, won't have to fix

Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms

Hello. On 3/9/2016 1:32 PM, Linus Walleij wrote: This approach is better then, won't have to fix again whenever SH gets DT support. Perhaps the of_have_populated_dt() check should be moved inside pinctrl_provide_dummies()? I suggest we pick up this patch now even with stable tag (the

Re: [PATCH] pinctrl: sh-pfc: core: only call pinctrl_provide_dummies() on SuperH

Hello. On 3/9/2016 2:09 PM, Linus Walleij wrote: The 'ravb' Ethernet driver couldn't connect to the PHY as the MDIO bus appeared empty on the Renesas R-Car boards. The bug hunt finally pointed at the commit adding the "init" pintcrl state: it tries to switch to non- default state before the

RE: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

Hi Felipe, > Hi Yoshihiro, > > Yoshihiro Shimoda writes: > > [ text/plain ] > > When unexpected situation happened (e.g. tx/rx irq happened while > > DMAC is used), the usbhsf_pkt_handler() was possible to cause NULL > > pointer dereference like the followings:

Re: [PATCH] pinctrl: sh-pfc: core: only call pinctrl_provide_dummies() on SuperH

On Sat, Mar 5, 2016 at 5:58 AM, Sergei Shtylyov wrote: > The 'ravb' Ethernet driver couldn't connect to the PHY as the MDIO bus > appeared empty on the Renesas R-Car boards. The bug hunt finally pointed > at the commit adding the "init" pintcrl state: it

RE: [PATCH] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

Hi, Yoshihiro Shimoda writes: > [ text/plain ] > Hi Mathias, > > Would you review this patch? > This patch could be applied into the latest usb.git / usb-next branch. > > Best regards, > Yoshihiro Shimoda > >> -Original Message- >> From: Yoshihiro

RE: [PATCH] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

Hi Mathias, Would you review this patch? This patch could be applied into the latest usb.git / usb-next branch. Best regards, Yoshihiro Shimoda > -Original Message- > From: Yoshihiro Shimoda > Sent: Tuesday, February 16, 2016 12:26 PM > To: mathias.ny...@intel.com;

Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms

On Wed, Mar 9, 2016 at 4:58 PM, Wolfram Sang wrote: > On Mon, Mar 07, 2016 at 10:00:37PM +0100, Geert Uytterhoeven wrote: >> >This approach is better then, won't have to fix again whenever SH gets >> > DT >> > support. >> >> Perhaps the of_have_populated_dt() check

Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms

On Tue, Mar 8, 2016 at 5:21 AM, Wolfram Sang wrote: > >> Perhaps the of_have_populated_dt() check should be moved inside >> pinctrl_provide_dummies()? > > Hmm, the kernel-doc for pinctrl_provide_dummies() says "Usually this > function is called by platforms without pinctrl

Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms

On Mon, Mar 07, 2016 at 10:00:37PM +0100, Geert Uytterhoeven wrote: > CC Shawn, Sascha for imx1 > > On Mon, Mar 7, 2016 at 9:34 PM, Sergei Shtylyov > wrote: > > On 03/07/2016 11:29 PM, Geert Uytterhoeven wrote: > > > > --- a/drivers/pinctrl/sh-pfc/core.c >