Re: [PATCH v2 08/11] serial: sh-sci: Correct pin initialization on (H)SCIF

Hi Peter, On Fri, Apr 29, 2016 at 5:59 PM, Peter Hurley wrote: > On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote: >> Correct pin initialization on (H)SCIF: >> - RTS must be deasserted (it's active low), >> - SCK must be an input, as it may be used as the optional external >> clock input.

[PATCH v3] ARM: dts: r8a7793: Add MMCIF0

Same as on r8a7791. Signed-off-by: Ulrich Hecht --- This version addresses the issues found by Geert and Simon (thank you): - change back to one DMA controller - use GIC_SPI - add max-frequency CU Uli arch/arm/boot/dts/r8a7793.dtsi | 13 + 1 file changed, 13 insertions(+) diff

Re: [PATCH v2 08/11] serial: sh-sci: Correct pin initialization on (H)SCIF

On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote: > Correct pin initialization on (H)SCIF: > - RTS must be deasserted (it's active low), > - SCK must be an input, as it may be used as the optional external > clock input. > > Initial pin configuration must always be done: > - Regardless o

Re: [PATCH v2 07/11] serial: sh-sci: Add more Serial Port Control/Data Register documentation

On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote: > Improve documentation for the SCIFA/SCIFB Serial Port Control and Data > Registers: > - State clearly that the RTS and CTS lines are active-low, > - Document the bits related to the serial port's SCK, RXD, and TXD > pins. Reviewed-by: Pet

Re: [PATCH v2 06/11] serial: sh-sci: Add more Serial Port Register documentation

On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote: > Improve documentation for the (H)SCIF Serial Port Register: > - Make it clear the RTS and CTS lines are active-low, > - Document the bits related to the serial port's clock pin. Reviewed-by: Peter Hurley

Re: [PATCH v2 04/11] serial: sh-sci: Add support for GPIO-controlled modem lines

On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote: > Enhance the Renesas SCI UART driver to add support for GPIO-controlled > modem lines (CTS, DSR, DCD, RNG, RTS, DTR), using the serial_mctrl_gpio > helpers. > > GPIO-controlled modem lines can be used when dedicated modem lines are > not available

Re: [PATCH v2 05/11] serial: sh-sci: Do not open-code sci_getreg()

On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote: > Replace open-coded variants of sci_getreg() by function calls, and drop > intermediate variables where appropriate. Reviewed-by: Peter Hurley

Re: [PATCH v2 03/11] serial: sh-sci: Always set TIOCM_CTS in .get_mctrl() callback

On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote: > Documentation/serial/driver clearly states: > > If the port does not support CTS, DCD or DSR, the driver should > indicate that the signal is permanently active. > > Hence always set TIOCM_CTS, as we currently don't look at the CTS > har

[PATCH v2 00/11] serial: sh-sci: Hardware Flow Control Updates

he patches apply to next-20160429, - The DT bindings refer to the Generic Serial DT Bindings that were added by "doc: DT: Add Generic Serial Device Tree Bindings", which is in tty-testing. This was tested on r8a7791/koelsch and r8a7740/armadillo, using UARTs and GPIO pins on

[PATCH v2 07/11] serial: sh-sci: Add more Serial Port Control/Data Register documentation

Improve documentation for the SCIFA/SCIFB Serial Port Control and Data Registers: - State clearly that the RTS and CTS lines are active-low, - Document the bits related to the serial port's SCK, RXD, and TXD pins. Signed-off-by: Geert Uytterhoeven --- v2: - New. --- drivers/tty/serial/

[PATCH v2 11/11] serial: sh-sci: Add DT support for dedicated RTS/CTS

Add support for indicating the availability of dedicated lines for RTS/CTS hardware flow control, using the standard "uart-has-rtscts" DT property. Signed-off-by: Geert Uytterhoeven --- v2: - New. --- drivers/tty/serial/sh-sci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tt

[PATCH v2 05/11] serial: sh-sci: Do not open-code sci_getreg()

Replace open-coded variants of sci_getreg() by function calls, and drop intermediate variables where appropriate. Signed-off-by: Geert Uytterhoeven --- v2: - New. --- drivers/tty/serial/sh-sci.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/sh-sc

[PATCH v2 08/11] serial: sh-sci: Correct pin initialization on (H)SCIF

Correct pin initialization on (H)SCIF: - RTS must be deasserted (it's active low), - SCK must be an input, as it may be used as the optional external clock input. Initial pin configuration must always be done: - Regardless of the presence of dedicated RTS and CTS pins: if the registe

[PATCH v2 01/11] serial: sh-sci: Update DT binding documentation for GPIO modem lines

Amend the DT bindings for the Renesas SCI driver to allow describing optional GPIO-controlled modem lines, which can be used where dedicated modem lines are not available. The property naming is dictated by the Generic Serial DT Bindings. Signed-off-by: Geert Uytterhoeven Acked-by: Rob Herring

[PATCH v2 09/11] serial: sh-sci: Add pin initialization for SCIFA/SCIFB

Before, the driver relied on initialization by the boot loader, or by implicit reset state. Note that unlike on (H)SCIF, the RTS/CTS bits exist only if dedicated RTS/CTS pins are available, which depends on the SoC and UART instance. Signed-off-by: Geert Uytterhoeven --- v2: - New. --- driver

[PATCH v2 04/11] serial: sh-sci: Add support for GPIO-controlled modem lines

Enhance the Renesas SCI UART driver to add support for GPIO-controlled modem lines (CTS, DSR, DCD, RNG, RTS, DTR), using the serial_mctrl_gpio helpers. GPIO-controlled modem lines can be used when dedicated modem lines are not available. Invalid configurations specifying both GPIO RTS/CTS and dedi

[PATCH v2 03/11] serial: sh-sci: Always set TIOCM_CTS in .get_mctrl() callback

Documentation/serial/driver clearly states: If the port does not support CTS, DCD or DSR, the driver should indicate that the signal is permanently active. Hence always set TIOCM_CTS, as we currently don't look at the CTS hardware line state at all. FWIW, this fixes the transmit path whe

[PATCH v2 02/11] serial: sh-sci: Update DT binding documentation for dedicated RTS/CTS

Some Renesas SCIF UARTs have dedicated lines for RTS/CTS hardware flow control. Whether these lines exist depends on SoC and UART instance inside the SoC. Whether these lines can be used for hardware flow control depends on board wiring. Amend the DT bindings with an optional property to indicat

[PATCH v2 10/11] serial: sh-sci: Fix support for hardware-assisted RTS/CTS

The existing support for hardware-assisted RTS/CTS is rudimentary and doesn't work. Add support for hardware-assisted RTS/CTS hardware flow control for the (H)SCIF, SCIFA, and SCIFB variants. Signed-off-by: Geert Uytterhoeven --- v2: - New. --- drivers/tty/serial/sh-sci.c | 90 +++

[PATCH v2 06/11] serial: sh-sci: Add more Serial Port Register documentation

Improve documentation for the (H)SCIF Serial Port Register: - Make it clear the RTS and CTS lines are active-low, - Document the bits related to the serial port's clock pin. Signed-off-by: Geert Uytterhoeven --- v2: - New. --- drivers/tty/serial/sh-sci.h | 10 ++ 1 file changed, 6

Re: [PATCH 0/3] phy: rcar-gen3-usb2: add vbus-supply and extcon

On Thursday 03 March 2016 03:39 PM, Yoshihiro Shimoda wrote: > This patch set is based on the latest linux-phy / next branch > (commit id = 89636adde4a05953e3bf18807ba1f6f205572f67) > and the following patches: > > http://thread.gmane.org/gmane.linux.kernel/2166364 > http://thread.gmane.org/gman

Re: [PATCH] arm64: dts: r8a7795: Increase the size of GIC-400 mapped registers

On Fri, 29 Apr 2016 09:43:45 +1000 Simon Horman wrote: > [Cc Mark Zyngier, linux-arm-kernel] > > Hi Dirk, > > On Thu, Apr 28, 2016 at 07:41:57AM +0200, Dirk Behme wrote: > > Hi Simon, > > > > On 28.04.2016 01:30, Simon Horman wrote: > > >Hi Dirk, > > > > > >I understand that there is an issue

Re: [PATCH 1/4] drm_mode: add TCON encoder/connector

On Fri, Apr 29, 2016 at 12:02:15AM +0300, Sergei Shtylyov wrote: > TCON (Timing Controller) usually means a chip that drives a LCD panel. > In our case, such controller is a part of the Renesas R-Car SoCs. Add > the TCON encoder/connector #define's to be used by the TCON support code > in the

Re: [PATCH] pinctrl: sh-pfc: Kill unused variable in sh_pfc_remove()

On Tue, Apr 26, 2016 at 12:30 PM, Geert Uytterhoeven wrote: > If CONFIG_PINCTRL_SH_PFC_GPIO=n: > > drivers/pinctrl/sh-pfc/core.c: In function 'sh_pfc_remove': > drivers/pinctrl/sh-pfc/core.c:649:17: warning: unused variable 'pfc' > [-Wunused-variable] > > Fixes: 67ec8d7b48463904 ("pinctr

Re: [PATCH v2] phy: rcar-gen3-usb2, rcar-gen2: Use ARCH_RENESAS

On Friday 25 March 2016 07:42 AM, Simon Horman wrote: > On Mon, Mar 07, 2016 at 09:01:48AM +0100, Geert Uytterhoeven wrote: >> On Mon, Mar 7, 2016 at 2:14 AM, Simon Horman >> wrote: >>> Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. >>> A now redundant dependency on OF is also dropped. >>>

Re: [PATCH v3 0/2] phy: rcar-gen2, rcar-gen3-usb2: add fallback binding

On Thursday 07 April 2016 03:17 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 25 March 2016 07:39 AM, Simon Horman wrote: >> On Mon, Mar 07, 2016 at 10:58:39AM +0900, Simon Horman wrote: >>> Add fallback compatibility strings for rcar phy drivers. >>> >>> In the case of Renesas R-Car har

[PATCH] pinctrl: sh-pfc: Let gpio_chip.to_irq() return -ENXIO on error

Currrently the gpio_chip.to_irq() callback returns -ENOSYS on error, which causes bad interactions with the serial_mctrl_gpio helpers. mctrl_gpio_init() returns -ENOSYS if GPIOLIB is not enabled, which is intended to be ignored by its callers. However, ignoring -ENOSYS when it was caused by a gpio