Re: [PATCH v3 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

2016-11-28 Thread Eduardo Valentin
Wolfram, Thanks for sending the driver. Questions on the driver locking strategy as follows. On Mon, Nov 28, 2016 at 10:09:22PM +0100, Wolfram Sang wrote: No commit message ? :-( generally speaking here, it is a good practice to describe what you are doing, what you have considered, and what yo

Re: [PATCH v2] net: phy: Fix use after free in phy_detach()

2016-11-28 Thread Zach Brown
On Mon, Nov 28, 2016 at 03:18:31PM +0100, Geert Uytterhoeven wrote: > If device_release_driver(&phydev->mdio.dev) is called, it releases all > resources belonging to the PHY device. Hence the subsequent call to > phy_led_triggers_unregister() will access already freed memory when > unregistering th

[PATCH v3 4/4] arm64: dts: r8a7796: Add R-Car Gen3 thermal support

2016-11-28 Thread Wolfram Sang
Signed-off-by: Hien Dang Signed-off-by: Thao Nguyen Signed-off-by: Khiem Nguyen Signed-off-by: Wolfram Sang --- Changes since last version: * DTSI updates refactored to meet the above changes arch/arm64/boot/dts/renesas/r8a7796.dtsi | 58 1 file changed, 58 i

[PATCH v3 3/4] arm64: dts: r8a7795: Add R-Car Gen3 thermal support

2016-11-28 Thread Wolfram Sang
Signed-off-by: Hien Dang Signed-off-by: Thao Nguyen Signed-off-by: Khiem Nguyen Signed-off-by: Wolfram Sang --- Changes since last version: * DTSI updates refactored to meet the above changes arch/arm64/boot/dts/renesas/r8a7795.dtsi | 58 1 file changed, 58 i

[PATCH v3 1/4] thermal: rcar_gen3_thermal: Document the R-Car Gen3

2016-11-28 Thread Wolfram Sang
Signed-off-by: Hien Dang Signed-off-by: Khiem Nguyen Signed-off-by: Wolfram Sang --- Changes since last version: * earlier versions had one node per sensor. This version has one node for all, but we now have one reg entry per sensor. This makes it easier to use the shared resources (FUSE re

[PATCH v3 0/4] thermal: add driver for R-Car Gen3

2016-11-28 Thread Wolfram Sang
Finally, here is a new series adding support for the thermal sensors on Renesas R-Car Gen3 SoCs. The driver has been largely refactored since v2 sent by Khiem. It is a lot simpler (no interrupts for now, will be added later), so I hope we could still apply the 'new-driver-rule' and make it for 4.10

[PATCH v3 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

2016-11-28 Thread Wolfram Sang
Signed-off-by: Hien Dang Signed-off-by: Thao Nguyen Signed-off-by: Khiem Nguyen Signed-off-by: Wolfram Sang --- Changes since last version: * removed interrupt support, needs to be refactored seperately * adapt code to the new bindings, especially one node for all sensors. Similarly, we hav

Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks

2016-11-28 Thread Thomas Petazzoni
Hello, On Mon, 28 Nov 2016 19:25:04 +0100, Johan Hovold wrote: > Make sure to deregister and free any fixed-link PHY registered using > of_phy_register_fixed_link() on probe errors and on driver unbind. > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") > Signed-off-by: Johan Ho

[PATCH net 12/16] net: ethernet: mediatek: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on initialisation errors and on uninit. Fixes: 0c72c50f6f93 ("net-next: mediatek: add fixed-phy support") Signed-off-by: Johan Hovold --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 1 file

[PATCH net 09/16] net: ethernet: gianfar: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Fixes: be40364544bd ("gianfar: use the new fixed PHY helpers") Signed-off-by: Johan Hovold --- drivers/net/ethernet/freescale/gianfar.c | 8 1 file cha

[PATCH net 14/16] net: ethernet: dwc_eth_qos: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Fixes: 077742dac2c7 ("dwc_eth_qos: Add support for Synopsys DWC Ethernet QoS") Signed-off-by: Johan Hovold --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 20

[PATCH net 16/16] net: dsa: slave: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on slave-setup errors and on slave destroy. Fixes: 0d8bcdd383b8 ("net: dsa: allow for more complex PHY setups") Signed-off-by: Johan Hovold --- net/dsa/slave.c | 12 +++- 1 file changed, 11

[PATCH net 05/16] net: ethernet: bcmsysport: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Fixes: 186534a3f832 ("net: systemport: use the new fixed PHY helpers") Signed-off-by: Johan Hovold --- drivers/net/ethernet/broadcom/bcmsysport.c | 17 +

[PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") Signed-off-by: Johan Hovold --- drivers/net/ethernet/marvell/mvneta.c | 5 + 1 file changed

[PATCH net 06/16] net: ethernet: bcmgenet: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Note that we're still leaking any fixed-link PHY registered in the non-OF probe path. Fixes: 9abf0c2b717a ("net: bcmgenet: use the new fixed PHY helpers") Signed

[PATCH net 13/16] net: ethernet: renesas: ravb: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on initialisation errors and on device close after having disconnected the PHY. Fixes: b4bc88a868ed ("ravb: Add fixed-link support") Signed-off-by: Johan Hovold --- drivers/net/ethernet/renesas/ravb

[PATCH net 15/16] net: ethernet: ti: davinci_emac: fix fixed-link phydev and of-node leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Also remember to put the of-node reference on probe errors. Fixes: 1bb6aa56bb38 ("net: davinci_emac: Add support for fixed-link PHY") Signed-off-by: Johan Hovold

[PATCH net 07/16] net: ethernet: fec: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Fixes: 407066f8f371 ("net: fec: Support phys probed from devicetree and fixed-link") Signed-off-by: Johan Hovold --- drivers/net/ethernet/freescale/fec_main.c |

[PATCH net 10/16] net: ethernet: ucc_geth: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Fixes: 87009814cdbb ("ucc_geth: use the new fixed PHY helpers") Signed-off-by: Johan Hovold --- drivers/net/ethernet/freescale/ucc_geth.c | 23 -

[PATCH net 08/16] net: ethernet: fs_enet: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Fixes: bb74d9a4a87b ("fs_enet: use the new fixed PHY helpers") Signed-off-by: Johan Hovold --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 7 ++-

[PATCH net 03/16] net: ethernet: altera: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Fixes: 7cdbc6f74f8e ("altera tse: add support for fixed-links.") Signed-off-by: Johan Hovold --- drivers/net/ethernet/altera/altera_tse_main.c | 9 - 1

[PATCH net 04/16] net: ethernet: aurora: nb8800: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on probe errors and on driver unbind. Fixes: c7dfe3abf40e ("net: ethernet: nb8800: support fixed-link DT node") Signed-off-by: Johan Hovold --- drivers/net/ethernet/aurora/nb8800.c | 9 +++-- 1

[PATCH net 00/16] net: fix fixed-link phydev leaks

2016-11-28 Thread Johan Hovold
This series fixes failures to deregister and free fixed-link phydevs that have been registered using the of_phy_register_fixed_link() interface. All but two drivers currently fail to do this and this series fixes most of them with the exception of a staging driver and the stmmac drivers which will

[PATCH net 02/16] of_mdio: add helper to deregister fixed-link PHYs

2016-11-28 Thread Johan Hovold
Add helper to deregister fixed-link PHYs registered using of_phy_register_fixed_link(). Convert the two drivers that care to deregister their fixed-link PHYs to use the new helper, but note that most drivers currently fail to do so. Signed-off-by: Johan Hovold --- drivers/net/ethernet/ti/cpsw.c

[PATCH net 01/16] net: dsa: slave: fix of-node leak and phy priority

2016-11-28 Thread Johan Hovold
Make sure to drop the reference taken by of_parse_phandle() before returning from dsa_slave_phy_setup(). Note that this also modifies the PHY priority so that any fixed-link node is only parsed when no phy-handle is given, which is in accordance with the common scheme for this. Fixes: 0d8bcdd383b

[PATCH v2] net: phy: Fix use after free in phy_detach()

2016-11-28 Thread Geert Uytterhoeven
If device_release_driver(&phydev->mdio.dev) is called, it releases all resources belonging to the PHY device. Hence the subsequent call to phy_led_triggers_unregister() will access already freed memory when unregistering the LEDs. Move the call to phy_led_triggers_unregister() before the possible

[PATCH] arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins

2016-11-28 Thread Niklas Söderlund
The EthernetAVB should not depend on the bootloader to setup correct drive-strength values. Values for drive-strength where found by examine the registers after the bootloader have configured the registers and successfully used the EthernetAVB. Signed-off-by: Niklas Söderlund --- arch/arm64/boot

Re: [PATCH renesas-next 1/3] ARM: dts: r8a73a4: Use SoC-specific compat string for mmcif

2016-11-28 Thread Simon Horman
On Fri, Nov 25, 2016 at 09:58:40AM +0100, Geert Uytterhoeven wrote: > On Thu, Nov 24, 2016 at 9:15 PM, Simon Horman > wrote: > > Use the SoC-specific compat string for mmcif in DT for the r8a73a4 SoC. > > This is in keeping with the use of compat strings for mmcif for other > > Renesas ARM based S

Re: renesas-drivers-2016-11-22-v4.9-rc6

2016-11-28 Thread Kuninori Morimoto
Hi Geert > I've found what's wrong: while my repo has the > renesas-drivers-next-2016-11-22-v4.9-rc6 tag, and all objects pointed to by > it, it does not have a branch matching the tag. > > When doing "git remote update", git updates all branches first, followed by > importing all tags. Apparen

Re: renesas-drivers-2016-11-22-v4.9-rc6

2016-11-28 Thread Geert Uytterhoeven
Hi Morimoto-san, On Mon, Nov 28, 2016 at 1:17 AM, Kuninori Morimoto wrote: >> I did just "git fetch" on my local renesas-drivers.git repo. >> The local repo has other tags (e.g. renesas-drivers-2016-11-22-v4.9-rc6). >> And renesas-drivers-next-2016-11-22-v4.9-rc6 didn't exist. >> But, I tried "gi