Re: [PATCH v2] dmaengine: rcar-dmac: Widen DMA mask to 40 bits

2017-02-13 Thread Vinod Koul
On Mon, Feb 13, 2017 at 12:00:26PM +0100, Geert Uytterhoeven wrote: > By default, the DMA mask covers only the low 32-bit address space, which > causes SWIOTLB on arm64 to fall back to a bounce buffer for DMA > transfers involving memory outside the 32-bit address space. > > The R-Car DMA

Re: [PATCH 00/11] media: rcar-vin: fix OPS and format/pad index issues

2017-02-13 Thread Niklas Söderlund
Hi Hans, On 2017-02-13 21:57:48 +0100, Hans Verkuil wrote: > On 02/13/2017 06:47 PM, Niklas Söderlund wrote: > > Hi Hans, > > > > Thanks for your feedback. > > > > On 2017-02-13 15:19:13 +0100, Hans Verkuil wrote: > >> Hi Niklas, > >> > >> One general remark: in many commit logs you mistype

Re: [PATCH v4 4/4] v4l: vsp1: Remove redundant pipe->dl usage from drm

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 06 Jan 2017 12:15:31 Kieran Bingham wrote: > The pipe->dl is used only inside vsp1_du_atomic_flush(), and can be > obtained and stored locally to simplify the code. > > Signed-off-by: Kieran Bingham

Re: [PATCH 0/8] v4l: vsp1: Partition phase developments

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patches. On Friday 10 Feb 2017 20:27:28 Kieran Bingham wrote: > This series presents ongoing work with the scaler partition algorithm. > > It is based upon the previous partition algorithm improvements submission > [0] This series has been pushed to a tag [1] for

Re: [PATCH 5/8] v4l: vsp1: Operate on partition struct data directly

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:33 Kieran Bingham wrote: > When generating the partition windows, operate directly on the partition > struct rather than copying and duplicating the processed data > > Signed-off-by: Kieran Bingham

Re: [PATCH 4/8] v4l: vsp1: Move partition rectangles to struct

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:32 Kieran Bingham wrote: > As we develop the partition algorithm, we need to store more information > per partition to describe the phase and other parameters. > > To keep this data together, further abstract the existing v4l2_rect

Re: [PATCH 1/8] v4l: vsp1: Provide UDS register updates

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:29 Kieran Bingham wrote: > Provide register definitions required for UDS phase and partition > algorithm support I would mention here that those registers and bits are available on Gen3 only. > > Signed-off-by: Kieran Bingham

Re: [PATCH 00/11] media: rcar-vin: fix OPS and format/pad index issues

2017-02-13 Thread Laurent Pinchart
Hi Hans, On Monday 13 Feb 2017 15:19:13 Hans Verkuil wrote: > Hi Niklas, > > One general remark: in many commit logs you mistype 'subdeivce'. Can you > fix that for the v2? > > On 01/31/2017 04:40 PM, Niklas Söderlund wrote: > > Hi, > > > > This series address issues with the R-Car Gen2 VIN

Re: [PATCHv2 5/5] tests: Test suspend/resume on active pipelines

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday 01 Dec 2016 21:31:49 Kieran Bingham wrote: > From: Kieran Bingham > > Provide a test to verify the hardware completes a functional test whilst > performing a suspend resume cycle in parallel. Make use of the >

Re: [PULL REQUEST] renesas/topic/sdhi-autocmd12-resp for renesas drivers

2017-02-13 Thread Ulf Hansson
On 13 February 2017 at 11:04, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Sun, Feb 12, 2017 at 12:27 PM, Wolfram Sang wrote: >> here is a topic branch for renesas-drivers to report back autocmd12 >> responses for SDHI. It is based on mmc/next. Please

Re: [PATCHv2 2/5] scripts: Provide bin2png.sh helper

2017-02-13 Thread Laurent Pinchart
Hi Geert, On Monday 13 Feb 2017 15:17:10 Geert Uytterhoeven wrote: > On Mon, Feb 13, 2017 at 3:03 PM, Laurent Pinchart wrote: > >> +PNM=$(echo $FILE | sed -e 's|\.bin$|.pnm|') > > > > You can write this as > > > > PNM=${FILE/.bin/.pnm} > > / doesn't just match the suffix, try with

Re: [PATCHv2 3/5] logger: Log to the FTrace buffer if tracing is enabled

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday 01 Dec 2016 21:31:47 Kieran Bingham wrote: > From: Kieran Bingham > > Extend the logger such that it will detect the tracing system, and also > append print statement to this ring buffer. > > This provides the

Re: [PATCH 00/11] media: rcar-vin: fix OPS and format/pad index issues

2017-02-13 Thread Hans Verkuil
Hi Niklas, One general remark: in many commit logs you mistype 'subdeivce'. Can you fix that for the v2? On 01/31/2017 04:40 PM, Niklas Söderlund wrote: > Hi, > > This series address issues with the R-Car Gen2 VIN driver. The most > serious issue is the OPS when unbind and rebinding the i2c

Re: [PATCHv2 2/5] scripts: Provide bin2png.sh helper

2017-02-13 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Feb 13, 2017 at 3:03 PM, Laurent Pinchart wrote: >> +PNM=$(echo $FILE | sed -e 's|\.bin$|.pnm|') > > You can write this as > > PNM=${FILE/.bin/.pnm} / doesn't just match the suffix, try with waste.bin.picture.bin :-) PNM=${FILE%.bin}.pnm

[PATCH] scripts: bin2png: Support conversion of all files in a directory

2017-02-13 Thread Laurent Pinchart
When the first argument is a directory name instead of a file name, convert all test script output binaries in that directory. Signed-off-by: Laurent Pinchart --- scripts/bin2png.sh | 41 - 1 file changed, 28

Re: [PATCH 2/4] mmc: host: tmio: fix minor typos in a comment

2017-02-13 Thread Wolfram Sang
> > -/* Definitions for values the CTRL_STATUS register can take. */ > > +/* Definitions for values the CTL_STATUS register can take */ > > #define TMIO_STAT_CMDRESPENDBIT(0) > > #define TMIO_STAT_DATAEND BIT(2) > > #define TMIO_STAT_CARD_REMOVE BIT(3) > > Is a similar update for

Re: [PATCHv2 2/5] scripts: Provide bin2png.sh helper

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday 01 Dec 2016 21:31:46 Kieran Bingham wrote: > From: Kieran Bingham > > Identify the size and format from the test output filename, and pass > to raw2rgbpnm for conversion to a PNM file. > > From there we can

Re: [PATCHv2 1/5] scripts: Test suite runner

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday 01 Dec 2016 21:31:45 Kieran Bingham wrote: > From: Kieran Bingham > > Provide a utility script to execute all vsp unit tests, as well > as the option to execute multiple iterations of the suite. > >

Re: [PATCH v4 4/4] arm64: dts: r8a7796: salvator-x: add SCIF1 (DEBUG1)

2017-02-13 Thread Geert Uytterhoeven
Hi Simon, On Mon, Feb 13, 2017 at 2:05 PM, Simon Horman wrote: > On Wed, Feb 08, 2017 at 12:19:55PM +0100, Ulrich Hecht wrote: >> On Wed, Feb 8, 2017 at 11:54 AM, Simon Horman wrote: >> > On Fri, Feb 03, 2017 at 11:38:20AM +0100, Ulrich Hecht wrote: >> >>

Re: [PATCH v4 4/4] arm64: dts: r8a7796: salvator-x: add SCIF1 (DEBUG1)

2017-02-13 Thread Simon Horman
On Wed, Feb 08, 2017 at 12:19:55PM +0100, Ulrich Hecht wrote: > On Wed, Feb 8, 2017 at 11:54 AM, Simon Horman wrote: > > On Fri, Feb 03, 2017 at 11:38:20AM +0100, Ulrich Hecht wrote: > >> Enables the SCIF hooked up to the DEBUG1 connector. > >> > >> Signed-off-by: Ulrich Hecht

Re: [PATCH v2 3/4] arm64: renesas: r8a7796 dtsi: Add all HSCIF nodes

2017-02-13 Thread Simon Horman
On Mon, Feb 13, 2017 at 03:06:21PM +0300, Sergei Shtylyov wrote: > Hello! > > On 2/13/2017 3:01 PM, Simon Horman wrote: > > >>>Add the device nodes for all HSCIF serial ports, incl. clocks, and > >>>clock domain. > >> > >> Not power domain? > >> > >>>Signed-off-by: Ulrich Hecht

Re: [PATCH 4/4] mmc: host: tmio: fill in response from auto cmd12

2017-02-13 Thread Simon Horman
On Sun, Feb 12, 2017 at 12:12:27PM +0100, Wolfram Sang wrote: > After we received the dataend interrupt, R1 response register carries > the value from the automatically generated stop command. Report that > info back to the MMC block layer, so we will be notified in case of e.g. > ECC errors which

Re: [PATCH v3 0/7] Add V4L2 SDR (DRIF & MAX2175) driver

2017-02-13 Thread Hans Verkuil
On 02/07/2017 04:02 PM, Ramesh Shanmugasundaram wrote: > Hi Media, DT maintainers, All, > > This patch set contains two drivers > - Renesas R-Car Digital Radio Interface (DRIF) driver > - Maxim's MAX2175 RF to Bits tuner driver > > These patches were based on top of media-tree repo > commit:

Re: [PATCH 3/4] mmc: host: tmio: don't BUG on unsupported stop commands

2017-02-13 Thread Simon Horman
On Sun, Feb 12, 2017 at 12:12:26PM +0100, Wolfram Sang wrote: > Halting the kernel on an unsupported stop command seems overkill, report > the error and say what we already did (due to autocmd12) instead. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon

Re: [PATCH v3 3/7] media: i2c: max2175: Add MAX2175 support

2017-02-13 Thread Hans Verkuil
Hi Ramesh, A few little nitpicks: On 02/07/2017 04:02 PM, Ramesh Shanmugasundaram wrote: > This patch adds driver support for the MAX2175 chip. This is Maxim > Integrated's RF to Bits tuner front end chip designed for software-defined > radio solutions. This driver exposes the tuner as a

Re: [PATCH 2/4] mmc: host: tmio: fix minor typos in a comment

2017-02-13 Thread Simon Horman
On Sun, Feb 12, 2017 at 12:12:25PM +0100, Wolfram Sang wrote: > Making sure we match the actual register name. > > Signed-off-by: Wolfram Sang > --- > drivers/mmc/host/tmio_mmc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH/RESEND] arm64: defconfig: Enlarge CMA alignment to 2 MiB

2017-02-13 Thread Will Deacon
On Mon, Feb 13, 2017 at 12:04:18PM +0100, Geert Uytterhoeven wrote: > Some IOMMUs (e.g. Renesas IPMMU/VMSA) support only page sizes of 4 KiB, > 2 MiB, and 1 GiB. > > With the default setting of CONFIG_CMA_ALIGNMENT = 8, allocations larger > than 1 MiB are aligned to a 1 MiB boundary only. Hence

Re: [PATCH 1/4] mmc: host: tmio: use defines for CTL_STOP_INTERNAL_ACTION values

2017-02-13 Thread Simon Horman
On Sun, Feb 12, 2017 at 12:12:24PM +0100, Wolfram Sang wrote: > Don't use hardcoded values. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman

Re: [PATCH/RFC v3 net] ravb: unmap descriptors when freeing rings

2017-02-13 Thread Simon Horman
On Fri, Feb 10, 2017 at 02:52:50PM +0100, Geert Uytterhoeven wrote: > On Wed, Jan 25, 2017 at 5:18 PM, Sergei Shtylyov > wrote: > > On 01/24/2017 09:21 PM, Simon Horman wrote: > > > >> From: Kazuya Mizuguchi > >> > >> "swiotlb

Re: [PATCH v2 3/4] arm64: renesas: r8a7796 dtsi: Add all HSCIF nodes

2017-02-13 Thread Sergei Shtylyov
Hello! On 2/13/2017 3:01 PM, Simon Horman wrote: Add the device nodes for all HSCIF serial ports, incl. clocks, and clock domain. Not power domain? Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven ---

Re: [PATCH v2 3/4] arm64: renesas: r8a7796 dtsi: Add all HSCIF nodes

2017-02-13 Thread Simon Horman
On Thu, Dec 08, 2016 at 12:09:02PM +0300, Sergei Shtylyov wrote: > On 12/7/2016 7:44 PM, Ulrich Hecht wrote: > > >Add the device nodes for all HSCIF serial ports, incl. clocks, and > >clock domain. > >Not power domain? > > >Signed-off-by: Ulrich Hecht >

RE: [PATCH] ARM: shmobile: r7s72100: add restart handler

2017-02-13 Thread Chris Brandt
Hi Geert, On Monday, February 13, 2017, Geert Uytterhoeven wrote: > On Fri, Feb 10, 2017 at 8:46 PM, Chris Brandt > wrote: > > On Friday, February 10, 2017, Geert Uytterhoeven wrote: > >> Alternatively, you can write a restart driver (cfr. > >>

[PATCH/RESEND] arm64: defconfig: Enlarge CMA alignment to 2 MiB

2017-02-13 Thread Geert Uytterhoeven
Some IOMMUs (e.g. Renesas IPMMU/VMSA) support only page sizes of 4 KiB, 2 MiB, and 1 GiB. With the default setting of CONFIG_CMA_ALIGNMENT = 8, allocations larger than 1 MiB are aligned to a 1 MiB boundary only. Hence a 2 MiB allocation may not be aligned, leading to a mapping of 512 4 KiB

[PATCH v2] dmaengine: rcar-dmac: Widen DMA mask to 40 bits

2017-02-13 Thread Geert Uytterhoeven
By default, the DMA mask covers only the low 32-bit address space, which causes SWIOTLB on arm64 to fall back to a bounce buffer for DMA transfers involving memory outside the 32-bit address space. The R-Car DMA controller hardware supports a 40-bit address space, hence widen the DMA mask to 40

Re: [PATCH] ARM: shmobile: r7s72100: add restart handler

2017-02-13 Thread Geert Uytterhoeven
Hi Chris, On Fri, Feb 10, 2017 at 8:46 PM, Chris Brandt wrote: > On Friday, February 10, 2017, Geert Uytterhoeven wrote: >> Alternatively, you can write a restart driver (cfr. >> drivers/power/reset/rmobile-reset.c) that binds against a >> "renesas,r7s72100-wdt" device

Re: [PATCH/RFC] arm64: defconfig: Enlarge CMA alignment to 2 MiB

2017-02-13 Thread Geert Uytterhoeven
Hi Robin, On Wed, Feb 1, 2017 at 3:06 PM, Robin Murphy wrote: > On 01/02/17 13:45, Magnus Damm wrote: >> On Sat, Jan 28, 2017 at 1:03 AM, Geert Uytterhoeven >> wrote: >>> Some IOMMUs (e.g. Renesas IPMMU/VMSA) support only page sizes of 4 KiB, >>> 2

Re: [GIT PULL FOR renesas-drivers] R-Car DU fences support

2017-02-13 Thread Laurent Pinchart
Hi Geert, On Monday 13 Feb 2017 11:13:31 Geert Uytterhoeven wrote: > On Mon, Feb 13, 2017 at 11:05 AM, Geert Uytterhoeven wrote: > > On Sun, Feb 12, 2017 at 2:13 PM, Laurent Pinchart wrote: > >> The following changes since commit 5685cab84a6dc376a8d0e4534ae4b973546158b4: > >> Merge

Re: [GIT PULL FOR renesas-drivers] R-Car DU fences support

2017-02-13 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Feb 13, 2017 at 11:05 AM, Geert Uytterhoeven wrote: > On Sun, Feb 12, 2017 at 2:13 PM, Laurent Pinchart > wrote: >> The following changes since commit 5685cab84a6dc376a8d0e4534ae4b973546158b4: >> >> Merge

Re: [GIT PULL FOR renesas-drivers] R-Car DU fences support

2017-02-13 Thread Geert Uytterhoeven
Hi Laurent, On Sun, Feb 12, 2017 at 2:13 PM, Laurent Pinchart wrote: > The following changes since commit 5685cab84a6dc376a8d0e4534ae4b973546158b4: > > Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm/next/base > (2017-02-12 13:18:50 +0200) > >

Re: [PATCH] spi: rspi: fix the bug related to mount/remount jffs2

2017-02-13 Thread Geert Uytterhoeven
On Mon, Feb 6, 2017 at 1:46 PM, Mark Brown wrote: > On Mon, Feb 06, 2017 at 10:02:13AM +0900, DongCV wrote: >> From: Dong >> >> This patch fixes the output warning logs and data loss when >> performing mount/umount then remount the device with jffs2

Re: [PATCH] spi: rspi: fix the bug related to mount/remount jffs2

2017-02-13 Thread Geert Uytterhoeven
Hi Hiep, On Mon, Feb 13, 2017 at 7:50 AM, Hiep Cao Minh wrote: > Sorry to bother you! No, thank you for finally make me see my wrong reasoning! >> qspi_transfer_in() does: >> >> while (n > 0) { >> len = qspi_set_receive_trigger(rspi, n); >>