USB-OTG on RCar Gen2 i.e. renesas_usbhs

2017-02-21 Thread Baumann, Christoph (C.)
Hi all, recently I noticed a strange behaviour of the OTG feature. When connecting an Apple device using CarPlay, which implies OTG resp. Gadget mode, there are IRQ bursts observable. Something around one IRQ per ~10us for 30ms. Especially if the system is already well occupied this causes

Re: [PATCH/RFC 0/6] PSCI: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Rafael J. Wysocki
On Tuesday, February 21, 2017 06:45:13 PM Sudeep Holla wrote: > > On 21/02/17 18:27, Sudeep Holla wrote: > > > > > > On 21/02/17 17:51, Sudeep Holla wrote: > >> > >> > >> On 21/02/17 17:34, Geert Uytterhoeven wrote: > > > > [...] > > > >>> > >>> The SoC can wake-up. It's just not guaranteed

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Joe Perches
On Tue, 2017-02-21 at 11:48 -0800, Matthew Giassa wrote: > * Joe Perches [2017-02-21 10:47:31 -0800]: > > > On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: > > > * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: > > > > > > > The first

Re: [PATCH 1/1] clk: renesas: cpg-mssr: r8a7796: add IMR clocks

2017-02-21 Thread Sergei Shtylyov
On 02/21/2017 10:39 PM, Geert Uytterhoeven wrote: On 02/20/2017 11:38 AM, Geert Uytterhoeven wrote: Add the IMR[0-1] clocks to the R8A7796 CPG/MSSR driver. Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven ---

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Matthew Giassa
* Joe Perches [2017-02-21 10:47:31 -0800]: On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: > The first declaration fit nicely on a single line. > The second one indeed has a few spaces instead

Re: [PATCH 1/1] clk: renesas: cpg-mssr: r8a7796: add IMR clocks

2017-02-21 Thread Geert Uytterhoeven
Hi Sergei, On Tue, Feb 21, 2017 at 7:54 PM, Sergei Shtylyov wrote: > On 02/20/2017 11:38 AM, Geert Uytterhoeven wrote: >>> Add the IMR[0-1] clocks to the R8A7796 CPG/MSSR driver. >>> >>> Signed-off-by: Sergei Shtylyov >> >>

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Geert Uytterhoeven
Hi Mark, On Tue, Feb 21, 2017 at 6:20 PM, Mark Rutland wrote: > On Tue, Feb 21, 2017 at 05:32:50PM +0100, Geert Uytterhoeven wrote: >> On Tue, Feb 21, 2017 at 12:14 PM, Sudeep Holla wrote: >> > On 21/02/17 11:07, Pavel Machek wrote: >> >>> Enable

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Joe Perches
On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: > * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: > > > The first declaration fit nicely on a single line. > > The second one indeed has a few spaces instead of TABs in the > > continuation line. But that can be

Re: [PATCH 1/1] clk: renesas: cpg-mssr: r8a7796: add IMR clocks

2017-02-21 Thread Sergei Shtylyov
On 02/20/2017 11:38 AM, Geert Uytterhoeven wrote: Add the IMR[0-1] clocks to the R8A7796 CPG/MSSR driver. Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven --- linux.orig/drivers/clk/renesas/r8a7796-cpg-mssr.c +++

Re: [PATCH/RFC 0/6] PSCI: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Sudeep Holla
On 21/02/17 18:27, Sudeep Holla wrote: > > > On 21/02/17 17:51, Sudeep Holla wrote: >> >> >> On 21/02/17 17:34, Geert Uytterhoeven wrote: > > [...] > >>> >>> The SoC can wake-up. It's just not guaranteed that it can wake-up using >>> the wakeup-source configured from Linux. Which

Re: [PATCH/RFC 0/6] PSCI: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Sudeep Holla
On 21/02/17 17:51, Sudeep Holla wrote: > > > On 21/02/17 17:34, Geert Uytterhoeven wrote: [...] >> >> The SoC can wake-up. It's just not guaranteed that it can wake-up using >> the wakeup-source configured from Linux. Which wakeup-sources are available >> depends on the actual PSCI

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Geert Uytterhoeven
Hi Mark, On Tue, Feb 21, 2017 at 7:18 PM, Mark Rutland wrote: >> On top of that, the Linux PM subsystem allows to configure wakeup by writing >> "enabled" to a device's "wakeup" file in sysfs. Or you can use ethtool for >> Wake-on-LAN. > > Sure; userspace can always do

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Mark Rutland
Hi, On Tue, Feb 21, 2017 at 07:06:04PM +0100, Geert Uytterhoeven wrote: > On Tue, Feb 21, 2017 at 6:20 PM, Mark Rutland wrote: > > On Tue, Feb 21, 2017 at 05:32:50PM +0100, Geert Uytterhoeven wrote: > >> How can Linux know if using "deep" suspend will allow to wake-up the

Re: [PATCHv2 2/5] scripts: Provide bin2png.sh helper

2017-02-21 Thread Kieran Bingham
Hi Geert, On 20/02/17 20:45, Geert Uytterhoeven wrote: > Hi Kieran, > > On Mon, Feb 20, 2017 at 6:47 PM, Kieran Bingham > wrote: >> This change breaks POSIX SH compliance, as reported by shellcheck: >> >> In scripts/bin2png.sh line 7: >> local

Re: [PATCH/RFC 4/6] drivers: firmware: psci: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Mark Rutland
On Tue, Feb 21, 2017 at 12:07:30PM +0100, Pavel Machek wrote: > On Mon 2017-02-20 21:33:27, Geert Uytterhoeven wrote: > > Nothing in the PSCI specification requires the SoC to remain powered and > > to support wake-up sources when suspended using SYSTEM_SUSPEND. > > If the firmware implements the

Re: [PATCH/RFC 0/6] PSCI: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Sudeep Holla
On 21/02/17 17:34, Geert Uytterhoeven wrote: > Hi Sudeep, > > On Tue, Feb 21, 2017 at 5:45 PM, Sudeep Holla wrote: >> On 21/02/17 16:21, Geert Uytterhoeven wrote: >>> On Tue, Feb 21, 2017 at 11:38 AM, Sudeep Holla wrote: On 20/02/17 20:33,

Re: [PATCH/RFC 4/6] drivers: firmware: psci: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Mark Rutland
Hi, On Mon, Feb 20, 2017 at 09:33:27PM +0100, Geert Uytterhoeven wrote: > + - arm,psci-system-suspend-is-power-down > + Nothing in the PSCI specification requires the SoC to remain > + powered and to support wake-up sources when suspended using > +

Re: [PATCH/RFC 0/6] PSCI: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Geert Uytterhoeven
Hi Sudeep, On Tue, Feb 21, 2017 at 5:45 PM, Sudeep Holla wrote: > On 21/02/17 16:21, Geert Uytterhoeven wrote: >> On Tue, Feb 21, 2017 at 11:38 AM, Sudeep Holla wrote: >>> On 20/02/17 20:33, Geert Uytterhoeven wrote: This patch series adds

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Matthew Giassa
* Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: The first declaration fit nicely on a single line. The second one indeed has a few spaces instead of TABs in the continuation line. But that can be fixed easily, without moving the first parameter to a continuation line.

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Sudeep Holla
On 21/02/17 16:32, Geert Uytterhoeven wrote: > Hi Sudeep, > > On Tue, Feb 21, 2017 at 12:14 PM, Sudeep Holla wrote: >> On 21/02/17 11:07, Pavel Machek wrote: Enable support for "shallow" suspend mode, also known as "Standby" or "Power-On Suspend". As

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Mark Rutland
Hi, On Tue, Feb 21, 2017 at 05:32:50PM +0100, Geert Uytterhoeven wrote: > On Tue, Feb 21, 2017 at 12:14 PM, Sudeep Holla wrote: > > On 21/02/17 11:07, Pavel Machek wrote: > >>> Enable support for "shallow" suspend mode, also known as "Standby" or > >>> "Power-On Suspend". >

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Sudeep Holla
On 21/02/17 16:23, Geert Uytterhoeven wrote: > Hi Sudeep, > > On Tue, Feb 21, 2017 at 11:42 AM, Sudeep Holla wrote: >> On 20/02/17 20:33, Geert Uytterhoeven wrote: >>> Enable support for "shallow" suspend mode, also known as "Standby" or >>> "Power-On Suspend". >>> >>> As

Re: [PATCH/RFC 4/6] drivers: firmware: psci: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Sudeep Holla
Hi Geert, On 21/02/17 16:36, Geert Uytterhoeven wrote: > Hi Sudeep, > > On Tue, Feb 21, 2017 at 11:50 AM, Sudeep Holla wrote: >> On 20/02/17 20:33, Geert Uytterhoeven wrote: >>> Nothing in the PSCI specification requires the SoC to remain powered and >>> to support wake-up

Re: [PATCH/RFC 0/6] PSCI: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Sudeep Holla
Hi Geert, On 21/02/17 16:21, Geert Uytterhoeven wrote: > Hi Sudeep, > > On Tue, Feb 21, 2017 at 11:38 AM, Sudeep Holla wrote: >> On 20/02/17 20:33, Geert Uytterhoeven wrote: >>> This patch series adds support for using non-PMIC wake-up sources on the >>> Renesas R-Car Gen3

Re: [PATCH/RFC 4/6] drivers: firmware: psci: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Geert Uytterhoeven
Hi Pavel, On Tue, Feb 21, 2017 at 12:07 PM, Pavel Machek wrote: > On Mon 2017-02-20 21:33:27, Geert Uytterhoeven wrote: >> Nothing in the PSCI specification requires the SoC to remain powered and >> to support wake-up sources when suspended using SYSTEM_SUSPEND. >> If the firmware

Re: [PATCH/RFC 4/6] drivers: firmware: psci: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Geert Uytterhoeven
Hi Sudeep, On Tue, Feb 21, 2017 at 11:50 AM, Sudeep Holla wrote: > On 20/02/17 20:33, Geert Uytterhoeven wrote: >> Nothing in the PSCI specification requires the SoC to remain powered and >> to support wake-up sources when suspended using SYSTEM_SUSPEND. >> If the firmware

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Geert Uytterhoeven
Hi Sudeep, On Tue, Feb 21, 2017 at 12:14 PM, Sudeep Holla wrote: > On 21/02/17 11:07, Pavel Machek wrote: >>> Enable support for "shallow" suspend mode, also known as "Standby" or >>> "Power-On Suspend". >>> >>> As secondary CPU cores are taken offline, "shallow" suspend

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Geert Uytterhoeven
Hi Sudeep, On Tue, Feb 21, 2017 at 11:42 AM, Sudeep Holla wrote: > On 20/02/17 20:33, Geert Uytterhoeven wrote: >> Enable support for "shallow" suspend mode, also known as "Standby" or >> "Power-On Suspend". >> >> As secondary CPU cores are taken offline, "shallow" suspend

Re: [PATCH/RFC 0/6] PSCI: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Geert Uytterhoeven
Hi Sudeep, On Tue, Feb 21, 2017 at 11:38 AM, Sudeep Holla wrote: > On 20/02/17 20:33, Geert Uytterhoeven wrote: >> This patch series adds support for using non-PMIC wake-up sources on the >> Renesas R-Car Gen3 (H3 or M3-W) Salvator-X development boards. >> >> Nothing in the

renesas-drivers-2017-02-21-v4.10

2017-02-21 Thread Geert Uytterhoeven
I have pushed renesas-drivers-2017-02-21-v4.10 to https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git This tree is meant to ease development of platform support and drivers for Renesas ARM SoCs. It is created by merging (a) the for-next branches of various subsystem trees and

Re: [PATCH v2 3/3] arm64: renesas: r8a7796: Enable SCIF DMA

2017-02-21 Thread Geert Uytterhoeven
Hi Simon, On Wed, Dec 7, 2016 at 5:44 PM, Ulrich Hecht wrote: > Signed-off-by: Ulrich Hecht > --- > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 13 + > 1 file changed, 13 insertions(+) > > diff --git

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Geert Uytterhoeven
Hi Matthew, On Tue, Feb 21, 2017 at 3:12 PM, Matthew Giassa wrote: >>> drivers/staging/ks7010/ks_wlan_ioctl.h | 80 >>> +- >>> 1 file changed, 41 insertions(+), 39 deletions(-) >>> >>> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h >>>

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Matthew Giassa
* Geert Uytterhoeven [2017-02-21 08:59:18 +0100]: Hi Geert, On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa wrote: Please pardon the earlier e-mail which was missing the changelog text. This line should be between the "---" and the diffstat below.

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Sudeep Holla
On 21/02/17 11:07, Pavel Machek wrote: > Hi! > >> Enable support for "shallow" suspend mode, also known as "Standby" or >> "Power-On Suspend". >> >> As secondary CPU cores are taken offline, "shallow" suspend mode saves >> slightly more power than "s2idle", but less than "deep" suspend mode. >>

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Pavel Machek
Hi! > Enable support for "shallow" suspend mode, also known as "Standby" or > "Power-On Suspend". > > As secondary CPU cores are taken offline, "shallow" suspend mode saves > slightly more power than "s2idle", but less than "deep" suspend mode. > However, unlike "deep" suspend mode, "shallow"

Re: [PATCH/RFC 4/6] drivers: firmware: psci: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Pavel Machek
On Mon 2017-02-20 21:33:27, Geert Uytterhoeven wrote: > Nothing in the PSCI specification requires the SoC to remain powered and > to support wake-up sources when suspended using SYSTEM_SUSPEND. > If the firmware implements the PSCI SYSTEM_SUSPEND operation by cutting > power to the SoC, the only

[PATCH v2 0/2] usb: host: ehci-platform: fix usb 1.1 device is not connected in system resume

2017-02-21 Thread Yoshihiro Shimoda
This patch set is based on Greg's usb.git / usb-next branch (the commit id = 0df8a3dbacb585bb9c8b2e55de43c6aac9d86488). This patch set is related to the following email threads: http://marc.info/?t=14865351421=1=2 http://marc.info/?t=14871253435=1=2 Changes from v1 as RFC: - Remove

[PATCH v2 2/2] usb: host: ehci-platform: fix usb 1.1 device is not connected in system resume

2017-02-21 Thread Yoshihiro Shimoda
This patch fixes an issue that a usb 1.1 device is not connected in system resume and then the following message appeared if debug messages are enabled: usb 2-1: Waited 2000ms for CONNECT To resolve this issue, the EHCI controller must be resumed after its companion controllers. So, this

[PATCH v2 1/2] usb: of: add functions to bind a companion controller

2017-02-21 Thread Yoshihiro Shimoda
EHCI controllers will have a companion controller. However, on platform bus, there was difficult to bind them in previous code. So, this patch adds helper functions to bind them using a "companion" property. Signed-off-by: Yoshihiro Shimoda ---

Re: [PATCH/RFC 4/6] drivers: firmware: psci: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Sudeep Holla
On 20/02/17 20:33, Geert Uytterhoeven wrote: > Nothing in the PSCI specification requires the SoC to remain powered and > to support wake-up sources when suspended using SYSTEM_SUSPEND. > If the firmware implements the PSCI SYSTEM_SUSPEND operation by cutting > power to the SoC, the only

Re: [PATCH 1/7] pinctrl: Renesas RZ/A1 pin and gpio controller

2017-02-21 Thread jacopo mondi
Hello, small self-review On 20/02/2017 18:13, Jacopo Mondi wrote: [snip] +/** + * rza1_pinctrl_register() - Enumerate pins, ports, gpiochips and functions and + * register to pinctrl and gpio cores + * + * @rza1_pctl: RZ/A1 pin controller device + */ +static int

Re: [PATCH 4/7] arm: dts: r7s72100: Add pin controller node

2017-02-21 Thread jacopo mondi
Hello, self-review to save you all some time On 20/02/2017 18:13, Jacopo Mondi wrote: Add pin controller node with 12 gpio controller sub-nodes to r7s72100 dtsi. Signed-off-by: Jacopo Mondi --- arch/arm/boot/dts/r7s72100.dtsi | 81

Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

2017-02-21 Thread Sudeep Holla
Hi Geert, On 20/02/17 20:33, Geert Uytterhoeven wrote: > Enable support for "shallow" suspend mode, also known as "Standby" or > "Power-On Suspend". > > As secondary CPU cores are taken offline, "shallow" suspend mode saves > slightly more power than "s2idle", but less than "deep" suspend mode.

Re: [PATCH/RFC 0/6] PSCI: Fix non-PMIC wake-up if SYSTEM_SUSPEND cuts power

2017-02-21 Thread Sudeep Holla
Hi Geert, On 20/02/17 20:33, Geert Uytterhoeven wrote: > Hi all, > > This patch series adds support for using non-PMIC wake-up sources on the > Renesas R-Car Gen3 (H3 or M3-W) Salvator-X development boards. > > Nothing in the PSCI specification requires the SoC to remain powered and > to

RE: [PATCH/RFC 2/2] usb: host: ehci-platform: fix usb 1.1 device is not connected in system resume

2017-02-21 Thread Yoshihiro Shimoda
Hi Peter, > From: Peter Chen > Sent: Tuesday, February 21, 2017 5:51 PM > > On Mon, Feb 20, 2017 at 04:35:11PM +0900, Yoshihiro Shimoda wrote: < snip > > > @@ -297,6 +298,8 @@ static int ehci_platform_probe(struct platform_device > > *dev) > > goto err_power; > > > >

Re: [PATCH/RFC 2/2] usb: host: ehci-platform: fix usb 1.1 device is not connected in system resume

2017-02-21 Thread Peter Chen
On Mon, Feb 20, 2017 at 04:35:11PM +0900, Yoshihiro Shimoda wrote: > This patch fixes an issue that a usb 1.1 device is not connected in > system resume and then the following message appeared if debug messages > are enabled: > usb 2-1: Waited 2000ms for CONNECT > > To resolve this issue,

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Geert Uytterhoeven
Hi Matthew, On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa wrote: > Please pardon the earlier e-mail which was missing the changelog text. This line should be between the "---" and the diffstat below. > Some additional style changes to appease checkpatch. Which additional