Re: [PATCH] drm: remove NULL pointer check for clk_disable_unprepare

2017-05-20 Thread Rob Clark
On Sat, May 20, 2017 at 3:04 PM, Masahiro Yamada wrote: > 2017-05-21 2:58 GMT+09:00 Masahiro Yamada : >> After long term efforts of fixing non-common clock implementations, >> clk_disable() is a no-op for a NULL pointer input, and this

Re: [PATCH 14/16] rcar-vin: make use of video_device_alloc() and video_device_release()

2017-05-20 Thread Laurent Pinchart
Hi Niklas, On Saturday 20 May 2017 20:27:41 Niklas Söderlund wrote: > On 2017-05-10 16:36:03 +0300, Laurent Pinchart wrote: > > On Tuesday 14 Mar 2017 19:59:55 Niklas Söderlund wrote: > >> Make use of the helper functions video_device_alloc() and > >> video_device_release() to control the

Re: [PATCH] drm: remove NULL pointer check for clk_disable_unprepare

2017-05-20 Thread Masahiro Yamada
2017-05-21 2:58 GMT+09:00 Masahiro Yamada : > After long term efforts of fixing non-common clock implementations, > clk_disable() is a no-op for a NULL pointer input, and this is now > tree-wide consistent. > > All clock consumers can safely call

Re: [PATCH 14/16] rcar-vin: make use of video_device_alloc() and video_device_release()

2017-05-20 Thread Niklas Söderlund
Hi Laurent, Thanks for your feedback. On 2017-05-10 16:36:03 +0300, Laurent Pinchart wrote: > Hi Niklas, > > On Tuesday 14 Mar 2017 19:59:55 Niklas Söderlund wrote: > > Make use of the helper functions video_device_alloc() and > > video_device_release() to control the lifetime of the struct > >

[PATCH] drm: remove NULL pointer check for clk_disable_unprepare

2017-05-20 Thread Masahiro Yamada
After long term efforts of fixing non-common clock implementations, clk_disable() is a no-op for a NULL pointer input, and this is now tree-wide consistent. All clock consumers can safely call clk_disable(_unprepare) without NULL pointer check. Signed-off-by: Masahiro Yamada

Re: [PATCH 02/16] rcar-vin: use rvin_reset_format() in S_DV_TIMINGS

2017-05-20 Thread Niklas Söderlund
Hi Laurent, Thanks for your feedback. On 2017-05-10 16:22:16 +0300, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Tuesday 14 Mar 2017 19:59:43 Niklas Söderlund wrote: > > Use rvin_reset_format() in rvin_s_dv_timings() instead of just resetting > > a few fields. This

Re: [RFC v4 1/8] include: media: Move and update CEU driver interface

2017-05-20 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Friday 19 May 2017 18:02:53 Jacopo Mondi wrote: > Update Renesas CEU driver interface to use driver interface I'm not sure this matches the content of the patch. > SQUASH ? :-) > Signed-off-by: Jacopo Mondi > --- >