>> The script “checkpatch.pl” pointed information out like the following.
>>
>> Comparison to NULL could be written !…
>>
>> Thus fix the affected source code places.
>>
>
> This one is fine
This kind of feedback is nice.
> except for the commit message.
Would you like to support Unicode chara
> But anyways I guess other people sometimes disagree with me.
Am I one of them? ;-)
> Unwinding is for when you allocate five things in a row.
This is a general issue.
I find that it is also needed in this function as usual.
> You have to undo four if the last allocation fails.
Concrete
Hi Geert,
today, I want to learn some history ;)
On 12.11.2015 16:54, Geert Uytterhoeven wrote:
Add a new R-Car H3 Clock Pulse Generator / Module Standby and Software
Reset driver, using the new CPG/MSSR driver core.
Signed-off-by: Geert Uytterhoeven
---
...
diff --git a/drivers/clk/shmobil
On Tue, Oct 24, 2017 at 06:02:30PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 24 Oct 2017 17:47:37 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The script “checkpatch.pl” pointed information out like the followi
This is a subtle thing but my preference on this type of thing is the
way the original code is written. I'm still slightly annoyed that
someone once made me rewrite a patch using the new style... But anyways
I guess other people sometimes disagree with me.
Unwinding is for when you allocate five
From: Markus Elfring
Date: Tue, 24 Oct 2017 17:47:37 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code pl
From: Markus Elfring
Date: Tue, 24 Oct 2017 17:16:09 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c
From: Markus Elfring
Date: Tue, 24 Oct 2017 17:55:43 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use common error handling code in rcar_du_encoders_init()
Adjust 14 checks for null pointers
drivers/gpu/drm/rcar-du/rcar_du_crtc.
On Wed, Oct 18, 2017 at 01:28:30PM +0200, Geert Uytterhoeven wrote:
> On Wed, Oct 18, 2017 at 1:24 PM, Mark Brown wrote:
> >> Hence you cannot enable wakeup mode while suspending, as the proper
> >> system suspend/resume procedure is:
> >> 1. Enable backup mode in the PMIC,
> >> 2. Switch ACC
