Re: [PATCH v2] PCI: rcar: Use common error handling code in rcar_pcie_enable_msi()

On Thu, Nov 2, 2017 at 2:00 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 2 Nov 2017 13:35:17 +0100 > > * Adjust a jump target so that a specific error message is stored only once > at the end of this function

Re: [PATCH] ARM: dts: koelsch: Move cec_clock to root node

Hi Simon, Thank you for the patch. On Thursday, 2 November 2017 11:18:05 EET Simon Horman wrote: > cec-clock is a fixed clock generator that is not controlled by i2c5 and > thus should not be a child of the i2c5 bus node. Rather, it should be > a child of the root node of the DT. > > Fixes:

Re: [PATCH v2 5/5] [RFC] PM / Domains: Remove gpd_dev_ops.active_wakeup() callback

Geert Uytterhoeven writes: > There are no more users left of the gpd_dev_ops.active_wakeup() > callback. All have been converted to GENPD_FLAG_ACTIVE_WAKEUP. > Hence remove the callback. > > Signed-off-by: Geert Uytterhoeven > --- > This must

Re: [PATCH v2 1/5] PM / Domains: Allow genpd users to specify default active wakeup behavior

Geert Uytterhoeven writes: > It is quite common for PM Domains to require slave devices to be kept > active during system suspend if they are to be used as wakeup sources. > To enable this, currently each PM Domain or driver has to provide its > own

Applied "spi: sh-msiof: Fix DMA transfer size check" to the spi tree

The patch spi: sh-msiof: Fix DMA transfer size check has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to

[PATCH v2] PCI: rcar: Use common error handling code in rcar_pcie_enable_msi()

From: Markus Elfring Date: Thu, 2 Nov 2017 13:35:17 +0100 * Adjust a jump target so that a specific error message is stored only once at the end of this function implementation. * Replace two calls of the function "dev_err" by goto statements. This issue was

[PATCH RFT 3/5] i2c: sh_mobile: manually "inline" two short functions

Those two functions are very short and only called once. The code becomes easier to understand if the code is directly put into the main xfer function. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-sh_mobile.c | 28 +--- 1 file

[PATCH RFT 0/5] i2c: sh_mobile: refactor HW init/deinit

When clearing the ICE bit, all registers fall back to their defaut value. That allows for some simplifications in the code. Tested on a Renesas Lager board (R-Car H2) doing a bunch of consecutive commands. No spurious interrupts have been observed and the signals look exactly the same when

[PATCH RFT 5/5] i2c: sh_mobile: shorten exit of xfer routine

We can use the ternary operator for easier reading. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-sh_mobile.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-sh_mobile.c

[PATCH RFT 1/5] i2c: sh_mobile: remove redundant initialization

Following the documentation, we initialize the HW before each START in start_ch(). No need to do the same in activate_ch(). Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-sh_mobile.c | 10 -- 1 file changed, 10 deletions(-) diff --git

[PATCH RFT 4/5] i2c: sh_mobile: use direct writes when accessing ICE bit

ICE bit is for resetting the module. Other bits don't matter then, so we don't need to use the iic_set_clr() function but can use iic_wr(). Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-sh_mobile.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH RFT 2/5] i2c: sh_mobile: remove redundant deinitialization

No need to clear the interrupt registers because right after that we disable the IP core which will reload registers with their initial values anyhow. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-sh_mobile.c | 4 1 file changed, 4 deletions(-)

Re: [PATCH v2 3/5] [RFC] soc: mediatek: Use GENPD_FLAG_ACTIVE_WAKEUP

On 10/31/2017 07:11 PM, Geert Uytterhoeven wrote: > Set the newly introduced GENPD_FLAG_ACTIVE_WAKEUP, which allows to > remove the driver's own flag-based callback. > > Signed-off-by: Geert Uytterhoeven > --- > This must not be applied before "PM / Domain: Enable

[PATCH] serial: sh-sci: Fix unlocked access to SCSCR register

From: Takatoshi Akiyama The SCSCR register access in sci_break_ctl() is not locked. sci_start_tx() and sci_set_termios() changes the SCSCR register, but does not lock sci_port. Therefore, this patch adds lock during register access. Also, remove

Re: [PATCH/RFC] serial: sh-sci: Fix unlocked access to SCSCR register

On Mon, Nov 07, 2016 at 04:52:09PM +0100, Wolfram Sang wrote: > On Mon, Nov 07, 2016 at 04:42:53PM +0100, Simon Horman wrote: > > From: Takatoshi Akiyama > > > > The SCSCR register access in sci_break_ctl() is not locked. > > > > sci_start_tx() and

Re: [PATCH v2 4/5] [RFC] soc: rockchip: power-domain: Use GENPD_FLAG_ACTIVE_WAKEUP

Am Dienstag, 31. Oktober 2017, 19:11:33 CET schrieb Geert Uytterhoeven: > Set the newly introduced GENPD_FLAG_ACTIVE_WAKEUP, which allows to > remove the driver's own flag-based callback. > > Signed-off-by: Geert Uytterhoeven looks ok, so Acked-by: Heiko Stuebner

Re: [PATCH] spi: sh-msiof: Fix DMA transfer size check

On 02.11.2017 10:32, Simon Horman wrote: From: Hiromitsu Yamasaki DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Fixes: b0d0ce8b6b91 ("spi: sh-msiof: Add DMA support") Signed-off-by: Hiromitsu Yamasaki

[PATCH] spi: sh-msiof: Fix DMA transfer size check

From: Hiromitsu Yamasaki DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Fixes: b0d0ce8b6b91 ("spi: sh-msiof: Add DMA support") Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Simon Horman

RE: [PATCH] ARM: dts: iwg20d-q7: Add support for ttySC3

> Subject: Re: [PATCH] ARM: dts: iwg20d-q7: Add support for ttySC3 > > On Mon, Oct 09, 2017 at 01:45:07PM +, Fabrizio Castro wrote: > > Hello Geert, > > > > thank you for your feedback! > > > > > > > > Hi Fabrizio, Chris, > > > > > > On Mon, Oct 9, 2017 at 11:06 AM, Fabrizio Castro > > >

[PATCH] ARM: dts: koelsch: Move cec_clock to root node

cec-clock is a fixed clock generator that is not controlled by i2c5 and thus should not be a child of the i2c5 bus node. Rather, it should be a child of the root node of the DT. Fixes: 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI transmitter") Reported-by: Laurent Pinchart

Re: [PATCH v2 0/5] PM / Domains: Remove gpd_dev_ops.active_wakeup() callback

Hi Ulf, On Wed, Nov 1, 2017 at 11:10 AM, Ulf Hansson wrote: > On 31 October 2017 at 19:11, Geert Uytterhoeven > wrote: >> It is quite common for PM Domains to require slave devices to be kept >> active during system suspend if they are to be

Re: [PATCH v2 2/5] [RFC] ARM: shmobile: pm-rmobile: Use GENPD_FLAG_ACTIVE_WAKEUP

On Tue, Oct 31, 2017 at 07:11:31PM +0100, Geert Uytterhoeven wrote: > Set the newly introduced GENPD_FLAG_ACTIVE_WAKEUP, which allows to > remove the driver's own "always true" callback. > > Signed-off-by: Geert Uytterhoeven > --- > This must not be applied before "PM /

Re: [PATCH v2 13/26] media: rcar: fix a debug printk

Hi Mauro, Thanks for your patch. On 2017-11-01 17:05:50 -0400, Mauro Carvalho Chehab wrote: > Two orthogonal changesets caused a breakage at a printk > inside rcar. Changeset 859969b38e2e > ("[media] v4l: Switch from V4L2 OF not V4L2 fwnode API") > made davinci to use struct fwnode_handle

Re: PCI: rcar: Use common error handling code in rcar_pcie_enable_msi()

On Wed, Nov 01, 2017 at 09:57:00AM +0100, SF Markus Elfring wrote: > > This is fine by me > > Thanks for another bit of change acceptance. > > > > except that the change in the name of the goto label seems spurious. > > I am curious if the popularity of a jump label like “err” will decrease >

Re: [PATCH] ARM: dts: iwg20d-q7: Add support for ttySC3

On Mon, Oct 09, 2017 at 01:45:07PM +, Fabrizio Castro wrote: > Hello Geert, > > thank you for your feedback! > > > > > Hi Fabrizio, Chris, > > > > On Mon, Oct 9, 2017 at 11:06 AM, Fabrizio Castro > > wrote: > > > Signed-off-by: Fabrizio Castro

Re: [PATCH 1/3] ARM: shmobile: Document Renesas M3-W-based Salvator-XS board DT bindings

On Wed, Nov 01, 2017 at 04:49:04PM -0500, Rob Herring wrote: > On Mon, Oct 30, 2017 at 06:29:57PM +0100, Geert Uytterhoeven wrote: > > The Renesas Salvator-XS (Salvator-X 2nd version) development board can > > be equipped with either an R-Car H3 ES2.0 or M3-W ES1.x SiP, which are > >