Re: [PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check

2018-01-03 Thread Dirk Behme
On 03.01.2018 18:25, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Sep 7, 2017 at 11:12 AM, Geert Uytterhoeven wrote: On Thu, Sep 7, 2017 at 11:05 AM, Dirk Behme wrote: On 07.09.2017 10:59, Geert Uytterhoeven wrote: On Thu, Sep 7, 2017 at 10:42 AM, Dirk Behme wrote: On 07.09.2017 10:39, Geer

Re: Applied "spi: sh-msiof: Fix timeout failures for TX-only DMA transfers" to the spi tree

2018-01-03 Thread Dirk Behme
On 03.01.2018 18:44, Mark Brown wrote: The patch spi: sh-msiof: Fix timeout failures for TX-only DMA transfers has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git Would it make sense to forward this to -stable, too? Best regards Dir

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Fabio, On Wed, Jan 03, 2018 at 04:14:35PM -0200, Fabio Estevam wrote: > On Wed, Jan 3, 2018 at 3:37 PM, jacopo mondi wrote: > > >> Initially the rest GPIO was doing: > >> > >> - gpio_set_value(GPIO_PTT3, 0); > >> - mdelay(10); > >> - gpio_set_value(GPIO_PTT3, 1); > >> -

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread Fabio Estevam
On Wed, Jan 3, 2018 at 3:37 PM, jacopo mondi wrote: >> Initially the rest GPIO was doing: >> >> - gpio_set_value(GPIO_PTT3, 0); >> - mdelay(10); >> - gpio_set_value(GPIO_PTT3, 1); >> - mdelay(10); /* wait to let chip come out of reset */ > > And that's what my driver code

Applied "spi: sh-msiof: Fix timeout failures for TX-only DMA transfers" to the spi tree

2018-01-03 Thread Mark Brown
The patch spi: sh-msiof: Fix timeout failures for TX-only DMA transfers has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Fabio, On Wed, Jan 03, 2018 at 03:27:53PM -0200, Fabio Estevam wrote: > Hi Jacopo, > > On Wed, Jan 3, 2018 at 3:13 PM, jacopo mondi wrote: > > > That would be true if I would have declared the GPIO to be ACTIVE_LOW. > > See patch [5/9] in this series and search for "rstb". The GPIO (which > >

Re: [PATCH v3 0/3] arm64: dts: r8a779[56]: Add OPPs table for cpu devices

2018-01-03 Thread Niklas Söderlund
Hi Simon, Thanks for your work. I tested these patches together with the dependencies of the topic/rcar-gen3-cpufreq-v4 branch, feel free to add to all patches in this series. Tested-by: Niklas Söderlund On 2018-01-03 13:41:02 +0100, Simon Horman wrote: > These are dependencies for supportin

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread Fabio Estevam
Hi Jacopo, On Wed, Jan 3, 2018 at 3:13 PM, jacopo mondi wrote: > That would be true if I would have declared the GPIO to be ACTIVE_LOW. > See patch [5/9] in this series and search for "rstb". The GPIO (which > is shared between two devices) is said to be active high... Just looked at your patch

Re: [PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check

2018-01-03 Thread Geert Uytterhoeven
Hi Dirk, On Thu, Sep 7, 2017 at 11:12 AM, Geert Uytterhoeven wrote: > On Thu, Sep 7, 2017 at 11:05 AM, Dirk Behme wrote: >> On 07.09.2017 10:59, Geert Uytterhoeven wrote: >>> On Thu, Sep 7, 2017 at 10:42 AM, Dirk Behme >>> wrote: On 07.09.2017 10:39, Geert Uytterhoeven wrote: > On Thu,

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Fabio, On Wed, Jan 03, 2018 at 02:41:20PM -0200, Fabio Estevam wrote: > Hi Jacopo, > > On Thu, Dec 28, 2017 at 12:01 PM, Jacopo Mondi > wrote: > > > + if (priv->rstb_gpio) { > > + gpiod_set_value(priv->rstb_gpio, 0); > > + usleep_range(500, 1000); > > +

[PATCH] spi: sh-msiof: Fix timeout failures for TX-only DMA transfers

2018-01-03 Thread Geert Uytterhoeven
When using RX (with or without TX), the DMA interrupt triggers completion when the RX FIFO has been emptied, i.e. after the full transfer has finished. However, when using TX without RX, the DMA interrupt triggers completion as soon as the DMA engine has filled the TX FIFO, i.e. before the full tr

[PATCH] sh_eth: fix TSU resource handling

2018-01-03 Thread Sergei Shtylyov
When switching the driver to the managed device API, I managed to break the case of a dual Ether devices sharing a single TSU: the 2nd Ether port wouldn't probe. Iwamatsu-san has tried to fix this but his patch was buggy and he then dropped the ball... The solution is to limit calling devm_re

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread Fabio Estevam
Hi Jacopo, On Thu, Dec 28, 2017 at 12:01 PM, Jacopo Mondi wrote: > + if (priv->rstb_gpio) { > + gpiod_set_value(priv->rstb_gpio, 0); > + usleep_range(500, 1000); > + gpiod_set_value(priv->rstb_gpio, 1); > + usleep_range(500, 1000); T

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 05:50:38PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:21 EET Jacopo Mondi wrote: > > - priv->clk = v4l2_clk_get(&client->dev, "mclk"); > > - if (IS_ERR(priv->clk)) > > + priv->clk = clk_

Re: [PATCH v2 7/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Laurent, On Wed, Jan 03, 2018 at 05:49:55PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > > > > DT based platforms won't have any info->xlkc_rate, so they should be > > fine. I wonder how could I set rate in board code, as I'm just > > registering an alias for the clock there... > > Exactly a

Re: [PATCH v2 7/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-03 Thread Laurent Pinchart
Hi Jacopo, On Wednesday, 3 January 2018 17:44:58 EET jacopo mondi wrote: > On Tue, Jan 02, 2018 at 05:44:03PM +0200, Laurent Pinchart wrote: > > On Thursday, 28 December 2017 16:01:19 EET Jacopo Mondi wrote: > >> Remove soc_camera framework dependencies from ov772x sensor driver. > >> - Handle clo

Re: [PATCH v2 7/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 05:44:03PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:19 EET Jacopo Mondi wrote: > > Remove soc_camera framework dependencies from ov772x sensor driver. > > - Handle clock and gpios > > - Regi

Re: [PATCH 0/2] Kill redundant checks in the Renesas Ethernet drivers

2018-01-03 Thread Sergei Shtylyov
Hello! On 01/03/2018 06:21 PM, David Miller wrote: From: Sergei Shtylyov Date: Sun, 31 Dec 2017 21:41:34 +0300 Here's a set of 2 patches against DaveM's 'net-next.git' repo removing redundant checks in the driver probe() methods. Series applied with the "disassembly" typo fixed. Thank

Re: [PATCH 0/2] Kill redundant checks in the Renesas Ethernet drivers

2018-01-03 Thread David Miller
From: Sergei Shtylyov Date: Sun, 31 Dec 2017 21:41:34 +0300 > Here's a set of 2 patches against DaveM's 'net-next.git' repo removing > redundant checks in the driver probe() methods. Series applied with the "disassembly" typo fixed.

RE: iwg20d display driver

2018-01-03 Thread Chris Paterson
Hello Laurent, > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: 03 January 2018 13:34 > > Hi Chris, > > On Wednesday, 3 January 2018 12:09:48 EET Chris Paterson wrote: > > Hello Laurent, > > > > Happy new year! > > Onnellista uutta vuotta to you too :) > > > We are l

Re: [PATCH v3 3/3] arm64: dts: renesas: r8a7796: Add OPPs table for cpu devices

2018-01-03 Thread Geert Uytterhoeven
On Wed, Jan 3, 2018 at 1:41 PM, Simon Horman wrote: > From: Dien Pham > > Define OOP tables for all CPUs. > This allows CPUFreq to function. > > Based in part on work by Hien Dang. > > Signed-off-by: Dien Pham > Signed-off-by: Takeshi Kihara > Signed-off-by: Simon Horman Looks good and matche

Re: [PATCH v3 2/3] arm64: dts: renesas: r8a7795: Add OPPs table for cpu devices

2018-01-03 Thread Geert Uytterhoeven
On Wed, Jan 3, 2018 at 1:41 PM, Simon Horman wrote: > From: Dien Pham > > Define OOP tables for all CPUs. > This allows CPUFreq to function. > > Based in part on work by Hien Dang. > > Signed-off-by: Dien Pham > Signed-off-by: Takeshi Kihara > Signed-off-by: Simon Horman Looks good and matche

Re: [PATCH v3 1/3] arm64: dts: renesas: r8a7795: move scif node into alphabetical order

2018-01-03 Thread Geert Uytterhoeven
On Wed, Jan 3, 2018 at 1:41 PM, Simon Horman wrote: > Move scif node so that sub-nodes of the root node are in > alphabetical order. > > Signed-off-by: Simon Horman Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux

Re: iwg20d display driver

2018-01-03 Thread Laurent Pinchart
Hi Chris, On Wednesday, 3 January 2018 12:09:48 EET Chris Paterson wrote: > Hello Laurent, > > Happy new year! Onnellista uutta vuotta to you too :) > We are looking at upstreaming support for the display provided in the iwg20d > development kit [1]. The setup is slightly unusual in the sense t

Re: [PATCH v4 2/6] clk: renesas: rcar-gen3: Add Z2 clock divider support

2018-01-03 Thread Geert Uytterhoeven
Hi Simon, On Wed, Jan 3, 2018 at 1:18 PM, Simon Horman wrote: > From: Takeshi Kihara > > This patch adds Z2 clock divider support for R-Car Gen3 SoC. > > Signed-off-by: Takeshi Kihara > Signed-off-by: Simon Horman > --- > v4 [Simon Horman] > * Rebase > * Use __ffs as FIELD_{GET,PREP} don't not

[PATCH v3 2/3] arm64: dts: renesas: r8a7795: Add OPPs table for cpu devices

2018-01-03 Thread Simon Horman
From: Dien Pham Define OOP tables for all CPUs. This allows CPUFreq to function. Based in part on work by Hien Dang. Signed-off-by: Dien Pham Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman --- v3 [Simon Horman] - Preserve alphabetical order of sub-nodes of root node - Do not provi

[PATCH v3 3/3] arm64: dts: renesas: r8a7796: Add OPPs table for cpu devices

2018-01-03 Thread Simon Horman
From: Dien Pham Define OOP tables for all CPUs. This allows CPUFreq to function. Based in part on work by Hien Dang. Signed-off-by: Dien Pham Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman --- v3 [Simon Horman] * Do not give nodes a unit name, they have no base address * Preserve

[PATCH v3 1/3] arm64: dts: renesas: r8a7795: move scif node into alphabetical order

2018-01-03 Thread Simon Horman
Move scif node so that sub-nodes of the root node are in alphabetical order. Signed-off-by: Simon Horman --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts

[PATCH v3 0/3] arm64: dts: r8a779[56]: Add OPPs table for cpu devices

2018-01-03 Thread Simon Horman
These are dependencies for supporting CPUFreq. The remainder of that work is being posted separately and can be found at: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/rcar-gen3-cpufreq-v4 Patch 1: Cleanup of DTS, only related as its an apply-time conflict Patches 2 &

[PATCH v4 5/6] clk: renesas: r8a7796: Add Z clock

2018-01-03 Thread Simon Horman
From: Takeshi Kihara This patch adds Z clock for R8A7796 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman Reviewed-by: Geert Uytterhoeven --- drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/dri

[PATCH v4 2/6] clk: renesas: rcar-gen3: Add Z2 clock divider support

2018-01-03 Thread Simon Horman
From: Takeshi Kihara This patch adds Z2 clock divider support for R-Car Gen3 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman --- v4 [Simon Horman] * Rebase * Use __ffs as FIELD_{GET,PREP} don't not work with non-constant masks * Use correct mask in cpg_z_clk_recalc_rate() v3 [S

[PATCH v4 6/6] clk: renesas: r8a7796: Add Z2 clock

2018-01-03 Thread Simon Horman
From: Takeshi Kihara This patch adds Z2 clock for R8A7796 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman Reviewed-by: Geert Uytterhoeven --- drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/dr

[PATCH v4 0/6] clk: renesas: r8a779[56]: Add Z and Z2 clock support

2018-01-03 Thread Simon Horman
Hi, this patch-set adds Z and Z2 clock support. These are dependencies for supporting CPUFreq. The remainder of that work is being posted separately and can be found at: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/rcar-gen3-cpufreq-v4 Based on v4.15-rc1 Changes si

[PATCH v4 1/6] clk: renesas: rcar-gen3: Add Z clock divider support

2018-01-03 Thread Simon Horman
From: Takeshi Kihara This patch adds Z clock divider support for R-Car Gen3 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman --- v4 [Simon Horman] * Rebase * Divide parent clock by 2 to give correct rate (again) * Take care not to overflow multiplication on 32 but platforms v3

[PATCH v4 4/6] clk: renesas: r8a7795: Add Z2 clock

2018-01-03 Thread Simon Horman
From: Takeshi Kihara This patch adds Z2 clock for r8a7795 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman Reviewed-by: Geert Uytterhoeven --- drivers/clk/renesas/r8a7795-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/dr

[PATCH v4 3/6] clk: renesas: r8a7795: Add Z clock

2018-01-03 Thread Simon Horman
From: Takeshi Kihara This patch adds Z clock for R8A7795 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman Reviewed-by: Geert Uytterhoeven --- drivers/clk/renesas/r8a7795-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/dri

Re: [PATCH v2 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-03 Thread Laurent Pinchart
Hi Jacopo, On Wednesday, 3 January 2018 10:49:52 EET jacopo mondi wrote: > On Tue, Jan 02, 2018 at 01:45:30PM +0200, Laurent Pinchart wrote: > > On Thursday, 28 December 2017 16:01:13 EET Jacopo Mondi wrote: > >> Add bindings documentation for Renesas Capture Engine Unit (CEU). > >> > >> Signed-o

Re: [PATCH v2 3/9] v4l: platform: Add Renesas CEU driver

2018-01-03 Thread Laurent Pinchart
Hi Jacopo, On Wednesday, 3 January 2018 12:47:48 EET jacopo mondi wrote: > On Tue, Jan 02, 2018 at 03:46:27PM +0200, Laurent Pinchart wrote: > >> +/* > >> + * ceu_device - CEU device instance > >> + */ > >> +struct ceu_device { > >> + struct device *dev; > >> + struct video_device

Re: [PATCH v3] arm64: dts: renesas: salvator-common: add GPIO extender

2018-01-03 Thread Wolfram Sang
On Wed, Jan 03, 2018 at 12:16:11PM +0100, Wolfram Sang wrote: > > > > + pca9654: gpio@20 { > > > + compatible = "onnn,pca9654"; > > > + reg = <0x20>; > > > + gpio-controller; > > > + #gpio-cells = <2>; > > > > interrupts? > > > > You

Re: [PATCH v3] arm64: dts: renesas: salvator-common: add GPIO extender

2018-01-03 Thread Wolfram Sang
> > + pca9654: gpio@20 { > > + compatible = "onnn,pca9654"; > > + reg = <0x20>; > > + gpio-controller; > > + #gpio-cells = <2>; > > interrupts? > > You can test them using CP16/17 and gpio-keys. Too low priority. We can add it when n

Re: [PATCH v2 3/9] v4l: platform: Add Renesas CEU driver

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 03:46:27PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > > +/* > > + * ceu_device - CEU device instance > > + */ > > +struct ceu_device { > > + struct device *dev; > > + struct video_device vdev; > > + struct v4

Re: [PATCH v3] arm64: dts: renesas: salvator-common: add GPIO extender

2018-01-03 Thread Geert Uytterhoeven
Hi Wolfram, On Fri, Dec 22, 2017 at 9:11 PM, Wolfram Sang wrote: > We need to configure its GPIOs later. > > Signed-off-by: Wolfram Sang > --- > > Changes since V2: > * added two more required properties (Thanks Geert!) > > And no dependency anymore (my statement for V2 was wrong). > > arch/arm

Re: [PATCH] gpio: pca953x: add required properties to example in bindings

2018-01-03 Thread Geert Uytterhoeven
Hi Wolfram, On Fri, Dec 22, 2017 at 9:09 PM, Wolfram Sang wrote: > The binding documentation was missing two required properties in the > example. Fix it and add them also to the list of required properties. > > Signed-off-by: Wolfram Sang > --- > Documentation/devicetree/bindings/gpio/gpio-pca

Re: [PATCH v2 1/2] arm64: dts: renesas: salvator-x: Remove renesas,no-ether-link property

2018-01-03 Thread Simon Horman
On Tue, Jan 02, 2018 at 10:38:24AM +0100, Simon Horman wrote: > Hi Vladimir, > > Happy New Year! > > On Fri, Dec 22, 2017 at 12:22:09PM +0200, Vladimir Zapolskiy wrote: > > Hi Simon, > > > > On 12/22/2017 10:40 AM, Simon Horman wrote: > > > On Fri, Dec 22, 2017 at 09:32:03AM +0100, Simon Horman

Re: [1/2] arm64: dts: r8a7795: add thermal cooling management

2018-01-03 Thread Geert Uytterhoeven
Hi Simon, On Wed, Jan 3, 2018 at 11:14 AM, Simon Horman wrote: > On Wed, Jan 03, 2018 at 01:03:52AM +0100, Niklas Söderlund wrote: >> On 2018-01-02 10:19:44 +0100, Simon Horman wrote: >> > On Mon, Jan 01, 2018 at 10:13:35AM -0800, Eduardo Valentin wrote: >> > > On Wed, Sep 13, 2017 at 12:59:08PM

Re: [PATCH] soc: renesas: rcar-sysc: Mark rcar_sysc_matches[] __initconst

2018-01-03 Thread Simon Horman
On Tue, Jan 02, 2018 at 03:50:19PM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Dec 20, 2017 at 9:25 AM, Simon Horman wrote: > > On Tue, Dec 19, 2017 at 04:54:44PM +0100, Geert Uytterhoeven wrote: ... > Thank you. > Please note this is a patch intended for your soc-for-v4.16 branch

Re: [PATCH v2] arm64: dts: renesas: salvator-common: add GPIO extender

2018-01-03 Thread Simon Horman
On Tue, Jan 02, 2018 at 11:45:00AM +0100, Wolfram Sang wrote: > > > > Well, it was not in renesas-drivers/sh-pfc-for-v4.16 which I used as a > > > base for the SATA work which again is based on v4.15-rc1. But nice that > > > it is upstream already, thanks for the heads up. > > > > My tree is also

Re: [1/2] arm64: dts: r8a7795: add thermal cooling management

2018-01-03 Thread Simon Horman
On Wed, Jan 03, 2018 at 01:03:52AM +0100, Niklas Söderlund wrote: > Hi Simon, > > On 2018-01-02 10:19:44 +0100, Simon Horman wrote: > > On Mon, Jan 01, 2018 at 10:13:35AM -0800, Eduardo Valentin wrote: > > > On Wed, Sep 13, 2017 at 12:59:08PM +0200, Niklas Söderlund wrote: > > > > Add nodes and pr

Re: [PATCH v3 01/34] clk_ops: change round_rate() to return unsigned long

2018-01-03 Thread Mauro Carvalho Chehab
Em Mon, 1 Jan 2018 19:42:40 + Bryan O'Donoghue escreveu: > Right now it is not possible to return a value larger than LONG_MAX on 32 > bit systems. You can pass a rate of ULONG_MAX but can't return anything > past LONG_MAX due to the fact both the rounded_rate and negative error > codes are

Re: [PATCH v2 2/9] include: media: Add Renesas CEU driver interface

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 01:50:07PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:14 EET Jacopo Mondi wrote: > > Add renesas-ceu header file. > > > > Do not remove the existing sh_mobile_ceu.h one as long as the original

Re: [PATCH v2 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 01:45:30PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:13 EET Jacopo Mondi wrote: > > Add bindings documentation for Renesas Capture Engine Unit (CEU). > > > > Signed-off-by: Jacopo Mondi > >