Re: [PATCH v2] v4l: doc: Clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Hans Verkuil
On 01/08/2018 06:55 PM, Kieran Bingham wrote: > The v4l2_mbus_fmt width and height corresponds directly with the > v4l2_pix_format definitions, yet the differences in documentation make > it ambiguous what to do in the event of field heights. > > Clarify this using the same text as is provided for

Re: [PATCH v2] media: i2c: adv748x: fix HDMI field heights

2018-01-08 Thread Hans Verkuil
On 01/08/2018 07:14 PM, Kieran Bingham wrote: > The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field > types. The correct specification for the height on the mbus is the > image height, in this instance, the field height. > > The AFE component already correctly adjusts the height

Re: [PATCH v2] v4l: doc: Clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Niklas Söderlund
Hi Kieran, Thanks for your patch. On 2018-01-08 17:55:24 +, Kieran Bingham wrote: > The v4l2_mbus_fmt width and height corresponds directly with the > v4l2_pix_format definitions, yet the differences in documentation make > it ambiguous what to do in the event of field heights. > > Clarify t

Re: [PATCH v2] v4l: doc: Clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Sakari Ailus
Hi Kieran, Thanks for the update. On Mon, Jan 08, 2018 at 05:55:24PM +, Kieran Bingham wrote: > The v4l2_mbus_fmt width and height corresponds directly with the > v4l2_pix_format definitions, yet the differences in documentation make > it ambiguous what to do in the event of field heights. >

Re: [PATCH] sh_eth: fix TXALCR1 offsets

2018-01-08 Thread David Miller
From: Sergei Shtylyov Date: Sun, 07 Jan 2018 00:26:47 +0300 > The TXALCR1 offsets are incorrect in the register offset tables, most > probably due to copy&paste error. Luckily, the driver never uses this > register. :-) > > Fixes: 4a55530f38e4 ("net: sh_eth: modify the definitions of register"

Re: [PATCH] sh_eth: remove sh_eth_plat_data::edmac_endian

2018-01-08 Thread David Miller
From: Sergei Shtylyov Date: Fri, 05 Jan 2018 00:26:46 +0300 > Since the commit 888cc8c20cf ("sh_eth: remove EDMAC_BIG_ENDIAN") (geez, > I didn't realize that was 2 years ago!) the initializers in the SuperH > platform code for the 'sh_eth_plat_data::edmac_endian' stopped to matter, > so we can re

[PATCH v2] media: i2c: adv748x: fix HDMI field heights

2018-01-08 Thread Kieran Bingham
The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field types. The correct specification for the height on the mbus is the image height, in this instance, the field height. The AFE component already correctly adjusts the height on the mbus, but the HDMI component got left behind. A

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Kieran Bingham
Hi Hans, Niklas, Sakari, Thank you for the very prompt reviews! I fired the patch - disappeared to teach code club, and came back to the answers :-D - very streamlined! On 08/01/18 15:48, Hans Verkuil wrote: > On 01/08/2018 04:32 PM, Niklas Söderlund wrote: >> Hi, >> >> Thanks for your patch. >>

Re: [PATCH] media: i2c: adv748x: fix HDMI field heights

2018-01-08 Thread Kieran Bingham
Hi Niklas, On 08/01/18 17:56, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your patch. > > On 2018-01-08 17:39:30 +, Kieran Bingham wrote: >> The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field >> types. The correct specification for the height on the mbus is the >>

Re: [PATCH v9 21/28] rcar-vin: add group allocator functions

2018-01-08 Thread Laurent Pinchart
Hi Niklas, On Monday, 8 January 2018 19:24:47 EET Niklas Söderlund wrote: > On 2017-12-08 22:12:56 +0200, Laurent Pinchart wrote: > > On Friday, 8 December 2017 03:08:35 EET Niklas Söderlund wrote: > >> In media controller mode all VIN instances needs to be part of the same > >> media graph. There

Re: [PATCH] media: i2c: adv748x: fix HDMI field heights

2018-01-08 Thread Niklas Söderlund
Hi Kieran, Thanks for your patch. On 2018-01-08 17:39:30 +, Kieran Bingham wrote: > The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field > types. The correct specification for the height on the mbus is the > image height, in this instance, the field height. > > The AFE comp

[PATCH v2] v4l: doc: Clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Kieran Bingham
The v4l2_mbus_fmt width and height corresponds directly with the v4l2_pix_format definitions, yet the differences in documentation make it ambiguous what to do in the event of field heights. Clarify this using the same text as is provided for the v4l2_pix_format which is explicit on the matter, an

Re: [PATCH v9 07/28] rcar-vin: change name of video device

2018-01-08 Thread Laurent Pinchart
Hi Niklas, On Monday, 8 January 2018 18:42:05 EET Niklas Söderlund wrote: > On 2018-01-08 18:35:23 +0200, Laurent Pinchart wrote: > > On Wednesday, 20 December 2017 17:20:55 EET Niklas Söderlund wrote: > >> On 2017-12-14 17:50:24 +0200, Laurent Pinchart wrote: > >>> On Thursday, 14 December 2017 1

[PATCH] media: i2c: adv748x: fix HDMI field heights

2018-01-08 Thread Kieran Bingham
The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field types. The correct specification for the height on the mbus is the image height, in this instance, the field height. The AFE component already correctly adjusts the height on the mbus, but the HDMI component got left behind. A

Re: [PATCH v9 21/28] rcar-vin: add group allocator functions

2018-01-08 Thread Niklas Söderlund
Hi Laurent, Thanks for your comments. On 2017-12-08 22:12:56 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday, 8 December 2017 03:08:35 EET Niklas Söderlund wrote: > > In media controller mode all VIN instances needs to be part of the same > > media graph.

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Hans Verkuil
On 01/08/2018 05:11 PM, Niklas Söderlund wrote: > On 2018-01-08 16:48:35 +0100, Hans Verkuil wrote: >> On 01/08/2018 04:32 PM, Niklas Söderlund wrote: >>> Hi, >>> >>> Thanks for your patch. >>> >>> On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: Hi Kieran, On Mon, Jan 08, 2018 at 0

Re: [PATCH v9 07/28] rcar-vin: change name of video device

2018-01-08 Thread Niklas Söderlund
Hi Laurent, On 2018-01-08 18:35:23 +0200, Laurent Pinchart wrote: > Hi Niklas, > > On Wednesday, 20 December 2017 17:20:55 EET Niklas Söderlund wrote: > > On 2017-12-14 17:50:24 +0200, Laurent Pinchart wrote: > > > On Thursday, 14 December 2017 16:25:00 EET Sakari Ailus wrote: > > >> On Fri, Dec

Re: [PATCH v9 07/28] rcar-vin: change name of video device

2018-01-08 Thread Laurent Pinchart
Hi Niklas, On Wednesday, 20 December 2017 17:20:55 EET Niklas Söderlund wrote: > On 2017-12-14 17:50:24 +0200, Laurent Pinchart wrote: > > On Thursday, 14 December 2017 16:25:00 EET Sakari Ailus wrote: > >> On Fri, Dec 08, 2017 at 10:17:36AM +0200, Laurent Pinchart wrote: > >>> On Friday, 8 Decemb

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Niklas Söderlund
On 2018-01-08 16:48:35 +0100, Hans Verkuil wrote: > On 01/08/2018 04:32 PM, Niklas Söderlund wrote: > > Hi, > > > > Thanks for your patch. > > > > On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: > >> Hi Kieran, > >> > >> On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: > >>> The

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Hans Verkuil
On 01/08/2018 04:32 PM, Niklas Söderlund wrote: > Hi, > > Thanks for your patch. > > On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: >> Hi Kieran, >> >> On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: >>> The v4l2_mbus_fmt width and height corresponds directly with the >>> v4l2_

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Niklas Söderlund
Hi, Thanks for your patch. On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: > Hi Kieran, > > On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: > > The v4l2_mbus_fmt width and height corresponds directly with the > > v4l2_pix_format definitions, yet the differences in documentation

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Sakari Ailus
Hi Kieran, On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: > The v4l2_mbus_fmt width and height corresponds directly with the > v4l2_pix_format definitions, yet the differences in documentation make > it ambiguous what to do in the event of field heights. > > Clarify this by refer

[PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Kieran Bingham
The v4l2_mbus_fmt width and height corresponds directly with the v4l2_pix_format definitions, yet the differences in documentation make it ambiguous what to do in the event of field heights. Clarify this by referencing the v4l2_pix_format which is explicit on the matter, and by matching the termin

[PATCH v4 2/3] dt-bindings: usb: renesas_usbhs: Add support for RZ/A1

2018-01-08 Thread Chris Brandt
Document support for RZ/A1 SoCs Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven --- v4: * Re-added "renesas,usbhs-r7s72100" v3: * Removed "renesas,usbhs-r7s72100" v2: * Added Reviewed-by --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++ 1 file changed, 2 inserti

[PATCH v4 0/3] usb: renesas_usbhs: Add RZ/A1 support

2018-01-08 Thread Chris Brandt
This series adds RZ/A1 gadget support to the renesas_usbhs driver. Basically, it's almost the same HW as the R-Car (and SH) parts. The only real difference is the some extra registers for the PHY. This was tested on an RSK board by connecting to a PC as an Ethernet CDC gadget. v4: * Re-added "re

[PATCH v4 3/3] ARM: dts: r7s72100: add USB device to device tree

2018-01-08 Thread Chris Brandt
Add USB device support. Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven --- v4: * Changed to "renesas,usbhs-r7s72100", "renesas,rza1-usbhs" v3: * Changed from "renesas,usbhs-r7s72100" to "renesas,rza1-usbhs" v2: * Node name is now generic 'usb@' * GIC_SPI (73-32) is now just GIC_

[PATCH v4 1/3] usb: renesas_usbhs: Add support for RZ/A1

2018-01-08 Thread Chris Brandt
This patch adds the capability to support RZ/A1 SoCs. Signed-off-by: Chris Brandt --- v2: * Removed "renesas,usbhs-r7s72100" * Changed license of rza.c --- drivers/usb/renesas_usbhs/Makefile | 2 +- drivers/usb/renesas_usbhs/common.c | 13 ++ drivers/usb/renesas_usbhs/common.h | 6 ++

Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support

2018-01-08 Thread Geert Uytterhoeven
Hi Chris, On Mon, Jan 8, 2018 at 12:59 PM, Chris Brandt wrote: > On Monday, January 08, 2018, Geert Uytterhoeven wrote: >> Thanks for the update, but I think there has been a misunderstanding. >> I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from >> the matching in the driver. >

Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support

2018-01-08 Thread Geert Uytterhoeven
On Mon, Jan 8, 2018 at 12:59 PM, Chris Brandt wrote: > Hi Geert and Simon, > > > On Monday, January 08, 2018, Geert Uytterhoeven wrote: >> Thanks for the update, but I think there has been a misunderstanding. >> I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from >> the matching i

RE: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support

2018-01-08 Thread Chris Brandt
Hi Geert and Simon, On Monday, January 08, 2018, Geert Uytterhoeven wrote: > Thanks for the update, but I think there has been a misunderstanding. > I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from > the matching in the driver. Opps, I was all kinds of confused then. So, b

[PATCH v4] PM / wakeup: Print warn if device gets enabled as wakeup source during sleep

2018-01-08 Thread Ulf Hansson
In general, wakeup settings are not supposed to be changed during any of the system wide PM phases. The reason is simply that it would break guarantees provided by the PM core, to properly act on active wakeup sources. However, there are exceptions to when, in particular, disabling a device as wak

Re: [PATCH v3 4/4] PM / wakeup: Print warn if device gets enabled as wakeup source during sleep

2018-01-08 Thread Rafael J. Wysocki
On Mon, Jan 8, 2018 at 12:13 PM, Ulf Hansson wrote: > On 6 January 2018 at 00:57, Rafael J. Wysocki wrote: >> On Tue, Jan 2, 2018 at 5:08 PM, Ulf Hansson wrote: >>> In general, wakeup settings are not supposed to be changed during any of >>> the system wide PM phases. The reason is simply that i

Re: [PATCH v3 4/4] PM / wakeup: Print warn if device gets enabled as wakeup source during sleep

2018-01-08 Thread Ulf Hansson
On 6 January 2018 at 00:57, Rafael J. Wysocki wrote: > On Tue, Jan 2, 2018 at 5:08 PM, Ulf Hansson wrote: >> In general, wakeup settings are not supposed to be changed during any of >> the system wide PM phases. The reason is simply that it would break >> guarantees provided by the PM core, to pr

Re: [PATCH v4 2/6] clk: renesas: rcar-gen3: Add Z2 clock divider support

2018-01-08 Thread Geert Uytterhoeven
Hi Simon, On Mon, Jan 8, 2018 at 9:02 AM, Simon Horman wrote: > On Fri, Jan 05, 2018 at 03:35:13PM +0100, Geert Uytterhoeven wrote: >> On Fri, Jan 5, 2018 at 3:04 PM, Simon Horman wrote: >> > On Wed, Jan 03, 2018 at 01:47:08PM +0100, Geert Uytterhoeven wrote: >> >> On Wed, Jan 3, 2018 at 1:18 PM

Re: [PATCH v4 2/6] clk: renesas: rcar-gen3: Add Z2 clock divider support

2018-01-08 Thread Simon Horman
On Fri, Jan 05, 2018 at 03:35:13PM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Jan 5, 2018 at 3:04 PM, Simon Horman wrote: > > On Wed, Jan 03, 2018 at 01:47:08PM +0100, Geert Uytterhoeven wrote: > >> On Wed, Jan 3, 2018 at 1:18 PM, Simon Horman > >> wrote: > >> > From: Takeshi Kiha

Re: [PATCH v2 0/2] arm64: dts: r8a779[56]: update register size for thermal

2018-01-08 Thread Geert Uytterhoeven
Hi Simon, On Mon, Jan 8, 2018 at 7:59 AM, Simon Horman wrote: > On Fri, Jan 05, 2018 at 04:54:45PM +0100, Niklas Söderlund wrote: >> This series updates the register size for the thermal hardware. In later >> versions of the datasheet one additional register is documented. This >> register is nee