RE: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler

2018-02-12 Thread Fabrizio Castro
> > > I used to have this simpler version (back then for the UP case): > > > > > > +rwdt_start(wdev); > > > +rwdt_write(priv, 0x, RWTCNT); > > > +return 0; > > > > > > It should still work probably... > > > > It should still work, but it would be slower, I would stick with the > > version I

Re: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler

2018-02-12 Thread Wolfram Sang
> > I used to have this simpler version (back then for the UP case): > > > > +rwdt_start(wdev); > > +rwdt_write(priv, 0x, RWTCNT); > > +return 0; > > > > It should still work probably... > > It should still work, but it would be slower, I would stick with the > version I have submitted if

RE: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler

2018-02-12 Thread Fabrizio Castro
Hello Wolfram, thank you for your feedback! > Subject: Re: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler > > > > +static int rwdt_restart(struct watchdog_device *wdev, unsigned long action, > > +void *data) > > +{ > > +struct rwdt_priv *priv = watchdog_get_drvdata(wdev); > > + > >

RE: [RFC v4 12/26] watchdog: renesas_wdt: Add R-Car Gen2 support

2018-02-12 Thread Fabrizio Castro
Hello Wolfram, thank you for your feedback! > Subject: Re: [RFC v4 12/26] watchdog: renesas_wdt: Add R-Car Gen2 support > > > > +#ifdef CONFIG_PM > > +static int rwdt_suspend(struct device *dev) > > +{ > > +struct platform_device *pdev; > > +struct rwdt_priv *priv; > > + > > +pdev =

<    1   2