Re: [PATCH 02/15] v4l: vsp1: Remove outdated comment

Hi Kieran, On Wednesday, 28 March 2018 22:04:49 EEST Kieran Bingham wrote: > On 28/03/18 13:27, Kieran Bingham wrote: > > On 26/02/18 21:45, Laurent Pinchart wrote: > >> The entities in the pipeline are all started when the LIF is setup. > >> Remove the outdated comment that state otherwise. > >>

[PATCH v2 0/8] Add r8a77470/iW-RainboW-G23S single board computer support

currently been enabled in DTS and tested: serial boot console. This patch series tested against renesas-dev branch tag "renesas-dev-20180328-v4.16-rc7 V1-->V2 Incorporated geert's review comments. Biju Das (8): soc: renesas: rcar-sysc: Add r8a77470 support serial: sh-

[PATCH v2 6/8] ARM: dts: r8a77470: Initial SoC device tree

The initial R8A77470 SoC device tree including CPU0, GIC, timer, SYSC, RST, CPG, and the required clock descriptions. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven --- V1->V2: * Incorporated geert's review comment * Moved prr node inside soc node. arch/a

[PATCH v2 7/8] ARM: dts: iwg23s-sbc: Add support for iWave G23S-SBC based on RZ/G1C

Add support for iWave iW-RainboW-G23S single board computer based on RZ/G1C. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven --- V1->V2: * Incorporated review comments arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/r8a77470-iwg23s-sbc

[PATCH v2 8/8] ARM: multi_v7_defconfig: Enable r8a77470 SoC

Enable recently added r8a77470 (RZ/G1C) SoC. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro --- V1->V2: * Incorporated Fabrizio's comment arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_

[PATCH v2 5/8] ARM: shmobile: r8a77470: basic SoC support

Add minimal support for the RZ/G1C (R8A77470) SoC. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro --- V1->V2: * No change Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++ arch/arm/mach-shmobile/Kconfig | 4 arch/arm/mach-shmobile/setup-rcar-gen2.c

[PATCH v2 4/8] clk: renesas: cpg-mssr: Add r8a77470 support

Add RZ/G1C (R8A77470) Clock Pulse Generator / Module Standby and Software Reset support. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro --- V1->V2: * incorporated geert's review comment .../devicetree/bindings/clock/renesas,cpg-mssr.txt | 9 +- drivers/clk/renesas/Kconfig

[PATCH v2 3/8] clk: renesas: Add r8a77470 CPG Core Clock Definitions

Add all RZ/G1C Clock Pulse Generator Core Clock Outputs, as listed in Table 7.2 ("List of Clocks [RZ/G1C]") of the RZ/G1C Hardware User's Manual. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven --- V1->V2: * incorporated geert's review comment include/dt-b

[PATCH v2 2/8] serial: sh-sci: Document r8a77470 bindings

RZ/G1C (R8A77470) SoC also has the R-Car gen2 compatible SCIF and HSCIF ports, so document the SoC specific bindings. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman --- V1->V2: * No Change Documentation/devicetree/bindings/seria

[PATCH v2 1/8] soc: renesas: rcar-sysc: Add r8a77470 support

Add support for RZ/G1C (R8A77470) SoC power areas to the R-Car SYSC driver. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven --- V1->V2: * incorporated geert's review comment .../bindings/power/renesas,rcar-sysc.txt | 1 + drivers/soc/renesas/Kco

Re: [PATCH 02/15] v4l: vsp1: Remove outdated comment

On 28/03/18 13:27, Kieran Bingham wrote: > Hi Laurent, > > Thank you for the patch. > > On 26/02/18 21:45, Laurent Pinchart wrote: >> The entities in the pipeline are all started when the LIF is setup. >> Remove the outdated comment that state otherwise. >> >> Signed-off-by: Laurent Pinchart >

Re: [PATCH 08/15] v4l: vsp1: Setup BRU at atomic commit time

Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > To implement fully dynamic plane assignment to pipelines, we need to > reassign the BRU and BRS to the DRM pipelines in the atomic commit > handler. In preparation for this setup factor out the BRU source pad > code and call it both at LIF s

RE: [PATCH 06/12] clk: renesas: cpg-mssr: Add r8a77470 support

Hi Geert, Thanks for the review. > Hi Biju, > > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > Add RZ/G1C (R8A77470) Clock Pulse Generator / Module Standby and > > Software Reset support. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro > > Thanks for your patch! > > > --

Re: [PATCH 09/15] v4l: vsp1: Replace manual DRM pipeline input setup in vsp1_du_setup_lif

Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > The vsp1_du_setup_lif() function setups the DRM pipeline input manually. s/ setups the / sets up the / > This duplicates the code from the vsp1_du_pipeline_setup_input() > function. Replace the manual implementation by a call to the functi

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

Hello Wolfram and i2c/Renesas contributors, To give you some background behind this change, it is done in the context of rcar3 boot optimization, while trying to put our past experience in practice for reaching the "rvc-in-less-than-2s" requirement for our customers. The current commit descriptio

Re: [PATCH 07/15] v4l: vsp1: Move DRM atomic commit pipeline setup to separate function

Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > The DRM pipeline setup code used at atomic commit time is similar to the > setup code used when enabling the pipeline. Move it to a separate > function in order to share it. > > Signed-off-by: Laurent Pinchart Assuming no hidden secret co

Re: [PATCH 06/15] v4l: vsp1: Share duplicated DRM pipeline configuration code

On 26/02/18 21:45, Laurent Pinchart wrote: > Move the duplicated DRM pipeline configuration code to a function and > call it from vsp1_du_setup_lif() and vsp1_du_atomic_flush(). > > Signed-off-by: Laurent Pinchart LGTM. I thought I had a bit of deja-vu on this patch ... but I can't seem to fi

[PATCH] gpio: dwapb: Add support for 32 interrupts

The DesignWare GPIO IP can be configured for either 1 or 32 interrupts, but the driver currently only supports 1 interrupt. See the DesignWare DW_apb_gpio Databook description of the 'GPIO_INTR_IO' parameter. This change allows the driver to work with up to 32 interrupts, it will get as many inter

Re: [PATCH 05/15] v4l: vsp1: Use vsp1_entity.pipe to check if entity belongs to a pipeline

Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > The DRM pipeline handling code uses the entity's pipe list head to check > whether the entity is already included in a pipeline. This method is a > bit fragile in the sense that it uses list_empty() on a list_head that > is a list member. Re

RE: [PATCH 10/12] ARM: dts: iwg23s-sbc: Add support for iWave G23S-SBC based on RZ/G1C

Hi Geert, Thanks for the feedback. > Hi Biju, > > On Wed, Mar 28, 2018 at 3:13 PM, Biju Das wrote: > >> On Tue, Mar 27, 2018 at 4:37 PM, Biju Das > wrote: > >> > Add support for iWave iW-RainboW-G23S single board computer based > >> > on RZ/G1C. > >> > > >> > Signed-off-by: Biju Das > >> > Rev

Re: [PATCH 10/12] ARM: dts: iwg23s-sbc: Add support for iWave G23S-SBC based on RZ/G1C

Hi Biju, On Wed, Mar 28, 2018 at 3:13 PM, Biju Das wrote: >> On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: >> > Add support for iWave iW-RainboW-G23S single board computer based on >> > RZ/G1C. >> > >> > Signed-off-by: Biju Das >> > Reviewed-by: Fabrizio Castro >> >> Thanks for your patch!

Re: [PATCH 04/15] v4l: vsp1: Store pipeline pointer in vsp1_entity

Hi Laurent, Thank you for the patch. On 26/02/18 21:45, Laurent Pinchart wrote: > Various types of objects subclassing vsp1_entity currently store a > pointer to the pipeline. Move the pointer to vsp1_entity to simplify the > code and avoid storing the pipeline in more entity subclasses later. T

RE: [PATCH 08/12] ARM: dts: r8a77470: Initial SoC device tree

Hi Geert, Thanks for the feedback. > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > The initial R8A77470 SoC device tree including CPU0, GIC, timer, SYSC, > > RST, CPG, and the required clock descriptions. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro > > Thanks for yo

RE: [PATCH 10/12] ARM: dts: iwg23s-sbc: Add support for iWave G23S-SBC based on RZ/G1C

Hi Geert, Thanks for the feedback. > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > Add support for iWave iW-RainboW-G23S single board computer based on > > RZ/G1C. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro > > Thanks for your patch! > > Reviewed-by: Geert Uytterho

Re: [PATCH 10/12] ARM: dts: iwg23s-sbc: Add support for iWave G23S-SBC based on RZ/G1C

Hi Biju, On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > Add support for iWave iW-RainboW-G23S single board computer based on > RZ/G1C. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Thanks for your patch! Reviewed-by: Geert Uytterhoeven One question below. > --- /dev/null

Re: [PATCH 08/12] ARM: dts: r8a77470: Initial SoC device tree

Hi Biju, On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > The initial R8A77470 SoC device tree including CPU0, GIC, timer, SYSC, RST, > CPG, and the required clock descriptions. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Thanks for your patch! > --- /dev/null > +++ b/arch/ar

Re: [PATCH 03/15] v4l: vsp1: Remove unused field from vsp1_drm_pipeline structure

Hi Laurent, Thanks for the patch, On 26/02/18 21:45, Laurent Pinchart wrote: > The vsp1_drm_pipeline enabled field is set but never used. Remove it. > Indeed - not used. > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/media/platform/vsp1/vsp1_drm.c | 4 >

Re: [PATCH 02/15] v4l: vsp1: Remove outdated comment

Hi Laurent, Thank you for the patch. On 26/02/18 21:45, Laurent Pinchart wrote: > The entities in the pipeline are all started when the LIF is setup. > Remove the outdated comment that state otherwise. > > Signed-off-by: Laurent Pinchart I'll start with the easy ones :-) Reviewed-by: Kieran B

Re: [PATCH 06/12] clk: renesas: cpg-mssr: Add r8a77470 support

Hi Biju, On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > Add RZ/G1C (R8A77470) Clock Pulse Generator / Module Standby and Software > Reset support. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Thanks for your patch! > --- /dev/null > +++ b/drivers/clk/renesas/r8a7747x-cpg-mss

RE: [PATCH 05/12] clk: renesas: Add r8a77470 CPG Core Clock Definitions

Hi Geert, Thanks for the feedback. > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > Add all RZ/G1C Clock Pulse Generator Core Clock Outputs, as listed in > > Table 7.2 ("List of Clocks [RZ/G1C]") of the RZ/G1C Hardware User's > > Manual. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fa

RE: [PATCH 01/12] soc: renesas: rcar-sysc: Add r8a77470 support

Hi Geert, Thanks for the feedback. > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > Add support for RZ/G1C (R8A77470) SoC power areas to the R-Car SYSC > > driver. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro > > Thanks for your patch! > > > drivers/soc/renesas/r8a77

Re: [PATCH 12/12] ARM: multi_v7_defconfig: Enable r8a77470 SoC

On Tue, Mar 27, 2018 at 02:57:28PM +, Biju Das wrote: > Hello Fabrizio, > > Thanks for the feedback. > > > > Subject: [PATCH 12/12] ARM: multi_v7_defconfig: Enable r8a77470 SoC > > > > > > Enable recently added r8a77470 (RZ/G1C) SoC. > > > > > > Signed-off-by: Biju Das > > > Reviewed-by: Fab

Re: [PATCH 11/12] ARM: shmobile: defconfig: Enable r8a77470 SoC

On Wed, Mar 28, 2018 at 09:36:33AM +0200, Geert Uytterhoeven wrote: > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > Enable recently added r8a77470 (RZ/G1C) SoC. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro > > Reviewed-by: Geert Uytterhoeven Thanks, applied.

Re: [PATCH 09/12] ARM: shmobile: Document iW-RainboW-G23S single board computer

On Wed, Mar 28, 2018 at 09:36:10AM +0200, Geert Uytterhoeven wrote: > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > > > Document the iW-RainboW-G23S single board computer device tree bindings, > > listing it as a supported board. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Ca

Re: [PATCH 05/12] clk: renesas: Add r8a77470 CPG Core Clock Definitions

Hi Biju, On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > Add all RZ/G1C Clock Pulse Generator Core Clock Outputs, as listed in > Table 7.2 ("List of Clocks [RZ/G1C]") of the RZ/G1C Hardware User's > Manual. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Thanks for your patch! >

Re: [PATCH 04/12] serial: sh-sci: Document r8a77470 bindings

On Wed, Mar 28, 2018 at 10:03:27AM +0200, Geert Uytterhoeven wrote: > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > RZ/G1C (R8A77470) SoC also has the R-Car gen2 compatible SCIF and HSCIF > > ports, so document the SoC specific bindings. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fab

Re: [PATCH 03/12] soc: renesas: rcar-rst: Add support for RZ/G1C

On Wed, Mar 28, 2018 at 10:00:49AM +0200, Geert Uytterhoeven wrote: > Hi Biju, > > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro > > Reviewed-by: Geert Uytterhoeven Thanks, applied.

Re: [PATCH 04/12] serial: sh-sci: Document r8a77470 bindings

On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > RZ/G1C (R8A77470) SoC also has the R-Car gen2 compatible SCIF and HSCIF > ports, so document the SoC specific bindings. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 03/12] soc: renesas: rcar-rst: Add support for RZ/G1C

Hi Biju, On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In person

RE: [PATCH v2 0/8] arm: Base support for Renesas RZN1D-DB Board

Replying to myself here, more or less to reflect further discussion on IRC related to where the bindings goes. Also, to publicly acknowledge and thank Geert for tons of advice and comments outside the email chain... So, after further discussion on IRC, that's what I've been trying to do [hope ou

Re: [PATCH 02/12] soc: renesas: Identify RZ/G1C

On Wed, Mar 28, 2018 at 09:37:06AM +0200, Geert Uytterhoeven wrote: > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > Add support for identifying the RZ/G1C (r8a77470) SoC. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro > > Reviewed-by: Geert Uytterhoeven Thanks, applie

Re: [PATCH 01/12] soc: renesas: rcar-sysc: Add r8a77470 support

Hi Biju, On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > Add support for RZ/G1C (R8A77470) SoC power areas to the R-Car SYSC > driver. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Thanks for your patch! > drivers/soc/renesas/r8a7747x-sysc.c| 29 > +++

RE: [PATCH v2 3/8] DT: arm: renesas,r9a06g032: add the RZ/N1 bindings

Hi Geert, Thanks for your review! On 22 March 2018 12:37, Geert said: > Hi Michel, > > On Thu, Mar 22, 2018 at 12:44 PM, Michel Pollet > wrote: > > This documents the RZ/N1 bindings for both the RZ/N1 and the > > RZN1D400-DB board. > > > > Signed-off-by: Michel Pollet > > Thanks for your patch

Re: [PATCH 11/12] ARM: shmobile: defconfig: Enable r8a77470 SoC

On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > Enable recently added r8a77470 (RZ/G1C) SoC. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [PATCH 02/12] soc: renesas: Identify RZ/G1C

On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > Add support for identifying the RZ/G1C (r8a77470) SoC. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Lin

Re: [PATCH 09/12] ARM: shmobile: Document iW-RainboW-G23S single board computer

On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > > Document the iW-RainboW-G23S single board computer device tree bindings, > listing it as a supported board. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 07/12] ARM: shmobile: r8a77470: basic SoC support

On Tue, Mar 27, 2018 at 4:37 PM, Biju Das wrote: > Add minimal support for the RZ/G1C (R8A77470) SoC. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux b