[PATCH 2/2] arm64: dts: renesas: r8a77980: disable EtherAVB

2018-05-11 Thread Sergei Shtylyov
When adding the R8A77980 EtherAVB device I failed to notice that it does not have the usual "status" property disabling the described devices in anticipation that the board device trees enable the devices according to their needs. This causes the EtherAVB driver to successfully probe despite e.g. t

[PATCH 1/2] arm64: dts: renesas: r8a77970: disable EtherAVB

2018-05-11 Thread Sergei Shtylyov
When adding the R8A77970 EtherAVB device I failed to notice that it does not have the usual "status" property disabling the described devices in anticipation that the board device trees enable the devices according to their needs. This causes the EtherAVB driver to successfully probe despite e.g. t

[PATCH 0/2] Disable EtherAVB by default on R8A779{7|8}0 SoCs

2018-05-11 Thread Sergei Shtylyov
Hello! Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180511-v4.17-rc4' tag. I'm fixing the issue in the EtherAVB device nodes in the R8A779{7|8}0 device trees that missed the "status" prop, usually disabl

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a77990 SoC

2018-05-11 Thread David Miller
From: Yoshihiro Shimoda Date: Fri, 11 May 2018 12:18:56 +0900 > Add documentation for r8a77990 compatible string to renesas ravb device > tree bindings documentation. > > Signed-off-by: Yoshihiro Shimoda I'm assuming this isn't targetted at one of my trees. Just FYI.

Re: [PATCH v3 1/2] vfio: platform: Fix reset module leak in error path

2018-05-11 Thread Alex Williamson
On Wed, 11 Apr 2018 11:15:48 +0200 Geert Uytterhoeven wrote: > If the IOMMU group setup fails, the reset module is not released. > > Fixes: b5add544d677d363 ("vfio, platform: make reset driver a requirement by > default") > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Eric Auger > Reviewe

Re: [PATCH/RFC v2 1/6] dt-bindings: usb: add Renesas R-Car USB 3.0 role switch

2018-05-11 Thread Rob Herring
On Mon, May 7, 2018 at 9:43 PM, Yoshihiro Shimoda wrote: > Hi Rob, > > Sorry for the delayed response. I had a vacation in last week. > >> From: Rob Herring, Sent: Saturday, April 28, 2018 5:06 AM >> >> On Thu, Apr 26, 2018 at 08:26:41PM +0900, Yoshihiro Shimoda wrote: >> > This patch adds a new d

Re: [PATCH v2 2/2] rcar-vin: fix crop and compose handling for Gen3

2018-05-11 Thread Sergei Shtylyov
Hello! On 05/11/2018 05:41 PM, Niklas Söderlund wrote: > When refactoring the Gen3 enablement series crop and compose handling > where broken. This went unnoticed but can result in writing out side the s/Where/Were/? > capture buffer. Fix this by restoring the crop and compose to reflect > t

Re: [PATCH 5/5] media: rcar-vin: Use FTEV for digital input

2018-05-11 Thread jacopo mondi
Hi Hans, On Fri, May 11, 2018 at 12:28:55PM +0200, Hans Verkuil wrote: > On 05/11/18 11:59, Jacopo Mondi wrote: > > Since commit (015060cb "media: rcar-vin: enable field toggle after a set > > number of lines for Gen3) the VIN generates an internal field signal > > toggle after a fixed number of r

[PATCH v2 0/2] Fix potential buffer overrun root cause

2018-05-11 Thread Niklas Söderlund
Hi, Commit 015060cb7795eac3 ("media: rcar-vin: enable field toggle after a set number of lines for Gen3") was an attempt to fix the issue of writing outside the capture buffer for VIN Gen3. Unfortunately it only fixed a symptom of a problem to such a degree I could no longer reproduce it. Jacopo

[PATCH v2 2/2] rcar-vin: fix crop and compose handling for Gen3

2018-05-11 Thread Niklas Söderlund
When refactoring the Gen3 enablement series crop and compose handling where broken. This went unnoticed but can result in writing out side the capture buffer. Fix this by restoring the crop and compose to reflect the format dimensions as we have not yet enabled the scaler for Gen3. Fixes: 5e7c6236

[PATCH v2 1/2] Revert "media: rcar-vin: enable field toggle after a set number of lines for Gen3"

2018-05-11 Thread Niklas Söderlund
The offending commit was an attempt to fix the issue of writing outside the capture buffer for VIN Gen3. Unfortunately it only fixed the symptom of the problem to such a degree I could no longer reproduce it. Revert the offending commit before a proper fix can be added in a follow-up patch. This r

[PATCH] drm: rcar-du: disable dtc graph-endpoint warnings on DT overlays

2018-05-11 Thread Rob Herring
The rcar DT overlays are missing symetrical remote-endpoint properties in their graph nodes because the remote-endpoint is fixed up at run-time. Disable the dtc 'graph-endpoint' warnings when compiling these overlays. If this becomes a common problem for overlays, then perhaps this check needs to b

Re: [PATCH 1/2] Revert "media: rcar-vin: enable field toggle after a set number of lines for Gen3"

2018-05-11 Thread Hans Verkuil
On 05/11/18 16:15, Niklas Söderlund wrote: > This reverts commit 015060cb7795eac34454696cc9c9f8b76926a401. Why? The cover letter states the reason, but it also needs to be added here in the commit log. Regards, Hans > --- > drivers/media/platform/rcar-vin/rcar-dma.c | 20 +-

[PATCH 2/2] rcar-vin: fix crop and compose handling for Gen3

2018-05-11 Thread Niklas Söderlund
When refactoring the Gen3 enablement series crop and compose handling where broken. This went unnoticed but can result in writing out side the capture buffer. Fix this by restoring the crop and compose to reflect the format dimensions as we have not yet enabled the scaler for Gen3. Fixes: 5e7c6236

[PATCH 1/2] Revert "media: rcar-vin: enable field toggle after a set number of lines for Gen3"

2018-05-11 Thread Niklas Söderlund
This reverts commit 015060cb7795eac34454696cc9c9f8b76926a401. --- drivers/media/platform/rcar-vin/rcar-dma.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c index b41b

[PATCH 0/2] rcar-vin: Fix potential buffer overrun root cause

2018-05-11 Thread Niklas Söderlund
Hi, Commit 015060cb7795eac3 ("media: rcar-vin: enable field toggle after a set number of lines for Gen3") was an attempt to fix the issue of writing outside the capture buffer for VIN Gen3. Unfortunately it only fixed a symptom of a problem to such a degree I could no longer reproduce it. Jac

[PATCH v2] media: i2c: adv748x: Fix pixel rate values

2018-05-11 Thread Niklas Söderlund
From: Laurent Pinchart The pixel rate, as reported by the V4L2_CID_PIXEL_RATE control, must include both horizontal and vertical blanking. Both the AFE and HDMI receiver program it incorrectly: - The HDMI receiver goes to the trouble of removing blanking to compute the rate of active pixels. Thi

[RFT] arm64: dts: r8a77965: add I2C support

2018-05-11 Thread Niklas Söderlund
Signed-off-by: Niklas Söderlund --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 99 --- 1 file changed, 90 insertions(+), 9 deletions(-) Hi Simon, I have only tested i2c4 and the adv7482 which is connected there. But it seemed silly to post this patch without enable all i2c

Re: [PATCH 2/3] arm64: dts: renesas: r8a77995: Add VIN4

2018-05-11 Thread Simon Horman
On Fri, May 11, 2018 at 01:25:23PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-11 12:00:01 +0200, Jacopo Mondi wrote: > > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > > > Signed-off-by: Jacopo Mondi > > Acked-by: Niklas Söderlund > > > --- >

Re: [PATCH 1/3] dt-bindings: media: rcar-vin: Add R8A77995 support

2018-05-11 Thread Simon Horman
On Fri, May 11, 2018 at 12:00:00PM +0200, Jacopo Mondi wrote: > Add compatible string for R-Car D3 R8A7795 to list of SoCs supported by > rcar-vin driver. > > Signed-off-by: Jacopo Mondi Reviewed-by: Simon Horman

Re: [PATCH 6/9] NTB: ntb_hw_idt: fix typo 'can by' to 'can be'

2018-05-11 Thread Serge Semin
On Sun, May 06, 2018 at 01:23:50PM +0200, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang > --- > drivers/ntb/hw/idt/ntb_hw_idt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c > index 8d98872d0983b7.

Re: [PATCH 4/5] media: rcar-vin: Do not use crop if not configured

2018-05-11 Thread Niklas Söderlund
Hi again, On 2018-05-11 13:10:37 +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-11 11:59:40 +0200, Jacopo Mondi wrote: > > The crop_scale routine uses the crop rectangle memebers to configure the > > VIN clipping rectangle. When crop is not configured all it

Re: [PATCH 2/3] arm64: dts: renesas: r8a77995: Add VIN4

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work. On 2018-05-11 12:00:01 +0200, Jacopo Mondi wrote: > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++ > 1 file changed, 11 inserti

Re: [PATCH 1/3] dt-bindings: media: rcar-vin: Add R8A77995 support

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work. On 2018-05-11 12:00:00 +0200, Jacopo Mondi wrote: > Add compatible string for R-Car D3 R8A7795 to list of SoCs supported by > rcar-vin driver. > > Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund > --- > Documentation/devicetree/bindings/media/rcar_vin

Re: [PATCH 4/5] yavta-hdmi: Generalize capture parameters

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work. On 2018-05-11 12:00:38 +0200, Jacopo Mondi wrote: > Use the newly defined ${capture_vin} and ${convert_format} to generalize > capture operations from HDMI sources. > > Signed-off-by: Jacopo Mondi > --- > yavta-hdmi | 6 +++--- > 1 file changed, 3 insertions(+)

Re: [PATCH 5/5] convert: Accept destination format as parameter

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work. On 2018-05-11 12:00:39 +0200, Jacopo Mondi wrote: > Accept the destination image format as thrid parameter of the convert > function. > > Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund > --- > convert.sh | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [PATCH 3/5] gen3-links: Support linking for digital input

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, On 2018-05-11 12:00:37 +0200, Jacopo Mondi wrote: > Add support for linking the digital subdevice to a vin instance. This is > useful for D3 board. > > Signed-off-by: Jacopo Mondi As you might have noticed the vin-tests are in need of a big rework. But for now I'm happy with the di

Re: [PATCH 2/5] vin-tests: Add function to propagate digital format

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your patch, On 2018-05-11 12:00:36 +0200, Jacopo Mondi wrote: > Add function to vin-tests.sh to propagate the HDMI format for the > digital input use case. This is useful for D3 when capturing HDMI input > from adv7612 at 640x480 resolution. Why is there a need to hard code

Re: [PATCH 1/5] boards: Add R8A77995 D3 Draak board

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your patch. On 2018-05-11 12:00:35 +0200, Jacopo Mondi wrote: > Add support for R-Car Gen3 Draak board based on R8A77995 SoC. > Define additional variables such as which vin should be used to perform > capture operations and which is the destination image format for each > b

Re: [PATCH 4/5] media: rcar-vin: Do not use crop if not configured

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work. On 2018-05-11 11:59:40 +0200, Jacopo Mondi wrote: > The crop_scale routine uses the crop rectangle memebers to configure the > VIN clipping rectangle. When crop is not configured all its fields are > 0s, and setting the clipping rectangle vertical and horizontal e

Re: [PATCH 2/5] media: rcar-vin: Add digital input subdevice parsing

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work! The comments here apply to both 2/5 and 3/5. On 2018-05-11 11:59:38 +0200, Jacopo Mondi wrote: > Add support for digital input subdevices to Gen-3 rcar-vin. > The Gen-3, media-controller compliant, version has so far only accepted > CSI-2 input subdevices. Remove

Re: [PATCH 1/5] media: rcar-vin: Add support for R-Car R8A77995 SoC

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your patch. On 2018-05-11 11:59:37 +0200, Jacopo Mondi wrote: > Add R-Car R8A77995 SoC to the rcar-vin supported ones. > > Signed-off-by: Jacopo Mondi I would move this to be the last patch in the series as a indication that capture on R8A77995 is now ready to be used. B

Re: [PATCH 5/5] media: rcar-vin: Use FTEV for digital input

2018-05-11 Thread Hans Verkuil
On 05/11/18 11:59, Jacopo Mondi wrote: > Since commit (015060cb "media: rcar-vin: enable field toggle after a set > number of lines for Gen3) the VIN generates an internal field signal > toggle after a fixed number of received lines, and uses the internal > field signal to drive capture operations.

[PATCH 5/5] convert: Accept destination format as parameter

2018-05-11 Thread Jacopo Mondi
Accept the destination image format as thrid parameter of the convert function. Signed-off-by: Jacopo Mondi --- convert.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/convert.sh b/convert.sh index 4059868..878ac63 100755 --- a/convert.sh +++ b/convert.sh @@ -2,6 +2,7 @@

[PATCH 1/5] boards: Add R8A77995 D3 Draak board

2018-05-11 Thread Jacopo Mondi
Add support for R-Car Gen3 Draak board based on R8A77995 SoC. Define additional variables such as which vin should be used to perform capture operations and which is the destination image format for each board. These variables will be used later to generalize the image scripts. Signed-off-by: Jaco

[PATCH 2/5] vin-tests: Add function to propagate digital format

2018-05-11 Thread Jacopo Mondi
Add function to vin-tests.sh to propagate the HDMI format for the digital input use case. This is useful for D3 when capturing HDMI input from adv7612 at 640x480 resolution. Signed-off-by: Jacopo Mondi --- scripts/vin-tests.sh | 9 + 1 file changed, 9 insertions(+) diff --git a/scripts/

[PATCH 2/3] arm64: dts: renesas: r8a77995: Add VIN4

2018-05-11 Thread Jacopo Mondi
Describe VIN4 interface for R-Car D3 R8A77995 SoC. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index 82aed7e..bdf7

[PATCH 1/3] dt-bindings: media: rcar-vin: Add R8A77995 support

2018-05-11 Thread Jacopo Mondi
Add compatible string for R-Car D3 R8A7795 to list of SoCs supported by rcar-vin driver. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/media/rcar_vin.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/

[PATCH 0/3] arm64: dts: Draak: Enable HDMI input and VIN4

2018-05-11 Thread Jacopo Mondi
Hello, this series enables HDMI input and VIN4 on R-Car D3 Draak board. The Draak board has an HDMI input connected to an HDMI decoder that feeds the VIN capture interface through its parallel video interface. The series requires the just sent: [PATCH 0/5] rcar-vin: Add support for digital inp

[PATCH 0/5] vin-tests: Add D3 Draak support

2018-05-11 Thread Jacopo Mondi
Hello Niklas, this series extends the vin-test suites to allow capture from HDMI input on D3 Draak board. I have re-used as much as possible of the existing scripts, but had to extend and generalize some assumptions, as so far Gen3 had only been used and tested with CSI-2 inputs. To capture f

[PATCH 4/5] yavta-hdmi: Generalize capture parameters

2018-05-11 Thread Jacopo Mondi
Use the newly defined ${capture_vin} and ${convert_format} to generalize capture operations from HDMI sources. Signed-off-by: Jacopo Mondi --- yavta-hdmi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yavta-hdmi b/yavta-hdmi index a0a09a3..5806a0d 100755 --- a/yavta-hd

[PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input

2018-05-11 Thread Jacopo Mondi
Describe HDMI input connected to VIN4 interface for R-Car D3 Draak development board. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 68 ++ 1 file changed, 68 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/a

[PATCH 3/5] gen3-links: Support linking for digital input

2018-05-11 Thread Jacopo Mondi
Add support for linking the digital subdevice to a vin instance. This is useful for D3 board. Signed-off-by: Jacopo Mondi --- gen3-links.sh | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/gen3-links.sh b/gen3-links.sh index cfcdeb7..0ec30e4 100755 --- a/gen3-l

[PATCH 0/5] rcar-vin: Add support for digital input on Gen3

2018-05-11 Thread Jacopo Mondi
Hello, this series add support for 'digital' input to the Gen3 version of rcar-vin driver. 'Digital' inputs (the terms comes from the existing Gen2 version of the driver) describe parallel video input sources connected to a VIN instance. So far, the Gen3-version of the driver (the media-control

[PATCH 2/5] media: rcar-vin: Add digital input subdevice parsing

2018-05-11 Thread Jacopo Mondi
Add support for digital input subdevices to Gen-3 rcar-vin. The Gen-3, media-controller compliant, version has so far only accepted CSI-2 input subdevices. Remove assumptions on the supported bus_type and accepted number of subdevices, and allow digital input connections on port@0. Signed-off-by:

[PATCH 4/5] media: rcar-vin: Do not use crop if not configured

2018-05-11 Thread Jacopo Mondi
The crop_scale routine uses the crop rectangle memebers to configure the VIN clipping rectangle. When crop is not configured all its fields are 0s, and setting the clipping rectangle vertical and horizontal extensions to (0 - 1) causes the registers to be written with an incorrect 0x value.

[PATCH 3/5] media: rcar-vin: [un]bind and link digital subdevice

2018-05-11 Thread Jacopo Mondi
Add support for binding and unbinding digital subdevices to rcar-vin. On 'complete' also create direct links between the VIN instance and the digital subdevice. Signed-off-by: Jacopo Mondi --- drivers/media/platform/rcar-vin/rcar-core.c | 133 +++- 1 file changed, 110 ins

[PATCH 5/5] media: rcar-vin: Use FTEV for digital input

2018-05-11 Thread Jacopo Mondi
Since commit (015060cb "media: rcar-vin: enable field toggle after a set number of lines for Gen3) the VIN generates an internal field signal toggle after a fixed number of received lines, and uses the internal field signal to drive capture operations. When capturing from digital input, using FTEH

[PATCH 1/5] media: rcar-vin: Add support for R-Car R8A77995 SoC

2018-05-11 Thread Jacopo Mondi
Add R-Car R8A77995 SoC to the rcar-vin supported ones. Signed-off-by: Jacopo Mondi --- drivers/media/platform/rcar-vin/rcar-core.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c inde

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a77990 SoC

2018-05-11 Thread Sergei Shtylyov
On 5/11/2018 6:18 AM, Yoshihiro Shimoda wrote: Add documentation for r8a77990 compatible string to renesas ravb device tree bindings documentation. Signed-off-by: Yoshihiro Shimoda [...] Acked-by: Sergei Shtylyov MBR, Sergei

[PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-11 Thread Phil Edworthy
The DesignWare GPIO IP can be configured for either 1 interrupt or 1 per GPIO in port A, but the driver currently only supports 1 interrupt. See the DesignWare DW_apb_gpio Databook description of the 'GPIO_INTR_IO' parameter. This change allows the driver to work with up to 32 interrupts, it will

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-11 Thread Peter Rosin
On 2018-05-10 10:10, Andrzej Hajda wrote: > On 04.05.2018 15:52, Peter Rosin wrote: >> If the bridge supplier is unbound, this will bring the bridge consumer >> down along with the bridge. Thus, there will no longer linger any >> dangling pointers from the bridge consumer (the drm_device) to some >