RE: [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value

2018-08-07 Thread Chris Brandt
Hi Geert, On Tuesday, August 07, 2018, Geert Uytterhoeven wrote: > > I see that you added this: > > > > OF_EARLYCON_DECLARE(scif, "renesas,scif-r7s9210", > rza2_early_console_setup); > > > > and "renesas,scif-r7s9210" matches what I have in my .dtsi. > > > > But, when I run the code, I end up in

RE: [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value

2018-08-07 Thread Chris Brandt
Hi Geert, On Tuesday, August 07, 2018, Geert Uytterhoeven wrote: > > But, when I run the code, I end up in function scif_early_console_setup, > > not rza2_early_console_setup > > Hmm, perhaps it doesn't pick the first/most specialized match. > > > I'm assuming I'm just supposed to use this on

Re: [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value

2018-08-07 Thread Geert Uytterhoeven
Hi Chris, On Tue, Aug 7, 2018 at 9:24 PM Chris Brandt wrote: > On Monday, August 06, 2018 1, Geert Uytterhoeven wrote: > > > I had a simple patch to add support for CONFIG_DEBUG_LL for RZ/A2 > > > because earlycon never worked because of RZ/A2's different register > > locations. > > > > Yeah,

RE: [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value

2018-08-07 Thread Chris Brandt
Hi Geert, On Monday, August 06, 2018 1, Geert Uytterhoeven wrote: > > I had a simple patch to add support for CONFIG_DEBUG_LL for RZ/A2 > > because earlycon never worked because of RZ/A2's different register > locations. > > Yeah, sci_probe_regmap() assumed the wrong regtype for your TYPE_SCIF >

Re: [PATCH] ASoC: rsnd: Document R-Car M3-N support

2018-08-07 Thread Rob Herring
On Thu, Jul 26, 2018 at 05:40:15AM +0900, Yoshihiro Kaneko wrote: > From: Hiroyuki Yokoyama > > Document support for the sound modules in the Renesas M3-N (r8a77965) > SoC. > > No driver update is needed. > > Signed-off-by: Hiroyuki Yokoyama > Signed-off-by: Yoshihiro Kaneko > --- > > This

Re: [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support

2018-08-07 Thread Rob Herring
On Tue, Aug 07, 2018 at 08:57:03AM +0100, Biju Das wrote: > Update the DT bindings documentation with the optional gpio-reserved-ranges > properties. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro > --- > V2 --> V3 > * Incorporated review comments. > --- >

[PATCH] arm64: dts: renesas: salvator-common: adv748x: Override secondary addresses

2018-08-07 Thread Kieran Bingham
Ensure that the ADV748x device addresses do not conflict, and group them together (visually in i2cdetect) Signed-off-by: Kieran Bingham --- arch/arm64/boot/dts/renesas/salvator-common.dtsi | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-07 Thread Eugeniu Rosca
On Sun, Aug 05, 2018 at 01:11:02AM +0200, Eugeniu Rosca wrote: > diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt > b/Documentation/devicetree/bindings/arm/shmobile.txt > index d8cf740132c6..f391dba10574 100644 > --- a/Documentation/devicetree/bindings/arm/shmobile.txt > +++

Re: [GIT PULL FOR renesas-drivers] gmsl/for-renesas-drivers

2018-08-07 Thread Kieran Bingham
Hi Geert On 07/08/18 13:04, Geert Uytterhoeven wrote: > Hi Kieran, > > On Tue, Aug 7, 2018 at 1:25 PM Kieran Bingham > wrote: >> Please consider including this release in renesas-drivers. >> >> This brings in our GMSL developments for inclusion in renesas-drivers, but >> does >> not by default

Re: [GIT PULL FOR renesas-drivers] gmsl/for-renesas-drivers

2018-08-07 Thread Geert Uytterhoeven
Hi Kieran, On Tue, Aug 7, 2018 at 1:25 PM Kieran Bingham wrote: > Please consider including this release in renesas-drivers. > > This brings in our GMSL developments for inclusion in renesas-drivers, but > does > not by default enable any FAKRA overlays. Anyone wishing to try out the GMSL >

[GIT PULL FOR renesas-drivers] gmsl/for-renesas-drivers

2018-08-07 Thread Kieran Bingham
Hi Geert, Please consider including this release in renesas-drivers. This brings in our GMSL developments for inclusion in renesas-drivers, but does not by default enable any FAKRA overlays. Anyone wishing to try out the GMSL work must manually configure their specific camera configuration.

Re: [PATCH v3 1/5] gpio: rcar: Add GPIO hole support

2018-08-07 Thread Geert Uytterhoeven
On Tue, Aug 7, 2018 at 10:03 AM Biju Das wrote: > GPIO hole is present in RZ/G1C SoC. Valid GPIO pins on bank3 are in the > range GP3_0 to GP3_16 and GP3_27 to GP3_29. The GPIO pins between GP3_17 > to GP3_26 are unused. Add support for handling unused GPIO's. > > Signed-off-by: Biju Das > --- >

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-07 Thread Geert Uytterhoeven
Hi Laurent, On Tue, Aug 7, 2018 at 10:21 AM Laurent Pinchart wrote: > On Tuesday, 7 August 2018 11:18:11 EEST Kuninori Morimoto wrote: > > > Yeah, it is true "so far". I think there is no problem on current kernel. > > > But, unfortunately we need to keep compatibility for old/new DT > > > (=

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-07 Thread Laurent Pinchart
Hi Morimoto-san, On Tuesday, 7 August 2018 11:18:11 EEST Kuninori Morimoto wrote: > Hi Eugeniu, again > > > Yeah, it is true "so far". I think there is no problem on current kernel. > > But, unfortunately we need to keep compatibility for old/new DT > > (= actually, I don't like this DT rule. It

Re: [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support

2018-08-07 Thread Geert Uytterhoeven
On Tue, Aug 7, 2018 at 10:03 AM Biju Das wrote: > Update the DT bindings documentation with the optional gpio-reserved-ranges > properties. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-07 Thread Kuninori Morimoto
Hi Eugeniu, again > Yeah, it is true "so far". I think there is no problem on current kernel. > But, unfortunately we need to keep compatibility for old/new DT > (= actually, I don't like this DT rule. It is 100% "shackles for the legs") > Thus, my big concern is that, in the future, > "if" we

Re: [PATCH V2] ARM: dts: silk: Add DA9063 PMIC node

2018-08-07 Thread Geert Uytterhoeven
Hi Marek, On Sat, Aug 4, 2018 at 6:38 PM Marek Vasut wrote: > Add DA9063 PMIC node to the I2C bus. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Kuninori Morimoto > Cc: Simon Horman > Cc: Wolfram Sang > Cc: linux-renesas-soc@vger.kernel.org > --- > V2: - Replace shmobile

[PATCH v3 0/5] Add GPIO and EAVB Pinctrl support

2018-08-07 Thread Biju Das
This patch series aims to add GPIO and EAVB Pinctrl support for RZ/G1C SoC. V1-->V2 * Add support for gpio-reserved-ranges V2-->V3 * Updated binding documentation * Rework based on Geert's comment. Biju Das (5): gpio: rcar: Add GPIO hole support dt-bindings: gpio: rcar: Add

[PATCH v3 4/5] ARM: dts: iwg23s-sbc: specify EtherAVB PHY IRQ

2018-08-07 Thread Biju Das
Specify EtherAVB PHY IRQ in the board specific device tree, now that we have GPIO support. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven --- --- V1-->V2 * No change V2-->V3 * No change * compile time dependency on gpio dtsi patch --- ---

[PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB

2018-08-07 Thread Biju Das
Adding pinctrl support for EtherAVB interface. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven --- V1-->V2 * No change V2-->V3 * No change Depend onthe below patch https://patchwork.kernel.org/patch/10546801/ ---

[PATCH v3 3/5] ARM: dts: r8a77470: Add GPIO support

2018-08-07 Thread Biju Das
Describe GPIO blocks in the R8A77470 device tree. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven --- V2-->V3 * Moved gpio-reserved-ranges property just below gpio-ranges --- arch/arm/boot/dts/r8a77470.dtsi | 91 +

[PATCH v3 1/5] gpio: rcar: Add GPIO hole support

2018-08-07 Thread Biju Das
GPIO hole is present in RZ/G1C SoC. Valid GPIO pins on bank3 are in the range GP3_0 to GP3_16 and GP3_27 to GP3_29. The GPIO pins between GP3_17 to GP3_26 are unused. Add support for handling unused GPIO's. Signed-off-by: Biju Das --- V1-->V2 * Added gpio-reserved-ranges support for handling

[PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support

2018-08-07 Thread Biju Das
Update the DT bindings documentation with the optional gpio-reserved-ranges properties. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro --- V2 --> V3 * Incorporated review comments. --- .../devicetree/bindings/gpio/renesas,gpio-rcar.txt | 61 +- 1 file changed, 35

Re: [PATCH] gpiolib: Avoid calling chip->request() for unused gpios

2018-08-07 Thread Geert Uytterhoeven
Hi Biju, Thanks for your patch! On Tue, Aug 7, 2018 at 9:21 AM Biju Das wrote: > Add a check for unused gpios to avoid chip->request() call to client > driver for unused gpios. "... so not every driver has to do this in its chip->request() callback." Note that currently no driver seems to

Re: [PATCH] gpiolib: Fix of_node inconsistency

2018-08-07 Thread Geert Uytterhoeven
On Mon, Aug 6, 2018 at 11:54 AM Biju Das wrote: > Some platforms are not setting of_node in the driver. On these platforms > defining gpio-reserved-ranges on device tree leads to kernel crash. > > It is due to some parts of the gpio core relying on the driver to set up > of_node,while other parts

[PATCH] gpiolib: Avoid calling chip->request() for unused gpios

2018-08-07 Thread Biju Das
Add a check for unused gpios to avoid chip->request() call to client driver for unused gpios. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro --- drivers/gpio/gpiolib.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c