On Mon, Aug 27, 2018 at 11:21:39AM -0500, Chris Brandt wrote:
> Add support for the R7S9210 (RZ/A2) Clock Pulse Generator and Module
> Standby.
>
> The Module Standby HW in the RZ/A series is very close to R-Car HW, except
> for how the registers are laid out.
> The MSTP registers are only 8-bits
On Tue, Aug 28, 2018 at 10:07:40PM +0200, Wolfram Sang wrote:
> Hi Guenter,
>
> > > + __driver.remove = NULL; \
> >
> > Does that really do any good ? If I understand correctly, the only
> > impact is that the platform driver remove function will believe that
> > nothing needs to be done
On Fri, Aug 17, 2018 at 04:53:55PM +0900, Yoshihiro Kaneko wrote:
> From: Hiroyuki Yokoyama
>
> This patch adds the device tree binding of the r8a77990 SoC.
This doesn't apply against current code, please check and resend.
signature.asc
Description: PGP signature
Hi Guenter,
> > + __driver.remove = NULL; \
>
> Does that really do any good ? If I understand correctly, the only
> impact is that the platform driver remove function will believe that
> nothing needs to be done on removal. See platform_drv_remove().
This might be biased for my use ca
On Tue, Aug 28, 2018 at 09:14:13PM +0200, Wolfram Sang wrote:
> To prevent removing if NOWAYOUT, we invalidate the .remove function and
> suppress the bind/unbind attributes in sysfs. These are driver
> capabilities, so we need to set it up at runtime during init. To avoid
> boilerplate, introduce
Allow PCI drivers to prevent removing if NOWAYOUT, too.
Note: This is only a build-tested proof-of-concept!
Signed-off-by: Wolfram Sang
---
include/linux/watchdog.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
index 5768fb6b5cde..07
Use the new macro to prevent removing the driver if NOWAYOUT.
Signed-off-by: Wolfram Sang
---
drivers/watchdog/renesas_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
index f45cb183fa75..92339c744cce 100644
To prevent removing if NOWAYOUT, we invalidate the .remove function and
suppress the bind/unbind attributes in sysfs. These are driver
capabilities, so we need to set it up at runtime during init. To avoid
boilerplate, introduce module_watchdog_driver() similar to
module_driver(). On top of that, w
So, here is my second approach, now avoiding probe() and targetting the init
call. To avoid boilerplate, I introduced macros similar to module_driver(). It
still feels a little adventurous because of hard-coding '.remove' and
'.driver.suppress_bind_attts' in the macro and trusting various driver ty
Use the new macro to prevent removing the driver if NOWAYOUT.
Note: This is only a build-tested proof-of-concept!
Signed-off-by: Wolfram Sang
---
drivers/watchdog/i6300esb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/i6300esb.c b/drivers/watchdog/i6300e
Hi Geert,
On Tuesday, August 28, 2018, Geert Uytterhoeven wrote:
> Seriously, you do have to prevent registering the reset controller when
> running on RZ/A2 (based on cpg_mssr_info.stbyctrl or some other indicator).
OK. Since the reset controller registration is the last thing done
cpg_mssr_pro
Hi Chris,
On Tue, Aug 28, 2018 at 7:18 PM Chris Brandt wrote:
> Since my config for RZ/A2 does not set CONFIG_RESET_CONTROLLER, none of
> the reset code is built and cpg_mssr_reset_controller_register() just
> ends up being an empty function.
Let's try shmobile_defconfig instead :-)
Seriously,
Hi Geert,
Since my config for RZ/A2 does not set CONFIG_RESET_CONTROLLER, none of
the reset code is built and cpg_mssr_reset_controller_register() just
ends up being an empty function.
So basically my only change at this point is to make DTS and the module
clock table use "36" instead of "306"
> void watchdog_set_nowayout(struct watchdog_device *wdd, struct driver
> *drv, bool nowayout)
>
> I'd think this would work from a layering perspective.
No, this is also bogus. probe() works per device, and
.suppress_bind_attrs works per driver. We need to tackle this i
Replace the hardcoded clock indices by R9A06G032_CLK_* symbols.
Signed-off-by: Geert Uytterhoeven
---
arch/arm/boot/dts/r9a06g032.dtsi | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
index afe29c95a006
Refresh the defconfig for Renesas ARM boards:
- Move options that have moved,
- Remove CONFIG_HAVE_ARM_ARCH_TIMER (auto-enabled),
- Remove ENABLE_WARN_DEPRECATED (removed).
Signed-off-by: Geert Uytterhoeven
---
arch/arm/configs/shmobile_defconfig | 4 +---
1 file changed, 1 insertion(+), 3
Enable support for the CryptoCell core present in some R-Car Gen3 SoCs,
which allows to offload crypto operations.
Signed-off-by: Geert Uytterhoeven
---
arch/arm64/configs/renesas_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/renesas_defconfig
b/arch/arm64/con
Refresh the defconfig for Renesas R-Car Gen3 boards:
- Move options that have moved,
- Remove CONFIG_PCIE_DW_PLAT_HOST (auto-disabled),
- Remove CONFIG_DEBUG_FS (auto-enabled).
Signed-off-by: Geert Uytterhoeven
---
arch/arm64/configs/renesas_defconfig | 40 +---
1 f
Hi Guenter,
> > - if (nowayout)
> > + if (nowayout) {
> > set_bit(WDOG_NO_WAY_OUT, &wdd->status);
> > + wdd->parent->driver->suppress_bind_attrs = true;
>
> That makes sense to me. We can not assume that wdd->parent is set, so it
> won't work as-is.
Good point!
> Not
To preserve alphabetical sort order.
Fixes: 4edac426aff11a37 ("arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI
support")
Signed-off-by: Geert Uytterhoeven
---
.../arm64/boot/dts/renesas/r8a77980-v3hsk.dts | 24 +--
1 file changed, 12 insertions(+), 12 deletions(-)
diff --gi
To preserve alphabetical sort order.
Fixes: 4c529600eef0a6b7 ("arm64: dts: renesas: r8a77965: Add R-Car Gen3 thermal
support")
Signed-off-by: Geert Uytterhoeven
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arc
usb2_phy1 accidentally uses the same clock/reset as usb2_phy0.
Fixes: b5857630a829a8d5 ("arm64: dts: renesas: r8a77965: add usb2_phy nodes")
Signed-off-by: Geert Uytterhoeven
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arc
Signed-off-by: Geert Uytterhoeven
---
arch/arm64/boot/dts/renesas/r8a774a1.dtsi| 4 +-
arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi | 16 +++
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 48 ++--
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 48 ++--
ar
On 08/28/2018 03:29 AM, Wolfram Sang wrote:
With NOWAYOUT, prevent bind/unbind possibilities in SYSFS.
Proof-of-concept, not for upstream yet.
Signed-off-by: Wolfram Sang
---
So, this is really an RFC to check if something like this is considered useful
or not. If so, we probably need to do it
On 08/28/2018 03:13 AM, Wolfram Sang wrote:
We want to go into a sane state when unregistering. Currently, it
happens that the watchdog stops when unbinding because of RuntimePM
stopping the core clock. When rebinding, the core clock gets reactivated
and the watchdog fires even though it hasn't b
On 08/28/2018 03:13 AM, Wolfram Sang wrote:
watchdog_stop() calls watchdog_update_worker() which needs a valid
wdd->wd_data pointer. So, when unregistering the cdev, clear the
pointers after we call watchdog_stop(), not before.
Fixes: bb292ac1c602 ("watchdog: Introduce watchdog_stop_on_unregiste
Should be "renesas,usbhs-r8a77965", not "renesas,usbhs-r8a7796".
Fixes: a06e8af801760a98 ("arm64: dts: renesas: r8a77965: add HS-USB node")
Signed-off-by: Geert Uytterhoeven
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm
On Fri, Aug 24, 2018 at 11:43:49AM +0100, Biju Das wrote:
> Add usb3.0 phy, host and function device nodes on RZ/G2M SoC dtsi.
>
> Signed-off-by: Biju Das
> Reviewed-by: Fabrizio Castro
Thanks,
This looks fine to me but I will wait to see if there are other reviews
before applying.
Reviewed-b
I have pushed renesas-drivers-2018-08-28-v4.19-rc1 to
https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git
This tree is meant to ease development of platform support and drivers
for Renesas ARM SoCs. It is created by merging (a) the for-next branches
of various subsystem trees an
On Fri, Aug 24, 2018 at 11:43:48AM +0100, Biju Das wrote:
> Add usb dmac and hsusb device nodes on RZ/G2M SoC dtsi.
>
> Signed-off-by: Biju Das
> Reviewed-by: Fabrizio Castro
Thanks,
This looks fine to me but I will wait to see if there are other reviews
before applying.
Reviewed-by: Simon Ho
On Fri, Aug 24, 2018 at 11:43:47AM +0100, Biju Das wrote:
> Add USB2.0 phy and host (EHCI/OHCI) device nodes on RZ/G2M SoC dtsi.
>
> Signed-off-by: Biju Das
> Reviewed-by: Fabrizio Castro
Reviewed-by: Simon Horman
On Fri, Aug 24, 2018 at 09:06:49AM +, Fabrizio Castro wrote:
> Hello Simon,
>
> Thank you for your feedback!
>
> > Subject: Re: [PATCH 4/5] arm64: dts: renesas: r8a774a1: Add Ethernet AVB
> > node
> >
> > On Thu, Aug 23, 2018 at 09:58:50AM +0100, Biju Das wrote:
> > > From: Fabrizio Castro
Hi Sergei, Laurent, Kieran,
On Wed, Jun 13, 2018 at 10:11 PM Sergei Shtylyov
wrote:
> Describe the interconnected FCPVD0, VSPD0, DU, and LVDS0 devices in the
> R8A77980 device tree...
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov
> Signed-of
Hi,
This is intended as a submission to LTSI-4.14. It is the backport
of a fix for the R-Car I2C driver, and its dependency, both of which
are present in linux-next 20180821.
This pull-request is based on
"[GIT PULL LTSI-4.14] Renesas SoCs and Drivers to v4.18-rc8",
tagged as backport/v4.14.61/sn
This patch adds DU pins, groups and function for the R8A77990 (E3) SoC.
Signed-off-by: Laurent Pinchart
---
Changes since v1:
- Add DU_CLKIN0
---
drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 110 ++
1 file changed, 110 insertions(+)
diff --git a/drivers/pinctrl/sh-pf
Hi Geert,
On Tuesday, 28 August 2018 11:41:00 EEST Geert Uytterhoeven wrote:
> On Thu, Aug 23, 2018 at 9:09 AM Laurent Pinchart wrote:
> > This patch adds DU pins, groups and function for the R8A77990 (E3) SoC.
> >
> > Signed-off-by: Laurent Pinchart
> >
>
> Thanks for your patch!
>
> > --- a/
Hi Niklas,
On Monday, 27 August 2018 16:23:45 EEST Niklas Söderlund wrote:
> On 2018-08-27 11:49:56 +0200, Jacopo Mondi wrote:
> > On Sat, Aug 25, 2018 at 03:18:06PM +0200, jacopo mondi wrote:
> >> On Sat, Aug 25, 2018 at 08:37:15AM +0200, Niklas Söderlund wrote:
> >>> On 2018-08-25 02:54:44 +0300
With NOWAYOUT, prevent bind/unbind possibilities in SYSFS.
Proof-of-concept, not for upstream yet.
Signed-off-by: Wolfram Sang
---
So, this is really an RFC to check if something like this is considered useful
or not. If so, we probably need to do it differently because modifying the
parent's dr
I wanted to activate 'stop_on_unregister' for the Renesas R-Car driver (see
patch 2) and stumbled over an OOPS when using it. So, patch 1 addresses this
problem to the best of my knowledge. Looking forward to comments.
Happy hacking,
Wolfram
Wolfram Sang (2):
watchdog: core: fix null point
We want to go into a sane state when unregistering. Currently, it
happens that the watchdog stops when unbinding because of RuntimePM
stopping the core clock. When rebinding, the core clock gets reactivated
and the watchdog fires even though it hasn't been opened by userspace
yet. Strange scenario,
watchdog_stop() calls watchdog_update_worker() which needs a valid
wdd->wd_data pointer. So, when unregistering the cdev, clear the
pointers after we call watchdog_stop(), not before.
Fixes: bb292ac1c602 ("watchdog: Introduce watchdog_stop_on_unregister helper")
Signed-off-by: Wolfram Sang
---
d
Hi Simon,
On Monday, 27 August 2018 15:57:05 EEST Simon Horman wrote:
> On Fri, Aug 24, 2018 at 11:45:52AM +0300, Laurent Pinchart wrote:
> > On Friday, 24 August 2018 07:52:28 EEST Nguyen An Hoan wrote:
> > > From: Hoan Nguyen An
> >
> > You're missing a commit message. I agree that for simple
Hi Hoan,
On Fri, Aug 24, 2018 at 6:52 AM Nguyen An Hoan wrote:
> From: Hoan Nguyen An
>
> Signed-off-by: Hoan Nguyen An
Thanks for your patch!
> --- a/drivers/clk/renesas/r8a77965-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a77965-cpg-mssr.c
> @@ -112,6 +112,7 @@ static const struct cpg_core_clk
Hi Sergei,
On Tue, Aug 21, 2018 at 6:41 PM Sergei Shtylyov
wrote:
> On R-Car V3M (AKA R8A77970), the SD0CKCR is laid out differently than on
> the other R-Car gen3 SoCs. In fact, the layout is the same as on R-Car gen2
> SoCs, so we'll need to copy the divisor tables from the R-Car gen2 driver.
>
Hi Geert,
On Tue, Aug 28, 2018 at 09:46:57AM +0200, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Mon, Aug 20, 2018 at 12:17 PM Jacopo Mondi
> wrote:
> > From: Takeshi Kihara
> >
> > This patch adds VIN{4,5} pins, groups and functions to the R8A77990 SoC.
> >
> > Signed-off-by: Takeshi Kihara
Hi Laurent,
On Thu, Aug 23, 2018 at 9:09 AM Laurent Pinchart
wrote:
> This patch adds DU pins, groups and function for the R8A77990 (E3) SoC.
>
> Signed-off-by: Laurent Pinchart
Thanks for your patch!
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
>
Hi Uli,
On Fri, Aug 17, 2018 at 3:19 PM Ulrich Hecht wrote:
> From: Takeshi Kihara
>
> This patch adds I2C{0,3,5} pins, groups and functions to the R8A7795 SoC.
>
> These pins are physically muxed with other pins. Therefore, setup of
> MOD_SEL is needed for exclusive control with other pins.
>
>
On 27 August 2018 at 17:13, Niklas Söderlund
wrote:
> From: Masaharu Hayakawa
>
> Checking for SCC error during retuning is unnecessary.
>
> Signed-off-by: Masaharu Hayakawa
> [Niklas: fix small style issue]
> Signed-off-by: Niklas Söderlund
>
> ---
>
> * Changes since v2
> - Add comment to des
Hi Jacopo,
On Mon, Aug 20, 2018 at 12:17 PM Jacopo Mondi wrote:
> From: Takeshi Kihara
>
> This patch adds VIN{4,5} pins, groups and functions to the R8A77990 SoC.
>
> Signed-off-by: Takeshi Kihara
> Signed-off-by: Jacopo Mondi
Thanks for your patch!
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a779
On Tue, Aug 28, 2018 at 6:37 AM Nguyen An Hoan wrote:
> From: Hoan Nguyen An
>
> Add Audio SSI pin support for r8a77965
>
> Signed-off-by: Hoan Nguyen An
Reviewed-by: Geert Uytterhoeven
i.e. will queue in sh-pfc-for-v4.20.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoe
Hi Hoan,
On Tue, Aug 28, 2018 at 6:37 AM Nguyen An Hoan wrote:
> From: Hoan Nguyen An
>
> Add Audio clock pin support for r8a77965
>
> Signed-off-by: Hoan Nguyen An
Thanks for the update!
Reviewed-by: Geert Uytterhoeven
i.e. will queue in sh-pfc-for-v4.20.
Gr{oetje,eeting}s,
Hi Chris,
On Tue, Aug 28, 2018 at 12:13 AM Chris Brandt wrote:
> On Monday, August 27, 2018 1, Geert Uytterhoeven wrote:
> > Given the differences, and the limited amount of RAM on RZ/A2, I think you
> > would be better off with a separate renesas-cpg-stbcr driver, and an
> > r7s9210-cpg-stbcr co
52 matches
Mail list logo
