Re: [PATCH] mmc: tmio: simplify the DMA mode test

2018-10-14 Thread Wolfram Sang
On Sat, Oct 13, 2018 at 12:03:08AM +0900, Masahiro Yamada wrote: > host->chan_{rx,tx} represents the DMA capability of the platform. > Even if DMA is supported, there are cases where we want to use PIO, > for example, data length is short enough as commit 5f52c3552946 > ("mmc: tmio: use PIO for sho

Re: [PATCH v3 0/2] mmc: tmio: remove confusing TMIO_MMC_HAVE_HIGH_REG flag

2018-10-14 Thread Wolfram Sang
On Wed, Oct 10, 2018 at 12:51:30PM +0900, Masahiro Yamada wrote: > CTL_SDIO_REGS is a register specific to tmio_mmc.c > > Currently, we handle it in tmio_mmc_core.c, hence need > TMIO_MMC_HAVE_HIGH_REG flag to prevent the other platforms > from accessing to it. > > We can just move CTL_SDIO_REGS

Re: [PATCH v3 2/2] mmc: tmio: remove TMIO_MMC_HAVE_HIGH_REG flag

2018-10-14 Thread Wolfram Sang
On Wed, Oct 10, 2018 at 12:51:32PM +0900, Masahiro Yamada wrote: > TMIO_MMC_HAVE_HIGH_REG is confusing due to its counter-intuitive name. > > All the TMIO MMC variants (TMIO MMC, Renesas SDHI, UniPhier SD) actually > have high registers. It is just that each of them implements its own > registers

Re: [PATCH v3 1/2] mmc: tmio: move MFD variant reset to a platform hook

2018-10-14 Thread Wolfram Sang
On Wed, Oct 10, 2018 at 12:51:31PM +0900, Masahiro Yamada wrote: > CTL_RESET_SDIO register is specific to the TMIO MFD (tmio_mmc.c). > > Add a new hook host->reset() for performing a platform-specific > reset sequence, and move CTL_RESET_SDIO over there. > > Signed-off-by: Masahiro Yamada Revie

Re: [PATCH] mmc: renesas_sdhi: rename DTRAN_MODE_BUS_WID_TH to DTRAN_MODE_BUS_WIDTH

2018-10-14 Thread Wolfram Sang
On Wed, Oct 03, 2018 at 08:39:40PM +0900, Masahiro Yamada wrote: > Socionext UniPhier SoCs use the almost the same internal DMAC. > My datasheet says 'BUS_WIDTH' instead of 'BUS_WID_TH'. I suspect > this is a typo. > > Signed-off-by: Masahiro Yamada Already fixed in mmc/next. signature.asc D

Re: [PATCH] serial: sh-sci: do not warn if DMA transfers are not supported

2018-10-14 Thread Wolfram Sang
On Fri, Oct 12, 2018 at 03:47:49PM +0200, Ulrich Hecht wrote: > Not all (H)SCIF devices support DMA, and failure to set it up is not > normally a cause for concern. This patch demotes the associated warning to > debug output. > > Inspired by BSP patch "sci: sh-sci: Fix transfer sequence of unsuppo