[PATCH] serial: sh-sci: Fix could not remove dev_attr_rx_fifo_timeout

2018-10-29 Thread Yoshihiro Shimoda
This patch fixes an issue that the sci_remove() could not remove dev_attr_rx_fifo_timeout because uart_remove_one_port() set the port->port.type to PORT_UNKNOWN. Reported-by: Hiromitsu Yamasaki Fixes: 5d23188a473d ("serial: sh-sci: make RX FIFO parameters tunable via sysfs") Cc: # v4.11+ Signed

Re: [PATCH 1/2] pinctrl: sh-pfc: Introduce VIN_DATA_PIN_GROUP_VER

2018-10-29 Thread Ulrich Hecht
> On October 29, 2018 at 7:13 PM Jacopo Mondi wrote: > > > VIN data groups may appear on different sets of pins, usually named > "vinX_data_[a|b]". The existing VIN_DATA_PIN_GROUP() does not support > appending > the 'a' or 'b' suffix, leading to the definition of groups names not > consiste

Re: [PATCH 2/2] pinctrl: sh-pfc: r8a77965: Add VIN[4|5] groups/functions

2018-10-29 Thread Ulrich Hecht
Thank you for your patch. > On October 29, 2018 at 7:13 PM Jacopo Mondi wrote: > > > The VIN4 and VIN5 interfaces supports parallel video input. > Add pin, mux and functions definitions for VIN4 and VIN5 for R-Car M3-N. > > Signed-off-by: Jacopo Mondi > --- > drivers/pinctrl/sh-pfc/pfc-r8a77

Re: [PATCH linux-next v1 1/4] clk: renesas: clk-avb: add AVB Clock driver

2018-10-29 Thread Stephen Boyd
Quoting jiada_w...@mentor.com (2018-10-25 00:23:46) > diff --git a/drivers/clk/renesas/Makefile b/drivers/clk/renesas/Makefile > index 71d4cafe15c0..17b05955e4f4 100644 > --- a/drivers/clk/renesas/Makefile > +++ b/drivers/clk/renesas/Makefile > @@ -34,3 +34,4 @@ obj-$(CONFIG_CLK_RCAR_USB2_CLOCK_SEL

Re: [PATCH linux-next v1 2/4] clk: renesas: Add binding document for AVB Counter Clock

2018-10-29 Thread Stephen Boyd
Quoting jiada_w...@mentor.com (2018-10-25 00:23:47) > From: Jiada Wang > > Add device tree bindings for avb counter clock for Renesas > R-Car Socs. > > Signed-off-by: Jiada Wang > --- > .../bindings/clock/renesas,avb-clk.txt| 19 +++ > 1 file changed, 19 insertions(+) >

[PATCH 1/2] pinctrl: sh-pfc: Introduce VIN_DATA_PIN_GROUP_VER

2018-10-29 Thread Jacopo Mondi
VIN data groups may appear on different sets of pins, usually named "vinX_data_[a|b]". The existing VIN_DATA_PIN_GROUP() does not support appending the 'a' or 'b' suffix, leading to the definition of groups names not consistent with the ones defined using SH_PFC_PIN_GROUP() macro. Fix this by addi

[PATCH 2/2] pinctrl: sh-pfc: r8a77965: Add VIN[4|5] groups/functions

2018-10-29 Thread Jacopo Mondi
The VIN4 and VIN5 interfaces supports parallel video input. Add pin, mux and functions definitions for VIN4 and VIN5 for R-Car M3-N. Signed-off-by: Jacopo Mondi --- drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 254 ++ 1 file changed, 254 insertions(+) diff --git a/dri

[PATCH 0/2] pinctrl: sh-pfc: r8a77965: Add VIN4 and VIN5

2018-10-29 Thread Jacopo Mondi
Hello, this two patches add supports for VIN4 and VIN5 interfaces to R-Car M3-N. On this SoC (and in the forthcoming support for E3 R8A77990) the VIN groups could appear on different sets of pins, usually the 'a' and 'b' one. With the existing VIN_DATA_PIN_GROUP macro we have to specify group

Re: [PATCH 2/2] ARM: dts: r8a77470: Add USB-DMAC device nodes

2018-10-29 Thread Simon Horman
On Fri, Oct 26, 2018 at 09:47:09AM +, Fabrizio Castro wrote: > > Subject: [PATCH 2/2] ARM: dts: r8a77470: Add USB-DMAC device nodes > > > > This patch adds USB DMAC nodes. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro Thanks, applied for v4.21.

Re: [PATCH 1/2] dt-bindings: dmaengine: usb-dmac: Add binding for r8a77470

2018-10-29 Thread Simon Horman
On Thu, Oct 25, 2018 at 03:53:37PM +0100, Biju Das wrote: > This patch adds usb high-speed dmac binding for r8a77470 (RZ/G1C) SoC. > > Signed-off-by: Biju Das Reviewed-by: Simon Horman

Re: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support

2018-10-29 Thread Simon Horman
On Fri, Oct 26, 2018 at 09:42:40AM +, Fabrizio Castro wrote: > > Subject: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support > > > > This patch enables watchdog support on the iWave iwg23s sbc. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro Thanks, applied for v4.21

Re: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi

2018-10-29 Thread Simon Horman
On Fri, Oct 26, 2018 at 09:42:38AM +, Fabrizio Castro wrote: > > Subject: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi > > > > This patch adds watchdog support to the r8a77470 SoC dtsi. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro Thanks, applied for

Re: [PATCH v3] arm64: dts: renesas: add/enable USB2.0 peripheral for R-Car [DE]3

2018-10-29 Thread Simon Horman
On Wed, Oct 24, 2018 at 05:32:33PM +0900, Yoshihiro Shimoda wrote: > This patch adds/enables USB2.0 peripheral for R-Car [DE]3 boards. > > R-Car E3 Ebisu board connects the ID pin to the SoC, so this adds > a group "usb0_id" into usb0_pins node. Also, to use SW15 pin 3 side, > this patch adds vbus

Re: [PATCH 01/03] arm: dts: Include SoC name in DTSI for r8a7740

2018-10-29 Thread Simon Horman
On Mon, Oct 22, 2018 at 03:21:20AM +0900, Magnus Damm wrote: > From: Magnus Damm > > Update the R-Mobile A1 DTSI to include product name. > > Signed-off-by: Magnus Damm Thanks, applied for v4.21.

Re: [PATCH 02/03] arm: dts: Include SoC name in DTSI for sh73a0

2018-10-29 Thread Simon Horman
On Mon, Oct 22, 2018 at 03:21:30AM +0900, Magnus Damm wrote: > From: Magnus Damm > > Update the SH-Mobile AG5 DTSI to include product name. > > Signed-off-by: Magnus Damm Thanks, applied for v4.21.

Re: [PATCH 03/03] arm: dts: Include SoC name in DTSI for sh73a0

2018-10-29 Thread Simon Horman
On Mon, Oct 22, 2018 at 11:07:08AM +0300, Sergei Shtylyov wrote: > Hello! > >2 patches with the same name? > > On 21.10.2018 21:21, Magnus Damm wrote: > > > From: Magnus Damm > > > > Update the Emma Mobile EV2 DTSI to include product name. > >Shouldn't this be in the subject instead o

Re: [PATCH] arm64: dts: renesas: salvator-common: add companion property in usb3_peri0

2018-10-29 Thread Simon Horman
On Mon, Oct 22, 2018 at 03:47:29PM +0900, Yoshihiro Shimoda wrote: > This patch adds a property "companion" with xhci0 phandle to > the usb3_peri0 node in salvator-common.dtsi. > > About the detail of this property for renesas_usb3 udc driver, please > refer to the commit 39facfa01c9f ("usb: gadge

Re: [PATCH 02/03] arm64: dts: renesas: r8a77980: Connect R-Car V3H AVB to IPMMU

2018-10-29 Thread Simon Horman
On Mon, Oct 22, 2018 at 02:14:54AM +0900, Magnus Damm wrote: > From: Magnus Damm > > Hook up the R-Car V3H AVB device to IPMMU-DS1 33 as described in > the data sheet. > > Signed-off-by: Magnus Damm Thanks Magnus, applied for v4.21.

Re: [PATCH 01/03] arm64: dts: renesas: r8a77965: Connect R-Car M3-N AVB to IPMMU

2018-10-29 Thread Simon Horman
On Mon, Oct 22, 2018 at 02:14:44AM +0900, Magnus Damm wrote: > From: Magnus Damm > > Hook up the R-Car M3-N AVB device to IPMMU-DS0 16 as described in > the data sheet. > > Signed-off-by: Magnus Damm Tested-by: Simon Horman I will apply this for v4.21. > --- > > arch/arm64/boot/dts/renes

Re: [PATCH 03/03] arm64: dts: renesas: r8a77990: Connect R-Car E3 AVB to IPMMU

2018-10-29 Thread Simon Horman
On Mon, Oct 22, 2018 at 02:15:03AM +0900, Magnus Damm wrote: > From: Magnus Damm > > Hook up the R-Car E3 AVB device to IPMMU-DS0 16 as described in > the data sheet. > > Signed-off-by: Magnus Damm Tested-by: Simon Horman I will apply this for v4.21. > --- > > arch/arm64/boot/dts/renesas/

Re: [PATCH 5/5] pinctrl: pinctrl-at91-pio4: simplify getting .driver_data

2018-10-29 Thread Ludovic Desroches
On Sun, Oct 21, 2018 at 10:00:31PM +0200, Wolfram Sang wrote: > We should get 'driver_data' from 'struct device' directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Acked-by: Ludovic Desroches Thanks > --- > > Build tested only. buildbot i

Re: [PATCH] arm64: dts: renesas: r8a77990: add/enable USB3.0 peripheral device node

2018-10-29 Thread Simon Horman
On Mon, Oct 22, 2018 at 03:47:08PM +0900, Yoshihiro Shimoda wrote: > This patch adds/enables USB3.0 peripheral device node for r8a77990 > ebisu board. > > Signed-off-by: Yoshihiro Shimoda Thanks Shimoda-san, applied for v4.21.

Re: [PATCH linux-next v1 2/4] clk: renesas: Add binding document for AVB Counter Clock

2018-10-29 Thread Rob Herring
On Thu, Oct 25, 2018 at 9:32 PM Jiada Wang wrote: > > Hi Rob > > > On 2018/10/26 6:49, Rob Herring wrote: > > On Thu, Oct 25, 2018 at 04:23:47PM +0900, jiada_w...@mentor.com wrote: > >> From: Jiada Wang > >> > >> Add device tree bindings for avb counter clock for Renesas > >> R-Car Socs. > >> > >

RE: [PATCH 3/7] ARM: dts: r8a77470: Add USB PHY DT support

2018-10-29 Thread Biju Das
HI Shimoda-San, Thanks for the feedback. > Subject: RE: [PATCH 3/7] ARM: dts: r8a77470: Add USB PHY DT support > > Hi Biju-san, > > > From: Biju Das, Sent: Monday, October 29, 2018 6:15 PM > > > -Original Message- > > > From: Yoshihiro Shimoda > > > Sent: 29 October 2018 08:42 > > > > > >

RE: [PATCH 3/7] ARM: dts: r8a77470: Add USB PHY DT support

2018-10-29 Thread Yoshihiro Shimoda
Hi Biju-san, > From: Biju Das, Sent: Monday, October 29, 2018 6:15 PM > > -Original Message- > > From: Yoshihiro Shimoda > > Sent: 29 October 2018 08:42 > > > > Hi Biju-san, > > > > > From: Biju Das, Sent: Thursday, October 25, 2018 10:57 PM > > > > > > Define the r8a77470 generic part of

Re: [PATCH/RFT] arm64: dts: renesas: r8a77990: Add SCIF-{0,1,3,4,5} device nodes

2018-10-29 Thread Simon Horman
On Sun, Oct 21, 2018 at 06:30:00AM +0900, Yoshihiro Kaneko wrote: > From: Takeshi Kihara > > This patch adds the device nodes for SCIF-{0,1,3,4,5} serial ports to > the R8A77990 SoC. > > Signed-off-by: Takeshi Kihara > Signed-off-by: Yoshihiro Kaneko Thanks. I don't believe this can (easily)

Re: [PATCH v2] arm64: dts: renesas: r8a779{7|8}0: add MSIOF support

2018-10-29 Thread Simon Horman
On Fri, Oct 19, 2018 at 10:10:44PM +0300, Sergei Shtylyov wrote: > Describe MSIOF in the R8A779{7|8}0 device trees. > > The DMA props are omitted for R8A77980 as the RT-DMAC isn't supported > (yet?)... > > Based on the original (and large) patches by Vladimir Barinov. > > Signed-off-by: Vladimir

Re: [PATCH] arm64: renesas_defconfig: Enable R-Car thermal driver

2018-10-29 Thread Simon Horman
On Wed, Oct 17, 2018 at 12:07:22PM +0200, Simon Horman wrote: > Enable the R-Car thermal driver. > > This driver is used in conjunction with the R-Car V3M (r8a77970), > E3 (r8a77990) and D3 (r8a77995) SoCs. > > Signed-off-by: Simon Horman > --- > N.B: This is targeted at the devel branch of the

Re: [PATCH] arm64: defconfig: Enable R-Car thermal driver

2018-10-29 Thread Simon Horman
On Wed, Oct 17, 2018 at 12:07:18PM +0200, Simon Horman wrote: > Enable the R-Car thermal driver as a module. > > This driver is used in conjunction with the R-Car V3M (r8a77970), > E3 (r8a77990) and D3 (r8a77995) SoCs. > > Signed-off-by: Simon Horman Applied for v4.21. > --- > arch/arm64/conf

RE: [PATCH 2/7] phy: renesas: phy-rcar-gen2: Add support for r8a77470

2018-10-29 Thread Biju Das
Hi Shimoda-San, Thanks for the feedback. > Subject: RE: [PATCH 2/7] phy: renesas: phy-rcar-gen2: Add support for > r8a77470 > > Hi Biju-san, > > > From: Biju Das, Sent: Thursday, October 25, 2018 10:57 PM > > > > This patch adds support for RZ/G1C (r8a77470) SoC. RZ/G1C SoC has a > > PLL register

RE: [PATCH 3/7] ARM: dts: r8a77470: Add USB PHY DT support

2018-10-29 Thread Biju Das
Hi Shimoda-San, Thanks for the feedback. Regards, Biju > -Original Message- > From: Yoshihiro Shimoda > Sent: 29 October 2018 08:42 > To: Biju Das ; Rob Herring > ; Mark Rutland > Cc: Biju Das ; Simon Horman > ; Magnus Damm ; > linux-renesas-soc@vger.kernel.org; devicet...@vger.kernel.o

Re: [PATCH 2/2] arm64: dts: renesas: salvator: Switch eMMC bus to 1V8

2018-10-29 Thread Wolfram Sang
> > <&sdhi2_pins>;". So, basically the same phandles for both pinctrls. We > > can re-add the second one when we need it. > > I wonder if removing the sdhi2_pins_uhs is what we want to do, given > that we might need to adjust TDSEL or pull resistor configurations for > the HS200/HS400 modes in th

RE: [PATCH 2/7] phy: renesas: phy-rcar-gen2: Add support for r8a77470

2018-10-29 Thread Yoshihiro Shimoda
Hi Biju-san, > From: Biju Das, Sent: Thursday, October 25, 2018 10:57 PM > > This patch adds support for RZ/G1C (r8a77470) SoC. RZ/G1C SoC has a > PLL register shared between hsusb0 and hsusb1. Compared to other RZ/G1 > and R-Car Gen2/3, USB Host needs to deassert the pll reset. > > Signed-off-b

RE: [PATCH 3/7] ARM: dts: r8a77470: Add USB PHY DT support

2018-10-29 Thread Yoshihiro Shimoda
Hi Biju-san, > From: Biju Das, Sent: Thursday, October 25, 2018 10:57 PM > > Define the r8a77470 generic part of the USB PHY device node. > > Signed-off-by: Biju Das > --- > This patch is tested against renesas-devel Thank you for the patch! > + usbphy1: usb-phy@e6598100 { > +

Re: [PATCH 2/2] arm64: dts: renesas: salvator: Switch eMMC bus to 1V8

2018-10-29 Thread Marek Vasut
On 10/28/2018 10:34 PM, Wolfram Sang wrote: > Hi Marek, Hi, > On Sat, Oct 27, 2018 at 06:34:10PM +0200, Marek Vasut wrote: >> The eMMC card has two supplies, VCC and VCCQ. The VCC supplies the NAND >> array and the VCCQ supplies the bus. On this particular board, the VCC is >> connected to 3.3V r