Re: [PATCH v2 1/4] pinctrl: sh-pfc: Add physical pin multiplexing helper macros

2018-11-16 Thread Ulrich Hecht
> On November 16, 2018 at 9:42 AM Geert Uytterhoeven > wrote: > > > Hi Uli, > > On Fri, Nov 16, 2018 at 8:21 AM Ulrich Hecht wrote: > > Used by I2C controllers 0, 3 and 5 in R8A7795 and R8A7796 SoCs. > > > > Signed-off-by: Ulrich Hecht > > Thanks for your patch! > > Reviewed-by: Geert

RE: [PATCH v6 1/2] pinctrl: Add RZ/A2 pin and gpio controller

2018-11-16 Thread Chris Brandt
Hi Geert, On Friday, November 16, 2018, Geert Uytterhoeven wrote: > > We can have Geert give his opinion on the topic since it was his > > suggestion to begin with. > > > > > > > I'm sorry this is more work, and again, it might be post-poned imo, > > > provided you drop this change you have

Re: [PATCH] arm64: defconfig: Enable CONFIG_PHY_RCAR_GEN3_PCIE

2018-11-16 Thread Simon Horman
On Thu, Nov 15, 2018 at 03:47:10PM +0100, Marek Vasut wrote: > On 11/15/2018 03:33 PM, Simon Horman wrote: > > On Wed, Nov 14, 2018 at 04:32:05PM +0100, Marek Vasut wrote: > >> On 11/13/2018 04:22 PM, Geert Uytterhoeven wrote: > >>> Enable R-Car Gen3 PCIe PHY support, which is needed for PCIe to

Re: [PATCH v2 2/2] ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/

2018-11-16 Thread Simon Horman
On Fri, Nov 16, 2018 at 02:48:42PM +0100, Geert Uytterhoeven wrote: > For consistency with arm64, where vendors have a single Kconfig symbol > in arch/arm64/Kconfig.platforms. > > Signed-off-by: Geert Uytterhoeven Thanks Geert, applied for v4.21.

Re: [PATCH v2 1/2] arm64: renesas: Move SoC Kconfig symbols to drivers/soc/renesas/

2018-11-16 Thread Simon Horman
On Fri, Nov 16, 2018 at 02:48:41PM +0100, Geert Uytterhoeven wrote: > arch/arm64/Kconfig.platforms has SoC-specific Kconfig symbols for > Renesas SoCs, while other vendors have only a single Kconfig symbol. > > Increase consistency with other vendors by moving the SoC-specific > Kconfig symbols

Re: [PATCH] ARM: shmobile: Hide ARCH_RZN1 to improve consistency

2018-11-16 Thread Simon Horman
On Fri, Nov 16, 2018 at 02:38:03PM +0100, Geert Uytterhoeven wrote: > Unlike all other family-specific Kconfig symbols for Renesas ARM SoCs, > ARCH_RZN1 is user-visible. As this symbol is already selected by the > SoC-specific ARCH_R9A06G032 symbol, there is no need for that. > > Hide ARCH_RZN1

[PATCH v2 1/2] arm64: renesas: Move SoC Kconfig symbols to drivers/soc/renesas/

2018-11-16 Thread Geert Uytterhoeven
arch/arm64/Kconfig.platforms has SoC-specific Kconfig symbols for Renesas SoCs, while other vendors have only a single Kconfig symbol. Increase consistency with other vendors by moving the SoC-specific Kconfig symbols to drivers/soc/renesas/Kconfig. Increase consistency with R-Car Gen1 and Gen2

[PATCH v2 2/2] ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/

2018-11-16 Thread Geert Uytterhoeven
For consistency with arm64, where vendors have a single Kconfig symbol in arch/arm64/Kconfig.platforms. Signed-off-by: Geert Uytterhoeven --- v2: - Move family-specific Kconfig symbols, too. --- arch/arm/mach-shmobile/Kconfig | 126 drivers/soc/renesas/Kconfig

[PATCH v2 0/2] arm: renesas: Move SoC Kconfig symbols to drivers/soc/renesas/

2018-11-16 Thread Geert Uytterhoeven
Hi all, As pointed out by Arnd[*], there are lots of SoC-specific Kconfig symbols in the Renesas section of arch/arm64/Kconfig.platforms, while other vendors expose a single Kconfig symbol there. Hence this patch series moves them to drivers/soc/renesas/Kconfig, reducing the footprint

[PATCH] ARM: shmobile: Hide ARCH_RZN1 to improve consistency

2018-11-16 Thread Geert Uytterhoeven
Unlike all other family-specific Kconfig symbols for Renesas ARM SoCs, ARCH_RZN1 is user-visible. As this symbol is already selected by the SoC-specific ARCH_R9A06G032 symbol, there is no need for that. Hide ARCH_RZN1 from the user, and move it up, where all other family-specific Kconfig symbols

Re: [PATCH v6 1/2] pinctrl: Add RZ/A2 pin and gpio controller

2018-11-16 Thread Geert Uytterhoeven
Hi Chris, On Thu, Nov 15, 2018 at 5:50 PM Chris Brandt wrote: > On Thursday, November 15, 2018 1, jacopo mondi wrote: > > > v5: > > > * Specify number of ports using of_device_id.data and save as priv- > > >npins > > > * Use priv->npins everywhere instead of hard coded RZA2_NPINS > > > *

Re: [PATCH v7 1/2] pinctrl: Add RZ/A2 pin and gpio controller

2018-11-16 Thread Geert Uytterhoeven
On Thu, Nov 15, 2018 at 5:15 PM Chris Brandt wrote: > Adds support for the pin and gpio controller found in R7S9210 (RZ/A2) SoCs. > > Signed-off-by: Chris Brandt > Reviewed-by: Jacopo Mondi > --- > v6: > * Bug fix: Output value not being set in rza2_chip_direction_output() Reviewed-by: Geert

Re: [PATCH/RFT v2] pinctrl: sh-pfc: r8a77990: Add HSCIF pins, groups, and functions

2018-11-16 Thread Geert Uytterhoeven
Hi Kaneko-san, On Thu, Nov 15, 2018 at 5:47 PM Yoshihiro Kaneko wrote: > From: Takeshi Kihara > > This patch adds HSCIF{0,1,2,3,4} pins, groups and functions to > the R8A77990 SoC. > > Signed-off-by: Takeshi Kihara > Signed-off-by: Yoshihiro Kaneko > --- > > This patch is based on the sh-pfc

Re: [PATCH v2 1/4] pinctrl: sh-pfc: Add physical pin multiplexing helper macros

2018-11-16 Thread Geert Uytterhoeven
Hi Uli, On Fri, Nov 16, 2018 at 8:21 AM Ulrich Hecht wrote: > Used by I2C controllers 0, 3 and 5 in R8A7795 and R8A7796 SoCs. > > Signed-off-by: Ulrich Hecht Thanks for your patch! Reviewed-by: Geert Uytterhoeven Some bikeshedding below, which I believe would increase readability. > ---

Re: [PATCH v2 4/4] pinctrl: sh-pfc: r8a7796: Add I2C{0,3,5} pins, groups and functions

2018-11-16 Thread Geert Uytterhoeven
On Fri, Nov 16, 2018 at 8:21 AM Ulrich Hecht wrote: > From: Takeshi Kihara > > This patch adds I2C{0,3,5} pins, groups and functions to the R8A7796 SoC. > > These pins are physically muxed with other pins. Therefore, setup of > MOD_SEL is needed for exclusive control with other pins. > >

Re: [PATCH v2 3/4] pinctrl: sh-pfc: r8a7795-es1: Add I2C{0,3,5} pins, groups and functions

2018-11-16 Thread Geert Uytterhoeven
On Fri, Nov 16, 2018 at 8:21 AM Ulrich Hecht wrote: > From: Takeshi Kihara > > This patch adds I2C{0,3,5} pins, groups and functions to > the R8A7795 ES1.x SoC. > > These pins are physically muxed with other pins. Therefore, setup of > MOD_SEL is needed for exclusive control with other pins. > >

Re: [PATCH v2 2/4] pinctrl: sh-pfc: r8a7795: Add I2C{0,3,5} pins, groups and functions

2018-11-16 Thread Geert Uytterhoeven
On Fri, Nov 16, 2018 at 8:21 AM Ulrich Hecht wrote: > From: Takeshi Kihara > > This patch adds I2C{0,3,5} pins, groups and functions to the R8A7795 SoC. > > These pins are physically muxed with other pins. Therefore, setup of > MOD_SEL is needed for exclusive control with other pins. > >

Re: [PATCH v2 0/4] I2C0/3/5 pin control for H3 and M3-W

2018-11-16 Thread Geert Uytterhoeven
Hi Uli, On Fri, Nov 16, 2018 at 8:21 AM Ulrich Hecht wrote: > This is an up-port from the BSP. Unfortunately I could not test these > because none of those pins seem to be accessible on Salvator boards (not on > ULCB either, AFAICT), so the best thing I can say is that they don't seem to > break