Re: [PATCH 4/4] pinctrl: sh-pfc: r8a77990: Add CAN FD pins, groups and functions

2018-11-20 Thread Geert Uytterhoeven
Hi Marek, On Wed, Nov 21, 2018 at 12:33 AM Marek Vasut wrote: > On 11/19/2018 10:47 AM, Geert Uytterhoeven wrote: > > On Mon, Nov 19, 2018 at 10:06 AM Geert Uytterhoeven > > wrote: > >> On Sun, Nov 18, 2018 at 6:29 PM Marek Vasut wrote: > >>> From: Takeshi Kihara > >>> > >>> This patch adds CA

Re: [PATCH 1/2] arm64: dts: renesas: r8a77965: Add CAN controller nodes

2018-11-20 Thread Geert Uytterhoeven
Hi Marek, On Wed, Nov 21, 2018 at 12:33 AM Marek Vasut wrote: > On 11/19/2018 10:00 AM, Geert Uytterhoeven wrote: > > On Mon, Nov 19, 2018 at 12:46 AM Marek Vasut wrote: > >> On 11/19/2018 12:02 AM, Wolfram Sang wrote: > >>> On Sun, Nov 18, 2018 at 06:33:26PM +0100, Marek Vasut wrote: > Fro

[PATCH 2/2] usb: renesas_usbhs: Use SIMPLE_DEV_PM_OPS macro

2018-11-20 Thread Yoshihiro Shimoda
This patch uses SIMPLE_DEV_PM_OPS macro instead of struct dev_pm_ops directly. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/renesas_usbhs/common.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c

[PATCH 1/2] usb: renesas_usbhs: Remove dummy runtime PM callbacks

2018-11-20 Thread Yoshihiro Shimoda
From: Jarkko Nikula Platform drivers don't need dummy runtime PM callbacks that just return success in order to have runtime PM happening. This has changed since following commits: commit 05aa55dddb9e ("PM / Runtime: Lenient generic runtime pm callbacks") commit 543f2503a956 ("PM / platform_bus:

[PATCH 0/2] usb: renesas_usbhs: clean up the code around dev_pm_ops

2018-11-20 Thread Yoshihiro Shimoda
This patch set is based on the Felipe's usb.git / testing/next branch (commit id = 9c5f54eb289b244dc9f5e24f56c9a9373582ef35). The patch 1 comes from the following: https://patchwork.kernel.org/patch/10654679/ Jarkko Nikula (1): usb: renesas_usbhs: Remove dummy runtime PM callbacks Yoshihiro

Re: [RFC PATCH 0/3] mmc: refactor RPMB block count handling

2018-11-20 Thread Wolfram Sang
On Wed, Nov 21, 2018 at 01:31:35AM +0100, Ulf Hansson wrote: > + Avri, Clément (due to recent related discussions) Thanks! > Perhaps we should add a suggested by tag from Clément for patch2, as > he kind of suggested this change already [1]. No strong opinion on that, but technically my inspirat

Re: [PATCH 2/2] dt-binding: spi: Document Renesas R-Car RPC controller bindings

2018-11-20 Thread Marek Vasut
On 11/21/2018 01:53 AM, masonccy...@mxic.com.tw wrote: > Hi Marek, Hi, >> Marek Vasut >> 2018/11/20 下午 08:57 >> >> >> > diff --git a/Documentation/devicetree/bindings/spi/spi-renesas- >> >> rpc.txt b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> >> > new file mode 100644 >> >> > i

[PATCH] arm64: dts: renesas: r8a7796: add SSIU support for sound

2018-11-20 Thread Kuninori Morimoto
From: Kuninori Morimoto rsnd driver supports SSIU now, let's use it. Then, BUSIF DMA settings on rcar_sound,ssi (= rxu, txu) are no longer needed. To avoid git merge timing issue / git bisect issue, this patch doesn't remove it so far, but will be removed in the future. Signed-off-by: Kuninori

Re: [RFC PATCH 0/3] mmc: refactor RPMB block count handling

2018-11-20 Thread Ulf Hansson
+ Avri, Clément (due to recent related discussions) On 21 November 2018 at 00:08, Wolfram Sang wrote: > On Renesas R-Car SDHI hardware, we sometimes had timeouts accessing the RPMB. > This is because AutoCMD23/12 features needs a properly filled sbc to work > correctly. But RPMB sends an individu

Re: [PATCH 2/2] arm64: dts: renesas: r8a77965: Add CAN FD controller node

2018-11-20 Thread Marek Vasut
On 11/19/2018 11:44 AM, Simon Horman wrote: > On Mon, Nov 19, 2018 at 12:29:37AM +0100, Marek Vasut wrote: >> On 11/19/2018 12:10 AM, Wolfram Sang wrote: >>> On Sun, Nov 18, 2018 at 06:33:27PM +0100, Marek Vasut wrote: From: Takeshi Kihara This patch adds CAN FD controller nodes for

Re: [PATCH 4/4] pinctrl: sh-pfc: r8a77990: Add CAN FD pins, groups and functions

2018-11-20 Thread Marek Vasut
On 11/19/2018 10:47 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Mon, Nov 19, 2018 at 10:06 AM Geert Uytterhoeven > wrote: >> On Sun, Nov 18, 2018 at 6:29 PM Marek Vasut wrote: >>> From: Takeshi Kihara >>> >>> This patch adds CAN FD{0,1} pins, groups and functions to the R8A77990 >>> SoC

Re: [PATCH 1/2] arm64: dts: renesas: r8a77965: Add CAN controller nodes

2018-11-20 Thread Marek Vasut
On 11/19/2018 10:00 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Mon, Nov 19, 2018 at 12:46 AM Marek Vasut wrote: >> On 11/19/2018 12:02 AM, Wolfram Sang wrote: >>> On Sun, Nov 18, 2018 at 06:33:26PM +0100, Marek Vasut wrote: From: Takeshi Kihara This patch adds CAN{0,1} co

Re: [PATCH V3] arm64: dts: r8a77990: ebisu: Add and enable SDHI device nodes

2018-11-20 Thread Marek Vasut
On 11/20/2018 11:16 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Tue, Nov 6, 2018 at 9:46 PM Marek Vasut wrote: >> From: Takeshi Kihara >> >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC >> and enables SD card slot connected to SDHI0, micro SD card slot >> connected to SD

[PATCH V2] arm64: dts: renesas: r8a77965: Add CAN and CANFD controller nodes

2018-11-20 Thread Marek Vasut
From: Takeshi Kihara This patch adds CAN{0,1} and CANFD controller nodes for the R8A77965 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven Cc: Marc Kleine-Budde Cc: Rob Herring Cc: Simon Horman Cc: Wolfram Sang Cc: linux-renesas-soc@vger.kernel.org Cc:

Re: [PATCH 3/4] arm64: renesas: ulcb-kf: add pcm3168 sound codec

2018-11-20 Thread Kuninori Morimoto
Hi Jiada > >> + > >> +    clk8snd: clk8snd { > >> +    compatible = "fixed-clock"; > >> +    #clock-cells = <0>; > >> +    clock-frequency = <24576000>; > >> +    }; > > This is the same clock as cs2000, why not directly refer to &cs2000 > > from clksndsel, > > otherwise, if snd_soc_

[RFC PATCH 3/3] mmc: core: remove obsolete mmc_set_blockcount() function

2018-11-20 Thread Wolfram Sang
The only user was converted to fill a sbc command which is the proper way to do it because of AutoCMD23 feature of some hosts. Signed-off-by: Wolfram Sang --- drivers/mmc/core/core.c | 14 -- drivers/mmc/core/core.h | 2 -- 2 files changed, 16 deletions(-) diff --git a/drivers/mmc/

[RFC PATCH 1/3] mmc: core: validate user input for RPMB block count

2018-11-20 Thread Wolfram Sang
For RPMB, block count is a non-zero 16 bit wide number. Reject invalid values from userspace instead of just masking the unneeded bits. Tested with a modified 'mmc-utils' package. Signed-off-by: Wolfram Sang --- drivers/mmc/core/block.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/driv

[RFC PATCH 0/3] mmc: refactor RPMB block count handling

2018-11-20 Thread Wolfram Sang
On Renesas R-Car SDHI hardware, we sometimes had timeouts accessing the RPMB. This is because AutoCMD23/12 features needs a properly filled sbc to work correctly. But RPMB sends an individual CMD23. I could have fixed the driver but after some research concluded that fixing the core seems the prope

[RFC PATCH 2/3] mmc: core: use mrq->sbc when sending CMD23 for RPMB

2018-11-20 Thread Wolfram Sang
When sending out CMD23 in the blk preparation, the comment there rightfully says: * However, it is not sufficient to just send CMD23, * and avoid the final CMD12, as on an error condition * CMD12 (stop) needs to be sent anyway. This, coupled * with Auto-CMD23 en

Re: [PATCH v4 3/4] media: i2c: Add MAX9286 driver

2018-11-20 Thread jacopo mondi
Hi Luca, On Tue, Nov 20, 2018 at 11:51:37AM +0100, Luca Ceresoli wrote: > Hi Kieran, > > On 20/11/18 01:32, Kieran Bingham wrote: > > Hi Luca, > > > > My apologies for my travel induced delay in responding here, > > No problem. > > > On 14/11/2018 02:04, Luca Ceresoli wrote: > [...] > > +stati

[RFC v3 2/2] gpio: rcar: Set pin as a GPIO when configuring an interrupt

2018-11-20 Thread Fabrizio Castro
As it turns out, the bootloader or a POR may get in the way of the current implementation of gpio_rcar_irq_set_type, as the pinmuxing may not be GPIO. This patch makes sure the pin is configured as a GPIO when requesting it an interrupt, as that's necessary for the interrupt to work properly. Faili

[RFC v3 0/2] Request GPIO when enabling interrupt

2018-11-20 Thread Fabrizio Castro
Dear All, here is a new iteration of the fix for the pinmuxing issue while requesting an interrupt. I don't like this implementation either as: * pinctrl_mux_gpio_request_enable is very similar to pinctrl_gpio_request, and the name I have picked up is not exactly brilliant... * it may cause an e

[RFC v3 1/2] pinctrl: core: Add pinctrl_mux_gpio_request_enable

2018-11-20 Thread Fabrizio Castro
Sometimes there is the need to change the muxing of a pin to make it a GPIO without going through gpiolib. This patch adds pinctrl_mux_gpio_request_enable to deal with this new use case from code that has nothing to do with pinctrl. Signed-off-by: Fabrizio Castro --- drivers/pinctrl/core.c

Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver

2018-11-20 Thread Marek Vasut
On 11/20/2018 02:32 PM, Boris Brezillon wrote: > On Tue, 20 Nov 2018 14:09:05 +0100 > Marek Vasut wrote: > >> On 11/20/2018 08:23 AM, masonccy...@mxic.com.tw wrote: >>> Hi Marek, >> >> Hi, >> Marek Vasut 2018/11/19 下午 10:12 To > + > +static int rpc_spi_set_fr

Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver

2018-11-20 Thread Marek Vasut
On 11/20/2018 02:26 PM, Mark Brown wrote: > On Mon, Nov 19, 2018 at 11:10:04PM +0100, Marek Vasut wrote: >> On 11/19/2018 04:27 PM, Mark Brown wrote: > >>> The SPDX header needs to be C++ style so I push people to make the whole >>> block C++ otherwise it looks messy. > >> OK, I'm not gonna wrest

Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver

2018-11-20 Thread Boris Brezillon
On Tue, 20 Nov 2018 14:09:05 +0100 Marek Vasut wrote: > On 11/20/2018 08:23 AM, masonccy...@mxic.com.tw wrote: > > Hi Marek, > > Hi, > > >> Marek Vasut > >> 2018/11/19 下午 10:12 > >> > >> To > >> > >> > + > >> > +static int rpc_spi_set_freq(struct rpc_spi *rpc, unsigned long freq) > >> > +{

Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver

2018-11-20 Thread Mark Brown
On Mon, Nov 19, 2018 at 11:10:04PM +0100, Marek Vasut wrote: > On 11/19/2018 04:27 PM, Mark Brown wrote: > > The SPDX header needs to be C++ style so I push people to make the whole > > block C++ otherwise it looks messy. > OK, I'm not gonna wrestle you on this, but I think it looks horrible ;-)

Re: [PATCH] clk: Add (devm_)clk_get_optional() functions

2018-11-20 Thread Andy Shevchenko
On Tue, Nov 20, 2018 at 01:56:52PM +0100, Uwe Kleine-König wrote: > On Tue, Nov 20, 2018 at 12:38:33PM +0200, Andy Shevchenko wrote: > > On Mon, Nov 19, 2018 at 02:12:59PM +, Phil Edworthy wrote: > > > + if (clk == ERR_PTR(-ENOENT)) > > > + return NULL; > > > + else > > > + retu

Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver

2018-11-20 Thread Marek Vasut
On 11/20/2018 08:23 AM, masonccy...@mxic.com.tw wrote: > Hi Marek, Hi, >> Marek Vasut >> 2018/11/19 下午 10:12 >> >> To >> >> > + >> > +static int rpc_spi_set_freq(struct rpc_spi *rpc, unsigned long freq) >> > +{ >> > +   int ret; >> > + >> > +   if (rpc->cur_speed_hz == freq) >> > +      return 0

Re: [PATCH] clk: Add (devm_)clk_get_optional() functions

2018-11-20 Thread Uwe Kleine-König
Hello, On Tue, Nov 20, 2018 at 12:38:33PM +0200, Andy Shevchenko wrote: > On Mon, Nov 19, 2018 at 02:12:59PM +, Phil Edworthy wrote: > > + if (clk == ERR_PTR(-ENOENT)) > > + return NULL; > > + else > > + return clk; > > return clk == ERR_PTR(-ENOENT) ? NULL : clk; > >

Re: [PATCH 2/2] dt-binding: spi: Document Renesas R-Car RPC controller bindings

2018-11-20 Thread Marek Vasut
On 11/20/2018 06:42 AM, masonccy...@mxic.com.tw wrote: > Hi Marek, > > Marek Vasut 已在 2018/11/19 下午 09:49:31 上寫入: > >> Marek Vasut >> 2018/11/19 下午 09:49 >> >> To >> >> Mason Yang , broo...@kernel.org, >> tpie...@impinj.com, linux-ker...@vger.kernel.org, linux- >> s...@vger.kernel.org, linux-re

Re: [GIT PULL FOR renesas-drivers] R-Car DU IOMMU

2018-11-20 Thread Geert Uytterhoeven
Hi Laurent, Congratulations! ;-) On Wed, Nov 15, 2017 at 8:13 AM Laurent Pinchart wrote: > The following changes since commit d65d31388a23b14df9494135ad6c6549a59a3caa: > > Merge tag 'drm-misc-next-fixes-2017-11-07' of git://anongit.freedesktop.org/ > drm/drm-misc into drm-next (2017-11-08 05:2

renesas-drivers-2018-11-20-v4.20-rc3

2018-11-20 Thread Geert Uytterhoeven
I have pushed renesas-drivers-2018-11-20-v4.20-rc3 to https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git This tree is meant to ease development of platform support and drivers for Renesas ARM SoCs. It is created by merging (a) the for-next branches of various subsystem trees an

Re: [PATCH] clk: Add (devm_)clk_get_optional() functions

2018-11-20 Thread Andy Shevchenko
On Tue, Nov 20, 2018 at 10:53:33AM +, Phil Edworthy wrote: > On 20 November 2018 10:39 Andy Shevchenko wrote: > > On Mon, Nov 19, 2018 at 02:12:59PM +, Phil Edworthy wrote: > > > This adds clk_get_optional() and devm_clk_get_optional() functions to > > > get optional clocks. > > > They beha

RE: [PATCH] clk: Add (devm_)clk_get_optional() functions

2018-11-20 Thread Phil Edworthy
Hi Andy, On 20 November 2018 10:39 Andy Shevchenko wrote: > On Mon, Nov 19, 2018 at 02:12:59PM +, Phil Edworthy wrote: > > This adds clk_get_optional() and devm_clk_get_optional() functions to > > get optional clocks. > > They behave the same as (devm_)clk_get except where there is no clock >

Re: [PATCH v4 3/4] media: i2c: Add MAX9286 driver

2018-11-20 Thread Luca Ceresoli
Hi Kieran, On 20/11/18 01:32, Kieran Bingham wrote: > Hi Luca, > > My apologies for my travel induced delay in responding here, No problem. > On 14/11/2018 02:04, Luca Ceresoli wrote: [...] > +static int max9286_probe(struct i2c_client *client, > + const struct i2c_devi

Re: [PATCH] clk: Add (devm_)clk_get_optional() functions

2018-11-20 Thread Andy Shevchenko
On Mon, Nov 19, 2018 at 02:12:59PM +, Phil Edworthy wrote: > This adds clk_get_optional() and devm_clk_get_optional() functions to get > optional clocks. > They behave the same as (devm_)clk_get except where there is no clock > producer. In this case, instead of returning -ENOENT, the function

[PATCH] ARM: dts: r9a06g032: Correct the GIC DT node name

2018-11-20 Thread Phil Edworthy
Harmless mistake, but it's incorrect. Signed-off-by: Phil Edworthy --- arch/arm/boot/dts/r9a06g032.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi index 2322268bc862..4c1ab49c7d39 100644 --- a/arch/arm/b

RE: [PATCH v3 1/2] dt-bindings/interrupt-controller: rzn1: Add RZ/N1 gpio irq mux binding

2018-11-20 Thread Phil Edworthy
Hi Rob, On 19 November 2018 21:51, Rob Herring wrote: > On Mon, Nov 19, 2018 at 3:39 AM Phil Edworthy > wrote: > > > > Hi Rob, > > > > On 17 November 2018 14:33 Rob Herring wrote: > > > On Tue, Nov 13, 2018 at 01:09:09PM +, Phil Edworthy wrote: > > > > Add device binding documentation for the

Re: [PATCH V3] arm64: dts: r8a77990: ebisu: Add and enable SDHI device nodes

2018-11-20 Thread Geert Uytterhoeven
Hi Marek, On Tue, Nov 6, 2018 at 9:46 PM Marek Vasut wrote: > From: Takeshi Kihara > > This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC > and enables SD card slot connected to SDHI0, micro SD card slot > connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board > using the R

Re: [PATCH 3/4] arm64: renesas: ulcb-kf: add pcm3168 sound codec

2018-11-20 Thread Jiada Wang
Hi Morimoto-san On 2018/11/08 22:36, Jiada Wang wrote: Hi Morimoto-san with the TDM Split patch-set you sent earlier in community, together with this DTS change set, I am able to test TDM Split mode, just some minor findings. On 2018/11/08 10:59, Kuninori Morimoto wrote: From: Kuninori Morim

Re: [PATCH 3/9] drm: replace "drm_dev_unref" function with "drm_dev_put"

2018-11-20 Thread Jani Nikula
On Fri, 16 Nov 2018, Fernando wrote: > And, related to this, what is the "good" branch to start developing > new drm patches? Is is "drm-next" or "linux-next"? Or does it change > depending on how much time until the merge window closes? I advise most of our developers to work on drm-tip because

Re: [PATCH v3] drm/bridge/sii902x: Add missing dependency on I2C_MUX

2018-11-20 Thread Boris Brezillon
On Tue, 20 Nov 2018 09:00:47 +0100 Boris Brezillon wrote: > On Mon, 19 Nov 2018 19:09:33 + > Fabrizio Castro wrote: > > > Hello Boris, > > > > > From: Boris Brezillon > > > Sent: 19 November 2018 19:07 > > > Subject: Re: [PATCH v3] drm/bridge/sii902x: Add missing dependency on > > > I2

Re: [PATCH v4 4/4] media: i2c: Add RDACM20 driver

2018-11-20 Thread Sakari Ailus
Hi Kieran, On Fri, Nov 02, 2018 at 03:47:23PM +, Kieran Bingham wrote: > From: Kieran Bingham > > The RDACM20 is a GMSL camera supporting 1280x800 resolution images > developed by IMI based on an Omnivision 10635 sensor and a Maxim MAX9271 > GMSL serializer. > > The GMSL link carries power,

Re: [PATCH] pinctrl: sh-pfc: r8a77980: add QSPI pins, groups, and functions

2018-11-20 Thread Geert Uytterhoeven
On Mon, Nov 19, 2018 at 6:30 PM Sergei Shtylyov wrote: > From: Dmitry Shifrin > > Add the QSPI{0|1} pins/groups/functions to the R8A77980 PFC driver. > > [Sergei: ported to the upstream driver, fixed up the swapped QSPI0 SPCLK/ > SSL pins, fixed up the comments, moved the QSPI pins/groups/functio

Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver

2018-11-20 Thread Boris Brezillon
On Tue, 20 Nov 2018 09:01:29 +0100 Geert Uytterhoeven wrote: > > --- /dev/null > > +++ b/drivers/spi/spi-renesas-rpc.c > > @@ -0,0 +1,750 @@ > > > +static int rpc_spi_set_freq(struct rpc_spi *rpc, unsigned long freq) > > +{ > > + int ret; > > + > > + if (rpc->cur_speed_hz == freq)

Re: [PATCH 2/2] dt-binding: spi: Document Renesas R-Car RPC controller bindings

2018-11-20 Thread Geert Uytterhoeven
Hi Mason, On Mon, Nov 19, 2018 at 11:02 AM Mason Yang wrote: > Document the bindings used by the Renesas R-Car D3 RPC controller. > > Signed-off-by: Mason Yang Thanks for your patch > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > @@ -0,0 +1,33 @@ > +Renesas

Re: [PATCH v3] drm/bridge/sii902x: Add missing dependency on I2C_MUX

2018-11-20 Thread Boris Brezillon
On Mon, 19 Nov 2018 19:09:33 + Fabrizio Castro wrote: > Hello Boris, > > > From: Boris Brezillon > > Sent: 19 November 2018 19:07 > > Subject: Re: [PATCH v3] drm/bridge/sii902x: Add missing dependency on > > I2C_MUX > > > > On Mon, 19 Nov 2018 18:59:04 + > > Fabrizio Castro wrote: > >

Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver

2018-11-20 Thread Geert Uytterhoeven
Hi Mason, On Mon, Nov 19, 2018 at 11:01 AM Mason Yang wrote: > Add a driver for Renesas R-Car D3 RPC SPI controller driver. > > Signed-off-by: Mason Yang Thanks for your patch! > --- /dev/null > +++ b/drivers/spi/spi-renesas-rpc.c > @@ -0,0 +1,750 @@ > +static int rpc_spi_set_freq(struct rpc_