Re: [PATCH RESEND 2/2] input: da9063_onkey: convert header to SPDX

2019-05-20 Thread Dmitry Torokhov
On Mon, May 20, 2019 at 01:24:18PM +0200, Geert Uytterhoeven wrote: > On Mon, May 20, 2019 at 12:40 PM Wolfram Sang > wrote: > > Covnert the header of the source file to SPDX. > > Convert > > > Signed-off-by: Wolfram Sang > > Reviewed-by: Simon Horman > > Acked-by: Steve Twiss > > Reviewed-b

Re: [PATCH RESEND 1/2] input: da9063_onkey: remove platform_data support

2019-05-20 Thread Dmitry Torokhov
On Mon, May 20, 2019 at 01:26:15PM +0200, Geert Uytterhoeven wrote: > On Mon, May 20, 2019 at 12:40 PM Wolfram Sang > wrote: > > There are no in-kernel users anymore, so remove this outdated interface. > > > > Signed-off-by: Wolfram Sang > > Reviewed-by: Simon Horman > > Acked-by: Steve Twiss >

Re: [PATCH 5/9] input: ati_remote2: fix typo 'can by' to 'can be'

2018-05-08 Thread Dmitry Torokhov
On Sun, May 06, 2018 at 01:23:49PM +0200, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang Applied, thank you. > --- > drivers/input/misc/ati_remote2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/misc/ati_remote2.c > b/drivers/input/misc/ati_remote2

Re: [PATCH 20/61] input: keyboard: simplify getting .drvdata

2018-04-26 Thread Dmitry Torokhov
On Thu, Apr 26, 2018 at 10:04:01PM +0200, Wolfram Sang wrote: > Hi Dmitry, > > > > We should get drvdata from struct device directly. Going via > > > platform_device is an unneeded step back and forth. > > > > I consider the fact that platform device's driver data is accessible via > > device dri

Re: [PATCH 20/61] input: keyboard: simplify getting .drvdata

2018-04-26 Thread Dmitry Torokhov
Hi Wolfram, On Thu, Apr 19, 2018 at 04:05:50PM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. I consider the fact that platform device's driver data is accessible via device driver data being implemen

Re: [PATCH] Input: st1232 - Remove obsolete platform device support

2017-10-31 Thread Dmitry Torokhov
On Thu, Oct 12, 2017 at 11:41:15AM +0200, Geert Uytterhoeven wrote: > Commit 1fa59bda21c7fa36 ("ARM: shmobile: Remove legacy board code for > Armadillo-800 EVA"), removed the last user of st1232_pdata and the > "st1232-ts" platform device. All remaining users use DT. > > Signed-off-by: Geert Uytt

Re: [PATCH v2] Input: sh_keysc - Remove dependency on SUPERH

2016-03-04 Thread Dmitry Torokhov
On Thu, Mar 03, 2016 at 09:11:18AM +0100, Geert Uytterhoeven wrote: > On Thu, Mar 3, 2016 at 1:53 AM, Simon Horman > wrote: > > A dependency on ARCH_SHMOBILE seems to be the best option for sh_keysc: > > > > * For Super H based SoCs: sh_keysc is used on SH_MIGOR, SH_ECOVEC, > > SH_KFR2R09, > >