Re: [PATCH/RFT 0/2] thermal: add suport for R8A77990

2018-12-04 Thread Eduardo Valentin
Hello Yoshihiro, On Mon, Oct 15, 2018 at 11:11:57PM +0900, Yoshihiro Kaneko wrote: > This series adds thermal support for R-Car E3 (R8A77990). > > This series is based on the next branch of Eduardo Valentin's > linux-soc-thermal > tree. Sorry for the late response, but would you be able to

Re: [PATCH v2 2/2] ARM: dts: r8a7743: Add thermal device to DT

2018-01-01 Thread Eduardo Valentin
; > Signed-off-by: Biju Das <biju@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> As for the thermal composition of this patch: Acked-by: Eduardo Valentin <edubez...@gmail.com> Also taking care of patch 1.

Re: [1/2] arm64: dts: r8a7795: add thermal cooling management

2018-01-01 Thread Eduardo Valentin
On Wed, Sep 13, 2017 at 12:59:08PM +0200, Niklas Söderlund wrote: > Add nodes and properties for thermal cooling management support. > > Signed-off-by: Niklas Söderlund > --- Just a reminder, this series should go via your arch tree. You may add my acks.

Re: [1/2] arm64: dts: r8a7795: add thermal cooling management

2018-01-01 Thread Eduardo Valentin
On Wed, Sep 13, 2017 at 12:59:08PM +0200, Niklas Söderlund wrote: > Add nodes and properties for thermal cooling management support. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Acked-by: Eduardo Valentin <edubez...@gmail.com> > --- >

Re: [2/2] arm64: dts: r8a7796: add thermal cooling management

2018-01-01 Thread Eduardo Valentin
On Wed, Sep 13, 2017 at 12:59:09PM +0200, Niklas Söderlund wrote: > Add nodes and properties for thermal cooling management support. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Acked-by: Eduardo Valentin <edubez...@gmail.com> > --- >

Re: [PATCH v3 0/7] thermal: rcar_gen3_thermal: add support for interrupt triggerd trip points

2017-03-30 Thread Eduardo Valentin
On Wed, Mar 29, 2017 at 10:51:39PM +0200, Wolfram Sang wrote: > On Wed, Mar 29, 2017 at 08:43:49PM +0200, Niklas Söderlund wrote: > > Hi, > > > > This series adds support for hardware backed trip point windows. It is > > based on top of v4.11-rc1 and is tested on R-Car H3 and M3-W. > > > > The

Re: [PATCHv5 2/5] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

2016-12-13 Thread Eduardo Valentin
hey, On Tue, Dec 13, 2016 at 10:43:40AM +0100, Niklas Söderlund wrote: > Hi Eduardo, > > Thanks for your feedback. I will skip commenting where Wolfram already > have. > > On 2016-12-12 19:50:54 -0800, Eduardo Valentin wrote: > > > > > > +/* Structure

Re: [PATCHv5 2/5] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

2016-12-12 Thread Eduardo Valentin
Hey, On Mon, Dec 12, 2016 at 03:18:02PM +0100, Niklas Söderlund wrote: > From: Wolfram Sang > > Add support for R-Car Gen3 thermal sensors. Polling only for now, > interrupts will be added incrementally. Same goes for reading fuses. > This is documented

Re: [PATCHv5 5/5] thermal: rcar_gen3_thermal: Add delay in .thermal_init on r8a7795

2016-12-12 Thread Eduardo Valentin
On Mon, Dec 12, 2016 at 03:18:05PM +0100, Niklas Söderlund wrote: > From: Niklas Söderlund > > The .thermal_init needs to be delayed a short amount of time after > setting REG_GEN3_CTSR to allow for the TEMP register to contain > something useful. If it's

Re: [PATCH v4 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

2016-12-06 Thread Eduardo Valentin
Hello Wolfram, On Thu, Dec 01, 2016 at 11:04:40PM +0100, Wolfram Sang wrote: > Add support for R-Car Gen3 thermal sensors. Polling only for now, > interrupts will be added incrementally. Same goes for reading fuses. > This is documented already, but no hardware available for now. > >

Re: [PATCH v4 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

2016-12-06 Thread Eduardo Valentin
On Thu, Dec 01, 2016 at 11:04:40PM +0100, Wolfram Sang wrote: > Add support for R-Car Gen3 thermal sensors. Polling only for now, > interrupts will be added incrementally. Same goes for reading fuses. > This is documented already, but no hardware available for now. > > Signed-off-by: Hien Dang

Re: [PATCH v4 5/4] thermal: rcar_gen3_thermal: restrict to 64BIT

2016-12-06 Thread Eduardo Valentin
On Fri, Dec 02, 2016 at 09:44:22PM +0100, Wolfram Sang wrote: > COMPILE_TEST triggers problems on 32 bit machines, so limit this driver > to 64BIT for now. This is no loss because the hardware is only available > on 64 bit SoCs anyhow. After we obtained more data from the hardware > engineers, we

Re: [PATCH v3 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

2016-11-29 Thread Eduardo Valentin
Hey, On Tue, Nov 29, 2016 at 09:32:42AM +0100, Wolfram Sang wrote: > Hi Eduardo, > > > No commit message ? :-( generally speaking here, it is a good practice > > to describe what you are doing, what you have considered, and what you > > have tested, just for the sake of code

Re: [PATCH v3 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

2016-11-28 Thread Eduardo Valentin
Wolfram, Thanks for sending the driver. Questions on the driver locking strategy as follows. On Mon, Nov 28, 2016 at 10:09:22PM +0100, Wolfram Sang wrote: No commit message ? :-( generally speaking here, it is a good practice to describe what you are doing, what you have considered, and what

Re: [PATCH] thermal: rcar: Remove binding docs for r8a7794

2016-03-31 Thread Eduardo Valentin
On Tue, Mar 29, 2016 at 02:07:45PM +0900, Simon Horman wrote: > The latest information that I have is that there is no thermal IP > block present on the r8a7794 SoC so remove the corresponding binding. > > Cc: Geert Uytterhoeven > Signed-off-by: Simon Horman

Re: [PATCH 0/4][RESEND] thermal: rcar: use thermal-zone on DT

2016-02-09 Thread Eduardo Valentin
On Tue, Feb 09, 2016 at 01:33:17PM -0800, Eduardo Valentin wrote: > On Tue, Feb 09, 2016 at 01:56:19AM +, Kuninori Morimoto wrote: > > > > Hi Eduardo > > > > I'm sorry I didn't mention you. > > Can you please check these patches ? > > Yes Morimoto,