Re: [PATCH/RFC 17/19] arm64: dts: renesas: Add support for Salvator-XS with R-Car M3-W+

2019-10-16 Thread Eugeniu Rosca
Hi Geert, On Wed, Oct 16, 2019 at 10:54:12AM +0200, Geert Uytterhoeven wrote: > Hi Eugeniu, > > On Mon, Oct 14, 2019 at 7:57 PM Eugeniu Rosca wrote: > > On Mon, Oct 07, 2019 at 12:23:30PM +0200, Geert Uytterhoeven wrote: > > > Add initial support for the Renesa

Re: [PATCH/RFC 00/19] arm64: dts: renesas: Initial support for R-Car M3-W+

2019-10-14 Thread Eugeniu Rosca
Hi Geert, On Mon, Oct 07, 2019 at 12:23:13PM +0200, Geert Uytterhoeven wrote: > Hi all, > > This RFC patch series adds support for the R-Car M3-W+ (R8A77961) SoC > and the Salvator-XS board with R-Car M3-W+. This SoC is a derivative of > R-Car M3-W (R8A77960), and also known as R-Car M3-W

Re: [PATCH/RFC 03/19] dt-bindings: clock: renesas: cpg-mssr: Document r8a77961 support

2019-10-14 Thread Eugeniu Rosca
On Mon, Oct 07, 2019 at 12:23:16PM +0200, Geert Uytterhoeven wrote: > Add DT binding documentation for the Clock Pulse Generator / Module > Standby and Software Reset block in the Renesas R-Car M3-W+ (R8A77961) > SoC. > > Signed-off-by: Geert Uytterhoeven > --- > .../devicetree/bindings/clock/re

Re: [PATCH/RFC 17/19] arm64: dts: renesas: Add support for Salvator-XS with R-Car M3-W+

2019-10-14 Thread Eugeniu Rosca
Hi Geert, Thanks for the series. One question below. On Mon, Oct 07, 2019 at 12:23:30PM +0200, Geert Uytterhoeven wrote: > Add initial support for the Renesas Salvator-X 2nd version development > board equipped with an R-Car M3-W+ SiP with 8 (2 x 4) GiB of RAM. > > The memory map is as follows:

Re: [RFC DO-NOT-MERGE PATCH] arm64: dts: renesas: R8A77961: Add Renesas M3-W+ (M3 ES3.0) SoC support

2019-09-27 Thread Eugeniu Rosca
Hi Simon, On Sat, Aug 31, 2019 at 10:01:02AM +0200, Simon Horman wrote: [..] > +1 > > Your recollection of the decisions made around H3 and 4/5 digit identifiers > matches mine. And I agree that in hindsight we may have been better to use > a 5 digit identifier for H3 ES2.0. So I think it would

Re: [RFC DO-NOT-MERGE PATCH] arm64: dts: renesas: R8A77961: Add Renesas M3-W+ (M3 ES3.0) SoC support

2019-09-27 Thread Eugeniu Rosca
Hi Geert, Many thanks for the recent clarifications. I got some M3 ES3.0 reference targets on my desk. So, if time permits, I might push some bring-up patches to you. -- Best Regards, Eugeniu

Re: [PATCH v2 1/3] usb: renesas_usbhs: enable DVSE interrupt

2019-09-09 Thread Eugeniu Rosca
Hi Veeraiyan, On Fri, Sep 06, 2019 at 02:03:49PM +0200, Veeraiyan Chidambaram wrote: > From: Eugeniu Rosca > > Commit [1] enabled the possibility of checking the DVST (Device State > Transition) bit of INTSTS0 (Interrupt Status Register 0) and calling > the irq_dev_state() hand

Re: [PATCH v3] usb: gadget: udc: renesas_usb3: add suspend event support

2019-09-06 Thread Eugeniu Rosca
Hi Shimoda-san, On Fri, Sep 06, 2019 at 04:41:50AM +, Yoshihiro Shimoda wrote: > Hello Eugeniu-san, > > > From: Eugeniu Rosca, Sent: Friday, September 6, 2019 4:07 AM > > > > > I guess there are strong similarities between this patch and [3]. > > Would you

Re: [PATCH v3] usb: gadget: udc: renesas_usb3: add suspend event support

2019-09-05 Thread Eugeniu Rosca
Hello Shimoda-san, On Thu, Sep 05, 2019 at 11:07:02AM +, Yoshihiro Shimoda wrote: > Hi Veeraiyan, > > > From: Veeraiyan Chidambaram, Sent: Thursday, September 5, 2019 6:18 PM > > > > In R-Car Gen3 USB 3.0 Function, if host is detached an interrupt > > will be generated and Suspended state bi

Re: [RFC DO-NOT-MERGE PATCH] arm64: dts: renesas: R8A77961: Add Renesas M3-W+ (M3 ES3.0) SoC support

2019-08-28 Thread Eugeniu Rosca
Hi Geert, Thanks for taking some time to reflect retrospectively on the bring-up experiences from the past and to summarize the lessons learned. On Fri, Aug 23, 2019 at 04:18:09PM +0200, Geert Uytterhoeven wrote: [..] > Actually R-Car H3 ES2.0 is r8a77951, while ES1.x is r8a77950. That's a great

[RFC DO-NOT-MERGE PATCH] arm64: dts: renesas: R8A77961: Add Renesas M3-W+ (M3 ES3.0) SoC support

2019-08-21 Thread Eugeniu Rosca
e to separate: - DTS only - DTS + Kconfig (ARCH_R8A77961) - DTS + Kconfig (ARCH_R8A77961) + drivers (sysc, cpg-mssr, other?) Comments appreciated! Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77961.dtsi | 16 1 file changed, 16 insertions(+) create mod

Re: [PATCH v2 2/5] arm64: dts: r8a7795: Add cpuidle support for CA53 cores

2019-07-29 Thread Eugeniu Rosca
Hello Geert, hello Lorenzo, Many thanks for your comments and for the willingness to help. For your information, we've recently discovered that, with all the findings already described being absolutely valid for the reference targets, disabling CPUidle on the customer HW is apparently not enough

Re: [PATCH v2 2/5] arm64: dts: r8a7795: Add cpuidle support for CA53 cores

2019-07-26 Thread Eugeniu Rosca
On Fri, Jul 26, 2019 at 11:13:29AM +0200, Rosca, Eugeniu (ADITG/ESM1) wrote: [..] > The culprit BSP commits are: > https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit/?id=3c3b44c752c4ee > https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit/?id=902ff

Re: [PATCH 0/2] serial: sh-sci: Fix .flush_buffer() issues

2019-07-03 Thread Eugeniu Rosca
Hi Greg, On Wed, Jul 03, 2019 at 07:30:50PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 28, 2019 at 03:02:00PM +0200, Eugeniu Rosca wrote: [..] > > I am doing this per-patch to allow patchwork to reflect the status of > > each patch on the linux-renesas-soc front-page. AFAIK pa

Re: [PATCH] dmaengine: rcar-dmac: Reject zero-length slave DMA requests

2019-07-03 Thread Eugeniu Rosca
Hi Geert, On Fri, Jun 28, 2019 at 02:10:01PM +0200, Geert Uytterhoeven wrote: > On Wed, Jun 26, 2019 at 8:15 PM Eugeniu Rosca wrote: [..] > I'm not such a big fan of WARN()... [..] > > rcar-dmac e730.dma-controller: rcar_dmac_prep_slave_sg: bad parameter: > > len=1,

Re: [PATCH 2/2] serial: sh-sci: Terminate TX DMA during buffer flushing

2019-06-28 Thread Eugeniu Rosca
ted starting with commit [2], the API choice looks reasonable to me. Reviewed-by: Eugeniu Rosca Tested-by: Eugeniu Rosca [1] git grep -W "static void.*flush_buffer" -- drivers/tty/serial/ | grep dmaengine_terminate drivers/tty/serial/fsl_lpuart.c- dmaengine_termi

Re: [PATCH 0/2] serial: sh-sci: Fix .flush_buffer() issues

2019-06-28 Thread Eugeniu Rosca
Hi Wolfram, On Fri, Jun 28, 2019 at 02:55:34PM +0200, Wolfram Sang wrote: [..] > If you could formally add such a tag: > > Tested-by: > > (maybe also Acked-by: or Reviewed-by:, dunno if you think it is > apropriate) > > to the patches, this would be much appreciated and will usually speed up >

Re: [PATCH 1/2] serial: sh-sci: Fix TX DMA buffer flushing and workqueue races

2019-06-28 Thread Eugeniu Rosca
prep_slave_single(), as micro-optimization. > + } > > desc = dmaengine_prep_slave_single(chan, buf, s->tx_dma_len, > DMA_MEM_TO_DEV, > DMA_PREP_INTERRUPT | DMA_CTRL_ACK); Otherwise: Reviewed-by: Eugeniu Rosca Tested-by: Eugeniu Rosca -- Best Regards, Eugeniu.

Re: [PATCH 0/2] serial: sh-sci: Fix .flush_buffer() issues

2019-06-28 Thread Eugeniu Rosca
Hi Geert, On Fri, Jun 28, 2019 at 01:51:25PM +0200, Geert Uytterhoeven wrote: [..] > If a serial port is used as a console, the port is used for both DMA > (normal use) and PIO (serial console output). The latter can have a > negative impact on the former, aggravating existing bugs, or triggeri

Re: [Announce] Renesas SoC Co-Maintainer

2019-06-27 Thread Eugeniu Rosca
Hello Simon, Thank you for the amazing support and responsiveness delivered to the R-Car users and beyond. "horms" is like an emblem you cannot take away from the Renesas kernel. It is imprinted in the names of repositories and inspires quality, trust and consistency. Greatest wishes on behalf of

Re: [PATCH] dmaengine: rcar-dmac: Reject zero-length slave DMA requests

2019-06-26 Thread Eugeniu Rosca
Hi All, On Mon, Jun 24, 2019 at 02:38:18PM +0200, Geert Uytterhoeven wrote: [..] > - if (rchan->mid_rid < 0 || !sg_len) { > + if (rchan->mid_rid < 0 || !sg_len || !sg_dma_len(sgl)) { > dev_warn(chan->device->dev, >"%s: bad parameter: len=%d, id=%d\n",

Re: [PATCH 0/2] serial: sh-sci: Fix .flush_buffer() issues

2019-06-26 Thread Eugeniu Rosca
Hi Geert, CC: George On Mon, Jun 24, 2019 at 02:35:38PM +0200, Geert Uytterhoeven wrote: > Hi Greg, Jiri, > > This patch series attempts to fix the issues Eugeniu Rosca reported > seeing, where .flush_buffer() interfered with transmit DMA operation[*]. > > There's a third

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-06-12 Thread Eugeniu Rosca
; > On Mon, Jun 10, 2019 at 10:30 AM Tony Lindgren wrote: > >> * Kalle Valo [190610 07:01]: > >>> Eugeniu Rosca writes: > >>> > >>>> The wl1837mod datasheet [1] says about the WL_IRQ pin: > >>>> > >>>> ---8<---

Re: [PATCH] serial: sh-sci: disable DMA for uart_console

2019-05-10 Thread Eugeniu Rosca
console breakage every fourth boot or so on lots of R-Car3 targets. Tested-by: Eugeniu Rosca On Thu, May 09, 2019 at 10:43:30AM -0400, George G. Davis wrote: > As noted in commit 84b40e3b57ee ("serial: 8250: omap: Disable DMA for > console UART"), UART console lines use low-level

Re: Automated/remote flashing of R-Car3

2019-05-08 Thread Eugeniu Rosca
Hi Marek, On Tue, May 07, 2019 at 06:09:10PM +0200, Marek Vasut wrote: [..] > >>> 1.c Use OpenOCD > >>> + Presumably same advantages as using a Lauterbach > >>> + Based on Kieran's https://github.com/kbingham/renesas-jtag > >>> and on Adam's https://github.com/ntfreak/openocd/commit/1afec4f56139

Re: Automated/remote flashing of R-Car3

2019-05-08 Thread Eugeniu Rosca
On Tue, May 07, 2019 at 06:09:10PM +0200, Marek Vasut wrote: [..] > >>> 1.d. Use CPLD Configurator > >>> + H3_M3_StarterKit_Configurator.exe is a Windows tool shipped by > >>> Renesas, hence readily available, which allows to modify the MD > >>> pins, to conveniently switch between QSPI/Hyperfl

Re: Automated/remote flashing of R-Car3

2019-05-07 Thread Eugeniu Rosca
Hi Marek, Thanks for the swift reply and for the useful references/links. On Tue, May 07, 2019 at 03:23:12PM +0200, Marek Vasut wrote: > On 5/7/19 12:41 PM, Eugeniu Rosca wrote: > > Dear Marek, dear Kieran, > > Hi, > > [...] > > > 1.c Use OpenOCD > > + P

Automated/remote flashing of R-Car3

2019-05-07 Thread Eugeniu Rosca
Dear Marek, dear Kieran, CC: Michael, Gotthard, Adam CC: U-Boot, linux-renesas-soc CC: ADIT We in ADIT have recently set up some remote servers for CI deployment/testing of R-Car3 targets (Salvator-X and ULCB-KF). Since re-flashing of "firmware" (i.e. ATF, U-Boot and OPTEE-OS) on Hyperflash invo

Re: [PATCH 2/6] Revert "arm64: dts: renesas: r8a7796: Enable DMA for SCIF2"

2019-05-06 Thread Eugeniu Rosca
Hi Geert, On Mon, May 06, 2019 at 12:02:41PM +0200, Geert Uytterhoeven wrote: > Hi Eugeniu, > > Thanks for your report! Thanks for your feedback. > > On Sat, May 4, 2019 at 2:45 AM Eugeniu Rosca wrote: > > This reverts commit 97f26702bc95b5c3a72671d5c6675e4d6ee0a2f4

Re: [PATCH 1/6] serial: sh-sci: Reveal ptrval in dev_dbg

2019-05-06 Thread Eugeniu Rosca
On Mon, May 06, 2019 at 06:46:57PM +0200, Geert Uytterhoeven wrote: > Hi Eugeniu, > > On Mon, May 6, 2019 at 5:24 PM Eugeniu Rosca wrote: > > On Mon, May 06, 2019 at 03:47:05PM +0200, Simon Horman wrote: > > > On Sat, May 04, 2019 at 02:42:53AM +0200, Eugeniu Rosca wrot

Re: [PATCH 1/6] serial: sh-sci: Reveal ptrval in dev_dbg

2019-05-06 Thread Eugeniu Rosca
On Mon, May 06, 2019 at 03:47:05PM +0200, Simon Horman wrote: > On Sat, May 04, 2019 at 02:42:53AM +0200, Eugeniu Rosca wrote: > > Starting with v4.15-rc2 commit ad67b74d2469d9 ("printk: hash addresses > > printed with %p"), enabling debug prints in sh-sci.c would gener

[PATCH 6/6] Revert "arm64: dts: renesas: r8a77995: add DMA for SCIF2"

2019-05-03 Thread Eugeniu Rosca
CIF2""). Fixes: af2ea3df851ffa ("arm64: dts: renesas: r8a77995: add DMA for SCIF2") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renes

[PATCH 1/6] serial: sh-sci: Reveal ptrval in dev_dbg

2019-05-03 Thread Eugeniu Rosca
b74d2469d9 ("printk: hash addresses printed with %p") Signed-off-by: Eugeniu Rosca --- drivers/tty/serial/sh-sci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 3cd139752d3f..82660f8e6d86 10064

[PATCH 5/6] Revert "arm64: dts: renesas: r8a77990: Enable DMA for SCIF2"

2019-05-03 Thread Eugeniu Rosca
CIF2""). Fixes: a99de47921565c ("arm64: dts: renesas: r8a77990: Enable DMA for SCIF2") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/a

[PATCH 2/6] Revert "arm64: dts: renesas: r8a7796: Enable DMA for SCIF2"

2019-05-03 Thread Eugeniu Rosca
24a9e4fa61d1db88c66 Fixes: 97f26702bc95b5 ("arm64: dts: renesas: r8a7796: Enable DMA for SCIF2") Reported-by: Michael Rodin Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a7

[PATCH 0/6] Zap SCIF2 DMA configuration in R-Car Gen3 DTS

2019-05-03 Thread Eugeniu Rosca
included here as well. Tested using v5.1-rc7-131-gea9866793d1e on: - H3-ES2.0-ULCB - M3N-ES1.1-ULCB - M3-ES1.1-Salvator-XS Eugeniu Rosca (6): serial: sh-sci: Reveal ptrval in dev_dbg Revert "arm64: dts: renesas: r8a7796: Enable DMA for SCIF2" arm64: dts: renesas: r8a7795: zap dm

[PATCH 3/6] arm64: dts: renesas: r8a7795: zap dma configuration in scif2

2019-05-03 Thread Eugeniu Rosca
r8a7795: Add missing SYS-DMAC2 dmas") Fixes: 49af46b4095672 ("arm64: renesas: r8a7795: Add all SCIF nodes") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/a

[PATCH 4/6] Revert "arm64: dts: renesas: r8a77965: Enable DMA for SCIF2"

2019-05-03 Thread Eugeniu Rosca
CIF2""). Fixes: 05c8478abd4855 ("arm64: dts: renesas: r8a77965: Enable DMA for SCIF2") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renes

Re: [PATCH] arm64: dts: ulcb-kf: Add support for TI WL1837

2019-04-29 Thread Eugeniu Rosca
Hi Simon, On Mon, Apr 29, 2019 at 10:17:48AM +0200, Simon Horman wrote: > Hi again, > > I have been able to solicit a limited private review of this patch and > have gone ahead and applied it for inclusion in v5.2. Thank you. In case of any concerns/reports/fixes applicable to this patch, we wou

Re: [PATCH] arm64: dts: ulcb-kf: Add support for TI WL1837

2019-04-25 Thread Eugeniu Rosca
Hi Simon, Do we have any chance getting this upstream? If so, would you kindly list the acceptance criteria we have to conform to? Many thanks. On Thu, Apr 11, 2019 at 02:41:03PM +0200, Spyridon Papageorgiou wrote: > This patch adds description of TI WL1837 and links interfaces > to communicate

Re: [PATCH v4 12/12] staging: most: Documentation: update driver documentation

2019-04-17 Thread Eugeniu Rosca
niu. On Wed, Apr 17, 2019 at 01:45:41PM +, christian.gr...@microchip.com wrote: > On Mo, 2019-04-15 at 23:21 +0200, Eugeniu Rosca wrote: > > External E-Mail > > > > > > Hello Christian, hello Andrey, > > cc: Vladimir Barinov > > cc: linux-renes

Re: [PATCH v4 12/12] staging: most: Documentation: update driver documentation

2019-04-15 Thread Eugeniu Rosca
Hello Christian, hello Andrey, cc: Vladimir Barinov cc: linux-renesas-soc Our team currently has the requirement of adding MOST support to the v4.14-based R-Car3 kernel [1], matching the level of features and interfaces of mld-1.8.0 [2] release. Based on a quick check [3], the mld-1.8.0 release c

Re: [PATCH v2] serial: sh-sci: Support for HSCIF RX sampling point adjustment

2019-03-27 Thread Eugeniu Rosca
Dear Renesas Open Source team, We've recently switched from rcar-3.7.x to rcar-3.9.x [1] kernel and the latter contains this patch [2] by virtue of rcar-3.9.0 commit [3], which mirrors v4.18-rc1 commit [4] in mainline. JFYI, quite far away in the delivery chain, we've received below report: > Wi

Re: [PATCH 1/2] i2c: rcar: refactor private flags

2018-10-08 Thread Eugeniu Rosca
Hi Wolfram, On Fri, Oct 05, 2018 at 06:27:28PM +0200, Wolfram Sang wrote: > > > May I ask how exactly you spotted the "shift-31-problem" in > > drivers/i2c/busses/i2c-rcar.c: > > - visual code review? > > - static analysis, special compiler flags? > > This one. I run a set of static code analy

Re: [PATCH 1/2] i2c: rcar: refactor private flags

2018-10-04 Thread Eugeniu Rosca
Hi Wolfram, > On August 8, 2018 at 9:59 AM Wolfram Sang > wrote: > > Use BIT macro to avoid shift-31-problem, May I ask how exactly you spotted the "shift-31-problem" in drivers/i2c/busses/i2c-rcar.c: - visual code review? - static analysis, special compiler flags? - run-time testing with

Re: [PATCH v3 net-next] dt-bindings: can: rcar_can: document r8a77965 support

2018-09-21 Thread Eugeniu Rosca
Hi Marc, On Mon, Aug 27, 2018 at 12:08:48PM +0200, Marc Kleine-Budde wrote: > On 08/20/2018 04:49 PM, Eugeniu Rosca wrote: > > From: Eugeniu Rosca > > > > Document the support for rcar_can on R8A77965 SoC devices. > > Add R8A77965 to the list of SoCs which requir

Re: [PATCH v2 6/7] arm64: dts: renesas: r8a77965: Add HSCIF0 device node

2018-08-27 Thread Eugeniu Rosca
Hi Simon, On Wed, Aug 22, 2018 at 01:12:47PM +0200, Simon Horman wrote: > On Sun, Aug 12, 2018 at 03:31:48PM +0200, Eugeniu Rosca wrote: > > Fix below DTC error: > > Error: arch/arm64/boot/dts/renesas/ulcb-kf.dtsi:36.1-8 Label or path hscif0 > > not found > > >

Re: [PATCH v2 3/7] pinctrl: sh-pfc: r8a77965: Add HSCIF0 pins, groups, and functions

2018-08-27 Thread Eugeniu Rosca
Hi Geert, On Mon, Aug 27, 2018 at 05:07:39PM +0200, Geert Uytterhoeven wrote: > Hi Eugeniu, > > On Sun, Aug 12, 2018 at 3:33 PM Eugeniu Rosca wrote: > > According to R-Car Gen3 HW manual Rev.1.00 Apr 2018, M3-N SoC implements > > five (0..4) HSCIF channels, simil

Re: [PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes

2018-08-27 Thread Eugeniu Rosca
Hi Simon, hi Geert, On Mon, Aug 27, 2018 at 02:44:47PM +0200, Simon Horman wrote: > On Thu, Aug 23, 2018 at 10:52:09AM +0200, Geert Uytterhoeven wrote: > > On Fri, Aug 17, 2018 at 3:53 PM Kieran Bingham > > wrote: > > > On 12/08/18 14:31, Eugeniu Rosca wrote: > >

Re: [PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes

2018-08-27 Thread Eugeniu Rosca
Hi Kieran, I appreciate the detailed reply zooming in into many aspects (both technical and related to process/workflow) of contributing/reviewing patches. I take it as is. I could elaborate on specific parts of it, like applying the "undefined behavior" term (which comes from the world of compile

Re: [PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes

2018-08-23 Thread Eugeniu Rosca
ts. > > >>> Fix them beforehand. > > >>> > > >>> CAN support is inspired from below commits: > > >>> - v4.7 commit 308b7e4ba62e ("arm64: dts: r8a7795: Add CAN support") > > >>> - v4.11 commit 909c16252415 ("arm64: dts:

Re: [PATCH v2 2/7] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-17 Thread Eugeniu Rosca
Hi Kieran, On Fri, Aug 17, 2018 at 05:10:06PM +0100, Kieran Bingham wrote: > Hi Eugeniu, > > On 17/08/18 16:56, Eugeniu Rosca wrote: > > Hello Kieran, > > > > On Fri, Aug 17, 2018 at 02:44:25PM +0100, Kieran Bingham wrote: > >> Hi Eugeniu > >> > &

Re: [PATCH v2 2/7] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-17 Thread Eugeniu Rosca
Hello Kieran, On Fri, Aug 17, 2018 at 02:44:25PM +0100, Kieran Bingham wrote: > Hi Eugeniu > > Thank you for the patch. > > On 12/08/18 14:31, Eugeniu Rosca wrote: > > Document the support for rcar_can on R8A77965 SoC devices. > > Add R8A77965 to the list of SoCs

Re: [PATCH v2 2/7] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-17 Thread Eugeniu Rosca
Hi Simon, On Fri, Aug 17, 2018 at 11:04:03AM +0200, Simon Horman wrote: > On Sun, Aug 12, 2018 at 03:31:44PM +0200, Eugeniu Rosca wrote: > > Document the support for rcar_can on R8A77965 SoC devices. > > Add R8A77965 to the list of SoCs which require the "assigned-clocks"

[PATCH v2 7/7] arm64: dts: renesas: r8a77965: m3nulcb-kf: Initial device tree

2018-08-12 Thread Eugeniu Rosca
This is based on the existing KF device tree sources: $ ls -1 arch/arm64/boot/dts/renesas/*-kf.dts arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts Signed-off-by: Eugeniu Rosca --- Changes in

[PATCH v2 6/7] arm64: dts: renesas: r8a77965: Add HSCIF0 device node

2018-08-12 Thread Eugeniu Rosca
HSCIF nodes") - commit 6d50bb893504 ("arm64: dts: r8a7796: Enable HSCIF DMA") - commit bec0948e810f ("arm64: dts: r8a7796: Add reset control properties") Signed-off-by: Eugeniu Rosca --- Changes in v2: - Slightly improved the commit description. - Note that this commit

[PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes

2018-08-12 Thread Eugeniu Rosca
9c16252415 ("arm64: dts: r8a7796: Add CAN support") - v4.12 commit bec0948e810f ("arm64: dts: r8a7796: Add reset control properties") Signed-off-by: Eugeniu Rosca --- Changes in v2: - [Kieran Bingham] Improved commit description: - Referenced the newer HW manual rev1.00 inst

[PATCH v2 4/7] arm64: dts: renesas: r8a77965: m3nulcb: Initial device tree

2018-08-12 Thread Eugeniu Rosca
Allow the bare M3-N-based ULCB board to boot. Signed-off-by: Eugeniu Rosca Reviewed-by: Jacopo Mondi --- Changes in v2: - [Jacopo Mondi] Removed redundant license text. Added Reviewed-by. - [Simon Horman] - Renamed DTS 's/r8a77965-ulcb.dts/r8a77965-m3nulcb.dts/' - Renamed boa

[PATCH v2 3/7] pinctrl: sh-pfc: r8a77965: Add HSCIF0 pins, groups, and functions

2018-08-12 Thread Eugeniu Rosca
hat `checkpatch --strict` throws several "CHECK: Please use a blank line after function/struct/union/enum declarations", which are ignored for the sake of staying in sync with the aforementioned commits. Signed-off-by: Eugeniu Rosca --- Changes in v2: - Newly added. - IMHO mirroring the

[PATCH v2 1/7] dt-bindings: arm: Document Renesas R-Car M3-N-based ULCB board

2018-08-12 Thread Eugeniu Rosca
1.1 ---8< DRAM: 1.9 GiB Bank #0: 0x04800 - 0x0bfff, 1.9 GiB ---8< [3] https://patchwork.kernel.org/patch/10555957/#22169325 Signed-off-by: Eugeniu Rosca --- Changes in v2: - [Jacopo Mondi] Emphasized the fact the amount of RAM is encoded in the board

[PATCH v2 2/7] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-12 Thread Eugeniu Rosca
Document the support for rcar_can on R8A77965 SoC devices. Add R8A77965 to the list of SoCs which require the "assigned-clocks" and "assigned-clock-rates" properties (thanks, Sergei). Rewrap text. Signed-off-by: Eugeniu Rosca --- Changes in v2: - [Kieran Bingham] Simplifie

Re: [PATCH 09/14] dt-bindings: arm: Document Renesas R-Car M3-N-based ULCB board

2018-08-10 Thread Eugeniu Rosca
Hi again Jacopo, On Mon, Aug 06, 2018 at 12:40:02AM +0200, Eugeniu Rosca wrote: > Hi Jacopo, > > Thanks for your comments. Please, find my replies below. > > On Sun, Aug 05, 2018 at 10:15:43AM +0200, jacopo mondi wrote: > > Helle Eugeniu, > > > > On Sun,

Re: [PATCH 01/14] arm64: dts: renesas: Cut redundant in *-ulcb*.dts

2018-08-10 Thread Eugeniu Rosca
Hi Simon, Laurent, On Fri, Aug 10, 2018 at 01:22:49PM +0200, Simon Horman wrote: > On Mon, Aug 06, 2018 at 01:35:08PM +0300, Laurent Pinchart wrote: [snip] > > The naming convention is roughly -.dts. For instance, in > > r8a7795- > > h3ulcb.dts, the SoC is R8A7795 and the board "H3 ULCB". With th

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-08 Thread Eugeniu Rosca
Hello Geert, Laurent, Morimoto-san, On Tue, Aug 07, 2018 at 10:30:14AM +0200, Geert Uytterhoeven wrote: > Hi Laurent, > > On Tue, Aug 7, 2018 at 10:21 AM Laurent Pinchart > wrote: > > On Tuesday, 7 August 2018 11:18:11 EEST Kuninori Morimoto wrote: > > > > Yeah, it is true "so far". I think ther

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-07 Thread Eugeniu Rosca
On Sun, Aug 05, 2018 at 01:11:02AM +0200, Eugeniu Rosca wrote: > diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt > b/Documentation/devicetree/bindings/arm/shmobile.txt > index d8cf740132c6..f391dba10574 100644 > --- a/Documentation/devicetree/bindings/arm/shmobile

Re: [PATCH 12/14] arm64: dts: renesas: r8a77965: add CAN support

2018-08-06 Thread Eugeniu Rosca
Hi Geert, On Mon, Aug 06, 2018 at 05:15:37PM +0200, Geert Uytterhoeven wrote: > Hi Eugeniu, > > On Sun, Aug 5, 2018 at 1:14 AM Eugeniu Rosca wrote: > > According to R-Car Gen3 HW manual rev0.55E, R-Car M3-N has two CAN > > interfaces, similar to H3, M3-W and other SoCs

Re: [PATCH 12/14] arm64: dts: renesas: r8a77965: add CAN support

2018-08-06 Thread Eugeniu Rosca
Hi Kieran, On Mon, Aug 06, 2018 at 12:11:22PM +0100, Kieran Bingham wrote: > Hi Eugeniu, > > On 05/08/18 00:11, Eugeniu Rosca wrote: > > According to R-Car Gen3 HW manual rev0.55E, R-Car M3-N has two CAN > > rev 0.55E sounds like rather an old version of this document. Do

Re: [PATCH 11/14] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-06 Thread Eugeniu Rosca
Hi Kieran, On Mon, Aug 06, 2018 at 11:56:56AM +0100, Kieran Bingham wrote: > Hi Eugeniu > > On 05/08/18 00:11, Eugeniu Rosca wrote: > > After adding CAN support to arch/arm64/boot/dts/renesas/r8a77965.dtsi, > > checkpatch complained that the new compatible string > >

Re: [PATCH 11/14] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-06 Thread Eugeniu Rosca
Hi Sergei, On Mon, Aug 06, 2018 at 06:21:09PM +0300, Sergei Shtylyov wrote: > Hello! > > On 08/05/2018 02:11 AM, Eugeniu Rosca wrote: > > > After adding CAN support to arch/arm64/boot/dts/renesas/r8a77965.dtsi, > > checkpatch complained that the new compatible string &

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-06 Thread Eugeniu Rosca
Hi Morimoto-san, Thank you for your comments. On Mon, Aug 06, 2018 at 12:33:34AM +, Kuninori Morimoto wrote: > Hi Eugeniu > > > In the context of M3N-ULCB (RTP0RC77965SKBX010SA00) board bring-up, it's > > rather pointless to add a new "renesas,m3nulcb" compatible string. Any > > SoC-level di

Re: [PATCH 13/14] arm64: dts: renesas: r8a77965: Add HSCIF0 device node

2018-08-05 Thread Eugeniu Rosca
Hello Simon, Geert, Takeshi, On Sun, Aug 05, 2018 at 01:11:13AM +0200, Eugeniu Rosca wrote: > Add hscif0 node to avoid below r8a77965-ulcb-kf.dtb build failure: > Error: arch/arm64/boot/dts/renesas/ulcb-kf.dtsi:36.1-8 Label or path hscif0 > not found > > Inspired from v4

Re: [PATCH 14/14] arm64: dts: renesas: r8a77965: ulcb-kf: Initial device tree

2018-08-05 Thread Eugeniu Rosca
Hi Jacopo, On Sun, Aug 05, 2018 at 11:01:36AM +0200, jacopo mondi wrote: > Hi Eugeniu, > > On Sun, Aug 05, 2018 at 01:11:14AM +0200, Eugeniu Rosca wrote: > > Signed-off-by: Eugeniu Rosca > > --- > > arch/arm64/boot/dts/renesas/Makefile | 1 + >

Re: [PATCH 09/14] dt-bindings: arm: Document Renesas R-Car M3-N-based ULCB board

2018-08-05 Thread Eugeniu Rosca
Hi Jacopo, Thanks for your comments. Please, find my replies below. On Sun, Aug 05, 2018 at 10:15:43AM +0200, jacopo mondi wrote: > Helle Eugeniu, > > On Sun, Aug 05, 2018 at 01:11:09AM +0200, Eugeniu Rosca wrote: > > In harmony with ATF and U-Boot outputs [1] and [2], t

[PATCH 08/14] arm64: dts: renesas: r8a7796: ulcb-kf: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,m3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7796-ulcb-kf.dts | 2 +- 1 file change

[PATCH 12/14] arm64: dts: renesas: r8a77965: add CAN support

2018-08-04 Thread Eugeniu Rosca
48e810f ("arm64: dts: r8a7796: Add reset control properties") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/d

[PATCH 07/14] arm64: dts: renesas: r8a7796: ulcb: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,m3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7796-ulcb.dts | 2 +- 1 file change

[PATCH 10/14] arm64: dts: renesas: r8a77965: ulcb: Initial device tree

2018-08-04 Thread Eugeniu Rosca
Allow the bare M3-N-based ULCB board to boot. Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/Makefile | 1 + arch/arm64/boot/dts/renesas/r8a77965-ulcb.dts | 37 + 2 files changed, 38 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH 13/14] arm64: dts: renesas: r8a77965: Add HSCIF0 device node

2018-08-04 Thread Eugeniu Rosca
quot;arm64: dts: r8a7796: Enable HSCIF DMA") - commit bec0948e810f ("arm64: dts: r8a7796: Add reset control properties") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boo

[PATCH 14/14] arm64: dts: renesas: r8a77965: ulcb-kf: Initial device tree

2018-08-04 Thread Eugeniu Rosca
Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/Makefile | 1 + arch/arm64/boot/dts/renesas/r8a77965-ulcb-kf.dts | 20 2 files changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile index

[PATCH 11/14] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-04 Thread Eugeniu Rosca
After adding CAN support to arch/arm64/boot/dts/renesas/r8a77965.dtsi, checkpatch complained that the new compatible string "renesas,can-r8a77965" is not documented. Fix the warning. Signed-off-by: Eugeniu Rosca --- Documentation/devicetree/bindings/net/can/rcar_can.txt | 10 +++-

[PATCH 09/14] dt-bindings: arm: Document Renesas R-Car M3-N-based ULCB board

2018-08-04 Thread Eugeniu Rosca
-* CPU: Renesas Electronics R8A77965 rev 1.1 ---8< DRAM: 1.9 GiB Bank #0: 0x04800 - 0x0bfff, 1.9 GiB ---8< Signed-off-by: Eugeniu Rosca --- Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documen

[PATCH 00/14] Add minimal DTS support for M3-N Starter Kit

2018-08-04 Thread Eugeniu Rosca
uot;-ulcb*.dts" - to "-ulcb*.dts" These patches have been tested on M3-N ULCB using v4.18-rc7 kernel. Any comments would be greatly appreciated. Best regards, Eugeniu. Eugeniu Rosca (14): arm64: dts: renesas: Cut redundant in *-ulcb*.dts dt-bindings: arm: don't embed

[PATCH 04/14] arm64: dts: renesas: r8a7795-es1: ulcb-kf: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,h3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7795-es1-ulcb-kf.dts | 2 +- 1 file

[PATCH 05/14] arm64: dts: renesas: r8a7795: ulcb: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,h3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7795-ulcb.dts | 2 +- 1 file change

[PATCH 03/14] arm64: dts: renesas: r8a7795-es1: ulcb: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,h3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7795-es1-ulcb.dts | 2 +- 1 file change

[PATCH 06/14] arm64: dts: renesas: r8a7795: ulcb-kf: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,h3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7795-ulcb-kf.dts | 2 +- 1 file change

[PATCH 01/14] arm64: dts: renesas: Cut redundant in *-ulcb*.dts

2018-08-04 Thread Eugeniu Rosca
gs/r8a7796_ulcb_defconfig DTB md5 sums match with and w/o the patch (hence no functional change). Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/Makefile | 12 ++-- arch/arm64/boot/dts/renesas/{r8a7795-es1-h3ulcb-kf.dts

[PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-04 Thread Eugeniu Rosca
renesas,r8a7796" and "renesas,r8a77965" compatibles. Prior to adding M3-N Starter Kit to the list, rename: - "renesas,h3ulcb" => "renesas,ulcb" - "renesas,m3ulcb" => "renesas,ulcb" Relevant DTS changes come in separate per-DTS commits. Sign

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-04 Thread Eugeniu Rosca
[re-sending due to lost To: field] Hello Wolfram, Vladimir, Thanks for your precious inputs. I think you outlined two topics in your comments (based on the description submitted with the patch). One (primary?) is related to async probing and one (secondary, but still interesting) is related to t

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-04 Thread Eugeniu Rosca
Hello Wolfram, Vladimir, Thanks for your precious inputs. I think you outlined two topics in your comments (based on the description submitted with the patch). One (primary?) is related to async probing and one (secondary, but still interesting) is related to the minor (~7ms -> ~1ms) startup impr

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-03-28 Thread Eugeniu Rosca
iewing and submitting the patch. Best regards, Eugeniu. On Fri, Mar 16, 2018 at 12:58:52PM +0200, Vladimir Zapolskiy wrote: > From: Eugeniu Rosca > > The purpose of this patch looks pretty similar to: > 104522806a7d ("i2c: designware: dw_i2c_init_driver as subsys initcall") > 74f5

Re: [PATCH] v4l: vsp1: Fix function declaration/definition mismatch

2017-12-04 Thread Eugeniu Rosca
Hello Laurent, Kieran, On Mon, Dec 04, 2017 at 12:52:17PM +0200, Laurent Pinchart wrote: > Hello, > > On Friday, 24 November 2017 20:40:57 EET Kieran Bingham wrote: > > Hi Eugeniu, > > > > Thankyou for the patch, > > > > Laurent - Any comments on this? Otherwise I'll bundle this in with my > >

Re: [v3,15/20] drm: bridge: dw-hdmi: Handle overflow workaround based on device version

2017-08-20 Thread Eugeniu Rosca
Hello Laurent, Jose, As you might know, Renesas uses the same Synopsis Designware HDMI transmitter IP in the Rcar Gen3 SoCs. There are v4.9+ patches present in [1] to enable support for this. Why I reply in this specific thread is because I am having a trial attempt to rebase the RCAR-specific v4

[PATCH] v4l: vsp1: Fix function declaration/definition mismatch

2017-08-20 Thread Eugeniu Rosca
From: Eugeniu Rosca Cppcheck v1.81 complains that the parameter names of certain vsp1 functions don't match between declaration and definition. Fix this. No functional change is confirmed by the empty delta between the disassembled object files before and after the change. Signed-o

Re: [PATCH] ravb: Fix use-after-free on `ifconfig eth0 down`

2017-06-06 Thread Eugeniu Rosca
On Tue, Jun 06, 2017 at 12:35:30PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/6/2017 1:08 AM, Eugeniu Rosca wrote: > > >Commit a47b70ea86bd ("ravb: unmap descriptors when freeing rings") has > >introduced the issue seen in [1] reproduced on H3ULCB board. &g

[PATCH] ravb: Fix use-after-free on `ifconfig eth0 down`

2017-06-05 Thread Eugeniu Rosca
f ff ff ff ff == Disabling lock debugging due to kernel taint root@salvator-x:~# Fixes: a47b70ea86bd ("ravb: unmap descriptors when freeing rings") Signed-off-by: Eugeniu Rosca --- drivers/net/ethernet/renesas/ravb_main.c | 24 1 file change

Re: [PATCH] pinctrl: sh-pfc: Print correct pinmux info name

2017-03-19 Thread Eugeniu Rosca
On Sun, Mar 19, 2017 at 03:02:48PM +0100, Geert Uytterhoeven wrote: Hi Geert, > Thanks for your patch! > But next time, please send it inline, for easier commenting. Thanks! Will do that next time. > From a code maintenance point of view, I think it's safer to update the info > pointer itself,

[PATCH] pinctrl: sh-pfc: Print correct pinmux info name

2017-03-18 Thread Eugeniu Rosca
>From cce7953dac965d620bb4fe5a456cffe40793f39b Mon Sep 17 00:00:00 2001 From: Eugeniu Rosca Date: Tue, 28 Feb 2017 13:38:36 +0100 Subject: [PATCH] pinctrl: sh-pfc: Print correct pinmux info name commit 0c151062f32c ("sh-pfc: Add support for SoC-specific initialization") allows