RE: [PATCH] usb: gadget: udc: renesas_usb3: add support for r8a774c0

2019-02-14 Thread Felipe Balbi
Hi, (no top-posting, please) Fabrizio Castro writes: > Hello Felipe, > > Who is the best person for taking patches for renesas_usb3.c? they're already in my 'next' branch. I'll send pull request to Greg shortly -- balbi signature.asc Description: PGP signature

RE: [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990

2018-10-02 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Hi Felipe-san, > >> From: Felipe Balbi, Sent: Tuesday, October 2, 2018 9:18 PM >> >> Yoshihiro Shimoda writes: >> >> > This patch adds bindings for r8a77990 (R-Car E3). >> > >> > Signed-off-by: Y

Re: [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990

2018-10-02 Thread Felipe Balbi
Yoshihiro Shimoda writes: > This patch adds bindings for r8a77990 (R-Car E3). > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > b/

Re: [PATCH v2] usb: gadget: function: printer: avoid wrong list handling in printer_write()

2018-05-21 Thread Felipe Balbi
ctive) wrongly. After that, > if we do unbind the printer driver, WARN_ON() happens in > printer_func_unbind() because the list entry is not removed. > > So, this patch moves list_add(&req->list, &dev->tx_reqs_active) > calling before usb_ep_queue(). > > Signed-off-b

RE: [PATCH/RFC] usb: gadget: function: printer: avoid wrong list handling in printer_write()

2018-05-21 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Hi, > >> From: Felipe Balbi, Sent: Monday, May 21, 2018 5:05 PM > >> seems like it would be better to just move this like before >> usb_ep_queue(): >> >> modified drivers/usb/gadget/function/f_printer.c >> @@ -63

RE: [PATCH/RFC] usb: gadget: function: printer: avoid wrong list handling in printer_write()

2018-05-21 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Hi, > >> From: Felipe Balbi, Sent: Monday, May 21, 2018 3:57 PM >> >> Hi, >> >> Yoshihiro Shimoda writes: >> > The usb_ep_queue() in printer_write() is possible to call req->complete(). >> > In

Re: [PATCH/RFC] usb: gadget: function: printer: avoid wrong list handling in printer_write()

2018-05-20 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > The usb_ep_queue() in printer_write() is possible to call req->complete(). > In that case, since tx_complete() calls list_add(&req->list, &dev->tx_reqs), > printer_write() should not call list_add(&req->list, &dev->tx_reqs_active) > because the transfer has alread

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

2017-10-17 Thread Felipe Balbi
Hi, Biju Das writes: > Hi, > >> -Original Message- >> From: devicetree-ow...@vger.kernel.org [mailto:devicetree- >> ow...@vger.kernel.org] On Behalf Of Felipe Balbi >> Sent: 17 October 2017 09:26 >> To: Biju Das ; Greg Kroah-Hartman >> ; R

Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

2017-10-17 Thread Felipe Balbi
Hi, Biju Das writes: > This patch adds support for r8a7743/5 SoC. The Renesas RZ/G1[ME] > (R8A7743/5) usbhs is identical to the R-Car Gen2 family. > > This doesn't change the driver, so it does nothing by itself. But it does > mean that checkpatch won't complain about a future patch that adds

Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

2017-10-10 Thread Felipe Balbi
ance > : Register/unregister extcon device > : Set the state of each external connector > : Set the property value of each external connector > : Set the property capability of each external connector > > Cc: Felipe Balbi Acked-by: Felipe Balbi -- balbi

Re: [PATCH v2 3/3] usb: gadget: udc: renesas_usb3: add support for R-Car M3-W

2017-08-15 Thread Felipe Balbi
Hi, Rob Herring writes: > On Fri, Aug 04, 2017 at 11:16:58AM +0900, Yoshihiro Shimoda wrote: >> This patch adds support for R-Car M3-W. This patch also adds R-Car >> Gen3 generic version's compatible and changes ".compatible" in >> the usb3_of_match from "renesas,r8a7796-usb3-peri" to >> "renesa

RE: [PATCH 0/5] usb: gadget: udc: renesas_usb3: add DMAC support

2017-06-06 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Hi, > >> From: Felipe Balbi >> Sent: Friday, June 2, 2017 6:49 PM >> >> Hi, >> >> Yoshihiro Shimoda writes: >> > Hi Felipe, >> > >> >> -Original Message- >> >> From: Yo

RE: [PATCH 0/5] usb: gadget: udc: renesas_usb3: add DMAC support

2017-06-02 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Hi Felipe, > >> -Original Message- >> From: Yoshihiro Shimoda >> Sent: Wednesday, April 26, 2017 8:50 PM >> >> This patch set is based on the latest Feribe's usb.git / testing/next branch >> (the commit id = 28ea6be01e2cf244c461a40c8e9593816f894412.) > >

Re: [PATCH v3 3/3] usb: gadget: udc: renesas_usb3: add support for usb role swap

2017-03-30 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > This patch adds support for usb role swap via sysfs "role". > > For example: > 1) Connect a usb cable using 2 Salvator-X boards. > - For A-Device, the cable is connected to CN11 (USB3.0 ch0). > - For B-Device, the cable is connected to CN9 (USB2.0 ch0). > 2)

RE: [PATCH 1/4] usb: gadget: udc: renesas_usb3: add sysfs "role" to set "b-device" mode

2017-03-29 Thread Felipe Balbi
Yoshihiro-san Yoshihiro Shimoda writes: >> >> Yoshihiro Shimoda writes: >> >> > Sadly, to change the role ("host" and "peripheral") of USB3.0 DRD >> >> > controller on R-Car Gen3, software has to set the DRD_CON register >> >> > which is included in a usb3.0 peripheral controler's register. >>

RE: [PATCH 1/4] usb: gadget: udc: renesas_usb3: add sysfs "role" to set "b-device" mode

2017-03-28 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Hi Felipe-san, > >> From: Felipe Balbi, Sent: Tuesday, March 28, 2017 9:06 PM >> >> Hi, >> >> Yoshihiro Shimoda writes: >> > Sadly, to change the role ("host" and "peripheral") of USB3.0 D

Re: [PATCH 1/4] usb: gadget: udc: renesas_usb3: add sysfs "role" to set "b-device" mode

2017-03-28 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Sadly, to change the role ("host" and "peripheral") of USB3.0 DRD > controller on R-Car Gen3, software has to set the DRD_CON register > which is included in a usb3.0 peripheral controler's register. > To simply implementation, the previous code always set periphe

Re: [PATCH v2 1/6] usb: dwc3: omap: Replace the extcon API

2017-01-16 Thread Felipe Balbi
Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi > Acked-by: Felipe Bal

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

2016-12-02 Thread Felipe Balbi
Hi, Chanwoo Choi writes: > Hi Felipe, > > On 2016년 11월 30일 19:36, Felipe Balbi wrote: >> >> Hi, >> >> Chanwoo Choi writes: >>> This patch uses the resource-managed extcon API for >>> extcon_register_notifier() >

Re: [PATCH 12/12] usb: renesas_usbhs: Replace the deprecated extcon API

2016-11-30 Thread Felipe Balbi
Hi, Chanwoo Choi writes: > This patch replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 10/12] usb: phy: qcom-8x16-usb: Replace the extcon API

2016-11-30 Thread Felipe Balbi
Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe

Re: [PATCH 11/12] usb: phy: tahvo: Replace the deprecated extcon API

2016-11-30 Thread Felipe Balbi
Hi, Chanwoo Choi writes: > This patch replaces the deprecated extcon API as following: > - extcon_set_cable_state_() -> extcon_set_state_sync() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 09/12] usb: phy: omap-otg: Replace the extcon API

2016-11-30 Thread Felipe Balbi
Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe

Re: [PATCH 08/12] usb: phy: msm: Replace the extcon API

2016-11-30 Thread Felipe Balbi
Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

2016-11-30 Thread Felipe Balbi
Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Felipe Balbi
Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >> > > The semantic patch that makes

Re: [PATCH/RFC 0/4] usb: gadget: add a new quirk to avoid skb_reserve in u_ether.c

2016-08-18 Thread Felipe Balbi
Yoshihiro-san, Yoshihiro Shimoda writes: > This patch set is based on the latest Felipe's usb.git / testing/next branch. > (commit id = 15e4292a2d21e9997fdb2b8c014cc461b3f268f0) > > This patch set also needs an additional patch (like the end of this email) > to fix the renesas_usbhs driver for R

RE: [PATCH 0/2] usb: renesas_usbhs: fix issues on specific situations

2016-06-29 Thread Felipe Balbi
Yoshihiro Shimoda writes: > Hi Felipe, > > Would you review this patch set? both in my queue. -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: renesas_usbhs: make usbhs_write32() static

2016-06-22 Thread Felipe Balbi
Hi, Mathieu Malaterre writes: > On Tue, Jun 21, 2016 at 7:52 PM, Ben Dooks wrote: >> The usbhs_write32 function is not used outside of the rcar3.c >> file, so fix the following sparse warning by making it static: >> >> drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was

RE: [PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-06-01 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: >> From: Felipe Balbi >> Sent: Wednesday, June 01, 2016 4:01 PM >> >> Yoshihiro Shimoda writes: >> >> > I'm afraid but I found a regression of xhci-rcar in v4.7-rc1. >> > This regressio

Re: [PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-06-01 Thread Felipe Balbi
Yoshihiro Shimoda writes: > I'm afraid but I found a regression of xhci-rcar in v4.7-rc1. > This regression is caused by the following commit: > > commit b1c127ae990bccf0187d741c1695a61e54de1943 > Author: Felipe Balbi > Date: Fri Apr 22 13:17:16 2016 +0300 > >

Re: [PATCH v3] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-05-06 Thread Felipe Balbi
ONFIG_USB_XHCI_RCAR. > > Fixes: 4ac8918f3a7 (usb: host: xhci-plat: add support for the R-Car H2 and M2 > xHCI controllers) > Cc: # v3.17+ > > Signed-off-by: Yoshihiro Shimoda looks good to me, thanks :) Reviewed-by: Felipe Balbi > --- > Changes from v2: > -

RE: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-24 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: >> > Yoshihiro Shimoda writes: >> >> The firmware of R-Car USB 3.0 host controller will control the reset. >> >> So, if the xhci driver doesn't do firmware downloading (e.g. kernel >> >> configuration is CONFIG_USB_XHCI_PLATFORM=y and CONFIG_USB_XHCI_RCAR >> >> is

Re: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-22 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > The firmware of R-Car USB 3.0 host controller will control the reset. > So, if the xhci driver doesn't do firmware downloading (e.g. kernel > configuration is CONFIG_USB_XHCI_PLATFORM=y and CONFIG_USB_XHCI_RCAR > is not set), the reset of USB 3.0 host controller d

RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-22 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: >> > > And, kernel log is the following: >> > > >> > > [1.565605] xhci-hcd ee00.usb: xHCI Host Controller >> > > [1.570636] xhci-hcd ee00.usb: new USB bus registered, assigned >> > > bus number 5 >> > > [ 22.270160] xhci-hcd ee00.usb: can't se

Re: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-21 Thread Felipe Balbi
Hi, Geert Uytterhoeven writes: > On Thu, Apr 21, 2016 at 12:27 PM, Yoshihiro Shimoda > wrote: >>> > [1.565605] xhci-hcd ee00.usb: xHCI Host Controller >>> > [1.570636] xhci-hcd ee00.usb: new USB bus registered, assigned >>> > bus number 5 >>> > [ 22.270160] xhci-hcd ee00.

RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-21 Thread Felipe Balbi
Yoshihiro Shimoda writes: > Hi Felipe, > >> From: Felipe Balbi >> Sent: Thursday, April 21, 2016 7:05 PM >> >> Yoshihiro Shimoda writes: >> >> > If kernel configuration is CONFIG_USB_XHCI_PLATFORM=y and >> > CONFIG_USB_XHCI_RCAR is not set

Re: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-21 Thread Felipe Balbi
Yoshihiro Shimoda writes: > If kernel configuration is CONFIG_USB_XHCI_PLATFORM=y and > CONFIG_USB_XHCI_RCAR is not set, R-Car Gen2/3 will cause long wait > in xhci_reset() because such SoCs need specific initialization. where is the delay coming from exactly ? > So, this patch modifies the xhc

RE: [PATCH v2 0/2] usb: renesas_usbhs: fix to avoid unexpected condition

2016-03-22 Thread Felipe Balbi
Yoshihiro-san, Yoshihiro Shimoda writes: >> From: Yoshihiro Shimoda >> Sent: Thursday, March 10, 2016 11:30 AM >> >> This patch set is based on the latest Felipe's usb.git / testing/next branch. >> (commit id = ac5706631325ae3695bfa1527101ab2b2f64859f) > > Would you review the patch set? > > I

Re: [PATCH v3 0/2] usb: host: xhci: add a new quirk and fix an issue for R-Car Gen2/3

2016-03-14 Thread Felipe Balbi
new quirk XHCI_NO_64BIT_SUPPORT > usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB > phys for your entire series: Reviewed-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 2/2] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-10 Thread Felipe Balbi
Yoshihiro Shimoda writes: > [ text/plain ] > This patch fixes an issue that cannot work if R-Car Gen2/3 run on > above 4GB physical memory environment to use a quirk XHCI_CLEAR_AC64. > > Signed-off-by: Yoshihiro Shimoda > --- > drivers/usb/host/xhci-plat.c | 7 +++ > 1 file changed, 7 inser

Re: [PATCH v2 1/2] usb: host: xhci: add a new quirk XHCI_CLEAR_AC64

2016-03-10 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > [ text/plain ] > On some xHCI controllers (e.g. R-Car SoCs), the AC64 bit (bit 0) of > HCCPARAMS1 is set to 1. However, the xHCs don't support 64-bit > address memory pointers actually. So, in this case, this driver should > call dma_set_coherent_mask(dev, DMA_BIT

RE: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-09 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: >> Yoshihiro Shimoda writes: >> > [ text/plain ] >> > When unexpected situation happened (e.g. tx/rx irq happened while >> > DMAC is used), the usbhsf_pkt_handler() was possible to cause NULL >> > pointer dereference like the followings: >> > >> > Unable to handle

Re: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-09 Thread Felipe Balbi
Hi Yoshihiro, Yoshihiro Shimoda writes: > [ text/plain ] > When unexpected situation happened (e.g. tx/rx irq happened while > DMAC is used), the usbhsf_pkt_handler() was possible to cause NULL > pointer dereference like the followings: > > Unable to handle kernel NULL pointer dereference at vir

RE: [PATCH] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-09 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > [ text/plain ] > Hi Mathias, > > Would you review this patch? > This patch could be applied into the latest usb.git / usb-next branch. > > Best regards, > Yoshihiro Shimoda > >> -Original Message- >> From: Yoshihiro Shimoda >> Sent: Tuesday, February 16, 2

RE: [PATCH] usb: renesas_usbhs: gadget: fix giveback status code in usbhsg_pipe_disable()

2016-03-03 Thread Felipe Balbi
Hi Yoshihiro, Yoshihiro Shimoda writes: > [ text/plain ] > Hi Felipe, > > Oops, I completely forgot this patch. > Would you review this patch? Or should I resend it? > I confirmed that this patch could be applied on your latest > testing/fixes branch. I don't seem to have the original patch in